panbingkun commented on code in PR #37588:
URL: https://github.com/apache/spark/pull/37588#discussion_r1378701726
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala:
##########
@@ -165,4 +154,222 @@ class ShowTablesSuite extends ShowTablesSuiteBase with
CommandSuiteBase {
}
}
}
+
+ test("show table extended in non-partitioned table") {
+ val namespace = "ns1"
+ val table = "tbl"
+ withNamespaceAndTable(namespace, table, catalog) { tbl =>
+ sql(s"CREATE TABLE $tbl (id bigint, data string) $defaultUsing")
+ val e = intercept[AnalysisException] {
+ sql(s"SHOW TABLE EXTENDED IN $catalog.$namespace LIKE '$table'
PARTITION(id = 1)")
+ }
+ checkError(
+ exception = e,
+ errorClass = "_LEGACY_ERROR_TEMP_1251",
+ parameters = Map("action" -> "SHOW TABLE EXTENDED", "tableName" ->
table)
+ )
+ }
+ }
+
+ test("show table extended in multi partition key - " +
Review Comment:
Done.
I have updated some logic of UT. Previously, I used the `exclude method` to
exclude fields with `non-deterministic `values, but now I have changed it to
`replace` with `a fixed template value` for better comparison of results. At
present, the difference displayed by UT should be relatively clear. eg:
`Created Time: Wed Nov 01 04:51:19 PDT 2023` => `Created Time: <created
time>`
`Last Access: UNKNOWN` => `Last Access: <last access>`
`Created By: Spark` => `Created By: <created by>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
