panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1378705860
########## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ########## @@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat messageParameters = Map( "specKeys" -> specKeys, "partitionColumnNames" -> partitionColumnNames.mkString(", "), - "tableName" -> tableName)) + "tableName" -> toSQLId(tableName))) Review Comment: @cloud-fan Do we really need to split a UT logic into subclasses in order not to `modify the above logic`? Separate into two subclasses, so it seems that the similarities cannot be seen anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org