gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585528937
##########
core/src/main/scala/org/apache/spark/Dependency.scala:
##########
@@ -211,10 +212,13 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
// This may crash the driver with an OOM error.
if (numPartitions.toLong * partitioner.numPartitions.toLong > (1L << 30)) {
logWarning(
- s"The number of shuffle blocks (${numPartitions.toLong *
partitioner.numPartitions.toLong})" +
- s" for shuffleId ${shuffleId} for ${_rdd} with ${numPartitions}
partitions" +
- " is possibly too large, which could cause the driver to crash with an
out-of-memory" +
- " error. Consider decreasing the number of partitions in this shuffle
stage."
+ log"The number of shuffle blocks " +
+ log"(${MDC(NUM_PARTITION, numPartitions.toLong *
partitioner.numPartitions.toLong)})" +
+ log" for shuffleId ${MDC(SHUFFLE_ID, shuffleId)} " +
+ log"for ${MDC(RDD_DESCRIPTION, _rdd)} " +
+ log"with ${MDC(NUM_PARTITION, numPartitions)} partitions" +
Review Comment:
@dtenedor we can't use a same key for two values in a log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
