gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585555540
##########
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerDiskManager.scala:
##########
@@ -312,8 +314,9 @@ private class HistoryServerDiskManager(
if (committedUsage.get() > maxUsage) {
val current = Utils.bytesToString(committedUsage.get())
val max = Utils.bytesToString(maxUsage)
- logWarning(s"Commit of application $appId / $attemptId causes maximum
disk usage to be " +
- s"exceeded ($current > $max)")
+ logWarning(log"Commit of application ${MDC(APP_ID, appId)} / " +
+ log"${MDC(APP_ATTEMPT_ID, attemptId)} causes maximum disk usage to
be " +
+ log"exceeded (${MDC(NUM_BYTES, current > max)}")
Review Comment:
`current` and `max` should be two MDC here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
