gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585558505
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -1280,8 +1293,8 @@ private[deploy] class Master(
for (worker <- toRemove) {
if (worker.state != WorkerState.DEAD) {
val workerTimeoutSecs =
TimeUnit.MILLISECONDS.toSeconds(workerTimeoutMs)
- logWarning("Removing %s because we got no heartbeat in %d
seconds".format(
- worker.id, workerTimeoutSecs))
+ logWarning(log"Removing ${MDC(LogKeys.WORKER_ID, worker.id)} because
we got no heartbeat " +
+ log"in ${MDC(LogKeys.TIME_UNITS, workerTimeoutSecs)} seconds")
Review Comment:
All the time units are now using ms instead of seconds. Shall we just use
`ms` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
