gengliangwang commented on code in PR #46309: URL: https://github.com/apache/spark/pull/46309#discussion_r1585609934
########## core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala: ########## @@ -154,9 +154,11 @@ private[spark] class FairSchedulableBuilder(val rootPool: Pool, sc: SparkContext val xmlSchedulingMode = (poolNode \ SCHEDULING_MODE_PROPERTY).text.trim.toUpperCase(Locale.ROOT) - val warningMessage = s"Unsupported schedulingMode: $xmlSchedulingMode found in " + - s"Fair Scheduler configuration file: $fileName, using " + - s"the default schedulingMode: $defaultValue for pool: $poolName" + val warningMessage = log"Unsupported schedulingMode: " + + log"${MDC(XML_SCHEDULING_MODE, xmlSchedulingMode)} found in " + + log"Fair Scheduler configuration file: ${MDC(FILE_NAME, fileName)}, using " + + log"the default schedulingMode: ${MDC(SCHEDULING_MODE, defaultValue)} for pool: " + Review Comment: ```suggestion log"the default schedulingMode: ${MDC(DEFAULT_SCHEDULING_MODE, defaultValue)} for pool: " + ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org