Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r97707703
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,9 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !=
"binary") {
vec <- do.call(c, col)
stopifnot(class(vec) != "list")
+ # If vec is an vector with only NAs, the type is
logical
--- End diff --
if the DataFrame column is of type string, shouldn't it converts to R as
character (which can be all NA), even though the column only has NULL (which
maps to NA in R)?
it seems with this change it would become logical in R instead of character.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
