Github user titicaca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r97712469
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,9 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !=
"binary") {
vec <- do.call(c, col)
stopifnot(class(vec) != "list")
+ # If vec is an vector with only NAs, the type is
logical
--- End diff --
Yes. My first commit was trying to cast the column to its corresponding R
data type explicitly, even if it is an vector with all NAs. However some
existed tests were failed and expecting to get logical NA. For example
```
3. Failure: column functions (@test_sparkSQL.R#1280)
---------------------------
collect(select(df, first(df$age)))[[1]] not equal to NA.
Types not compatible: double vs logical
4. Failure: column functions (@test_sparkSQL.R#1282)
---------------------------
collect(select(df, first("age")))[[1]] not equal to NA.
Types not compatible: double vs logical
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
