Github user titicaca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16689#discussion_r97714703
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1138,6 +1138,9 @@ setMethod("collect",
if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType !=
"binary") {
vec <- do.call(c, col)
stopifnot(class(vec) != "list")
+ # If vec is an vector with only NAs, the type is
logical
--- End diff --
In local R, if we try
```
df <- data.frame(x = c(0,1,2), y = c(NA, NA, 1))
class(head(df, 1)$y)
```
The output is still numeric instead of logical. But the existed test is
expecting NA logical instead of NA numeric.
So is it necessary to correct the existed tests, for example
@test_sparkSQL.R#1280
from `expect_equal(collect(select(df, first(df$age)))[[1]], NA)` to
`expect_equal(collect(select(df, first(df$age)))[[1]], NA_real_)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
