Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131288786
--- Diff: python/pyspark/ml/util.py ---
@@ -283,3 +353,143 @@ def numFeatures(self):
Returns the number of features the model was trained on. If
unknown, returns -1
"""
return self._call_java("numFeatures")
+
+
+@inherit_doc
+class DefaultParamsWritable(MLWritable):
+ """
+ Class for making simple Params types writable. Assumes that all
parameters
+ are JSON-serializable.
+
+ .. versionadded:: 2.3.0
+ """
+
+ def write(self):
+ """Returns a DefaultParamsWriter instance for this class."""
+ if isinstance(self, Params):
+ return DefaultParamsWriter(self)
+ else:
+ raise TypeError("Cannot use DefautParamsWritable with type %s
because it does not " +
+ " extend Params.", type(self))
+
+
+@inherit_doc
+class DefaultParamsWriter(MLWriter):
+ """
+ Class for writing Estimators and Transformers whose parameters are
JSON-serializable.
+
+ .. versionadded:: 2.3.0
+ """
+
+ def __init__(self, instance):
+ super(DefaultParamsWriter, self).__init__()
+ self.instance = instance
+
+ def saveImpl(self, path):
+ DefaultParamsWriter.save_metadata(self.instance, path, self.sc)
+
+ @staticmethod
+ def save_metadata(instance, path, sc, extraMetadata=None,
paramMap=None):
+ metadataPath = os.path.join(path, "metadata")
+ metadataJson = DefaultParamsWriter.get_metadata_to_save(instance,
+
metadataPath,
+ sc,
+
extraMetadata,
+ paramMap)
+ sc.parallelize([metadataJson], 1).saveAsTextFile(metadataPath)
+
+ @staticmethod
+ def get_metadata_to_save(instance, path, sc, extraMetadata=None,
paramMap=None):
--- End diff --
path is not used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
