Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131285744
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -471,3 +471,24 @@ private[ml] object MetaAlgorithmReadWrite {
List((instance.uid, instance)) ++ subStageMaps
}
}
+
+private[ml] class FileSystemOverwrite extends Logging {
+
+ def handleOverwrite(path: String, shouldOverwrite: Boolean, sc:
SparkContext): Unit = {
--- End diff --
This is the same now as the code in MLWriter.save, so please use this
within MLWriter.save to eliminate the duplicated code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
