Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131288629 --- Diff: python/pyspark/ml/util.py --- @@ -237,6 +300,13 @@ def _load_java_obj(cls, clazz): java_obj = getattr(java_obj, name) return java_obj + @classmethod + def _load_given_name(cls, java_class): --- End diff -- Please also stick with camelCase for methods since that's what pyspark does. (here and elsewhere)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org