GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19116
[SPARK-21903][BUILD] Upgrade scalastyle to 1.0.0.
## What changes were proposed in this pull request?
1.0.0 fixes an issue with import order, explicit type for public methods,
line length limitation and comment validation:
```
[error]
.../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala:50:16:
Are you sure you want to println? If yes, wrap the code block with
[error] // scalastyle:off println
[error] println(...)
[error] // scalastyle:on println
[error]
.../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:49:
File line length exceeds 100 characters
[error]
.../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:22:21:
Are you sure you want to println? If yes, wrap the code block with
[error] // scalastyle:off println
[error] println(...)
[error] // scalastyle:on println
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:35:6:
Public method must have explicit type
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:51:6:
Public method must have explicit type
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:93:15:
Public method must have explicit type
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:98:15:
Public method must have explicit type
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:47:2:
Insert a space after the start of the comment
[error]
.../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:26:43:
JavaDStream should come before JavaDStreamLike.
```
This PR also fixes the workaround added in SPARK-16877 for
`org.scalastyle.scalariform.OverrideJavaChecker` feature, added from 0.9.0.
## How was this patch tested?
Manually tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark scalastyle-1.0.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19116
----
commit 2447fd0e152ace4dd074a92bd0d3cdc638b09b1a
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2017-09-04T04:26:19Z
Upgrade scalastyle to 1.0.0.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
