Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19116#discussion_r136745559
--- Diff: project/SparkBuild.scala ---
@@ -163,14 +163,15 @@ object SparkBuild extends PomBuild {
val configUrlV = scalastyleConfigUrl.in(config).value
val streamsV = streams.in(config).value
val failOnErrorV = true
+ val failOnWarningV = true
val scalastyleTargetV = scalastyleTarget.in(config).value
val configRefreshHoursV =
scalastyleConfigRefreshHours.in(config).value
val targetV = target.in(config).value
val configCacheFileV =
scalastyleConfigUrlCacheFile.in(config).value
logger.info(s"Running scalastyle on ${name.value} in
${config.name}")
- Tasks.doScalastyle(args, configV, configUrlV, failOnErrorV,
scalaSourceV, scalastyleTargetV,
- streamsV, configRefreshHoursV, targetV, configCacheFileV)
+ Tasks.doScalastyle(args, configV, configUrlV, failOnErrorV,
failOnWarningV, scalaSourceV,
--- End diff --
This change looks required -
https://github.com/scalastyle/scalastyle-sbt-plugin/commit/cbbb9c9d1c33b9e90bf187edb0dd2d6b4eceaa21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
