Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r139809836
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -399,14 +399,17 @@ private[ml] object DefaultParamsReader {
* This works if all Params implement
[[org.apache.spark.ml.param.Param.jsonDecode()]].
* TODO: Move to [[Metadata]] method
*/
- def getAndSetParams(instance: Params, metadata: Metadata): Unit = {
+ def getAndSetParams(instance: Params, metadata: Metadata,
+ skipParams: List[String] = null): Unit = {
--- End diff --
Use an `Option[List[String]]` that defaults to `None` instead of a
`List[String]` that defaults to null?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
