Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r139854984
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -212,14 +213,12 @@ object CrossValidator extends
MLReadable[CrossValidator] {
val (metadata, estimator, evaluator, estimatorParamMaps) =
ValidatorParams.loadImpl(path, sc, className)
- val numFolds = (metadata.params \ "numFolds").extract[Int]
- val seed = (metadata.params \ "seed").extract[Long]
- new CrossValidator(metadata.uid)
+ val cv = new CrossValidator(metadata.uid)
.setEstimator(estimator)
.setEvaluator(evaluator)
.setEstimatorParamMaps(estimatorParamMaps)
- .setNumFolds(numFolds)
- .setSeed(seed)
+ DefaultParamsReader.getAndSetParams(cv, metadata, skipParams =
List("estimatorParamMaps"))
--- End diff --
No. Because `estimator` and `evaluator` isn't included in metadata. You can
check the `saveImpl`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
