Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140150229
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2594,12 +2596,12 @@ setMethod("merge",
} else {
# if by or both by.x and by.y have length 0, use Cartesian
Product
joinRes <- crossJoin(x, y)
- return (joinRes)
+ return(joinRes)
}
# sets alias for making colnames unique in dataframes 'x' and
'y'
- colsX <- generateAliasesForIntersectedCols(x, by, suffixes[1])
- colsY <- generateAliasesForIntersectedCols(y, by, suffixes[2])
+ colsX <- generateAliasesForIntersectedCols(x, by, suffixes[1])
# nolint
+ colsY <- generateAliasesForIntersectedCols(y, by, suffixes[2])
# nolint
--- End diff --
what's the problem here? name too long I think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
