Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19290#discussion_r140150499
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2649,15 +2651,15 @@ setMethod("merge",
#' @return list of columns
#'
#' @note generateAliasesForIntersectedCols since 1.6.0
-generateAliasesForIntersectedCols <- function (x, intersectedColNames,
suffix) {
+generateAliasesForIntersectedCols <- function(x, intersectedColNames,
suffix) { # nolint
--- End diff --
wait... this isn't public though; it's not in
https://github.com/apache/spark/blob/master/R/pkg/NAMESPACE
looks like this shouldn't be in the doc (`@noRd` or `#` instead of `#'`)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
