Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19290#discussion_r140244036
  
    --- Diff: dev/lint-r.R ---
    @@ -28,6 +28,7 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC, 
logical.return = TRUE)) {
     # NOTE: The CRAN's version is too old to adapt to our rules.
     if ("lintr" %in% row.names(installed.packages())  == FALSE) {
       devtools::install_github("jimhester/lintr@a769c0b")
    +  # devtools::install_github("jimhester/lintr@5431140")
    --- End diff --
    
    Oh, just to be clear, I didn't change this yet but just commented this for 
now ... Actually, `devtools::install_github("jimhester/lintr@5431140")` is new 
one but I didn't change this yet just in case.
    
    Will add some comments around this when I add few more changes and clean up 
soon in any event.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to