Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680353
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8 @@ private[mesos] object MesosSchedulerBackendUtil extends
Logging {
.toList
}
- def containerInfo(conf: SparkConf): ContainerInfo.Builder = {
+ def buildContainerInfo(conf: SparkConf, secretConfig: MesosSecretConfig):
--- End diff --
Maybe change `secretConfig` to `mesosConfig` and pass the whole thing? That
way if we want to add new functionality later this function is more general.
Given that most of what we do is proto-generation, I bet we'll have to do this
eventually anyways.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
