Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680448
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8 @@ private[mesos] object MesosSchedulerBackendUtil extends
Logging {
.toList
}
- def containerInfo(conf: SparkConf): ContainerInfo.Builder = {
+ def buildContainerInfo(conf: SparkConf, secretConfig: MesosSecretConfig):
+ ContainerInfo.Builder = {
val containerType = if
(conf.contains("spark.mesos.executor.docker.image") &&
--- End diff --
Should probably have a check here for if secrets are present, because I
don't think that secrets will work if you're _not_ also using the Mesos
containerizer.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
