Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22332#discussion_r215145351
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
           }.toSeq)
         assert(df.schema.map(_.name) === Seq("key", "value", "newCol"))
     
    -    val df2 = testData.toDF().withColumn("newCol", col("key") + 1, false)
    +    val df2 = testData.toDF().withColumn("newCol", col("key") + 1, 0)
    --- End diff --
    
    What about tests with negative positions?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to