Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22332#discussion_r215144982
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
         * `column`'s expression must only refer to attributes supplied by this 
Dataset. It is an
         * error to add a column that refers to some other Dataset.
         *
    -    * You can choose to add new columns either at the end (default 
behavior) or at the beginning.
    +    * The position of the new column start from 0, and a negative position 
means at the end (default behavior).
         */
    -  def withColumn(colName: String, col: Column, atTheEnd: Boolean): 
DataFrame =
    -    withColumns(Seq(colName), Seq(col), atTheEnd)
    +  def withColumn(colName: String, col: Column, atPosition: Int): DataFrame 
=
    +    withColumns(Seq(colName), Seq(col), atPosition)
     
       /**
        * Returns a new Dataset by adding columns or replacing the existing 
columns that has
        * the same names.
    +   *
    +   * The position of new columns start from 0, and a negative position 
means at the end (default behavior).
    --- End diff --
    
    Same as above


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to