Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22473#discussion_r219576657
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -83,6 +83,17 @@ package object config {
       private[spark] val EXECUTOR_CLASS_PATH =
         
ConfigBuilder(SparkLauncher.EXECUTOR_EXTRA_CLASSPATH).stringConf.createOptional
     
    +  private[spark] val EXECUTOR_HEARTBEAT_DROP_ZERO_METRICS =
    +    
ConfigBuilder("spark.executor.heartbeat.dropZeroMetrics").booleanConf.createWithDefault(true)
    --- End diff --
    
    maybe call it `spark.executor.heartbeat.dropZeroAccumulatorUpdates`? 
`externalAccums` may contain user accumulators and not all of them are metrics.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to