Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219574155
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -149,7 +149,7 @@ private[spark] class Executor(
// Executor for the heartbeat task.
private val heartbeater = new Heartbeater(env.memoryManager,
reportHeartBeat,
- "executor-heartbeater",
conf.getTimeAsMs("spark.executor.heartbeatInterval", "10s"))
+ "executor-heartbeater",
conf.getTimeAsMs(EXECUTOR_HEARTBEAT_INTERVAL.key, "10s"))
--- End diff --
nit: `conf.get(EXECUTOR_HEARTBEAT_INTERVAL)`. Could you search the whole
code base and update them as well?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
