Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219575944
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -799,15 +799,21 @@ private[spark] class Executor(
if (taskRunner.task != null) {
taskRunner.task.metrics.mergeShuffleReadMetrics()
taskRunner.task.metrics.setJvmGCTime(curGCTime -
taskRunner.startGCTime)
- accumUpdates += ((taskRunner.taskId,
taskRunner.task.metrics.accumulators()))
+ val accumulatorsToReport =
+ if (conf.getBoolean(EXECUTOR_HEARTBEAT_DROP_ZERO_METRICS.key,
true)) {
--- End diff --
nit: I would prefer to keep this config value close to
`HEARTBEAT_MAX_FAILURES` to avoid searching it in configs every heartbeat.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
