Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r223560748
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
 ---
    @@ -47,6 +50,13 @@ private[spark] case class KubernetesExecutorSpecificConf(
         driverPod: Option[Pod])
       extends KubernetesRoleSpecificConf
     
    +/*
    + * Structure containing metadata for HADOOP_CONF_DIR customization
    + */
    +private[spark] case class HadoopConfSpecConf(
    --- End diff --
    
    Can you create a similar one for krb5 and call it `Krb5ConfSpec`, which 
contains an optional krb5 file location or the name of a pre-defined krb5 
ConfigMap? Then you can use that `Krb5ConfSpec` in places where you use both 
the file location and ConfigMap as parameters. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to