Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r223557398
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
 ---
    @@ -61,7 +71,16 @@ private[spark] case class KubernetesConf[T <: 
KubernetesRoleSpecificConf](
         roleSecretEnvNamesToKeyRefs: Map[String, String],
         roleEnvs: Map[String, String],
         roleVolumes: Iterable[KubernetesVolumeSpec[_ <: 
KubernetesVolumeSpecificConf]],
    -    sparkFiles: Seq[String]) {
    +    sparkFiles: Seq[String],
    +    hadoopConfDir: Option[HadoopConfSpecConf]) {
    --- End diff --
    
    Can you rename this parameter to `hadoopConfSpec`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to