Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r223558932
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
 ---
    @@ -78,4 +80,29 @@ private[spark] object Constants {
       val KUBERNETES_MASTER_INTERNAL_URL = "https://kubernetes.default.svc";
       val DRIVER_CONTAINER_NAME = "spark-kubernetes-driver"
       val MEMORY_OVERHEAD_MIN_MIB = 384L
    +
    +  // Hadoop Configuration
    +  val HADOOP_FILE_VOLUME = "hadoop-properties"
    +  val KRB_FILE_VOLUME = "krb5-file"
    +  val HADOOP_CONF_DIR_PATH = "/opt/hadoop/conf"
    +  val KRB_FILE_DIR_PATH = "/etc"
    +  val ENV_HADOOP_CONF_DIR = "HADOOP_CONF_DIR"
    +  val HADOOP_CONFIG_MAP_NAME =
    +    "spark.kubernetes.executor.hadoopConfigMapName"
    +  val KRB5_CONFIG_MAP_NAME =
    +    "spark.kubernetes.executor.krb5ConfigMapName"
    +
    +  // Kerberos Configuration
    +  val KERBEROS_DELEGEGATION_TOKEN_SECRET_NAME = "delegation-tokens"
    +  val KERBEROS_KEYTAB_SECRET_NAME =
    --- End diff --
    
    Looks like this is used as the name of the secret storing the DT, not the 
keytab. So please rename it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to