Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23184#discussion_r238055126
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala 
---
    @@ -225,4 +225,10 @@ private[sql] object SQLUtils extends Logging {
         }
         sparkSession.sessionState.catalog.listTables(db).map(_.table).toArray
       }
    +
    +  def createArrayType(elementType: DataType): ArrayType = 
DataTypes.createArrayType(elementType)
    --- End diff --
    
    as mentioned before, I kinda have to disagree with you here... I'd prefer 
less stuff in r/SQLUtils, and instead, call the scala/jvm method directly from 
R...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to