Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23184#discussion_r238056981
--- Diff: R/pkg/R/functions.R ---
@@ -2254,40 +2255,48 @@ setMethod("date_format", signature(y = "Column", x
= "character"),
column(jc)
})
+setClassUnion("characterOrstructTypeOrColumn", c("character",
"structType", "Column"))
--- End diff --
Yup, I agree.. Would you mind if I do this separately? I roughly checked by
`grep` and looks:
```
./pkg/R/DataFrame.R:setClassUnion("characterOrstructType", c("character",
"structType"))
./pkg/R/DataFrame.R:setClassUnion("numericOrcharacter", c("numeric",
"character"))
./pkg/R/DataFrame.R:setClassUnion("characterOrColumn", c("character",
"Column"))
./pkg/R/DataFrame.R:setClassUnion("numericOrColumn", c("numeric", "Column"))
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
