Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23184#discussion_r238055143
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2254,40 +2255,48 @@ setMethod("date_format", signature(y = "Column", x 
= "character"),
                 column(jc)
               })
     
    +setClassUnion("characterOrstructTypeOrColumn", c("character", 
"structType", "Column"))
    --- End diff --
    
    we should probably try to pull all the setClassUnion in one place. (to 
avoid conflict or duplication)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to