Re: [VOTE] Release Apache httpd 2.4.28 as GA

[Gregg Smith]

Feel free to do whatever you please with the cmake build. I just added 
the new loadlibrary.c file to it is all so technically it is ready to go 
and apu can be tagged.


On 9/26/2017 10:29 AM, William A Rowe Jr wrote:

This doesn't make sense to me; in unbundling, and providing a modern build
system, why are these sources mentioned?

Expat 2.2.x has it's own build schema, any attempt to replace expat's with
APR's seems misguided. Happy to stay mostly hands-off the mak/dsp as
this legacy tangle that users continue to consume, but the cmake was done
to turn windows builds into a conventional solution. The right fix there is to
just switch compiling sources for linking to a library, and let that library
maintainer do their thing.

So +1 to the dsp/mak change, but alternate CMakeFiles.txt feedback
to follow...


On Tue, Sep 26, 2017 at 10:13 AM, Gregg Smith  wrote:

cmake should be as well. http://svn.apache.org/r1805330


On 9/26/2017 7:12 AM, William A Rowe Jr wrote:


Proceeding with the understanding that mak, and dsp files are OK on -dev,
thank
you for the review in your schema, Steffen!

Cheers,

Bill

On Tue, Sep 26, 2017 at 4:00 AM, Steffen  wrote:


No issues seen with building and running  httpd with apr 1.6.3 and
apr-util
1.6.1


On Monday 25/09/2017 at 21:34, Steffen wrote:

No, used 1.6.2/1.6.0.

Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev.


Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr 
het
volgende geschreven:

Hi Steffen,

were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util
(1.6.1-dev)?
Or the last released 1.6.2/1.6.0 flavors?

I'm reviewing here to avoid tagging something that won't build, if you
had already
done so for Windows, it would speed things up here.

Cheers,

Bill

On Mon, Sep 25, 2017 at 12:11 PM, Steffen  wrote:
On Windows it does not build out of the box.

Missing modules/core include for mod_watchdog.h in
mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked cmake.

Steffen

On Monday 25/09/2017 at 14:13, Jim Jagielski wrote:

The pre-release test tarballs for Apache httpd
version 2.4.28 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.28 as GA

[William A Rowe Jr]

This doesn't make sense to me; in unbundling, and providing a modern build
system, why are these sources mentioned?

Expat 2.2.x has it's own build schema, any attempt to replace expat's with
APR's seems misguided. Happy to stay mostly hands-off the mak/dsp as
this legacy tangle that users continue to consume, but the cmake was done
to turn windows builds into a conventional solution. The right fix there is to
just switch compiling sources for linking to a library, and let that library
maintainer do their thing.

So +1 to the dsp/mak change, but alternate CMakeFiles.txt feedback
to follow...


On Tue, Sep 26, 2017 at 10:13 AM, Gregg Smith  wrote:
> cmake should be as well. http://svn.apache.org/r1805330
>
>
> On 9/26/2017 7:12 AM, William A Rowe Jr wrote:
>>
>> Proceeding with the understanding that mak, and dsp files are OK on -dev,
>> thank
>> you for the review in your schema, Steffen!
>>
>> Cheers,
>>
>> Bill
>>
>> On Tue, Sep 26, 2017 at 4:00 AM, Steffen  wrote:
>>>
>>> No issues seen with building and running  httpd with apr 1.6.3 and
>>> apr-util
>>> 1.6.1
>>>
>>>
>>> On Monday 25/09/2017 at 21:34, Steffen wrote:
>>>
>>> No, used 1.6.2/1.6.0.
>>>
>>> Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev.
>>>
>>>
>>> Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr 
>>> het
>>> volgende geschreven:
>>>
>>> Hi Steffen,
>>>
>>> were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util
>>> (1.6.1-dev)?
>>> Or the last released 1.6.2/1.6.0 flavors?
>>>
>>> I'm reviewing here to avoid tagging something that won't build, if you
>>> had already
>>> done so for Windows, it would speed things up here.
>>>
>>> Cheers,
>>>
>>> Bill
>>>
>>> On Mon, Sep 25, 2017 at 12:11 PM, Steffen  wrote:
>>> On Windows it does not build out of the box.
>>>
>>> Missing modules/core include for mod_watchdog.h in
>>> mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked cmake.
>>>
>>> Steffen
>>>
>>> On Monday 25/09/2017 at 14:13, Jim Jagielski wrote:
>>>
>>> The pre-release test tarballs for Apache httpd
>>> version 2.4.28 can be found at the usual place:
>>>
>>> http://httpd.apache.org/dev/dist/
>>>
>>> I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA.
>>>
>>> [ ] +1: Good to go
>>> [ ] +0: meh
>>> [ ] -1: Danger Will Robinson. And why.
>>>
>>> Vote will last the normal 72 hrs.
>>>
>>> NOTE: The *-deps are only there for convenience.
>>>
>>> Thx!
>>>
>>>
>>>
>>>
>

Re: Regression in 1.6.2 testpipe on Windows

[Yann Ylavic]

On Tue, Sep 26, 2017 at 2:56 PM, Steven Nairn  wrote:
>
> I've finally got around to using 1.6 and have come across a problem with
> testpipe on Windows (built using MSYS2 and mingw32/64):
>   $ testall.exe -v testpipe
>   testpipe:  Line 161: expected <0>, but saw <22>
>   FAILED 1 of 9
>   Failed TestsTotal   FailFailed %
>   ===
>   testpipe9  1 11.11%
>
> The problem does not occur with v1.5.1 (last version I used).
>
> The problem happens when it tries to set a timeout with
> apr_file_pipe_timeout_set which fails with APR_EINVAL because the pipe was
> opened blocking.

Thanks, probably a bad copy/paste from [1].
Fixed in trunk with [2] and backported to upcoming 1.6.3 with [3].

Regards,
Yann.

[1] http://svn.apache.org/r1734816
[2] http://svn.apache.org/r1809753
[3] http://svn.apache.org/r1809754

Re: [VOTE] Release Apache httpd 2.4.28 as GA

[Gregg Smith]

cmake should be as well. http://svn.apache.org/r1805330

On 9/26/2017 7:12 AM, William A Rowe Jr wrote:

Proceeding with the understanding that mak, and dsp files are OK on -dev, thank
you for the review in your schema, Steffen!

Cheers,

Bill

On Tue, Sep 26, 2017 at 4:00 AM, Steffen  wrote:

No issues seen with building and running  httpd with apr 1.6.3 and apr-util
1.6.1


On Monday 25/09/2017 at 21:34, Steffen wrote:

No, used 1.6.2/1.6.0.

Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev.


Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr  het
volgende geschreven:

Hi Steffen,

were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util (1.6.1-dev)?
Or the last released 1.6.2/1.6.0 flavors?

I'm reviewing here to avoid tagging something that won't build, if you
had already
done so for Windows, it would speed things up here.

Cheers,

Bill

On Mon, Sep 25, 2017 at 12:11 PM, Steffen  wrote:
On Windows it does not build out of the box.

Missing modules/core include for mod_watchdog.h in
mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked cmake.

Steffen

On Monday 25/09/2017 at 14:13, Jim Jagielski wrote:

The pre-release test tarballs for Apache httpd
version 2.4.28 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: Re: [VOTE] Release Apache httpd 2.4.28 as GA

[William A Rowe Jr]

Proceeding with the understanding that mak, and dsp files are OK on -dev, thank
you for the review in your schema, Steffen!

Cheers,

Bill

On Tue, Sep 26, 2017 at 4:00 AM, Steffen  wrote:
> No issues seen with building and running  httpd with apr 1.6.3 and apr-util
> 1.6.1
>
>
> On Monday 25/09/2017 at 21:34, Steffen wrote:
>
> No, used 1.6.2/1.6.0.
>
> Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev.
>
>
> Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr  het
> volgende geschreven:
>
> Hi Steffen,
>
> were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util (1.6.1-dev)?
> Or the last released 1.6.2/1.6.0 flavors?
>
> I'm reviewing here to avoid tagging something that won't build, if you
> had already
> done so for Windows, it would speed things up here.
>
> Cheers,
>
> Bill
>
> On Mon, Sep 25, 2017 at 12:11 PM, Steffen  wrote:
> On Windows it does not build out of the box.
>
> Missing modules/core include for mod_watchdog.h in
> mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked cmake.
>
> Steffen
>
> On Monday 25/09/2017 at 14:13, Jim Jagielski wrote:
>
> The pre-release test tarballs for Apache httpd
> version 2.4.28 can be found at the usual place:
>
> http://httpd.apache.org/dev/dist/
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA.
>
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
>
> Vote will last the normal 72 hrs.
>
> NOTE: The *-deps are only there for convenience.
>
> Thx!
>
>
>
>

Regression in 1.6.2 testpipe on Windows

[Steven Nairn]

Hi all,

I've finally got around to using 1.6 and have come across a problem with
testpipe on Windows (built using MSYS2 and mingw32/64):
  $ testall.exe -v testpipe
  testpipe:  Line 161: expected <0>, but saw <22>
  FAILED 1 of 9
  Failed TestsTotal   FailFailed %
  ===
  testpipe9  1 11.11%

The problem does not occur with v1.5.1 (last version I used).

The problem happens when it tries to set a timeout with
apr_file_pipe_timeout_set which fails with APR_EINVAL because the pipe was
opened blocking.

The pipes should not be blocking since they were set up with:
apr_procattr_io_set(procattr, APR_CHILD_BLOCK, APR_CHILD_BLOCK,
APR_CHILD_BLOCK);

However, it appears a bug was introduced in file_io/win32/pipe.c in
r1736523 (and r1734816 in trunk). That change introduced the new function
apr_file_pipe_create_pools() and refactored apr_file_pipe_create_ex() to
use it as follows:

APR_DECLARE(apr_status_t) apr_file_pipe_create_ex(apr_file_t **in,
  apr_file_t **out,
  apr_int32_t blocking,
  apr_pool_t *p)
{
return apr_file_pipe_create_pools(in, out, APR_FULL_BLOCK, p, p);
}

So apr_file_pipe_create_ex() now ignores the "blocking" parameter passed to
it and only creates blocking pipes.

If "APR_FULL_BLOCK" is replaced with "blocking" then everything appears to
work as expected and the testpipe tests all pass.

As a diff:
==
--- pipe.c-orig 2017-09-26 11:52:24.509293200 +0100
+++ pipe.c  2017-09-26 13:07:15.441143200 +0100
@@ -76,7 +76,7 @@
   apr_int32_t blocking,
   apr_pool_t *p)
 {
-return apr_file_pipe_create_pools(in, out, APR_FULL_BLOCK, p, p);
+return apr_file_pipe_create_pools(in, out, blocking, p, p);
 }

 APR_DECLARE(apr_status_t) apr_file_pipe_create_pools(apr_file_t **in,
==

Cheers,
Steve

Re: Re: [VOTE] Release Apache httpd 2.4.28 as GA

[Steffen]

No issues seen with building and running  httpd with apr 1.6.3 and 
apr-util 1.6.1




On Monday 25/09/2017 at 21:34, Steffen  wrote:

No, used 1.6.2/1.6.0.

Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev.




Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr  
het volgende geschreven:


Hi Steffen,

were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util 
(1.6.1-dev)?

Or the last released 1.6.2/1.6.0 flavors?

I'm reviewing here to avoid tagging something that won't build, if you
had already
done so for Windows, it would speed things up here.

Cheers,

Bill



On Mon, Sep 25, 2017 at 12:11 PM, Steffen  
wrote:

On Windows it does not build out of the box.

Missing modules/core include for mod_watchdog.h in
mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked 
cmake.


Steffen

On Monday 25/09/2017 at 14:13, Jim Jagielski wrote:

The pre-release test tarballs for Apache httpd
version 2.4.28 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!