[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481063#comment-17481063
]
Marco Neumann commented on JENA-2213:
-
Ok I see [~andy] not a big deal these current values now will not break the
build and satisfy SIS1.1 as well.
I have used a VM last night to diff the changes and subsequently have scrubbed
the node and code. But the new proposed values are now recorded here in the
ticket and not mandatory to successfully build the project with SIS1.1
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481005#comment-17481005
]
Andy Seaborne commented on JENA-2213:
-
No - I have not taken the values from your comment. The PR was made several
days earlier.
The project normally works with github pull requests. We accept patches/diffs
on tickets (some people do not wish to use github).
Please read back - I have explained how to attach a diff *as a file* to a JIRA
issue. Screen scraping diffs from text comments is time-consuming, fragile and
error-prone.
The diff needs recreating relative to current the Jena codebase and will need
to only touch the tests. The POM update has been done.
Release are a busy time. I am now able to do the release as-and-when I have
time, and whether or not there are updated jena-geosparql tests.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480983#comment-17480983
]
Marco Neumann commented on JENA-2213:
-
[~andy] if you have used the values from the diff as posted we should be all
set. The tests are now improved. I have used the Centre point Cwmystwyth for
the United Kingdom instead of the coordinates in Africa used in the previous
tests which are outside the scope of the British National Grid and hence have
produced significant differences in the updated version of the model projection
in SIS1.1
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480968#comment-17480968
]
Andy Seaborne commented on JENA-2213:
-
Reopened and marked "resolved" which is how we managed tickets for releases. It
will be closed as part of the release process itself. This makes finding
tickets easier e.g. https://s.apache.org/jena-4.4.0-jira
As I understand the current state, we're waiting for updated tests making the
tests more appropriate for OSGB.
PR #1169 did a basic upgrade and simply updated the results of the affected
tests without assessment for suitability.
We will be at SIS 1.1 for Jena 4.4.0.
[~neumarcx] - I will leave whether you want a separate ticket for the test
improvements, or use this one.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480765#comment-17480765
]
Andy Seaborne commented on JENA-2213:
-
[~neumarcx] A file upload would be much safer. Posting plain text into JIRA is
risky because it is interpreted as JIRA markdown.
Use the attachment control in the edit box of a comment or drag-and-drop a file
onto the issue in the browser.
I can see the diff is made comparing to the codebase at SIS 1.0 so I have just
applied the [PR #1169|https://github.com/apache/jena/pull/1169] to give you
something to diff against which will produce a clean diff.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480761#comment-17480761
]
ASF subversion and git services commented on JENA-2213:
---
Commit 5bcb0e1cf7ec223a0b9ced6c07cedf49561588e0 in jena's branch
refs/heads/main from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=5bcb0e1 ]
Merge pull request #1169 from afs/sis-update
JENA-2213: Update to Apache SIS 1.1; align tests to SIS changes.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480760#comment-17480760
]
ASF subversion and git services commented on JENA-2213:
---
Commit e12468a400dbcab321be424e258219525938bc00 in jena's branch
refs/heads/main from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=e12468a ]
JENA-2213: Update to Apache SIS 1.1; align tests to SIS changes.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480758#comment-17480758
]
Marco Neumann commented on JENA-2213:
-
diff --git
a/jena-geosparql/src/test/java/org/apache/jena/geosparql/implementation/SRSInfoTest.java
b/jena-geosparql/src/test/java/org/apache/jena/geosparql/implementation/SRSInfoTest.java
index 86e987a829..607f5306e7 100644
---
a/jena-geosparql/src/test/java/org/apache/jena/geosparql/implementation/SRSInfoTest.java
+++
b/jena-geosparql/src/test/java/org/apache/jena/geosparql/implementation/SRSInfoTest.java
@@ -99,7 +99,8 @@ public class SRSInfoTest {
CoordinateReferenceSystem crs = CRS.forCode(srsURI);
Boolean isAxisXY = SRSInfo.checkAxisXY(crs);
-Envelope expResult = new Envelope(-118397.00138845091,
751441.7790901454, -16627.734375018626, 1272149.3463499574);
+//Envelope expResult = new Envelope(-118397.00138845091,
751441.7790901454, -16627.734375018626, 1272149.3463499574);
+ Envelope expResult = new Envelope(-104009.35713717458,
688806.0073395987, -16627.734528041445, 1256558.4455361878);
Envelope result = SRSInfo.buildDomainEnvelope(crs, isAxisXY);
assertEquals(expResult, result);
}
diff --git
a/jena-geosparql/src/test/java/org/apache/jena/geosparql/spatial/SearchEnvelopeTest.java
b/jena-geosparql/src/test/java/org/apache/jena/geosparql/spatial/SearchEnvelopeTest.java
index fbeb3211e6..04c4eca967 100644
---
a/jena-geosparql/src/test/java/org/apache/jena/geosparql/spatial/SearchEnvelopeTest.java
+++
b/jena-geosparql/src/test/java/org/apache/jena/geosparql/spatial/SearchEnvelopeTest.java
@@ -61,10 +61,10 @@ public class SearchEnvelopeTest {
public static final double Y1 = -90;
public static final double Y2 = 90;
-public static final double OS_X1 = -118397.00138845091;
-public static final double OS_X2 = 751441.7790901454;
-public static final double OS_Y1 = -16627.734375018626;
-public static final double OS_Y2 = 1272149.3463499574;
+public static final double OS_X1 = -104009.35713717458;
+public static final double OS_X2 = 688806.0073395987;
+public static final double OS_Y1 = -16627.734528041445;
+public static final double OS_Y2 = 1256558.4455361878;
/**
* Test of build method, of class SearchEnvelope.
@@ -150,9 +150,9 @@ public class SearchEnvelopeTest {
@Test
public void testBuild_NORTH_OSGB() {
-GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(10.0 20.0)", WKTDatatype.URI);
+GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(52.33022 -3.766409)", WKTDatatype.URI);
CardinalDirection direction = CardinalDirection.NORTH;
-SearchEnvelope expResult = new SearchEnvelope(new Envelope(OS_X1,
OS_X2, 20, OS_Y2), SpatialIndexTestData.OSGB_SRS_INFO);
+SearchEnvelope expResult = new SearchEnvelope(new Envelope(OS_X1,
OS_X2, -3.766409, OS_Y2), SpatialIndexTestData.OSGB_SRS_INFO);
SearchEnvelope result = SearchEnvelope.build(geometryWrapper,
SpatialIndexTestData.OSGB_SRS_INFO, direction);
assertEquals(expResult, result);
}
@@ -163,9 +163,9 @@ public class SearchEnvelopeTest {
@Test
public void testBuild_SOUTH_OSGB() {
-GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(10.0 20.0)", WKTDatatype.URI);
+GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(52.33022 -3.766409)", WKTDatatype.URI);
CardinalDirection direction = CardinalDirection.SOUTH;
-SearchEnvelope expResult = new SearchEnvelope(new Envelope(OS_X1,
OS_X2, OS_Y1, 20), SpatialIndexTestData.OSGB_SRS_INFO);
+SearchEnvelope expResult = new SearchEnvelope(new Envelope(OS_X1,
OS_X2, OS_Y1, -3.766409), SpatialIndexTestData.OSGB_SRS_INFO);
SearchEnvelope result = SearchEnvelope.build(geometryWrapper,
SpatialIndexTestData.OSGB_SRS_INFO, direction);
assertEquals(expResult, result);
}
@@ -176,9 +176,9 @@ public class SearchEnvelopeTest {
@Test
public void testBuild_EAST_OSGB() {
-GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(10.0 20.0)", WKTDatatype.URI);
+GeometryWrapper geometryWrapper =
GeometryWrapper.extract("
POINT(52.33022 -3.766409)", WKTDatatype.URI);
CardinalDirection direction = CardinalDirection.EAST;
-SearchEnvelope expResult = new SearchEnvelope(new Envelope(10, OS_X2,
OS_Y1, OS_Y2), SpatialIndexTestData.OSGB_SRS_INFO);
+SearchEnvelope expResult = new SearchEnvelope(new Envelope(52.33022,
OS_X2, OS_Y1, OS_Y2),
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478800#comment-17478800
]
Marco Neumann commented on JENA-2213:
-
so I have compiled the project the SIS1.1 jar which seems to run fine and pass
the tests.
Is the javax.xml to jakarta.xml switch an issue for Jena?
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478775#comment-17478775
]
Marco Neumann commented on JENA-2213:
-
"Not for me.
main fails to compile without org.apache.sis.core:sis-referencing."
if I understand you correctly it fails if the jar is not present? What I meant
It should build without setting the SIS_DATA environment variable set to SIS
1.0.
I think the easiest way forward would be to remove the tests that depend on
version specific SIS1.0 results.
I am not sure yet what happens to the project if you upgrade the
dependencies/jars to SIS1.1 in the Apache Jena project.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478757#comment-17478757
]
Andy Seaborne commented on JENA-2213:
-
> jena-geosparql does compile and pass tests without "external" SIS presence.
Not for me.
main fails to compile without {{org.apache.sis.core:sis-referencing}}.
For SIS 1.1, I get {{[ERROR] Tests run: 1110, Failures: 5, Errors: 0, Skipped:
2}}
Without the non-free test dependency, I get {{[ERROR] Tests run: 1110,
Failures: 9, Errors: 171, Skipped: 2}}.
As RM, I can say that special-casing one module is a cost and detracts from
ensuring a smooth build and release.
> Going forward we are limited to SIS1.0 in the build.
Bold statement. Why not upgrade and update the tests? To my untrained eye, we
are not merely talking about changes to the calculation - some coordinates are
changing by large amounts.
We can not, over the long term (1 year? 5 years?), remain fixed at 1.0 unless
SIS commit to maintaining that version with fixes and security governance, let
alone all its transitive dependencies.
(I do not see a maintenance branch for 1.0 in their git repo.)
We don't have to makes any changes for Jena 4.4.0 but we have to do something.
The status quo is not sustainable. I do not want it left until it forced on the
project.
[^Diff-SIS-1.1]
Note - also they switched from {{javax.xml}} to {{jakarta.xml}}.
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.0:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
...
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.0:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test{noformat}
{noformat}
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.1:compile
[INFO] | +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
[INFO] | | \- jakarta.activation:jakarta.activation-api:jar:1.2.2:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
...
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.1:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test
{noformat}
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478662#comment-17478662
]
Marco Neumann commented on JENA-2213:
-
jena-geosparql does compile and pass tests without "external" SIS presence.
The dependency substitution is not meant to help the build. The SIS tests in
Apache Jena are hardcoded for SIS1.0.
I hope this clarifies the situation. Going forward we are limited to SIS1.0 in
the build.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478656#comment-17478656
]
Andy Seaborne commented on JENA-2213:
-
What stub are you referring to? {{jena-geosparql}} does not compile without SIS.
Why are we trying to support both?
Sounds like you have done is a dependency substitution - that doesn't help the
build.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478645#comment-17478645
]
Marco Neumann commented on JENA-2213:
-
that is indeed the case with a very limited set of reference coordinates. so if
SIS1.1 is not present Apache Jena will make use is the stub and successfully
build the project. If SIS 1.0 is present Apache Jena will build successfully as
well. If SIS1.1 is present values of transformations will change and the tests
will fail. In that sense SIS1.0 is a hard requirement for running the build
with tests. That said I am using SIS 1.1 with my own code and the Apache Jena
API and I haven't experienced any issues yet during runtime.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478612#comment-17478612
]
Andy Seaborne commented on JENA-2213:
-
Jena ships {{org.apache.sis.core:sis-referencing}} in the combined jar for
jena-fuseki-geosparql. We specific the version of SIS in the top POM.
I'm not clear whether the change is there or the test-only, non-free
{{org.apache.sis.non-free:sis-embedded-data}}.
But they have the same version number and, for me, the "barrier" on mixed
versions is very high.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478600#comment-17478600
]
Marco Neumann commented on JENA-2213:
-
5 Failures
SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
SearchEnvelopeTest.testBuild_EAST_OSGB:183
SearchEnvelopeTest.testBuild_NORTH_OSGB:157
SearchEnvelopeTest.testBuild_SOUTH_OSG:170
SearchEnvelopeTest.testBuild_WEST_OSGB:196
I have discussed these issues with the Apache SIS team last year and these are
indeed value changes based on an improved accuracy in the numeric approximation
of the underlying reference system.
We could test for a specific versions of SIS in the Apache Jena tests and
proceed accordingly. Or remove these tests entirely as the user decides which
SIS version they are using on the sub system in any event. This in my
experience is not transparent to the average Apache Jena user during maven
builds and removal of these tests might be advisable or we will have to enforce
a specific SIS version (1.0) in the description of the project setup to build
successfully with tests.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478580#comment-17478580
]
Andy Seaborne commented on JENA-2213:
-
[~neumarcx] "These tests" - how many?
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478574#comment-17478574
]
Marco Neumann commented on JENA-2213:
-
Andy, these are value comparison errors based on a change to the reference
system model in SIS. Therefore these tests will from now on always fail with
Jena in combination with SIS 1.1+ implementations.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478570#comment-17478570
]
Andy Seaborne commented on JENA-2213:
-
Any news here?
Is there just one failure? If not - how man test fail?
Should we upgrade in time for Jena 4.4.0?
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
