Problems with struts-faces
Hi Craig, I’m a profesional developer from Spain. We are decided to used strtus-faces jar to migrate an application from Struts to JSF. We have followed all steps described in PDF Migrating from Struts to JavaServer Faces from Kito. We can see the JSF page and everything is OK excepts the action form. When we see the generated source code for the page is like that form id=j_id_jsp_517671304_8 name=mantenimientoControlStockForm action=/Diana/WEB-INF/ram/almacen/pages/faces/MantenimientoControlStock.do method=post And the proper code action would be like that form id=j_id_jsp_517671304_8 name=mantenimientoControlStockForm action=/Diana/MantenimientoControlStock.do method=post So we can’t submit the form properly. Looking for Internet some people had the same error but there are no answers for them. Could you help us? Thanks a lot. Regards.
struts-faces problem not invoking Action class displaying blank page
Hi, I am using struts and JSF using struts-faces 1.3.8.jar file and using WSAD 5.1.2 My jsf page is like this s:form action=/logon .. h:commandbutton type=submit value=ok /s:form As soon as I click on submit button blank page displaying. No error it is showing it is populating ActionForm but it not invoking my Action class My struts-config.xml file is !-- Form Beans -- form-beans form-bean name=logonForm type=example.LogonForm/ /form-beans !-- Global Exceptions -- global-exceptions /global-exceptions !-- Global Forwards -- global-forwards /global-forwards !-- Action Mappings -- action-mappings action path=/logon type=example.LogonAction name=logonForm input=login.faces scope=request forward name=success path=/Success.faces/forward forward name=failure path=/error.faces/forward /action /action-mappings controller locale=true set-property property=processorClass value=org.apache.struts.faces.application.FacesRequestProcessor/ /controller Please help me it is urgent.. Thanks Regards, Sadasivarao Alokam, Wipro Technologies, Madhapur, Hyderabad, India Tel : +91-40-30795443 Mobile: +91-9989228936 The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com
Re: struts-faces problem not invoking Action class displaying blank page
On 7/3/07, sadasivarao [EMAIL PROTECTED] wrote: Hi, I am using struts and JSF using struts-faces 1.3.8.jar file and using WSAD 5.1.2 My jsf page is like this s:form action=/logon h:commandbutton type=submit value=ok /s:form As soon as I click on submit button blank page displaying. No error it is showing it is populating ActionForm but it not invoking my Action class My struts-config.xml file is !-- Form Beans -- form-beans form-bean name=logonForm type=example.LogonForm/ /form-beans !-- Global Exceptions -- global-exceptions /global-exceptions !-- Global Forwards -- global-forwards /global-forwards !-- Action Mappings -- action-mappings action path=/logon type=example.LogonAction name=logonForm input=login.faces scope=request forward name=success path=/Success.faces/forward forward name=failure path=/error.faces/forward /action /action-mappings controller locale=true set-property property=processorClass value=org.apache.struts.faces.application.FacesRequestProcessor/ /controller Please help me it is urgent.. Please ask questions like this on the user mailing list - this list is to discuss the development of Struts: http://struts.apache.org/mail.html Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces integration problem with existing struts based application?
Please post questions about using Struts to the Struts Users list only. The Struts Dev list is for discussing the development and enhancement of Struts itself. http://struts.apache.org/mail.html vijendra wrote: I am trying to integrate struts-faces in my previous struts based application. i am unable to get required results. the libraries i am using are:-(mainly) commons-beanutils-1.7.0, commons-chain-1.1, commons-digester-1.8, commons-lang-2.3, struts-faces-1.3.8, tomahawk-1.1.5, log4j-1.2.8, myfaces-api, myfaces-impl, struts, struts-el-1.3.8, struts-taglib-1.3.8, struts-extras-1.3.8, and many more. i feel these are the responsible files which are really required to be there. Now what i did is configured web.xml with faces settings. configured faces-config.xml. when i modified web.xml for faces integration and calling a page from some other page giving extention as faces to my new page either it gives me exception.or sometimes it comes as many templets shown in loop(one in other and so on:- useless) but original content is not shown. Exception is : javax.faces.FacesException: javax.servlet.jsp.JspException: org.apache.myfaces.context.servlet.ServletExternalContextImpl.dispatch(ServletExternalContextImpl.java: 422) and if i try using /faces/* combination it dosen't comes out at all. (In this case my doubt is its unable to find out the page itself) But when i am calling a particular jsp page(reporthome.faces) which was earlier normal jsp from index page.i modified this page with struts-faces libraries with what i require. but it first of all loads very slowly , sometime shows the same page in looped condition so upper tags are getting displayed many times and other data is gone. and finally it comes up with exception javax.faces.FacesException: org.apache.myfaces.context.servlet.ServletExternalContextImpl.dispatch(ServletExternalContextImpl.java: 422) this exception comes in many different situation but comes mostly. so what is the reason behind. please guide me. thanks vijendra - Posted via Jive Forums http://forums.opensymphony.com/thread.jspa?threadID=84385messageID=151283#151283 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces integration problem with existing struts based application?
I am trying to integrate struts-faces in my previous struts based application. i am unable to get required results. the libraries i am using are:-(mainly) commons-beanutils-1.7.0, commons-chain-1.1, commons-digester-1.8, commons-lang-2.3, struts-faces-1.3.8, tomahawk-1.1.5, log4j-1.2.8, myfaces-api, myfaces-impl, struts, struts-el-1.3.8, struts-taglib-1.3.8, struts-extras-1.3.8, and many more. i feel these are the responsible files which are really required to be there. Now what i did is configured web.xml with faces settings. configured faces-config.xml. when i modified web.xml for faces integration and calling a page from some other page giving extention as faces to my new page either it gives me exception.or sometimes it comes as many templets shown in loop(one in other and so on:- useless) but original content is not shown. Exception is : javax.faces.FacesException: javax.servlet.jsp.JspException: org.apache.myfaces.context.servlet.ServletExternalContextImpl.dispatch(ServletExternalContextImpl.java: 422) and if i try using /faces/* combination it dosen't comes out at all. (In this case my doubt is its unable to find out the page itself) But when i am calling a particular jsp page(reporthome.faces) which was earlier normal jsp from index page.i modified this page with struts-faces libraries with what i require. but it first of all loads very slowly , sometime shows the same page in looped condition so upper tags are getting displayed many times and other data is gone. and finally it comes up with exception javax.faces.FacesException: org.apache.myfaces.context.servlet.ServletExternalContextImpl.dispatch(ServletExternalContextImpl.java: 422) this exception comes in many different situation but comes mostly. so what is the reason behind. please guide me. thanks vijendra - Posted via Jive Forums http://forums.opensymphony.com/thread.jspa?threadID=84385messageID=151283#151283 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
struts-faces integration problem with existing struts based application?
i don't know what is wrong but i tried all he things i can do to get the results. http://www-128.ibm.com/developerworks/library/j-integrate/ is the first page i found useful in order to start. the first sample application itself is having many flaws. not designed properly. i tried many modification finally able to run upto some extent. but even to completely run the application supporting libraries ViewHandler and tree, i am unable to find them anywhere. now coming to my application integration part i am trying to modify web.xml for faces navigation where i used /faces/* and *.faces both options separately but nothing has given be desired results till now. Eevn i tried posting my problem in some diff sites but till now unable to get the solution. if either some can give me the real path with libraries to be used i may retry doing it again. till now i am unable to dispaly the fist jsf(faces) page in my application. i don't know how to prooceed now. is this whole problem because of version mismatch. what i tried is here:- http://forum.java.sun.com/thread.jspa?threadID=5173587 please guide me which way to go now. - Posted via Jive Forums http://forums.opensymphony.com/thread.jspa?threadID=84385messageID=150592#150592 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[s1.3.6] Where to download struts-faces?
We have this site issue https://issues.apache.org/struts/browse/STR-2926 The complaint is we don't have any download links for Struts-Faces. Now with the 1.3.5 release, struts-faces is part of the library. However, that wasn't the case with earlier releases. Do we want to provide a link on the website anywhere to previous releases? Or consider this defect solved by 1.3.5? Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s1.3.6] Where to download struts-faces?
On 11/28/06, Paul Benedict [EMAIL PROTECTED] wrote: We have this site issue https://issues.apache.org/struts/browse/STR-2926 The complaint is we don't have any download links for Struts-Faces. Now with the 1.3.5 release, struts-faces is part of the library. However, that wasn't the case with earlier releases. Do we want to provide a link on the website anywhere to previous releases? Or consider this defect solved by 1.3.5? I don't think we ever had a release of faces on its own. In the 1.2.x series it was in the Sandbox (and distrubuted in the contrib folder of the release). For 1.3.5 it had been merged back in under Struts1. So I don't think we need a download link for it. Niall Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Struts-Faces] commandLink obsolete ?
wow, it is still there :) On 10/27/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: commandLink was create in 2004, b/c of a RI bug. I guess (or assume) that it has been fixed there. works fine w/ MyFaces. however inside trinidad/adf the commandLink will not work ... -M -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Struts-Faces] commandLink obsolete ?
the bug, so can sb apply the patch ? On 10/28/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: wow, it is still there :) On 10/27/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: commandLink was create in 2004, b/c of a RI bug. I guess (or assume) that it has been fixed there. works fine w/ MyFaces. however inside trinidad/adf the commandLink will not work ... -M -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Struts-Faces] possible Bug in FormRenderer
On 10/26/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hey, two things. a) is this the right place to ask questions on Struts-Faces, or where ? It's the right place for dev type questions ... the Struts User list for user type questions :-). if so b) the demos of struts faces show a portal which uses links (done w/ JSF-components) to navigate to a tiles pages, which finally contains a s:form based formular. that is the key... ActionForm/Action on the java side and JSF comp.s on the page side. Every thing works. A form-submit sends a req. to the action So far so good... When I am converting one of my own apps w/ struts-faces I'd like to stay with html:link for linking to form pages (that are using s:form). But ... In other words, you want to use the Struts html:link tag in a form surrounded by the JSF s:form component? That's very likely not going to work reliably. You should stick to one technology or the other for all of your view tier tags on any particular page -- either the Struts HTML tags or the appropriate JSF component tags. You are only scratching the surface of a lot of problems that will show up trying to mix them. Craig since that is a GET request the form renders html like form name=fooForm action=/blub/tilesMasterLayout.do ... (only when using GET / html:link) so ... a submit causes a 404. Not wondering :) When I use firebug to change the action attr value to /blub/tilesMasterLayout.faces every thing works. Action is called. The action() method in FormRenderer returns in the wrong szenario a .do URL I think it is not to bad to check agains a struts pattern in that URL and replace that .do (if needed) with the jsf pattern (like .faces or add /faces/) I think this is valid, because the form renders already fine, which ensures you are inside the FacesContext ... If you all agree, I'd like to provide the patch for that. Greetz, Matt -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: [Struts-Faces] commandLink obsolete ?
On 10/28/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: the bug, so can sb apply the patch ? On 10/28/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: wow, it is still there :) What patch? If it's something in the Struts JIRA, add a comment to the issue. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Struts-Faces] commandLink obsolete ?
The bug is still in the RI (1.1._02) so s:commandLink is not obsolate. the bug in s:commandLink is, that it is not working w/ Trinidad http://issues.apache.org/struts/browse/STR-2966 -M On 10/28/06, Wendy Smoak [EMAIL PROTECTED] wrote: On 10/28/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: the bug, so can sb apply the patch ? On 10/28/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: wow, it is still there :) What patch? If it's something in the Struts JIRA, add a comment to the issue. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts-Faces] possible Bug in FormRenderer
Hey, two things. a) is this the right place to ask questions on Struts-Faces, or where ? if so b) the demos of struts faces show a portal which uses links (done w/ JSF-components) to navigate to a tiles pages, which finally contains a s:form based formular. that is the key... ActionForm/Action on the java side and JSF comp.s on the page side. Every thing works. A form-submit sends a req. to the action So far so good... When I am converting one of my own apps w/ struts-faces I'd like to stay with html:link for linking to form pages (that are using s:form). But ... since that is a GET request the form renders html like form name=fooForm action=/blub/tilesMasterLayout.do ... (only when using GET / html:link) so ... a submit causes a 404. Not wondering :) When I use firebug to change the action attr value to /blub/tilesMasterLayout.faces every thing works. Action is called. The action() method in FormRenderer returns in the wrong szenario a .do URL I think it is not to bad to check agains a struts pattern in that URL and replace that .do (if needed) with the jsf pattern (like .faces or add /faces/) I think this is valid, because the form renders already fine, which ensures you are inside the FacesContext ... If you all agree, I'd like to provide the patch for that. Greetz, Matt -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts-Faces] commandLink obsolete ?
commandLink was create in 2004, b/c of a RI bug. I guess (or assume) that it has been fixed there. works fine w/ MyFaces. however inside trinidad/adf the commandLink will not work ... -M -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [SAF1 - Struts-Faces] s:loadMessages / can't load the correct MessageResources in a multimodule webapp
Hi Craig,
I found also a similiar problem with the s:message / tag. I will open a
now issue about them two.
Alonso
2006/5/12, Craig McClanahan [EMAIL PROTECTED]:
On 5/12/06, A. Alonso Dominguez [EMAIL PROTECTED] wrote:
Hi there,
I think that there is a bug in the implementation of the
org.apache.struts.faces.taglib.LoadMessagesTag. When working in a
multimodule webapp with several messages-resources / per module, the
s:loadMessages / tag can't find the appropiate MessageResources
instance
via messages attribute.
The reason for this is the way that the tag uses to locate the
appropiate
MessageResources instance. This code explains it (line 76):
public int doStartTag() {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.APPLICATION_SCOPE
);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
}
// Expose a Map instance under the specified request attribute
key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.APPLICATION_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
As you can see, this code doesn't supports modules.
If we want to load a different bundle than the one configured as the
default, we must use the messages attribute but this code tries to
load
that MessageResources instance from the APPLICATION_SCOPE rather that
search
for it inside the REQUEST_SCOPE.
In a multimodule webapp the MessageResources instances are loaded on
startup
inside the APPLICATION_SCOPE with the key:
org.apache.struts.action/MESSAGE + [modulePrefix]
If we have more than one MessageResources instance per module the will
be
loaded with the key:
[bundleKey] + [modulePrefix]
So, the above code can't load any of those kind of messages resources.
This
can be solved easily:
public int doStartTag() throws JspException {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
ModuleConfig modConfig = ModuleUtils.getInstance
().getModuleConfig(
(HttpServletRequest) pageContext.getRequest(),
pageContext.getServletContext());
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE
);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
if(messages == null) {
messages = (MessageResources)
pageContext.getAttribute(this.messages +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE
);
}
}
if(messages == null)
throw new JspException(MessageResources bundle +
this.messages + not
found);
// Expose a Map instance under the specified request attribute
key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.REQUEST_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
Should I open a new issue about this?
Yes please ... this is not an issue (pardon the pun :-) that I was aware
of.
http://issues.apache.org/struts/
Alonso
Craig
[SAF1 - Struts-Faces] s:loadMessages / can't load the correct MessageResources in a multimodule webapp
Hi there,
I think that there is a bug in the implementation of the
org.apache.struts.faces.taglib.LoadMessagesTag. When working in a
multimodule webapp with several messages-resources / per module, the
s:loadMessages / tag can't find the appropiate MessageResources instance
via messages attribute.
The reason for this is the way that the tag uses to locate the appropiate
MessageResources instance. This code explains it (line 76):
public int doStartTag() {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.APPLICATION_SCOPE);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
}
// Expose a Map instance under the specified request attribute key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.APPLICATION_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
As you can see, this code doesn't supports modules.
If we want to load a different bundle than the one configured as the
default, we must use the messages attribute but this code tries to load
that MessageResources instance from the APPLICATION_SCOPE rather that search
for it inside the REQUEST_SCOPE.
In a multimodule webapp the MessageResources instances are loaded on startup
inside the APPLICATION_SCOPE with the key:
org.apache.struts.action/MESSAGE + [modulePrefix]
If we have more than one MessageResources instance per module the will be
loaded with the key:
[bundleKey] + [modulePrefix]
So, the above code can't load any of those kind of messages resources. This
can be solved easily:
public int doStartTag() throws JspException {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
ModuleConfig modConfig = ModuleUtils.getInstance().getModuleConfig(
(HttpServletRequest) pageContext.getRequest(),
pageContext.getServletContext());
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
if(messages == null) {
messages = (MessageResources)
pageContext.getAttribute(this.messages +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE);
}
}
if(messages == null)
throw new JspException(MessageResources bundle +
this.messages + not
found);
// Expose a Map instance under the specified request attribute key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.REQUEST_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
Should I open a new issue about this?
Alonso
Re: [SAF1 - Struts-Faces] s:loadMessages / can't load the correct MessageResources in a multimodule webapp
On 5/12/06, A. Alonso Dominguez [EMAIL PROTECTED] wrote:
Hi there,
I think that there is a bug in the implementation of the
org.apache.struts.faces.taglib.LoadMessagesTag. When working in a
multimodule webapp with several messages-resources / per module, the
s:loadMessages / tag can't find the appropiate MessageResources instance
via messages attribute.
The reason for this is the way that the tag uses to locate the appropiate
MessageResources instance. This code explains it (line 76):
public int doStartTag() {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.APPLICATION_SCOPE
);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
}
// Expose a Map instance under the specified request attribute key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.APPLICATION_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
As you can see, this code doesn't supports modules.
If we want to load a different bundle than the one configured as the
default, we must use the messages attribute but this code tries to load
that MessageResources instance from the APPLICATION_SCOPE rather that
search
for it inside the REQUEST_SCOPE.
In a multimodule webapp the MessageResources instances are loaded on
startup
inside the APPLICATION_SCOPE with the key:
org.apache.struts.action/MESSAGE + [modulePrefix]
If we have more than one MessageResources instance per module the will be
loaded with the key:
[bundleKey] + [modulePrefix]
So, the above code can't load any of those kind of messages resources.
This
can be solved easily:
public int doStartTag() throws JspException {
// Acquire the Locale to be wrapped
Locale locale =
FacesContext.getCurrentInstance().getViewRoot().getLocale();
ModuleConfig modConfig = ModuleUtils.getInstance
().getModuleConfig(
(HttpServletRequest) pageContext.getRequest(),
pageContext.getServletContext());
// Acquire the MessageResources to be wrapped
MessageResources messages = null;
if (this.messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY,
PageContext.REQUEST_SCOPE);
if (messages == null) {
messages = (MessageResources)
pageContext.getAttribute(Globals.MESSAGES_KEY +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE
);
}
} else {
messages = (MessageResources)
pageContext.getAttribute(this.messages,
PageContext.REQUEST_SCOPE);
if(messages == null) {
messages = (MessageResources)
pageContext.getAttribute(this.messages +
modConfig.getPrefix(),
PageContext.APPLICATION_SCOPE
);
}
}
if(messages == null)
throw new JspException(MessageResources bundle +
this.messages + not
found);
// Expose a Map instance under the specified request attribute key
pageContext.setAttribute(var,
new MessagesMap(messages, locale),
PageContext.REQUEST_SCOPE);
// Skip the body of this tag (if any)
return (SKIP_BODY);
}
Should I open a new issue about this?
Yes please ... this is not an issue (pardon the pun :-) that I was aware of.
http://issues.apache.org/struts/
Alonso
Craig
Re: Struts-Faces: Is this a bug?
A created a new issue about this bug:
http://issues.apache.org/struts/browse/STR-2873
2006/5/11, Craig McClanahan [EMAIL PROTECTED]:
On 5/9/06, A. Alonso Dominguez [EMAIL PROTECTED] wrote:
Hi there!
I'm trying to use the new struts-action framework, version 1.3.3 with
tiles
and faces. I'm following the example applications but I found possibly a
bug
when rendering a struts-based FormBean.
The jsp code that I was using is as follows:
s:errors /
s:form action=/login id=login styleClass=loginForm
focus=username
h:panelGrid columns=2
f:facet name=header
h:panelGroup
h:graphicImage
url=/common/skin/social-labs/img/circle1.png
/
s:message key=page.logon.form
f:param name=arg0 value=Social Labs /
/s:message
/h:panelGroup
/f:facet
h:outputLabel for=username
s:message key=form.logon.username /
/h:outputLabel
h:inputText id=username size=25 value=#{logonForm.username
}
/
h:outputLabel for=password
s:message filter=false key=form.logon.password /
/h:outputLabel
h:inputSecret id=password size=25 value=#{
logonForm.password}
/
f:facet name=footer
h:commandButton id=submit type=SUBMIT styleClass=img
image=/common/skin/social-labs/img/login.png /
/f:facet
/h:panelGrid
/s:form
but when it's rendered to the view, the HTML form's action attribute
references /common/skin/default/layout/base.do. There is not any
action
in
my application with that url. Instead there is a file
/common/skin/default/layout/base.jsp which is the base file for the
tiles
definitions:
definition name=base.layout
page=/common/skin/default/layout/base.jsp
put name=title value= /
put name=navigation value= /
put name=body value= /
putList name=scripts
add value= /
/putList
/definition
I dived inside the org.apache.struts.faces.renderer.FormRenderer code
and
I found this code (line 280):
protected String action(FacesContext context, UIComponent component) {
String actionURL =
context.getApplication().getViewHandler().
getActionURL(context, context.getViewRoot().getViewId());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot
().getViewId()
+
) -- + actionURL);
}
return (context.getExternalContext
().encodeActionURL(actionURL));
}
which really does nothing with the actionURL, It just takes de
ViewRootId
and returns it to the caller.
Playing with this code I have now the following:
protected String action(FacesContext context, UIComponent component,
ModuleConfig moduleConfig) {
//String actionURL =
//context.getApplication ().getViewHandler().
//getActionURL(context, context.getViewRoot().getViewId());
FormComponent form = (FormComponent) component;
String actionURL = context.getApplication().getViewHandler().
getActionURL(context, moduleConfig.getPrefix() +
form.getAction());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot
().getViewId()
+
) -- + actionURL);
}
return (context.getExternalContext
().encodeActionURL(actionURL));
}
I don't know if this is the correct way for retrieving the real
actionURL
but It works now and I'm using it.
Should this be posted as a bug??
Yes, this does sound like a bug. Could you please file an issue on it,
using project name Struts Action 1 and component Faces?
http://issues.apache.org/struts/
Craig
Re: Struts-Faces: Is this a bug?
On 5/9/06, A. Alonso Dominguez [EMAIL PROTECTED] wrote:
Hi there!
I'm trying to use the new struts-action framework, version 1.3.3 with
tiles
and faces. I'm following the example applications but I found possibly a
bug
when rendering a struts-based FormBean.
The jsp code that I was using is as follows:
s:errors /
s:form action=/login id=login styleClass=loginForm
focus=username
h:panelGrid columns=2
f:facet name=header
h:panelGroup
h:graphicImage
url=/common/skin/social-labs/img/circle1.png
/
s:message key=page.logon.form
f:param name=arg0 value=Social Labs /
/s:message
/h:panelGroup
/f:facet
h:outputLabel for=username
s:message key=form.logon.username /
/h:outputLabel
h:inputText id=username size=25 value=#{logonForm.username}
/
h:outputLabel for=password
s:message filter=false key=form.logon.password /
/h:outputLabel
h:inputSecret id=password size=25 value=#{logonForm.password}
/
f:facet name=footer
h:commandButton id=submit type=SUBMIT styleClass=img
image=/common/skin/social-labs/img/login.png /
/f:facet
/h:panelGrid
/s:form
but when it's rendered to the view, the HTML form's action attribute
references /common/skin/default/layout/base.do. There is not any action
in
my application with that url. Instead there is a file
/common/skin/default/layout/base.jsp which is the base file for the
tiles
definitions:
definition name=base.layout
page=/common/skin/default/layout/base.jsp
put name=title value= /
put name=navigation value= /
put name=body value= /
putList name=scripts
add value= /
/putList
/definition
I dived inside the org.apache.struts.faces.renderer.FormRenderer code
and
I found this code (line 280):
protected String action(FacesContext context, UIComponent component) {
String actionURL =
context.getApplication().getViewHandler().
getActionURL(context, context.getViewRoot().getViewId());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot().getViewId()
+
) -- + actionURL);
}
return (context.getExternalContext().encodeActionURL(actionURL));
}
which really does nothing with the actionURL, It just takes de ViewRootId
and returns it to the caller.
Playing with this code I have now the following:
protected String action(FacesContext context, UIComponent component,
ModuleConfig moduleConfig) {
//String actionURL =
//context.getApplication ().getViewHandler().
//getActionURL(context, context.getViewRoot().getViewId());
FormComponent form = (FormComponent) component;
String actionURL = context.getApplication().getViewHandler().
getActionURL(context, moduleConfig.getPrefix() +
form.getAction());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot().getViewId()
+
) -- + actionURL);
}
return (context.getExternalContext().encodeActionURL(actionURL));
}
I don't know if this is the correct way for retrieving the real actionURL
but It works now and I'm using it.
Should this be posted as a bug??
Yes, this does sound like a bug. Could you please file an issue on it,
using project name Struts Action 1 and component Faces?
http://issues.apache.org/struts/
Craig
Struts-Faces: Is this a bug?
Hi there!
I'm trying to use the new struts-action framework, version 1.3.3 with tiles
and faces. I'm following the example applications but I found possibly a bug
when rendering a struts-based FormBean.
The jsp code that I was using is as follows:
s:errors /
s:form action=/login id=login styleClass=loginForm focus=username
h:panelGrid columns=2
f:facet name=header
h:panelGroup
h:graphicImage url=/common/skin/social-labs/img/circle1.png
/
s:message key=page.logon.form
f:param name=arg0 value=Social Labs /
/s:message
/h:panelGroup
/f:facet
h:outputLabel for=username
s:message key=form.logon.username /
/h:outputLabel
h:inputText id=username size=25 value=#{logonForm.username}
/
h:outputLabel for=password
s:message filter=false key=form.logon.password /
/h:outputLabel
h:inputSecret id=password size=25 value=#{logonForm.password} /
f:facet name=footer
h:commandButton id=submit type=SUBMIT styleClass=img
image=/common/skin/social-labs/img/login.png /
/f:facet
/h:panelGrid
/s:form
but when it's rendered to the view, the HTML form's action attribute
references /common/skin/default/layout/base.do. There is not any action in
my application with that url. Instead there is a file
/common/skin/default/layout/base.jsp which is the base file for the tiles
definitions:
definition name=base.layout page=/common/skin/default/layout/base.jsp
put name=title value= /
put name=navigation value= /
put name=body value= /
putList name=scripts
add value= /
/putList
/definition
I dived inside the org.apache.struts.faces.renderer.FormRenderer code and
I found this code (line 280):
protected String action(FacesContext context, UIComponent component) {
String actionURL =
context.getApplication().getViewHandler().
getActionURL(context, context.getViewRoot().getViewId());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot().getViewId() +
) -- + actionURL);
}
return (context.getExternalContext().encodeActionURL(actionURL));
}
which really does nothing with the actionURL, It just takes de ViewRootId
and returns it to the caller.
Playing with this code I have now the following:
protected String action(FacesContext context, UIComponent component,
ModuleConfig moduleConfig) {
//String actionURL =
//context.getApplication ().getViewHandler().
//getActionURL(context, context.getViewRoot().getViewId());
FormComponent form = (FormComponent) component;
String actionURL = context.getApplication().getViewHandler().
getActionURL(context, moduleConfig.getPrefix() +
form.getAction());
if (log.isTraceEnabled()) {
log.trace(getActionURL( + context.getViewRoot().getViewId() +
) -- + actionURL);
}
return (context.getExternalContext().encodeActionURL(actionURL));
}
I don't know if this is the correct way for retrieving the real actionURL
but It works now and I'm using it.
Should this be posted as a bug??
[jira] Moved: (SHALE-91) [struts-faces] Example application doesn't deploy
[ http://issues.apache.org/struts/browse/SHALE-91?page=all ] Craig McClanahan moved STR-2792 to SHALE-91: Project: Shale (was: Struts Action 1) Key: SHALE-91 (was: STR-2792) Component: (was: Faces) Version: (was: Unknown) Assign To: (was: Struts Developer Mailing List) [struts-faces] Example application doesn't deploy - Key: SHALE-91 URL: http://issues.apache.org/struts/browse/SHALE-91 Project: Shale Type: Bug Environment: Operating System: other Platform: Other Reporter: Roland Priority: Critical Hello, I'm running Apache Tomcat/4.1.31 And java version 1.4.2_06 on Linux. I'm trying to deploy the example applications which come with struts-faces-20060313 nightly but I get the following errors: 2006-03-13 14:45:44 WebappLoader[/struts-faces-example2]: Deploy JAR /WEB-INF/lib/struts-faces.jar to /var/roland/CATALINA_BASE/webapps/struts-faces-example2/WEB-INF/lib/struts-faces.jar 2006-03-13 14:45:44 WebappLoader[/struts-faces-example2]: Deploy JAR /WEB-INF/lib/struts.jar to /var/roland/CATALINA_BASE/webapps/struts-faces-example2/WEB-INF/lib/struts.jar 2006-03-13 14:45:44 StandardManager[/struts-faces-example2]: Seeding random number generator class java.security.SecureRandom 2006-03-13 14:45:44 StandardManager[/struts-faces-example2]: Seeding of random number generator has been completed 2006-03-13 14:45:46 StandardContext[/struts-faces-example2]: Exception sending context initialized event to listener instance of class com.sun.faces.config.ConfigureListener java.lang.UnsupportedClassVersionError: org/apache/struts/faces/application/ActionListenerImpl (Unsupported major.minor version 49.0) at java.lang.ClassLoader.defineClass0(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:539) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123) at org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1649) at org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:931) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1373) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1252) at com.sun.faces.util.Util.loadClass(Util.java:403) at com.sun.faces.util.Util.createInstance(Util.java:1150) at com.sun.faces.config.ConfigureListener.configure(ConfigureListener.java:460) at com.sun.faces.config.ConfigureListener.configure(ConfigureListener.java:402) at com.sun.faces.config.ConfigureListener.contextInitialized(ConfigureListener.java:332) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3212) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3554) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:774) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:760) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:548) at org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:260) at org.apache.catalina.core.StandardHost.install(StandardHost.java:741) at org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:445) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:353) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:671) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:311) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1149) at org.apache.catalina.core.StandardHost.start(StandardHost.java:707) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1141) at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:316) at org.apache.catalina.core.StandardService.start(StandardService.java:450) at org.apache.catalina.core.StandardServer.start(StandardServer.java:2143) at org.apache.catalina.startup.Catalina.start(Catalina.java:463) at org.apache.catalina.startup.Catalina.execute(Catalina.java:350) at org.apache.catalina.startup.Catalina.process(Catalina.java:129) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:156) 2006-03-13 14:45:46
Re: Struts Faces - what to do?
Isn't the rule that this should have [faces] or something like that in the subject matter? On 4/13/06, James Mitchell [EMAIL PROTECTED] wrote: Perhaps Craig can shed some light on this, but are we going to continue to support the struts-faces project? If so, can someone please fix the faces example (1 and 2) apps? -- James Mitchell - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- You can lead a horse to water but you cannot make it float on its back. ~Dakota Jack~
Re: Struts Faces - what to do?
On 4/14/06, Dakota Jack [EMAIL PROTECTED] wrote: Isn't the rule that this should have [faces] or something like that in the subject matter? It is a convention, not a rule. And it is more for the user list than the dev list -- people subscribed here are presumed to have a clue :-). Craig
Re: Struts Faces - what to do?
On 4/13/06, James Mitchell [EMAIL PROTECTED] wrote: Perhaps Craig can shed some light on this, but are we going to continue to support the struts-faces project? We should. There will be people who want to have a few JSF components on a few pages (or they want to migrate) -- and using this library is the right strategy for them. Don was also talking about porting this to action2, which I also support. If so, can someone please fix the faces example (1 and 2) apps? Has the source organization and the build scripts settled down now? If so, I can devote some time to this ... but not until the end of next week. One more long trip first (St. Petersburg, Russia). -- James Mitchell Craig
Re: Struts Faces - what to do?
Yes, I believe things have settled down. Although I'm still working changes in the struts-scripting webapp. The error I was getting when deploying the faces-example1 app was: javax.faces.FacesException: Undefined component type org.apache.struts.faces.Html I was under the assumption that the struts-faces library only buys someone partial compatibility. And what they get was only jsf-1.0 compatible anyway, but I will be happy to be corrected. -- James Mitchell On Apr 14, 2006, at 12:14 AM, Craig McClanahan wrote: On 4/13/06, James Mitchell [EMAIL PROTECTED] wrote: Perhaps Craig can shed some light on this, but are we going to continue to support the struts-faces project? We should. There will be people who want to have a few JSF components on a few pages (or they want to migrate) -- and using this library is the right strategy for them. Don was also talking about porting this to action2, which I also support. If so, can someone please fix the faces example (1 and 2) apps? Has the source organization and the build scripts settled down now? If so, I can devote some time to this ... but not until the end of next week. One more long trip first (St. Petersburg, Russia). -- James Mitchell Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts Faces - what to do?
On 4/13/06, James Mitchell [EMAIL PROTECTED] wrote: Yes, I believe things have settled down. Although I'm still working changes in the struts-scripting webapp. The error I was getting when deploying the faces-example1 app was: javax.faces.FacesException: Undefined component type org.apache.struts.faces.Html Sounds like a jar file is missing from the webapp ... not all that surprising giving all the changes going on. I'll take a look. I was under the assumption that the struts-faces library only buys someone partial compatibility. And what they get was only jsf-1.0 compatible anyway, but I will be happy to be corrected. It buys you either JSF 1.0 or 1.1 or 1.2 ... but, more importantly, it buys you the ability to use the UI components part of JSF even if you don't want to use the controller part. For example, it has full integration with Commons Validator and Tiles, but uses JSF component tags instead of Struts HTML tags. -- James Mitchell Craig
svn commit: r393833 - in /struts/action/trunk/faces: ./ core-library/ core-library/src/ src/ systest1-webapp/src/java/org/apache/struts/faces/systest1/
Author: jmitchell
Date: Thu Apr 13 08:31:04 2006
New Revision: 393833
URL: http://svn.apache.org/viewcvs?rev=393833view=rev
Log:
Fixing Faces library and sample apps (Part 1)
* moving src back under core-library
* moving pom.xml back under core-library, the pom at the root of faces should
be similar to the one at the root of apps, which simply delegates to it's
children (modules)
* change ActionError usage to ActionMessage
Added:
struts/action/trunk/faces/core-library/pom.xml
- copied unchanged from r393817, struts/action/trunk/faces/pom.xml
struts/action/trunk/faces/core-library/src/
- copied from r393785, struts/action/trunk/faces/src/
Removed:
struts/action/trunk/faces/pom.xml
struts/action/trunk/faces/src/
Modified:
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/ContextAction.java
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/LogonAction.java
Modified:
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/ContextAction.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/ContextAction.java?rev=393833r1=393832r2=393833view=diff
==
---
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/ContextAction.java
(original)
+++
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/ContextAction.java
Thu Apr 13 08:31:04 2006
@@ -29,7 +29,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.action.ActionError;
import org.apache.struts.action.ActionErrors;
Modified:
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/LogonAction.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/LogonAction.java?rev=393833r1=393832r2=393833view=diff
==
---
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/LogonAction.java
(original)
+++
struts/action/trunk/faces/systest1-webapp/src/java/org/apache/struts/faces/systest1/LogonAction.java
Thu Apr 13 08:31:04 2006
@@ -29,8 +29,9 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.action.ActionError;
import org.apache.struts.action.ActionErrors;
+import org.apache.struts.action.ActionMessage;
+import org.apache.struts.action.ActionMessages;
/**
@@ -60,21 +61,21 @@
PropertyUtils.getSimpleProperty(form, username);
if ((username == null) || (.equals(username))) {
errors.add(username,
- new ActionError(logon.username));
+ new ActionMessage(logon.username));
}
String password = (String)
PropertyUtils.getSimpleProperty(form, password);
if ((password == null) || (.equals(password))) {
errors.add(password,
- new ActionError(logon.password));
+ new ActionMessage(logon.password));
}
if (log.isTraceEnabled()) {
log.trace(username= + username + ,password= + password);
}
if (errors.isEmpty()
(!gooduser.equals(username) || !goodpass.equals(password))) {
-errors.add(ActionErrors.GLOBAL_ERROR,
- new ActionError(logon.mismatch));
+errors.add(ActionMessages.GLOBAL_MESSAGE,
+ new ActionMessage(logon.mismatch));
}
if (errors.isEmpty()) {
if (log.isDebugEnabled()) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Struts Faces - what to do?
Perhaps Craig can shed some light on this, but are we going to continue to support the struts-faces project? If so, can someone please fix the faces example (1 and 2) apps? -- James Mitchell - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r392070 - in /struts/action/trunk: ./ faces/core-library/src/ faces/src/ faces/src/conf/ faces/src/java/ faces/src/java/org/apache/struts/faces/application/ faces/src/test/
Author: mrdon
Date: Thu Apr 6 13:54:30 2006
New Revision: 392070
URL: http://svn.apache.org/viewcvs?rev=392070view=rev
Log:
Adding faces and scripting to the module list, starting to restructure
faces, adding a maven 2 build for faces which works and all tests pass,
made faces work with latest action although backwards compatibility
might be compromised due the use of ModuleUtils and
InvalidCancelException. This should be addressed if we plan to keep
support for old versions of Struts Action 1.
Added:
struts/action/trunk/faces/src/
- copied from r392045, struts/action/trunk/faces/core-library/src/
struts/action/trunk/faces/src/conf/
- copied from r392064, struts/action/trunk/faces/core-library/src/conf/
struts/action/trunk/faces/src/java/
- copied from r392064, struts/action/trunk/faces/core-library/src/java/
struts/action/trunk/faces/src/test/
- copied from r392064, struts/action/trunk/faces/core-library/src/test/
Removed:
struts/action/trunk/faces/core-library/src/
Modified:
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java
struts/action/trunk/pom.xml
Modified:
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/faces/src/java/org/apache/struts/faces/application/ActionListenerImpl.java?rev=392070r1=392064r2=392070view=diff
==
---
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
(original)
+++
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
Thu Apr 6 13:54:30 2006
@@ -36,6 +36,7 @@
import org.apache.struts.faces.Constants;
import org.apache.struts.faces.component.FormComponent;
import org.apache.struts.util.RequestUtils;
+import org.apache.struts.util.ModuleUtils;
/**
@@ -152,7 +153,7 @@
// Invoke the appropriate request processor for this request
try {
request.setAttribute(Constants.ACTION_EVENT_KEY, event);
-RequestUtils.selectModule(request, servletContext);
+ModuleUtils.getInstance().selectModule(request, servletContext);
ModuleConfig moduleConfig = (ModuleConfig)
request.getAttribute(Globals.MODULE_KEY);
if (log.isTraceEnabled()) {
Modified:
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java?rev=392070r1=392064r2=392070view=diff
==
---
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java
(original)
+++
struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java
Thu Apr 6 13:54:30 2006
@@ -38,6 +38,7 @@
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.RequestProcessor;
+import org.apache.struts.action.InvalidCancelException;
import org.apache.struts.config.FormBeanConfig;
import org.apache.struts.config.ForwardConfig;
import org.apache.struts.faces.Constants;
@@ -403,7 +404,7 @@
HttpServletResponse response,
ActionForm form,
ActionMapping mapping)
-throws IOException, ServletException {
+throws IOException, ServletException, InvalidCancelException {
if (log.isTraceEnabled()) {
log.trace(Performing standard validation);
Modified: struts/action/trunk/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/pom.xml?rev=392070r1=392069r2=392070view=diff
==
--- struts/action/trunk/pom.xml (original)
+++ struts/action/trunk/pom.xml Thu Apr 6 13:54:30 2006
@@ -273,6 +273,8 @@
moduleel/module
moduleextras/module
moduletaglib/module
+modulefaces/module
+modulescripting/module
!--moduleapps/module--
/modules
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r392072 - in /struts/action/trunk/faces/src/java/org/apache/struts/faces/application: FacesTilesRequestProcessor.java FacesTilesRequestProcessor.java.bak
Author: mrdon Date: Thu Apr 6 14:00:43 2006 New Revision: 392072 URL: http://svn.apache.org/viewcvs?rev=392072view=rev Log: Moving the tiles version of the Faces request processor out of the build, until we determine what to do with it Added: struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java.bak - copied unchanged from r392071, struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java Removed: struts/action/trunk/faces/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r389368 - in /struts/faces/trunk: core-library/build.xml default.properties example1-webapp/build.xml example2-webapp/build.xml sysclient-app/build.xml systest1-webapp/build.xml
Author: wsmoak
Date: Mon Mar 27 18:43:25 2006
New Revision: 389368
URL: http://svn.apache.org/viewcvs?rev=389368view=rev
Log:
Add source and target attributes to all javac tasks to target JDK 1.3.
Both example webapps now deploy properly in Tomcat 4.1.31 using JDK 1.4.2.
Bug: 38955
Reported By: Roland roland at gisplan.com.br
Added:
struts/faces/trunk/default.properties (with props)
Modified:
struts/faces/trunk/core-library/build.xml
struts/faces/trunk/example1-webapp/build.xml
struts/faces/trunk/example2-webapp/build.xml
struts/faces/trunk/sysclient-app/build.xml
struts/faces/trunk/systest1-webapp/build.xml
Modified: struts/faces/trunk/core-library/build.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/build.xml?rev=389368r1=389367r2=389368view=diff
==
--- struts/faces/trunk/core-library/build.xml (original)
+++ struts/faces/trunk/core-library/build.xml Mon Mar 27 18:43:25 2006
@@ -29,6 +29,7 @@
property file=build.properties/
property file=../build.properties/
property file=../../build.properties/
+ property file=../default.properties/
property file=${user.home}/build.properties/
@@ -186,7 +187,9 @@
destdir=${build.home}/classes
debug=${compile.debug}
deprecation=${compile.deprecation}
- optimize=${compile.optimize}
+ optimize=${compile.optimize}
+source=${platform.source}
+target=${platform.target}
classpath refid=compile.classpath /
/javac
@@ -296,7 +299,9 @@
destdir=${build.home}/test-classes
debug=${compile.debug}
deprecation=${compile.deprecation}
- optimize=${compile.optimize}
+ optimize=${compile.optimize}
+source=${platform.source}
+target=${platform.target}
classpath refid=test.classpath /
/javac
Added: struts/faces/trunk/default.properties
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/default.properties?rev=389368view=auto
==
--- struts/faces/trunk/default.properties (added)
+++ struts/faces/trunk/default.properties Mon Mar 27 18:43:25 2006
@@ -0,0 +1,25 @@
+# default.properties
+# ---
+#
+#
==
+# Copyright 2006 The Apache Software Foundation.
+#
+# Licensed under the Apache License, Version 2.0 (the License);
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an AS IS BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
==
+
+# Java platform version which source code must conform to
+platform.source=1.3
+
+# Java platform version which generated class files must conform to
+platform.target=1.3
+
Propchange: struts/faces/trunk/default.properties
--
svn:eol-style = native
Modified: struts/faces/trunk/example1-webapp/build.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/build.xml?rev=389368r1=389367r2=389368view=diff
==
--- struts/faces/trunk/example1-webapp/build.xml (original)
+++ struts/faces/trunk/example1-webapp/build.xml Mon Mar 27 18:43:25 2006
@@ -29,6 +29,7 @@
property file=build.properties/
property file=../build.properties/
property file=../../build.properties/
+ property file=../default.properties/
property file=${user.home}/build.properties/
@@ -272,7 +273,9 @@
destdir=${build.home}/${context.path}/WEB-INF/classes
debug=${compile.debug}
deprecation=${compile.deprecation}
- optimize=${compile.optimize}
+ optimize=${compile.optimize}
+source=${platform.source}
+target=${platform.target}
classpath refid=compile.classpath /
/javac
Modified: struts/faces/trunk/example2-webapp/build.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/build.xml?rev=389368r1=389367r2=389368view=diff
==
--- struts/faces/trunk/example2-webapp/build.xml (original)
+++ struts/faces/trunk/example2-webapp/build.xml Mon Mar 27 18:43:25 2006
@@ -29,6 +29,7 @@
property file=build.properties
DO NOT REPLY [Bug 38955] - [struts-faces] Example application doesn't deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38955. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38955 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-03-28 03:48 --- Fixed in r389368 for the 20060328 nightly build. http://svn.apache.org/viewcvs?rev=389368view=rev I added source and target attributes to all the javac tasks, so we should now be targetting 1.3 for all the binaries. Both examples deploy and work in Tomcat 4.1.31 w/ JDK 1.4.2 even though I built the project with 1.5.0. Thanks for your patience. :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36054] - [struts-faces] Example 2 application does not get deployed properly.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36054. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36054 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2006-03-28 04:02 --- While resolving Bug 38955 I noted that both example apps start up and work correctly. I see the following in the Tomcat 4.1.31 console: Mar 27, 2006 7:49:10 PM org.apache.struts.tiles.TilesPlugin initDefinitionsFactory INFO: Tiles definition factory loaded for module ''. Feel free to reopen this if the example apps are still not working for you. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38955] - [struts-faces] Example application doesn't deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38955.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38955
--- Additional Comments From [EMAIL PROTECTED] 2006-03-16 00:29 ---
(In reply to comment #1)
The problem is that the struts-faces.jar was compiled with a higher java
version(probably java 5.0). Please fix this.
Adding source and target attributes to the javac task should fix it.
default.properties
# Java platform version which source code must conform to
platform.source=1.4
# Java platform version which generated class files must conform to
platform.target=1.4
build.xml
property file=../default.properties/
...
!-- Compile Java Sources --
javac srcdir=src/java
destdir=${build.home}/classes
debug=${compile.debug}
deprecation=${compile.deprecation}
optimize=${compile.optimize}
source=${platform.source}
target=${platform.target}
classpath refid=compile.classpath /
/javac
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38955] - [struts-faces] Example application doesn't deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38955. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38955 --- Additional Comments From [EMAIL PROTECTED] 2006-03-16 00:37 --- (In reply to comment #2) default.properties # Java platform version which source code must conform to platform.source=1.4 # Java platform version which generated class files must conform to platform.target=1.4 I copied that from Shale, but I believe Struts Faces should target 1.3 instead. Craig, is that correct? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38955] - [struts-faces] Example application doesn't deploy
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38955. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38955 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Example application doesn't |[struts-faces] Example |deploy |application doesn't deploy -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r384525 - /struts/faces/tags/STRUTS_1_2_9/
Author: niallp Date: Thu Mar 9 07:07:53 2006 New Revision: 384525 URL: http://svn.apache.org/viewcvs?rev=384525view=rev Log: Tag Struts 1.2.9 Added: struts/faces/tags/STRUTS_1_2_9/ - copied from r384524, struts/faces/branches/STRUTS_1_2_BRANCH/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36054] - [struts-faces] Example 2 application does not get deployed properly.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36054. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36054 --- Additional Comments From [EMAIL PROTECTED] 2006-01-18 17:38 --- The tiles-def.xml dtd cannot be resolved. tiles-config.dtd is not bundled in the struts.jar. Just change the DOCTYPE by this one. !DOCTYPE tiles-definitions PUBLIC -//Apache Software Foundation//DTD Tiles Configuration 1.1//EN http://jakarta.apache.org/struts/dtds/tiles-config_1_1.dtd; -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31829] - [struts-faces] Exception in second example
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31829. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31829 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30342] - Struts-faces JSF commandLink bug in RI 1.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30342. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30342 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26317] - struts-faces example2 - 2004-01-13 build
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26317. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26317 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31351] - JSF 1.1_01 and Struts-faces Problem
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31351. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31351 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31809] - [struts-faces] Unable to deploy struts-faces-example2.war
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31809. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31809 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31097] - Struts-faces renders blank pages when refreshing page.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31097. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31097 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31803] - Struts-Faces and Validator framework (of Struts 1.2.4)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31803. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31803 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31842] - [struts-faces] Simple JSF integration with Tiles
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31842. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31842 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.2 Family -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36054] - [struts-faces] Example 2 application does not get deployed properly.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36054. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36054 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Example 2 application does |[struts-faces] Example 2 |not get deployed properly. |application does not get ||deployed properly. --- Additional Comments From [EMAIL PROTECTED] 2005-11-13 22:36 --- Possibly duplicates Bug 35265 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r331730 - /struts/faces/tags/STRUTS_1_2_8/
Author: niallp Date: Tue Nov 8 00:17:40 2005 New Revision: 331730 URL: http://svn.apache.org/viewcvs?rev=331730view=rev Log: Tag Struts 1.2.8 Added: struts/faces/tags/STRUTS_1_2_8/ - copied from r331729, struts/faces/branches/STRUTS_1_2_BRANCH/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r278868 - /struts/faces/trunk/xdocs/
Author: wsmoak Date: Mon Sep 5 15:25:57 2005 New Revision: 278868 URL: http://svn.apache.org/viewcvs?rev=278868view=rev Log: Deleting xdocs to allow moving site/xdocs/faces into its place. Removed: struts/faces/trunk/xdocs/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Common build file issues (was Re: struts-faces won't compile)
Wendy wrote: But there are things in the common build file that are *not* common to all subprojects. We needs a way to make sure that core/taglib/el/apps/plugins are all using the same versions of their dependencies, without imposing those dependencies on 'standalone' subprojects. How about: /current/build/project.xml ... has the list of committers, reports, etc. Only things that are common to *all* sub-projects /current/build/project-core.xml ... extendproject.xml/extend ... has the list of dependencies for struts-core Then each subproject chooses which build file to extend. - core, taglib, el, struts-tiles, apps, plugins can all extend build/project-core.xml in order to keep their dependencies on [mostly] commons libraries in sync. Even if the subproject doesn't necessarily need one of the dependencies that struts-core does, you can't use these subprojects without core, so you end up needing that dependency anyway. Subprojects can add additional dependencies, but can't remove the ones they inherit from core. - Faces, Standalone Tiles, etc., can extend from the generic 'project.xml' to pick up the list of committers, reports, etc., but are responsible for their own dependencies. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Common build file issues (was Re: struts-faces won't compile)
I also had the same thoughts during the initial timeframe when I was setting up the Maven config. I think we should stay away from getting too complex with config inheritance. I was thinking about this the other day, and what we might want do is move to a completely independent maven configuration for all subprojects. We will still share the build/ dir via svn:externals for common stuff like license and CheckStyle config, but each subproject will be a complete configuration itself (no extends). By doing it this way, we can create a new project.xml and maven.xml in current/ which is actually the normal way of doing it. This also puts the subprojects in a position to go ahead and do releases independent of other subprojects. We need to further discuss how we handle this with respect to how Maven deals with dependencies. Specifically, someone will need to maintain a chart of compatibility issues for all projects under Struts. This will be the only way to keep what version of core works with what version of taglibs or el or foo type questions from making this split even worth the effort. As it is now, the same issue (sort of) applies across the commons dependencies. Things can get very complicated, very fast. In addition to the above, it will be easier for me to fix the problems with the nightly build that come up every time anything is changed or released. Currently the release targets are hardcoded in my cron script (because of the way the files have to be named for the cleanup cron to work properly) and I'd like to remove that inefficiency. I'll be making some changes a little later today and more this week (as free time allows). With all hope, we can simplify this whole process and get it moved over to our zone and stop relying on our personal machines and (my) sometimes flaky network connection. (Wendy, just got your other email, I'll look into doing that when things settle down a bit) -- James Mitchell Software Engineer / Open Source Evangelist Consulting / Mentoring / Freelance EdgeTech, Inc. http://www.edgetechservices.net/ 678.910.8017 AIM: jmitchtx MSN: [EMAIL PROTECTED] Skype: jmitchtx - Original Message - From: Wendy Smoak [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Sunday, August 14, 2005 8:27 AM Subject: Common build file issues (was Re: struts-faces won't compile) Wendy wrote: But there are things in the common build file that are *not* common to all subprojects. We needs a way to make sure that core/taglib/el/apps/plugins are all using the same versions of their dependencies, without imposing those dependencies on 'standalone' subprojects. How about: /current/build/project.xml ... has the list of committers, reports, etc. Only things that are common to *all* sub-projects /current/build/project-core.xml ... extendproject.xml/extend ... has the list of dependencies for struts-core Then each subproject chooses which build file to extend. - core, taglib, el, struts-tiles, apps, plugins can all extend build/project-core.xml in order to keep their dependencies on [mostly] commons libraries in sync. Even if the subproject doesn't necessarily need one of the dependencies that struts-core does, you can't use these subprojects without core, so you end up needing that dependency anyway. Subprojects can add additional dependencies, but can't remove the ones they inherit from core. - Faces, Standalone Tiles, etc., can extend from the generic 'project.xml' to pick up the list of committers, reports, etc., but are responsible for their own dependencies. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Common build file issues (was Re: struts-faces won't compile)
I also had the same thoughts during the initial timeframe when I was setting up the Maven config. I think we should stay away from getting too complex with config inheritance. I was thinking about this the other day, and what we might want do is move to a completely independent maven configuration for all subprojects. We will still share the build/ dir via svn:externals for common stuff like license and CheckStyle config, but each subproject will be a complete configuration itself (no extends). By doing it this way, we can create a new project.xml and maven.xml in current/ which is actually the normal way of doing it. This also puts the subprojects in a position to go ahead and do releases independent of other subprojects. We need to further discuss how we handle this with respect to how Maven deals with dependencies. Specifically, someone will need to maintain a chart of compatibility issues for all projects under Struts. This will be the only way to keep what version of core works with what version of taglibs or el or foo type questions from making this split even worth the effort. As it is now, the same issue (sort of) applies across the commons dependencies. Things can get very complicated, very fast. In addition to the above, it will be easier for me to fix the problems with the nightly build that come up every time anything is changed or released. Currently the release targets are hardcoded in my cron script (because of the way the files have to be named for the cleanup cron to work properly) and I'd like to remove that inefficiency. I'll be making some changes a little later today and more this week (as free time allows). With all hope, we can simplify this whole process and get it moved over to our zone and stop relying on our personal machines and (my) sometimes flaky network connection. (Wendy, just got your other email, I'll look into doing that when things settle down a bit) -- James Mitchell Software Engineer / Open Source Evangelist Consulting / Mentoring / Freelance EdgeTech, Inc. http://www.edgetechservices.net/ 678.910.8017 AIM: jmitchtx MSN: [EMAIL PROTECTED] Skype: jmitchtx - Original Message - From: Wendy Smoak [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Sunday, August 14, 2005 8:27 AM Subject: Common build file issues (was Re: struts-faces won't compile) Wendy wrote: But there are things in the common build file that are *not* common to all subprojects. We needs a way to make sure that core/taglib/el/apps/plugins are all using the same versions of their dependencies, without imposing those dependencies on 'standalone' subprojects. How about: /current/build/project.xml ... has the list of committers, reports, etc. Only things that are common to *all* sub-projects /current/build/project-core.xml ... extendproject.xml/extend ... has the list of dependencies for struts-core Then each subproject chooses which build file to extend. - core, taglib, el, struts-tiles, apps, plugins can all extend build/project-core.xml in order to keep their dependencies on [mostly] commons libraries in sync. Even if the subproject doesn't necessarily need one of the dependencies that struts-core does, you can't use these subprojects without core, so you end up needing that dependency anyway. Subprojects can add additional dependencies, but can't remove the ones they inherit from core. - Faces, Standalone Tiles, etc., can extend from the generic 'project.xml' to pick up the list of committers, reports, etc., but are responsible for their own dependencies. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces won't compile
On 8/11/05, Michael Rasmussen [EMAIL PROTECTED] wrote: Craig, I know this issue came up about a year ago that struts-faces wouldn't compile against the latest version of Struts (I think it was a validator issue). It makes sense to me that it should always work with the latest version of Struts. I think it would serve the project well to cut a *.0 release of struts-faces and give it a 1.1-1.2.x compatability...after that put it into maintenence mode. Then cut a new *.0 release that brings struts-faces up to date with struts core... I haven't been following faces too closely lately...has it gone to 1.x yet? If so, maybe this Struts dependency change to 1.2.x should denote a v 2.0? I totally understand that the target audience for struts-faces is the developer trying to migrate a struts app off of struts to jsf. I have a hard time (and sort of balked at struts-faces because of it) commiting to a path that may force me to run my app on struts 1.2.x and 1.3 in paralell if I decide later that JSF just won't get it done for me. Basically I just mean that I am forced to limit my options if I use struts-faces, and I thought the spirit of the library was to increase my options. The Maven-generated build script has been getting tweaked lately, and does indeed impose a Struts 1.2 dependency. I'll have to take a look at that -- but there seem to have been some incompatible changes in the underlying utility classes that is going to make supporting both 1.1 and 1.2 interesting -- let alone supporting 1.3 as well. NB - the nightly builds are compiled against 1.2.6 at the moment. http://cvs.apache.org/builds/struts/nightly/struts-faces/ My $0.02 Michael Craig On 8/8/05, Craig McClanahan [EMAIL PROTECTED] wrote: On 8/8/05, Wendy Smoak [EMAIL PROTECTED] wrote: From: Craig McClanahan [EMAIL PROTECTED] Maybe the Maven mavens can figure out a way to share the build infrastructure without sharing the dependency information? Not a problem... just change the dependency in project.xml. Looks like it needs at least 1.2.2 to compile. (It won't compile against Struts 1.1. Should it?) Given that Struts changed incompatibly, I'm ok with 1.2.x as a restriction. But doesn't that mean we still need an independent project.xml file instead of a shared one? If it makes sense, we can remove the extendbuild/project.xml/extend from project.xml, and that will make the build stand on its own. That seems more appropriate for Tiles than Struts-Faces, though. Yep ... but without disrupting all the subprojects that *do* want to share dependencies. Maybe another opportunity to use SVN externals creatively. Thanks, Wendy Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces won't compile
From: Craig McClanahan [EMAIL PROTECTED] +import org.apache.struts.util.ModuleUtils; -RequestUtils.selectModule(request, servletContext); +ModuleUtils.getInstance().selectModule(request,servletContext); Conceptually that fix makes sense in that it solves the compilation problem ... but I don't believe that struts-faces should inherit a dependency on 1.3.x. I don't see how switching from a deprecated method call to the replacement causes a dependency on 1.3.x. That change still compiles under 1.2.2. Today it works (runtime) on 1.1 and 1.2, and it would be pretty pointless to throw away the vast majority of the potential target market. Does it really still work on 1.1? It won't compile against 1.1 due to the use of org.apache.struts.taglib.TagUtils and org.apache.struts.util.ModuleUtils, which must not have existed then. I think Struts-Faces (if it's going to be built with Maven :-) needs its own set of dependencies, independent of whatever Struts Core is using. It was inheriting from the Struts Common Build, not from Struts Core. The incorrect dependency on struts-core-1.3.0-dev was actually *in* the struts-faces build file and has been corrected to struts-1.2.2. (You said you're using 1.2.6 for the Ant build, but that one isn't on ibiblio. Can we agree on 1.2.7 by any chance?) James, can you comment on how you'd like to see this handled? The website builds just fine whether or not the extend tag is there (so I'm happy either way). But there are things in the common build file that are *not* common to all subprojects. Maven is smart enough to allow sub-projects to override dependencies by specifying a different version number, (servletapi-2.2 instead of servletapi-2.3, for example.) But by extending the common build, Struts Faces picks up dependencies on antlr, commons-chain, commons-digester, commons-fileupload and oro, none of which it really needs. I don't see a way to override a dependency coming from the common build with nothing. Thanks, -- Wendy Smoak - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts-Faces build (was Re: Vote: ANT or Maven ... )
From: Craig McClanahan [EMAIL PROTECTED] Craig wrote: There was talk on some thread or another ... hmm, I seem to remember a certain advocate for a compromise position :-) ... that you could have it both ways by simply generating a build.xml file from Maven. I advocated for both... but not for Maven-generated Ant build files. You brought those up wrt Commons projects, I think. I was talking about Tiles (now we're back to the original topic) where I would like Maven to build it and install the .jar in the local repository so I can easily have it as a dependency in my own projects. I just want Maven to work for Tiles, completely separate from whatever is happening with the Ant build. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
struts-faces won't compile
Faces is using a formerly deprecated, and now removed, method in
RequestUtils. This breaks the Maven build, which works against
struts-core-1.3.0-dev.
Is this the correct fix?
Thanks,
Wendy
Index:
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
===
---
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
(revision 230657)
+++
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
(working copy)
@@ -35,6 +35,7 @@
import org.apache.struts.config.ModuleConfig;
import org.apache.struts.faces.Constants;
import org.apache.struts.faces.component.FormComponent;
+import org.apache.struts.util.ModuleUtils;
import org.apache.struts.util.RequestUtils;
@@ -152,7 +153,7 @@
// Invoke the appropriate request processor for this request
try {
request.setAttribute(Constants.ACTION_EVENT_KEY, event);
-RequestUtils.selectModule(request, servletContext);
+ModuleUtils.getInstance().selectModule(request,
servletContext);
ModuleConfig moduleConfig = (ModuleConfig)
request.getAttribute(Globals.MODULE_KEY);
if (log.isTraceEnabled()) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces won't compile
On 8/8/05, Wendy Smoak [EMAIL PROTECTED] wrote:
Faces is using a formerly deprecated, and now removed, method in
RequestUtils. This breaks the Maven build, which works against
struts-core-1.3.0-dev.
Is this the correct fix?
Conceptually that fix makes sense in that it solves the compilation
problem ... but I don't believe that struts-faces should inherit a
dependency on 1.3.x. Today it works (runtime) on 1.1 and 1.2, and it
would be pretty pointless to throw away the vast majority of the
potential target market.
I think Struts-Faces (if it's going to be built with Maven :-) needs
its own set of dependencies, independent of whatever Struts Core is
using. That may mean decoupling from the shared build
infrastructure that is so handy across Struts Core ... but this
problem is going to get faced by other subcomponents as soon as they
contemplate independent release cycles.
Maybe the Maven mavens can figure out a way to share the build
infrastructure without sharing the dependency information?
Craig
Thanks,
Wendy
Index:
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
===
---
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
(revision 230657)
+++
core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
(working copy)
@@ -35,6 +35,7 @@
import org.apache.struts.config.ModuleConfig;
import org.apache.struts.faces.Constants;
import org.apache.struts.faces.component.FormComponent;
+import org.apache.struts.util.ModuleUtils;
import org.apache.struts.util.RequestUtils;
@@ -152,7 +153,7 @@
// Invoke the appropriate request processor for this request
try {
request.setAttribute(Constants.ACTION_EVENT_KEY, event);
-RequestUtils.selectModule(request, servletContext);
+ModuleUtils.getInstance().selectModule(request,
servletContext);
ModuleConfig moduleConfig = (ModuleConfig)
request.getAttribute(Globals.MODULE_KEY);
if (log.isTraceEnabled()) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces won't compile
From: Craig McClanahan [EMAIL PROTECTED] Maybe the Maven mavens can figure out a way to share the build infrastructure without sharing the dependency information? Not a problem... just change the dependency in project.xml. Looks like it needs at least 1.2.2 to compile. (It won't compile against Struts 1.1. Should it?) If it makes sense, we can remove the extendbuild/project.xml/extend from project.xml, and that will make the build stand on its own. That seems more appropriate for Tiles than Struts-Faces, though. Thanks, Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces won't compile
On 8/8/05, Wendy Smoak [EMAIL PROTECTED] wrote: From: Craig McClanahan [EMAIL PROTECTED] Maybe the Maven mavens can figure out a way to share the build infrastructure without sharing the dependency information? Not a problem... just change the dependency in project.xml. Looks like it needs at least 1.2.2 to compile. (It won't compile against Struts 1.1. Should it?) Given that Struts changed incompatibly, I'm ok with 1.2.x as a restriction. But doesn't that mean we still need an independent project.xml file instead of a shared one? If it makes sense, we can remove the extendbuild/project.xml/extend from project.xml, and that will make the build stand on its own. That seems more appropriate for Tiles than Struts-Faces, though. Yep ... but without disrupting all the subprojects that *do* want to share dependencies. Maybe another opportunity to use SVN externals creatively. Thanks, Wendy Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r230968 - /struts/faces/trunk/project.xml
Author: wsmoak Date: Mon Aug 8 21:53:40 2005 New Revision: 230968 URL: http://svn.apache.org/viewcvs?rev=230968view=rev Log: Changed dependency from Struts Core 1.3.0-dev to Struts 1.2.2, removed dependencies on struts-taglib and struts-tiles. Modified: struts/faces/trunk/project.xml Modified: struts/faces/trunk/project.xml URL: http://svn.apache.org/viewcvs/struts/faces/trunk/project.xml?rev=230968r1=230967r2=230968view=diff == --- struts/faces/trunk/project.xml (original) +++ struts/faces/trunk/project.xml Mon Aug 8 21:53:40 2005 @@ -66,33 +66,14 @@ dependency groupIdstruts/groupId - artifactIdstruts-core/artifactId - version1.3.0-dev/version + artifactIdstruts/artifactId + version1.2.2/version properties war.bundletrue/war.bundle /properties urlhttp://struts.apache.org//url /dependency - dependency - groupIdstruts/groupId - artifactIdstruts-taglib/artifactId - version1.3.0-dev/version - properties - war.bundletrue/war.bundle - /properties - urlhttp://struts.apache.org//url - /dependency - - dependency - groupIdstruts/groupId - artifactIdstruts-tiles/artifactId - version1.3.0-dev/version - properties - war.bundletrue/war.bundle - /properties - urlhttp://struts.apache.org//url - /dependency dependency groupIdmyfaces/groupId - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Struts-Faces build (was Re: Vote: ANT or Maven ... )
From: Craig McClanahan [EMAIL PROTECTED] Still builds with Ant? That's the key for the nightlies. Did it ever NOT build with Ant? This whole thing started because Faces wouldn't build for me with Maven. (And how did it get on this thread? There was another one for Faces...) There's a build.xml file in the Faces directory that I assume you are using. I haven't touched it. (At least, I don't think so... it's not one of those Maven-generated Ant build files you were talking about, is it?) PS: Interestingly, one of the advantages Martin mentions for Maven (generates the web site for you) was *not* a particular motivator for the Struts web site, because we had already invested the pain and agony to build reasonable stylesheets for transformations from our xdocs files. Good thing too ... if we had followed the conventional wisdom at the time (Anakia) we would still not be done converting :-). Funny you should mention that... integrating the existing website into the Maven-built multiproject site what I've been working on tonight. More on that later. Or maybe tomorrow. :) -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts-Faces build (was Re: Vote: ANT or Maven ... )
On 8/8/05, Wendy Smoak [EMAIL PROTECTED] wrote: From: Craig McClanahan [EMAIL PROTECTED] Still builds with Ant? That's the key for the nightlies. Did it ever NOT build with Ant? This whole thing started because Faces wouldn't build for me with Maven. (And how did it get on this thread? There was another one for Faces...) There's a build.xml file in the Faces directory that I assume you are using. I haven't touched it. (At least, I don't think so... it's not one of those Maven-generated Ant build files you were talking about, is it?) Yes, the Ant script is what I use (for myself and for the nightly builds). There was talk on some thread or another ... hmm, I seem to remember a certain advocate for a compromise position :-) ... that you could have it both ways by simply generating a build.xml file from Maven. As pointed out in a couple of other emails, it's not clear to me whether that is sufficient to provide the functionality that the current struts-faces build.xml script provides -- particularly in adapting to the differences between the JSF RI and MyFaces. I may be ignorant in this respect (especially with respect to recent innovations in Maven land), but this is a dealbreaker for struts-faces (or Shale, for that matter) to rely on Maven. PS: Interestingly, one of the advantages Martin mentions for Maven (generates the web site for you) was *not* a particular motivator for the Struts web site, because we had already invested the pain and agony to build reasonable stylesheets for transformations from our xdocs files. Good thing too ... if we had followed the conventional wisdom at the time (Anakia) we would still not be done converting :-). Funny you should mention that... integrating the existing website into the Maven-built multiproject site what I've been working on tonight. More on that later. Or maybe tomorrow. :) Be interesting to see what you come up with. -- Wendy Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r202117 - /struts/faces/trunk/project.xml
Author: jmitchell Date: Mon Jun 27 19:38:05 2005 New Revision: 202117 URL: http://svn.apache.org/viewcvs?rev=202117view=rev Log: fix faces build - thanks Wendy\! Modified: struts/faces/trunk/project.xml Modified: struts/faces/trunk/project.xml URL: http://svn.apache.org/viewcvs/struts/faces/trunk/project.xml?rev=202117r1=202116r2=202117view=diff == --- struts/faces/trunk/project.xml (original) +++ struts/faces/trunk/project.xml Mon Jun 27 19:38:05 2005 @@ -66,8 +66,18 @@ dependency groupIdstruts/groupId - artifactIdstruts/artifactId - version1.1/version + artifactIdstruts-core/artifactId + version1.3.0-dev/version + properties + war.bundletrue/war.bundle + /properties + urlhttp://struts.apache.org//url + /dependency + + dependency + groupIdstruts/groupId + artifactIdstruts-taglib/artifactId + version1.3.0-dev/version properties war.bundletrue/war.bundle /properties - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35506] - [struts-faces] - core-library and example1-webapp patches
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35506 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Struts-Faces Library - core-|[struts-faces] - core- |library and example1-webapp |library and example1-webapp |patches |patches -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35506] New: - Struts-Faces Library - core-library and example1-webapp patches
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35506 Summary: Struts-Faces Library - core-library and example1-webapp patches Product: Struts Version: Nightly Build Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Struts-Faces Library AssignedTo: dev@struts.apache.org ReportedBy: [EMAIL PROTECTED] A couple one line patches to work with tomcat 5.5 1)Changed the assumed action tour/ in the struts-config of the example1 application to use an include on the the static document tour.htm. The forward wants the target to be a jsp resource. 2)Change the signature of the call to get the ModuleConfig to use the ServletContext, another overload. This is in the JavasrciptValidatorTag. This was raising a null pointer exception when not dispatched thru the request processor first. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35179] - [struts-faces] JSF Conversion and validation errors under s:errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35179. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35179 [EMAIL PROTECTED] changed: What|Removed |Added Summary|JSF Conversion and |[struts-faces] JSF |validation errors under |Conversion and validation |s:errors|errors under s:errors -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35265] - [struts-faces] Example applications don't work?!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35265. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35265 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Example applications don't |[struts-faces] Example |work?! |applications don't work?! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34682] - [struts-faces] Conversion errors are not showing up
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34682. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34682 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Conversion errors are not |[struts-faces] Conversion |showing up |errors are not showing up -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 35232] - [struts-faces] ErrorsRenderer assumes ActionErrors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35232. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35232 [EMAIL PROTECTED] changed: What|Removed |Added Summary|ErrorsRenderer assumes |[struts-faces] |ActionErrors|ErrorsRenderer assumes ||ActionErrors -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32165] - [struts-faces] FacesRequestProcessor bug when using prefix mapped Struts servlet extension mapped Faces servlet
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32165 [EMAIL PROTECTED] changed: What|Removed |Added Summary|FacesRequestProcessor bug |[struts-faces] |when using prefix mapped|FacesRequestProcessor bug |Struts servlet extension |when using prefix mapped |mapped Faces servlet|Struts servlet extension ||mapped Faces servlet -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r178996 - in /struts/faces/trunk: example1-webapp/build.xml example2-webapp/build.xml example2-webapp/src/web/loggedoff.jsp systest1-webapp/build.xml
Author: craigmcc
Date: Sun May 29 16:23:24 2005
New Revision: 178996
URL: http://svn.apache.org/viewcvs?rev=178996view=rev
Log:
Adapt build scripts to reflect the fact that commons-collections.jar is not
shipped with recent (i.e. 1.2.6+) versions of Struts.
Modified:
struts/faces/trunk/example1-webapp/build.xml
struts/faces/trunk/example2-webapp/build.xml
struts/faces/trunk/example2-webapp/src/web/loggedoff.jsp
struts/faces/trunk/systest1-webapp/build.xml
Modified: struts/faces/trunk/example1-webapp/build.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/build.xml?rev=178996r1=178995r2=178996view=diff
==
--- struts/faces/trunk/example1-webapp/build.xml (original)
+++ struts/faces/trunk/example1-webapp/build.xml Sun May 29 16:23:24 2005
@@ -66,6 +66,8 @@
!-- Conditional Processing Flags --
+ available property=collections.present
+ file=${commons-collections.jar}/
available property=jsfri.present
classname=com.sun.faces.RIConstants
classpath=${jsf-impl.jar}/
@@ -160,7 +162,16 @@
/target
- target name=static depends=prepare
+ target name=static-collections depends=prepare
+if=collections.present
+
+copytodir=${build.home}/${context.path}/WEB-INF/lib
+ file=${commons-collections.jar}/
+
+ /target
+
+
+ target name=static depends=static-collections
!-- Copy static web resources --
copytodir=${build.home}/${context.path}
@@ -180,8 +191,6 @@
file=${struts-faces.jar}/
copytodir=${build.home}/${context.path}/WEB-INF/lib
file=${commons-beanutils.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-collections.jar}/
copytodir=${build.home}/${context.path}/WEB-INF/lib
file=${commons-digester.jar}/
copytodir=${build.home}/${context.path}/WEB-INF/lib
Modified: struts/faces/trunk/example2-webapp/build.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/build.xml?rev=178996r1=178995r2=178996view=diff
==
--- struts/faces/trunk/example2-webapp/build.xml (original)
+++ struts/faces/trunk/example2-webapp/build.xml Sun May 29 16:23:24 2005
@@ -141,6 +141,7 @@
echo message=build.standalone = ${build.standalone}/
echo message=jsf-api.jar = ${jsf-api.jar}/
echo message=jsf-impl.jar = ${jsf-impl.jar}/
+echo message=struts.home = ${struts.home}/
echo message=struts.jar = ${struts.jar}/
echo message=struts-faces.jar = ${struts-faces.jar}/
echo message=jsfri.present =${jsfri.present}/
@@ -178,22 +179,10 @@
mkdir dir=${build.home}/${context.path}/WEB-INF/lib/
copytodir=${build.home}/${context.path}/WEB-INF/lib
file=${struts-faces.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-beanutils.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-collections.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-digester.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-fileupload.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-logging.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${commons-validator.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${jakarta-oro.jar}/
-copytodir=${build.home}/${context.path}/WEB-INF/lib
- file=${struts.jar}/
+copytodir=${build.home}/${context.path}/WEB-INF/lib
+ fileset dir=${struts.home}/lib
+ includes=*.jar/
+/copy
/target
Modified: struts/faces/trunk/example2-webapp/src/web/loggedoff.jsp
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/src/web/loggedoff.jsp?rev=178996r1=178995r2=178996view=diff
==
--- struts/faces/trunk/example2-webapp/src/web/loggedoff.jsp (original)
+++ struts/faces/trunk/example2-webapp/src/web/loggedoff.jsp Sun May 29
16:23:24 2005
@@ -24,6 +24,7 @@
--
+%--
h:formid=loggedoff
h:panelGridcolumns=1
h:commandLink id=register
@@ -38,3 +39,25 @@
/h:commandLink
/h:panelGrid
/h:form
+--%
+
+h:panelGrid columns=1
+
+ %-- FIXME - needs ?action=Create modifier --%
+ s:form action=/editRegistration
svn commit: r168538 - /struts/faces/tags/STRUTS_1_2_7
Author: niallp Date: Thu May 5 23:25:57 2005 New Revision: 168538 URL: http://svn.apache.org/viewcvs?rev=168538view=rev Log: faces - Version 1.2.7 Tagged Added: struts/faces/tags/STRUTS_1_2_7/ - copied from r168537, struts/faces/trunk/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r165410 - in /struts/faces/trunk: ./ core-library/src/java/org/apache/struts/faces/taglib/ core-library/src/java/org/apache/struts/faces/util/ sysclient-app/src/java/org/apache/struts/faces/sysclient/
Author: jmitchell
Date: Sat Apr 30 09:25:14 2005
New Revision: 165410
URL: http://svn.apache.org/viewcvs?rev=165410view=rev
Log:
bring faces current with all dependent subprojects(core, taglib, and tiles),
upgrade to htmlunit 1.5
Modified:
struts/faces/trunk/build.properties.sample
struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java
struts/faces/trunk/core-library/src/java/org/apache/struts/faces/util/StrutsContext.java
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/AbstractTestCase.java
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java
Modified: struts/faces/trunk/build.properties.sample
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/build.properties.sample?rev=165410r1=165409r2=165410view=diff
==
--- struts/faces/trunk/build.properties.sample (original)
+++ struts/faces/trunk/build.properties.sample Sat Apr 30 09:25:14 2005
@@ -142,7 +142,7 @@
# The absolute or relative pathname to your installation of HtmlUnit 1.2.3
# or later. This code can be acquired at SourceForge.
-htmlunit.home=/usr/local/htmlunit-1.2.3
+htmlunit.home=/usr/local/htmlunit-1.5
# The type of JSF state saving that should be used when the system integration
# test web application is depoyed (client or server)
Modified:
struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java?rev=165410r1=165409r2=165410view=diff
==
---
struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java
(original)
+++
struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java
Sat Apr 30 09:25:14 2005
@@ -28,6 +28,7 @@
import javax.faces.component.UIComponent;
import javax.faces.context.FacesContext;
import javax.faces.webapp.UIComponentTag;
+import javax.servlet.http.HttpServletRequest;
import javax.servlet.jsp.JspException;
import javax.servlet.jsp.JspWriter;
import javax.servlet.jsp.PageContext;
@@ -38,13 +39,14 @@
import org.apache.commons.validator.Form;
import org.apache.commons.validator.ValidatorAction;
import org.apache.commons.validator.ValidatorResources;
-import org.apache.commons.validator.ValidatorUtil;
import org.apache.commons.validator.Var;
+import org.apache.commons.validator.util.ValidatorUtils;
import org.apache.struts.Globals;
import org.apache.struts.config.ModuleConfig;
import org.apache.struts.faces.component.FormComponent;
+import org.apache.struts.taglib.TagUtils;
import org.apache.struts.util.MessageResources;
-import org.apache.struts.util.RequestUtils;
+import org.apache.struts.util.ModuleUtils;
import org.apache.struts.validator.Resources;
import org.apache.struts.validator.ValidatorPlugIn;
@@ -267,15 +269,16 @@
public int doStartTag() throws JspException {
StringBuffer results = new StringBuffer();
-ModuleConfig config = RequestUtils.getModuleConfig(pageContext);
+HttpServletRequest request =
(HttpServletRequest)pageContext.getRequest();
+ModuleConfig config =
ModuleUtils.getInstance().getModuleConfig(request);
ValidatorResources resources =
(ValidatorResources) pageContext.getAttribute(
ValidatorPlugIn.VALIDATOR_KEY + config.getPrefix(),
PageContext.APPLICATION_SCOPE);
-Locale locale = RequestUtils.retrieveUserLocale(this.pageContext,
null);
+Locale locale = TagUtils.getInstance().getUserLocale(pageContext,
null);
-Form form = resources.get(locale, formName);
+Form form = resources.getForm(locale, formName);
if (form != null) {
if (true.equalsIgnoreCase(dynamicJavascript)) {
MessageResources messages =
@@ -290,7 +293,7 @@
for (Iterator i = form.getFields().iterator(); i.hasNext();) {
Field field = (Field) i.next();
-for (Iterator x = field.getDependencies().iterator();
x.hasNext();) {
+for (Iterator x = field.getDependencyList().iterator();
x.hasNext();) {
Object o = x.next();
if (o != null !lActionMethods.contains(o)) {
@@ -338,7 +341,7 @@
(va2.getDepends() != null
va2.getDepends().length() 0)) {
return -1;
} else {
-return va1.getDependencies().size() -
va2.getDependencies().size
svn commit: r160075 - struts/faces/trunk/project.xml
Author: jmitchell Date: Mon Apr 4 11:30:06 2005 New Revision: 160075 URL: http://svn.apache.org/viewcvs?view=revrev=160075 Log: bring faces up to date with latest available htmlunit on ibiblio Modified: struts/faces/trunk/project.xml Modified: struts/faces/trunk/project.xml URL: http://svn.apache.org/viewcvs/struts/faces/trunk/project.xml?view=diffr1=160074r2=160075 == --- struts/faces/trunk/project.xml (original) +++ struts/faces/trunk/project.xml Mon Apr 4 11:30:06 2005 @@ -108,7 +108,7 @@ dependency groupIdhtmlunit/groupId artifactIdhtmlunit/artifactId - version1.2.3/version + version1.5/version urlhttp://htmlunit.sourceforge.net//url properties war.bundletrue/war.bundle - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r157452 - in struts/faces/trunk/core-library/src/java/org/apache/struts/faces: application/FacesRequestProcessor.java application/FacesTilesRequestProcessor.java util/HttpServletRequestWrapper.java
Author: craigmcc Date: Mon Mar 14 11:46:14 2005 New Revision: 157452 URL: http://svn.apache.org/viewcvs?view=revrev=157452 Log: Remove the problematic HttpServletRequestWrapper and references to it in the request processor implementations. Removed: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/util/HttpServletRequestWrapper.java Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java?view=diffr1=157451r2=157452 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java Mon Mar 14 11:46:14 2005 @@ -128,11 +128,6 @@ created = true; FacesContextFactory fcf = (FacesContextFactory) FactoryFinder.getFactory(FactoryFinder.FACES_CONTEXT_FACTORY); -// HttpServletRequestWrapper wrapper = new HttpServletRequestWrapper(request, uri); -// context = fcf.getFacesContext(servlet.getServletContext(), wrapper, -// response, lifecycle); -// Comment out the previous three lines and uncomment -// the following two lines to test eliminating the wrapper context = fcf.getFacesContext(servlet.getServletContext(), request, response, lifecycle); } Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java?view=diffr1=157451r2=157452 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java Mon Mar 14 11:46:14 2005 @@ -41,7 +41,6 @@ import org.apache.struts.config.ForwardConfig; import org.apache.struts.faces.Constants; import org.apache.struts.faces.component.FormComponent; -import org.apache.struts.faces.util.HttpServletRequestWrapper; import org.apache.struts.tiles.TilesRequestProcessor; @@ -129,13 +128,8 @@ created = true; FacesContextFactory fcf = (FacesContextFactory) FactoryFinder.getFactory(FactoryFinder.FACES_CONTEXT_FACTORY); -HttpServletRequestWrapper wrapper = new HttpServletRequestWrapper(request, uri); -context = fcf.getFacesContext(servlet.getServletContext(), wrapper, - response, lifecycle); -// Comment out the previous three lines and uncomment -// the following two lines to test eliminating the wrapper -// context = fcf.getFacesContext(servlet.getServletContext(), -// request, response, lifecycle); +context = fcf.getFacesContext(servlet.getServletContext(), + request, response, lifecycle); } // Create a new view root - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32014] - HttpServletRequestWrapper in struts-faces broken for servlet 2.4
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32014. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32014 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-03-14 20:49 --- Fixed in nightly build 20050315. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 --- Additional Comments From [EMAIL PROTECTED] 2005-03-14 20:50 --- Fixed in nightly build 20050315. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-03-14 20:50 --- (Forgot to change bug resolution) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 --- Additional Comments From [EMAIL PROTECTED] 2005-03-14 03:21 --- This is great news! I'll clean up the wrapper class stuff soon (still in a huge email backlog). By the way, is the Incubator CVS still the place to get the latest MyFaces source code? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
FYI, as soon as I apply some recent patches (to remove the wrapper class) this whole area will become a non-issue for struts-faces. In the general case, however, it is not currently feasible to create a wrapper that works across 2.3 and 2.4 unless you're willing to do a little work with Java reflection to transparently deal with the 2.4 methods that are not there in 2.3 (and therefore you cannot delegate to the underlying wrapper). Craig On Sat, 12 Mar 2005 09:16:39 -0500, Bill Siggelkow [EMAIL PROTECTED] wrote: On 2005-03-11 00:25:35 -0500, Martin Cooper [EMAIL PROTECTED] said: On Tue, 1 Mar 2005 09:11:28 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: Doing the simple version of a change like this will cause the wrapper class to not be compilable against a 2.2 or 2.3 version of the servlet API any longer, which is a particular problem for the standard Struts release. I don't believe that's the case. The current implementation of MultipartRequestWrapper uses exactly the same technique that Ramiro mentions to allow compilation against the Servlets 2.3 API. Adding extra methods to the implementation class allows it to compile against the newer API, while the methods become just ordinary class methods when compiled against the older API. It's true that the dummy methods added to satisfy the newer API are not useful (without the use of reflection, as you suggest below), but that doesn't seem to have caused problems for people using the Servlets 2.3 API while we've been dummying up the methods new to that version over Servlets 2.2. Well, I ran into this the other day -- and while it seemed like I could just no-op (or wrapper) for the new methods in the Servlet API (getLocalAddr() etc.) there are other problems in the taglibs against the JSP API -- because JSP 2.0 introduces new classes like ExpressionEvaluator. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
Having the wrapper extend the HttpServletRequestWrapper (introduced in Servlet 2.3) resolves this - just need to remove the dummy methods. Niall - Original Message - From: Craig McClanahan [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Monday, March 14, 2005 4:11 AM Subject: Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0 FYI, as soon as I apply some recent patches (to remove the wrapper class) this whole area will become a non-issue for struts-faces. In the general case, however, it is not currently feasible to create a wrapper that works across 2.3 and 2.4 unless you're willing to do a little work with Java reflection to transparently deal with the 2.4 methods that are not there in 2.3 (and therefore you cannot delegate to the underlying wrapper). Craig On Sat, 12 Mar 2005 09:16:39 -0500, Bill Siggelkow [EMAIL PROTECTED] wrote: On 2005-03-11 00:25:35 -0500, Martin Cooper [EMAIL PROTECTED] said: On Tue, 1 Mar 2005 09:11:28 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: Doing the simple version of a change like this will cause the wrapper class to not be compilable against a 2.2 or 2.3 version of the servlet API any longer, which is a particular problem for the standard Struts release. I don't believe that's the case. The current implementation of MultipartRequestWrapper uses exactly the same technique that Ramiro mentions to allow compilation against the Servlets 2.3 API. Adding extra methods to the implementation class allows it to compile against the newer API, while the methods become just ordinary class methods when compiled against the older API. It's true that the dummy methods added to satisfy the newer API are not useful (without the use of reflection, as you suggest below), but that doesn't seem to have caused problems for people using the Servlets 2.3 API while we've been dummying up the methods new to that version over Servlets 2.2. Well, I ran into this the other day -- and while it seemed like I could just no-op (or wrapper) for the new methods in the Servlet API (getLocalAddr() etc.) there are other problems in the taglibs against the JSP API -- because JSP 2.0 introduces new classes like ExpressionEvaluator. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 --- Additional Comments From [EMAIL PROTECTED] 2005-03-14 08:20 --- (In reply to comment #3) By the way, is the Incubator CVS still the place to get the latest MyFaces source code? yes, the infra@ guys are working on scripts for movement to own CVS ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
On 2005-03-11 00:25:35 -0500, Martin Cooper [EMAIL PROTECTED] said: On Tue, 1 Mar 2005 09:11:28 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: Doing the simple version of a change like this will cause the wrapper class to not be compilable against a 2.2 or 2.3 version of the servlet API any longer, which is a particular problem for the standard Struts release. I don't believe that's the case. The current implementation of MultipartRequestWrapper uses exactly the same technique that Ramiro mentions to allow compilation against the Servlets 2.3 API. Adding extra methods to the implementation class allows it to compile against the newer API, while the methods become just ordinary class methods when compiled against the older API. It's true that the dummy methods added to satisfy the newer API are not useful (without the use of reflection, as you suggest below), but that doesn't seem to have caused problems for people using the Servlets 2.3 API while we've been dummying up the methods new to that version over Servlets 2.2. Well, I ran into this the other day -- and while it seemed like I could just no-op (or wrapper) for the new methods in the Servlet API (getLocalAddr() etc.) there are other problems in the taglibs against the JSP API -- because JSP 2.0 introduces new classes like ExpressionEvaluator. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 --- Additional Comments From [EMAIL PROTECTED] 2005-03-10 18:16 --- I believe this has been resolved. I've been working with Matthias Wessendorf (myfaces) and have contributed a couple patches to myfaces which have been committed to cvs. The first patch fixes the servlet mapping issue: http://issues.apache.org/jira/browse/MYFACES-121 There is a catch with is patch, though, in that it may not perform correctly if a user has multiple servlet mappings to jsf in their webapp. This is not too common, though. Then, a bug in myfaces was exposed, which has been committed: http://issues.apache.org/jira/browse/MYFACES-122 I've tested both struts-faces example webapps against myfaces cvs and a modified struts-faces (because bug 32014 has not yet been resolved in cvs). All seems fine - both apps performed well. All that needs to be done is to commit bug 32014 . Mike -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 --- Additional Comments From [EMAIL PROTECTED] 2005-03-10 19:16 --- Mike- Interessting, I did the same (I gues) see here: http://issues.apache.org/bugzilla/show_bug.cgi?id=33950 So it should be OK the remove the *legacy* Wrapper clazz ;) -Matthias -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
On Tue, 1 Mar 2005 09:11:28 -0800, Craig McClanahan [EMAIL PROTECTED] wrote:
Doing the simple version of a change like this will cause the wrapper
class to not be compilable against a 2.2 or 2.3 version of the servlet
API any longer, which is a particular problem for the standard Struts
release.
I don't believe that's the case. The current implementation of
MultipartRequestWrapper uses exactly the same technique that Ramiro
mentions to allow compilation against the Servlets 2.3 API. Adding
extra methods to the implementation class allows it to compile against
the newer API, while the methods become just ordinary class methods
when compiled against the older API.
It's true that the dummy methods added to satisfy the newer API are
not useful (without the use of reflection, as you suggest below), but
that doesn't seem to have caused problems for people using the
Servlets 2.3 API while we've been dummying up the methods new to that
version over Servlets 2.2.
--
Martin Cooper
It will require a bit more work to use reflection to call
through these methods if they exist, or return nothing if they do not
exist.
Craig
On Tue, 01 Mar 2005 14:11:41 +0100, Ramiro Alba Queipo [EMAIL PROTECTED]
wrote:
Hello everybody:
I was using tomcat 4.0.24 to develop an application with struts, I and
decided to migrate to tomcat 5.0.28 so as I could user EL natively from
JSP 2.0. I thought it would be a good idea to compile STRUTS 1.2.4 under
servlet 2.4 and JSP 2.0 from tomcat 5.0.28. Everything went wright
except for one class:
org/apache/struts/upload/MultipartRequestWrapper.java
It is not implementing the following methods from interface
javax.servlet.ServletRequest corresponding to servlet-api.jar of tomcat
5.0.28:
public String getLocalName() {}
public String getLocalAddr() {}
public int getLocalPort() {}
public int getRemotePort() {}
To bypass the problem I created trivial methods, and then I could
complete the compilation process. Everything seams to work, but in order
to work with tomcat 5.0.x:
1) Is it a good idea to make this compilation o better to stuck with
the official binary supplied struts.jar?
2) Is this situation going to be solved in a near feature? (I have seen
no changes in struts 1.2.6)
I have found the same problem compiling struts-faces, which seams to be
compiled with servlet and jsp apis from tomcat 5.0.25
Thanks in advance
Regards
P.D: I have posted this e-mail at user@struts.apache.org more than a
week ago and I have no answer, probably due to be a question out of
scope for that list, so I decided to post here the same question. Sorry
for the cross posting.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32014] - HttpServletRequestWrapper in struts-faces broken for servlet 2.4
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32014. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32014 --- Additional Comments From [EMAIL PROTECTED] 2005-03-09 20:49 --- Created an attachment (id=14449) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14449action=view) removes references to HttpServletRequestWrapper from FacesRequestProcessor.java FacesTilesRequestProcessor.java and removes HttpServletRequestWrapper -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32014] - HttpServletRequestWrapper in struts-faces broken for servlet 2.4
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32014. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32014 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Additional Comments From [EMAIL PROTECTED] 2005-03-09 20:57 --- FacesTilesRequestProcessor in svn is still not functional becuase it's using HttpServletRequestWrapper. So, I've attached the above patch to speed up the process of removing HttpServletRequestWrapper. I'd like to be able to use the nightly builds without modification. Thanks, Mike p.s. I'm reopening this bug because it is my understanding that notifications are not sent out otherwise -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
On Tue, 2005-03-01 at 18:11, Craig McClanahan wrote: Doing the simple version of a change like this will cause the wrapper class to not be compilable against a 2.2 or 2.3 version of the servlet API any longer, which is a particular problem for the standard Struts release. It will require a bit more work to use reflection to call through these methods if they exist, or return nothing if they do not exist. So, in order to use STRUTS and STRUTS-FACES with JSP 2.0 and the Expression Language, what should I do? a) Compile against servlet 2.4 and JSP 2.0 and adding the mentioned methods not implemented. b) Using the oficial binary version for both STRUTS and STRUTS-FACES I understand that both STRUTS and STRUTS-FACES are compiled against servlet 2.2 and 2.3 and terster for servlet 2.4 and JSP 2.0. Regards - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r155889 - struts/faces/trunk/project.xml
On Wed, 02 Mar 2005 06:11:55 -, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: jmitchell Date: Tue Mar 1 22:11:55 2005 New Revision: 155889 URL: http://svn.apache.org/viewcvs?view=revrev=155889 Log: fix version (Craig is this what you want to see as the version number?) Works for me. Thanks for doing this. Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
Hello everybody:
I was using tomcat 4.0.24 to develop an application with struts, I and
decided to migrate to tomcat 5.0.28 so as I could user EL natively from
JSP 2.0. I thought it would be a good idea to compile STRUTS 1.2.4 under
servlet 2.4 and JSP 2.0 from tomcat 5.0.28. Everything went wright
except for one class:
org/apache/struts/upload/MultipartRequestWrapper.java
It is not implementing the following methods from interface
javax.servlet.ServletRequest corresponding to servlet-api.jar of tomcat
5.0.28:
public String getLocalName() {}
public String getLocalAddr() {}
public int getLocalPort() {}
public int getRemotePort() {}
To bypass the problem I created trivial methods, and then I could
complete the compilation process. Everything seams to work, but in order
to work with tomcat 5.0.x:
1) Is it a good idea to make this compilation o better to stuck with
the official binary supplied struts.jar?
2) Is this situation going to be solved in a near feature? (I have seen
no changes in struts 1.2.6)
I have found the same problem compiling struts-faces, which seams to be
compiled with servlet and jsp apis from tomcat 5.0.25
Thanks in advance
Regards
P.D: I have posted this e-mail at user@struts.apache.org more than a
week ago and I have no answer, probably due to be a question out of
scope for that list, so I decided to post here the same question. Sorry
for the cross posting.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Compiling STRUTS and STRUTS-FACES with servlet 2.4 and jsp 2.0
Doing the simple version of a change like this will cause the wrapper
class to not be compilable against a 2.2 or 2.3 version of the servlet
API any longer, which is a particular problem for the standard Struts
release. It will require a bit more work to use reflection to call
through these methods if they exist, or return nothing if they do not
exist.
Craig
On Tue, 01 Mar 2005 14:11:41 +0100, Ramiro Alba Queipo [EMAIL PROTECTED]
wrote:
Hello everybody:
I was using tomcat 4.0.24 to develop an application with struts, I and
decided to migrate to tomcat 5.0.28 so as I could user EL natively from
JSP 2.0. I thought it would be a good idea to compile STRUTS 1.2.4 under
servlet 2.4 and JSP 2.0 from tomcat 5.0.28. Everything went wright
except for one class:
org/apache/struts/upload/MultipartRequestWrapper.java
It is not implementing the following methods from interface
javax.servlet.ServletRequest corresponding to servlet-api.jar of tomcat
5.0.28:
public String getLocalName() {}
public String getLocalAddr() {}
public int getLocalPort() {}
public int getRemotePort() {}
To bypass the problem I created trivial methods, and then I could
complete the compilation process. Everything seams to work, but in order
to work with tomcat 5.0.x:
1) Is it a good idea to make this compilation o better to stuck with
the official binary supplied struts.jar?
2) Is this situation going to be solved in a near feature? (I have seen
no changes in struts 1.2.6)
I have found the same problem compiling struts-faces, which seams to be
compiled with servlet and jsp apis from tomcat 5.0.25
Thanks in advance
Regards
P.D: I have posted this e-mail at user@struts.apache.org more than a
week ago and I have no answer, probably due to be a question out of
scope for that list, so I decided to post here the same question. Sorry
for the cross posting.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r155883 - in struts/faces/trunk/core-library/src: java/org/apache/struts/faces/component/ java/org/apache/struts/faces/renderer/ java/org/apache/struts/faces/taglib/ test/org/apache/struts/faces/util/
Author: jmitchell Date: Tue Mar 1 22:03:13 2005 New Revision: 155883 URL: http://svn.apache.org/viewcvs?view=revrev=155883 Log: Fix many small improvements thanks to our new maven reports - unused import(s) - useless object creation - unnecessary casting Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/BaseComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/CommandLinkComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/ErrorsComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/HtmlComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/MessageComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/StylesheetComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/WriteComponent.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/renderer/AbstractRenderer.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/renderer/CommandLinkRenderer.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/renderer/MessageRenderer.java struts/faces/trunk/core-library/src/java/org/apache/struts/faces/taglib/JavascriptValidatorTag.java struts/faces/trunk/core-library/src/test/org/apache/struts/faces/util/MessagesMapTestCase.java Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/BaseComponent.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/BaseComponent.java?view=diffr1=155882r2=155883 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/BaseComponent.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/BaseComponent.java Tue Mar 1 22:03:13 2005 @@ -17,9 +17,6 @@ package org.apache.struts.faces.component; -import java.io.IOException; -import java.util.Iterator; - import javax.faces.component.UIOutput; import javax.faces.context.FacesContext; import javax.faces.el.ValueBinding; Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/CommandLinkComponent.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/CommandLinkComponent.java?view=diffr1=155882r2=155883 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/CommandLinkComponent.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/CommandLinkComponent.java Tue Mar 1 22:03:13 2005 @@ -17,9 +17,6 @@ package org.apache.struts.faces.component; -import java.io.IOException; -import java.util.Iterator; - import javax.faces.component.UICommand; import javax.faces.context.FacesContext; import javax.faces.el.ValueBinding; Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/ErrorsComponent.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/ErrorsComponent.java?view=diffr1=155882r2=155883 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/ErrorsComponent.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/ErrorsComponent.java Tue Mar 1 22:03:13 2005 @@ -17,9 +17,6 @@ package org.apache.struts.faces.component; -import java.io.IOException; -import java.util.Iterator; - import javax.faces.component.UIOutput; import javax.faces.context.FacesContext; import javax.faces.el.ValueBinding; Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/HtmlComponent.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/HtmlComponent.java?view=diffr1=155882r2=155883 == --- struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/HtmlComponent.java (original) +++ struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/HtmlComponent.java Tue Mar 1 22:03:13 2005 @@ -17,9 +17,6 @@ package org.apache.struts.faces.component; -import java.io.IOException; -import java.util.Iterator; - import javax.faces.component.UIOutput; import javax.faces.context.FacesContext; import javax.faces.el.ValueBinding; Modified: struts/faces/trunk/core-library/src/java/org/apache/struts/faces/component/MessageComponent.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/core
svn commit: r155884 - in struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example: EditRegistrationAction.java EditSubscriptionAction.java IndexBacking.java LogoffAction.java LogonAction.java MainMenuBacking.java RegistrationBacking.java SaveRegistrationAction.java
Author: jmitchell
Date: Tue Mar 1 22:03:56 2005
New Revision: 155884
URL: http://svn.apache.org/viewcvs?view=revrev=155884
Log:
Fix many small improvements thanks to our new maven reports
- unused import(s)
- useless object creation
- unnecessary casting
Modified:
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditRegistrationAction.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditSubscriptionAction.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/IndexBacking.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogoffAction.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogonAction.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/MainMenuBacking.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/RegistrationBacking.java
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/SaveRegistrationAction.java
Modified:
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditRegistrationAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditRegistrationAction.java?view=diffr1=155883r2=155884
==
---
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditRegistrationAction.java
(original)
+++
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditRegistrationAction.java
Tue Mar 1 22:03:56 2005
@@ -31,7 +31,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
/**
@@ -81,8 +80,6 @@
throws Exception {
// Extract attributes we will need
- Locale locale = getLocale(request);
- MessageResources messages = getResources(request);
HttpSession session = request.getSession();
String action = request.getParameter(action);
if (action == null)
Modified:
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditSubscriptionAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditSubscriptionAction.java?view=diffr1=155883r2=155884
==
---
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditSubscriptionAction.java
(original)
+++
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/EditSubscriptionAction.java
Tue Mar 1 22:03:56 2005
@@ -31,7 +31,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
/**
@@ -81,7 +80,6 @@
// Extract attributes we will need
Locale locale = getLocale(request);
- MessageResources messages = getResources(request);
HttpSession session = request.getSession();
String action = request.getParameter(action);
if (action == null) {
Modified:
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/IndexBacking.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/IndexBacking.java?view=diffr1=155883r2=155884
==
---
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/IndexBacking.java
(original)
+++
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/IndexBacking.java
Tue Mar 1 22:03:56 2005
@@ -18,8 +18,6 @@
package org.apache.struts.webapp.example;
-import java.io.IOException;
-import javax.faces.FacesException;
import javax.faces.context.FacesContext;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
Modified:
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogoffAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogoffAction.java?view=diffr1=155883r2=155884
==
---
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogoffAction.java
(original)
+++
struts/faces/trunk/example1-webapp/src/java/org/apache/struts/webapp/example/LogoffAction.java
Tue Mar 1 22:03:56 2005
@@ -28,7 +28,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import
svn commit: r155885 - in struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient: ContextTestCase.java LogonTestCase.java SimpleTestCase.java
Author: jmitchell Date: Tue Mar 1 22:04:30 2005 New Revision: 155885 URL: http://svn.apache.org/viewcvs?view=revrev=155885 Log: Many small improvements thanks to our new maven reports - unused import(s) - useless object creation - unnecessary casting Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java?view=diffr1=155884r2=155885 == --- struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java (original) +++ struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java Tue Mar 1 22:04:30 2005 @@ -16,31 +16,11 @@ package org.apache.struts.faces.sysclient; -import com.gargoylesoftware.htmlunit.ElementNotFoundException; -import com.gargoylesoftware.htmlunit.WebClient; -import com.gargoylesoftware.htmlunit.html.HtmlAnchor; -import com.gargoylesoftware.htmlunit.html.HtmlBase; -import com.gargoylesoftware.htmlunit.html.HtmlBody; -import com.gargoylesoftware.htmlunit.html.HtmlElement; -import com.gargoylesoftware.htmlunit.html.HtmlForm; -import com.gargoylesoftware.htmlunit.html.HtmlHead; -import com.gargoylesoftware.htmlunit.html.HtmlHiddenInput; -import com.gargoylesoftware.htmlunit.html.HtmlLink; -import com.gargoylesoftware.htmlunit.html.HtmlPage; -import com.gargoylesoftware.htmlunit.html.HtmlPasswordInput; -import com.gargoylesoftware.htmlunit.html.HtmlResetInput; -import com.gargoylesoftware.htmlunit.html.HtmlSpan; -import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput; -import com.gargoylesoftware.htmlunit.html.HtmlTextInput; - -import java.net.URL; -import java.util.ArrayList; -import java.util.Iterator; -import java.util.List; - import junit.framework.Test; -import junit.framework.TestCase; import junit.framework.TestSuite; + +import com.gargoylesoftware.htmlunit.html.HtmlSpan; +import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput; /** Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java?view=diffr1=155884r2=155885 == --- struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java (original) +++ struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java Tue Mar 1 22:04:30 2005 @@ -16,32 +16,21 @@ package org.apache.struts.faces.sysclient; -import com.gargoylesoftware.htmlunit.ElementNotFoundException; -import com.gargoylesoftware.htmlunit.WebClient; +import java.util.List; + +import junit.framework.Test; +import junit.framework.TestSuite; + import com.gargoylesoftware.htmlunit.html.HtmlAnchor; -import com.gargoylesoftware.htmlunit.html.HtmlBase; -import com.gargoylesoftware.htmlunit.html.HtmlBody; import com.gargoylesoftware.htmlunit.html.HtmlElement; import com.gargoylesoftware.htmlunit.html.HtmlForm; -import com.gargoylesoftware.htmlunit.html.HtmlHead; import com.gargoylesoftware.htmlunit.html.HtmlHiddenInput; -import com.gargoylesoftware.htmlunit.html.HtmlLink; -import com.gargoylesoftware.htmlunit.html.HtmlPage; import com.gargoylesoftware.htmlunit.html.HtmlPasswordInput; import com.gargoylesoftware.htmlunit.html.HtmlResetInput; import com.gargoylesoftware.htmlunit.html.HtmlSpan; import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput; import com.gargoylesoftware.htmlunit.html.HtmlTextInput; -import java.net.URL; -import java.util.ArrayList; -import java.util.Iterator; -import java.util.List; - -import junit.framework.Test; -import junit.framework.TestCase; -import junit.framework.TestSuite; - /** * pTest case for a logon form that accepts a username and password./p @@ -165,7 +154,7 @@ HtmlSpan span = null; -HtmlElement html = (HtmlElement) page; +HtmlElement html = page; assertEquals(html, html.getTagName()); assertEquals(http://www.w3.org/1999/xhtml;, html.getAttributeValue(xmlns)); Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java?view=diffr1=155884r2=155885
svn commit: r155886 - in struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2: EditRegistrationAction.java EditSubscriptionAction.java LogoffAction.java LogonAction.java
Author: jmitchell
Date: Tue Mar 1 22:04:47 2005
New Revision: 155886
URL: http://svn.apache.org/viewcvs?view=revrev=155886
Log:
Many small improvements thanks to our new maven reports
- unused import(s)
- useless object creation
- unnecessary casting
Modified:
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditRegistrationAction.java
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditSubscriptionAction.java
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogoffAction.java
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogonAction.java
Modified:
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditRegistrationAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditRegistrationAction.java?view=diffr1=155885r2=155886
==
---
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditRegistrationAction.java
(original)
+++
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditRegistrationAction.java
Tue Mar 1 22:04:47 2005
@@ -31,7 +31,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
/**
@@ -82,7 +81,6 @@
// Extract attributes we will need
Locale locale = getLocale(request);
- MessageResources messages = getResources(request);
HttpSession session = request.getSession();
String action = request.getParameter(action);
if (action == null)
Modified:
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditSubscriptionAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditSubscriptionAction.java?view=diffr1=155885r2=155886
==
---
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditSubscriptionAction.java
(original)
+++
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/EditSubscriptionAction.java
Tue Mar 1 22:04:47 2005
@@ -31,7 +31,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
/**
@@ -81,7 +80,6 @@
// Extract attributes we will need
Locale locale = getLocale(request);
- MessageResources messages = getResources(request);
HttpSession session = request.getSession();
String action = request.getParameter(action);
if (action == null) {
Modified:
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogoffAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogoffAction.java?view=diffr1=155885r2=155886
==
---
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogoffAction.java
(original)
+++
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogoffAction.java
Tue Mar 1 22:04:47 2005
@@ -28,7 +28,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
/**
@@ -77,7 +76,6 @@
// Extract attributes we will need
Locale locale = getLocale(request);
- MessageResources messages = getResources(request);
HttpSession session = request.getSession();
User user = (User) session.getAttribute(Constants.USER_KEY);
Modified:
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogonAction.java
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogonAction.java?view=diffr1=155885r2=155886
==
---
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogonAction.java
(original)
+++
struts/faces/trunk/example2-webapp/src/java/org/apache/struts/webapp/example2/LogonAction.java
Tue Mar 1 22:04:47 2005
@@ -31,7 +31,6 @@
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
-import org.apache.struts.util.MessageResources;
import org.apache.struts.util.ModuleException;
@@ -80,7 +79,6 @@
// Extract attributes we will need
Locale
svn commit: r155887 - struts/faces/trunk/project.xml
Author: jmitchell
Date: Tue Mar 1 22:05:30 2005
New Revision: 155887
URL: http://svn.apache.org/viewcvs?view=revrev=155887
Log:
initial project.xml that builds the core-library (using myfaces)
Added:
struts/faces/trunk/project.xml (with props)
Added: struts/faces/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/struts/faces/trunk/project.xml?view=autorev=155887
==
--- struts/faces/trunk/project.xml (added)
+++ struts/faces/trunk/project.xml Tue Mar 1 22:05:30 2005
@@ -0,0 +1,147 @@
+?xml version=1.0 encoding=UTF-8?
+project
+!--
+/*
+ * Copyright 2001-2004 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ --
+
+
+ extendbuild/project.xml/extend
+ idstruts-faces/id
+ nameStruts JSF Integration Library/name
+
+ packageorg.apache.struts.faces/package
+ packageGroups
+packageGroup
+ titleStruts Faces/title
+ packagesorg.apache.struts.faces/packages
+/packageGroup
+ /packageGroups
+
+ shortDescriptionStruts JSF Integration Library./shortDescription
+
+ description
+ This package contains an add-on library that supports the use of
+ JavaServer Faces (JSF) user interface technology in a Struts based web
+ application, in place of the Struts custom tag libraries. As a proof of
+ concept, it also includes the canonical struts-example example
+ web application, converted to use JSF tags, as well as tags from the
+ JSP Standard Tag Library (JSTL), version 1.0 or later. It also includes
+ a very basic Tiles based application, modified in a similar manner.
+
+ The Struts-Faces Integration Library should work with any implementation
+ of JavaServer Faces, version 1.0 or later. It has primarily been tested
+ against version 1.1 of the JavaServer Faces reference implementation,
+ available at:
+
+http://java.sun.com/j2ee/javaserverfaces/
+
+ /description
+
+ repository
+
connectionscm|svn|http|//svn.apache.org/repos/asf/struts/faces/trunk/connection
+
developerConnectionscm|svn|https|//svn.apache.org/repos/asf/struts/faces/trunk/developerConnection
+urlhttp://svn.apache.org/repos/asf/struts/faces/trunk/url
+ /repository
+
+ versions/
+
+ branches/
+
+ dependencies
+
+ dependency
+ groupIdstruts/groupId
+ artifactIdstruts/artifactId
+ version1.1/version
+ properties
+ war.bundletrue/war.bundle
+ /properties
+ urlhttp://struts.apache.org//url
+ /dependency
+
+ dependency
+ groupIdstruts/groupId
+ artifactIdstruts-tiles/artifactId
+ version1.3.0-dev/version
+ properties
+ war.bundletrue/war.bundle
+ /properties
+ urlhttp://struts.apache.org//url
+ /dependency
+
+ dependency
+ groupIdmyfaces/groupId
+ artifactIdmyfaces-jsf-api/artifactId
+ version1.0.8-beta/version
+ properties
+ war.bundletrue/war.bundle
+ /properties
+ urlhttp://incubator.apache.org/myfaces/index.html/url
+ /dependency
+
+dependency
+ groupIdcommons-httpclient/groupId
+ artifactIdcommons-httpclient/artifactId
+ version2.0.1/version
+ urlhttp://jakarta.apache.org/commons/httpclient//url
+ properties
+war.bundletrue/war.bundle
+cactus.bundletrue/cactus.bundle
+ /properties
+/dependency
+
+dependency
+ groupIdhtmlunit/groupId
+ artifactIdhtmlunit/artifactId
+ version1.2.3/version
+ urlhttp://htmlunit.sourceforge.net//url
+ properties
+war.bundletrue/war.bundle
+cactus.bundletrue/cactus.bundle
+ /properties
+/dependency
+
+
+
+ /dependencies
+
+ build
+nagEmailAddress/
+sourceDirectory${basedir}/core-library/src/java/sourceDirectory
+
unitTestSourceDirectory${basedir}/core-library/src/test/unitTestSourceDirectory
+
+unitTest
+ includes
+include**/*TestCase/include
+ /includes
+/unitTest
+
+resources
+ resource
+directory${basedir}/core-library/src/java/directory
+includes
+ include**/*.properties/include
+/includes
+ /resource
+/resources
+ /build
+
+ reports
+ !-- reports specific to faces--
+
+ /reports
+/project
Propchange: struts/faces/trunk/project.xml
svn commit: r155889 - struts/faces/trunk/project.xml
Author: jmitchell Date: Tue Mar 1 22:11:55 2005 New Revision: 155889 URL: http://svn.apache.org/viewcvs?view=revrev=155889 Log: fix version (Craig is this what you want to see as the version number?) Modified: struts/faces/trunk/project.xml Modified: struts/faces/trunk/project.xml URL: http://svn.apache.org/viewcvs/struts/faces/trunk/project.xml?view=diffr1=155888r2=155889 == --- struts/faces/trunk/project.xml (original) +++ struts/faces/trunk/project.xml Tue Mar 1 22:11:55 2005 @@ -22,6 +22,7 @@ extendbuild/project.xml/extend idstruts-faces/id nameStruts JSF Integration Library/name + currentVersion1.0-dev/currentVersion packageorg.apache.struts.faces/package packageGroups - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33672] New: - struts-faces is incompatible with myfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33672. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33672 Summary: struts-faces is incompatible with myfaces Product: Struts Version: Nightly Build Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Struts-Faces Library AssignedTo: dev@struts.apache.org ReportedBy: [EMAIL PROTECTED] This bug is esentially the same as bug 32014 , but I believe the descriptions lead one to believe that it only has to do with Tiles integration, whereas I believe that FacesRequestProcessor is also incompatible with myfaces. The example1 webapp included with struts-faces does not expose this bug because, if I understand it correctly, it never directly invokes a struts action, but instead struts actions are invoked through the tags-faces taglib, which is going through FacesServlet first. But, if you wrote an application which calls a struts action initially (as opposed to being forwarded to from FacesServlet), FacesRequestProcessor will fail against myfaces in the same manner that FacesTilesRequestProcessor fails (as described in bug 32014). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
