[PATCH] Translate German comments (multiple files)
Hi, I translated all comments in the following files from German to English: include/svtools/imapobj.hxx include/svtools/prnsetup.hxx include/svx/svdocapt.hxx svx/source/tbxctrls/tbcontrl.cxx sc/source/ui/unoobj/nameuno.cxx Please note that I'm not familiar with the code, so I weren't always sure what the authors intended to say. Yours sincerely, Sven WehnerFrom 85ac1c9181a6ef8fb01dcc8b2b2b2619fa4c1294 Mon Sep 17 00:00:00 2001 From: Sven Wehner m...@svenwehner.de Date: Tue, 14 Jan 2014 22:18:53 +0100 Subject: [PATCH] Translate German comments to English --- include/svtools/imapobj.hxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/svtools/imapobj.hxx b/include/svtools/imapobj.hxx index bd314d9..f04cbb7 100644 --- a/include/svtools/imapobj.hxx +++ b/include/svtools/imapobj.hxx @@ -64,11 +64,11 @@ class SVT_DLLPUBLIC IMapObject protected: sal_uInt16 nReadVersion; -// Binaer-Im-/Export +// binary import/export virtual voidWriteIMapObject( SvStream rOStm ) const = 0; virtual voidReadIMapObject( SvStream rIStm ) = 0; -// Hilfsmethoden +// helper methods void AppendCERNCoords(OStringBuffer rBuf, const Point rPoint100) const; void AppendCERNURL(OStringBuffer rBuf, const OUString rBaseURL) const; void AppendNCSACoords(OStringBuffer rBuf, const Point rPoint100) const; -- 1.8.3.2 From 0de3a96a90fa178431c73dcb5e4c1b1bcc880e97 Mon Sep 17 00:00:00 2001 From: Sven Wehner m...@svenwehner.de Date: Tue, 14 Jan 2014 22:22:59 +0100 Subject: [PATCH] Translate German comments to English --- include/svtools/prnsetup.hxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/svtools/prnsetup.hxx b/include/svtools/prnsetup.hxx index 006a70d..593b95e 100644 --- a/include/svtools/prnsetup.hxx +++ b/include/svtools/prnsetup.hxx @@ -73,9 +73,9 @@ public: voidSetOptionsHdl( const Link rLink ); }; -// -- -// - Hilfsfunktionen fuer Print-Dialoge - -// -- +// - +// - Helper functions for print dialog - +// - #define IMPL_PRINTDLG_STATUS_UPDATE 15000 -- 1.8.3.2 From 2579cf37b60336d61997884aaa51ee03ef91a390 Mon Sep 17 00:00:00 2001 From: Sven Wehner m...@svenwehner.de Date: Tue, 14 Jan 2014 22:26:52 +0100 Subject: [PATCH] Translate German comments to English --- include/svx/svdocapt.hxx | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/svx/svdocapt.hxx b/include/svx/svdocapt.hxx index 6181035..7b922dd 100644 --- a/include/svx/svdocapt.hxx +++ b/include/svx/svdocapt.hxx @@ -24,7 +24,7 @@ #include svx/svxdllapi.h // -// Vorausdeklarationen +// Forward Declarations // class ImpCaptParams; @@ -34,7 +34,7 @@ namespace sdr { namespace properties { }} // -// Hilfsklasse SdrCaptObjGeoData +// Helper Class SdrCaptObjGeoData // // #109872# @@ -53,14 +53,14 @@ class SVX_DLLPUBLIC SdrCaptionObj : public SdrRectObj private: // to allow sdr::properties::CaptionProperties access to ImpRecalcTail() friend class sdr::properties::CaptionProperties; -friend classSdrTextObj; // fuer ImpRecalcTail() bei AutoGrow +friend classSdrTextObj; // for ImpRecalcTail() during AutoGrow protected: virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties(); virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact(); private: -Polygon aTailPoly; // das ganze Polygon des Schwanzes +Polygon aTailPoly; // the whole tail polygon sal_BoolmbSpecialTextBoxShadow; // for calc special shadow, default FALSE sal_BoolmbFixedTail; // for calc note box fixed tail, default FALSE Point maFixedTailPos; // for calc note box fixed tail position. -- 1.8.3.2 From 223d5f7c37936c520a4849b4dad1aee35cce1dee Mon Sep 17 00:00:00 2001 From: Sven Wehner m...@svenwehner.de Date: Tue, 14 Jan 2014 22:33:19 +0100 Subject: [PATCH] Translate German comments to English --- svx/source/tbxctrls/tbcontrl.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx index 6d6befa..dfc9c9a 100644 --- a/svx/source/tbxctrls/tbcontrl.cxx +++ b/svx/source/tbxctrls/tbcontrl.cxx @@ -1675,7 +1675,7 @@ void SvxLineWindow_Impl::DataChanged( const DataChangedEvent rDCEvt
[PATCH] Translate German comments, correct some WS
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4331 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/4331/1 Translate German comments, correct some WS Change-Id: Ied6c233cba113673f928c1a6b41a5217b9fff077 --- M svl/source/numbers/numfmuno.cxx M svl/source/numbers/zforscan.cxx 2 files changed, 214 insertions(+), 235 deletions(-) diff --git a/svl/source/numbers/numfmuno.cxx b/svl/source/numbers/numfmuno.cxx index 40f34e9..826d53d 100644 --- a/svl/source/numbers/numfmuno.cxx +++ b/svl/source/numbers/numfmuno.cxx @@ -34,14 +34,10 @@ using namespace com::sun::star; -// - #define SERVICENAME_NUMBERFORMATTER com.sun.star.util.NumberFormatter #define SERVICENAME_NUMBERSETTINGS com.sun.star.util.NumberFormatSettings #define SERVICENAME_NUMBERFORMATS com.sun.star.util.NumberFormats #define SERVICENAME_NUMBERFORMATcom.sun.star.util.NumberFormatProperties - -// #define PROPERTYNAME_FMTSTR FormatString #define PROPERTYNAME_LOCALE Locale @@ -62,9 +58,7 @@ #define PROPERTYNAME_STDDEC StandardDecimals #define PROPERTYNAME_TWODIGIT TwoDigitDateStart -// - -// alles ohne Which-ID, Map nur fuer PropertySetInfo +// All without a Which-ID, Map only for PropertySetInfo static const SfxItemPropertyMapEntry* lcl_GetNumberFormatPropertyMap() { @@ -101,8 +95,6 @@ return aNumberSettingsPropertyMap_Impl; } -// - static LanguageType lcl_GetLanguage( const lang::Locale rLocale ) { // empty language - LANGUAGE_SYSTEM @@ -111,12 +103,10 @@ LanguageType eRet = LanguageTag( rLocale ).getLanguageType( false ); if ( eRet == LANGUAGE_NONE ) -eRet = LANGUAGE_SYSTEM; //! or throw an exception? +eRet = LANGUAGE_SYSTEM; //! or throw an exception? return eRet; } - -// SvNumberFormatterServiceObj::SvNumberFormatterServiceObj() :m_aMutex() @@ -145,7 +135,7 @@ SvNumberFormatsSupplierObj* pNew = SvNumberFormatsSupplierObj::getImplementation( _xSupplier ); if (!pNew) -throw uno::RuntimeException(); // wrong object +throw uno::RuntimeException(); // wrong object xAutoReleaseOld = xSupplier; @@ -231,7 +221,7 @@ { ::osl::MutexGuard aGuard( m_aMutex ); -util::Color nRet = aDefaultColor; // color = sal_Int32 +util::Color nRet = aDefaultColor; // color = sal_Int32 SvNumberFormatter* pFormatter = xSupplier.is() ? xSupplier-GetNumberFormatter() : NULL; if (pFormatter) { @@ -240,7 +230,7 @@ pFormatter-GetOutputString(fValue, nKey, aStr, pColor); if (pColor) nRet = pColor-GetColor(); -// sonst Default behalten +// Else keep Default } else throw uno::RuntimeException(); @@ -276,7 +266,7 @@ { ::osl::MutexGuard aGuard( m_aMutex ); -util::Color nRet = aDefaultColor; // color = sal_Int32 +util::Color nRet = aDefaultColor; // color = sal_Int32 SvNumberFormatter* pFormatter = xSupplier.is() ? xSupplier-GetNumberFormatter() : NULL; if (pFormatter) { @@ -288,7 +278,7 @@ { nRet = pColor-GetColor(); } -// sonst Default behalten +// Else keep Default } else { @@ -354,7 +344,7 @@ { ::osl::MutexGuard aGuard( m_aMutex ); -util::Color nRet = aDefaultColor; // color = sal_Int32 +util::Color nRet = aDefaultColor; // color = sal_Int32 SvNumberFormatter* pFormatter = xSupplier.is() ? xSupplier-GetNumberFormatter() : NULL; if (pFormatter) { @@ -372,7 +362,7 @@ { if (pColor) nRet = pColor-GetColor(); -// sonst Default behalten +// Else keep Default } else throw util::MalformedNumberFormatException(); @@ -405,8 +395,6 @@ pArray[0] = SERVICENAME_NUMBERFORMATTER; return aRet; } - -// SvNumberFormatsObj::SvNumberFormatsObj( SvNumberFormatsSupplierObj _rParent, ::comphelper::SharedMutex _rMutex ) :rSupplier( _rParent ) @@ -477,7 +465,7 @@ LanguageType eLang = lcl_GetLanguage( nLocale ); if (bScan) { -//! irgendwas muss hier noch passieren... +//! FIXME: Something still needs to happen here ... } nRet = pFormatter-GetEntryKey( aFormat, eLang ); } @@ -507,10 +495,10 @@ nRet = nKey; else if (nCheckPos) { -throw
[PATCH] Translate German comments, delete some WS and correct format...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4319 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/4319/1 Translate German comments, delete some WS and correct formatting Change-Id: I6426b37e7963ab3ad48221f1695abd6036339ad5 --- M svl/source/numbers/zformat.cxx 1 file changed, 267 insertions(+), 267 deletions(-) diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index fc9254b..7b6e0c7 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -85,7 +85,7 @@ { if( c = 32 ) { -int n = 2; // Default fuer Zeichen 128 (HACK!) +int n = 2; // Default for chars 128 (HACK!) if( c = 127 ) { n = (int)cCharWidths[ c - 32 ]; @@ -103,7 +103,7 @@ DBG_ASSERT( fAbsVal 0.0, GetPrecExp: fAbsVal = 0.0 ); if ( fAbsVal 1e-7 || fAbsVal 1e7 ) { -// die Schere, ob's schneller ist oder nicht, liegt zwischen 1e6 und 1e7 +// Shear: whether it's faster or not, falls in between 1e6 and 1e7 return (long) floor( log10( fAbsVal ) ) + 1; } else @@ -123,11 +123,13 @@ } } -const sal_uInt16 nNewCurrencyVersionId = 0x434E;// NC -const sal_Unicode cNewCurrencyMagic = 0x01; // Magic for format code in comment -const sal_uInt16 nNewStandardFlagVersionId = 0x4653;// SF +const sal_uInt16 nNewCurrencyVersionId = 0x434E; // NC +const sal_Unicode cNewCurrencyMagic = 0x01; // Magic for format code in comment +const sal_uInt16 nNewStandardFlagVersionId = 0x4653; // SF -/***Funktion SvNumberformatInfo**/ +/** + * SvNumberformatInfo + * */ void ImpSvNumberformatInfo::Copy( const ImpSvNumberformatInfo rNumFor, sal_uInt16 nAnz ) { @@ -152,23 +154,23 @@ short nType = nTypeArray[i]; switch ( nType ) { -// der Krampf fuer Versionen vor SV_NUMBERFORMATTER_VERSION_NEW_CURR -case NF_SYMBOLTYPE_CURRENCY : -rStream short( NF_SYMBOLTYPE_STRING ); +// The fight with versions before SV_NUMBERFORMATTER_VERSION_NEW_CURR +case NF_SYMBOLTYPE_CURRENCY : +rStream short( NF_SYMBOLTYPE_STRING ); break; -case NF_SYMBOLTYPE_CURRDEL : -case NF_SYMBOLTYPE_CURREXT : -rStream short(0);// werden ignoriert (hoffentlich..) -break; -default: -if ( nType NF_KEY_LASTKEYWORD_SO5 ) -{ -rStream short( NF_SYMBOLTYPE_STRING ); // all new keywords are string -} -else -{ -rStream nType; -} +case NF_SYMBOLTYPE_CURRDEL : +case NF_SYMBOLTYPE_CURREXT : +rStream short(0); // will be ignored (hopefully ...) +break; +default: +if ( nType NF_KEY_LASTKEYWORD_SO5 ) +{ +rStream short( NF_SYMBOLTYPE_STRING ); // all new keywords are string +} +else +{ +rStream nType; +} } } @@ -189,7 +191,6 @@ bThousand = bStreamThousand; } -// // static sal_uInt8 SvNumberNatNum::MapDBNumToNatNum( sal_uInt8 nDBNum, LanguageType eLang, bool bDate ) @@ -381,7 +382,9 @@ } #endif -/***Funktionen SvNumFor**/ +/** + * SvNumFor + */ ImpSvNumFor::ImpSvNumFor() { @@ -450,7 +453,7 @@ OUString rLoadedColorName ) { sal_uInt16 nAnz; -rStream nAnz;//! noch nicht direkt nAnzStrings wg. Enlarge +rStream nAnz; //! Not nAnzStrings rigth away due to Enlarge Enlarge( nAnz ); aI.Load( rStream, nAnz ); sColorName = rStream.ReadUniOrByteString( rStream.GetStreamCharSet() ); @@ -489,7 +492,7 @@ return true; } } -//! kein Erase an rSymbol, rExtension +//! No Erase at rSymbol, rExtension return false; } @@ -538,7 +541,9 @@ } } -/***Funktionen SvNumberformat/ +/** + * SvNumberformat + */ enum BracketFormatSymbolType { @@ -546,7 +551,7 @@ BRACKET_SYMBOLTYPE_COLOR= -2, // color BRACKET_SYMBOLTYPE_ERROR= -3, // error BRACKET_SYMBOLTYPE_DBNUM1 = -4, // DoubleByteNumber, represent numbers -BRACKET_SYMBOLTYPE_DBNUM2 = -5, // using CJK characters, Excel compatible. +BRACKET_SYMBOLTYPE_DBNUM2 = -5, // using CJK characters, Excel compatible BRACKET_SYMBOLTYPE_DBNUM3 = -6, BRACKET_SYMBOLTYPE_DBNUM4 = -7, BRACKET_SYMBOLTYPE_DBNUM5 = -8, @@ -557,7 +562,7 @@ BRACKET_SYMBOLTYPE_LOCALE = -13, BRACKET_SYMBOLTYPE_NATNUM0 = -14, // Our NativeNumber support,
[PATCH] Translate German comments, correct some WS
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4320 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/4320/1 Translate German comments, correct some WS Change-Id: Ia0ecca3dbaa1d44a7175ef6c454cd13c98bab030 --- M svl/source/numbers/numhead.cxx M svl/source/numbers/numhead.hxx M svl/source/numbers/numuno.cxx M svl/source/numbers/supservs.cxx M svl/source/numbers/supservs.hxx M svl/source/numbers/zforscan.hxx 6 files changed, 86 insertions(+), 132 deletions(-) diff --git a/svl/source/numbers/numhead.cxx b/svl/source/numbers/numhead.cxx index 04964e9..2d31846 100644 --- a/svl/source/numbers/numhead.cxx +++ b/svl/source/numbers/numhead.cxx @@ -21,12 +21,12 @@ #include numhead.hxx -// ID's fuer Dateien: +// ID's for files: #define SV_NUMID_SIZES 0x4200 //#pragma SEG_FUNCDEF(numhead_06) -//! mit Skip() synchron +//! Synchronous with Skip() ImpSvNumMultipleReadHeader::ImpSvNumMultipleReadHeader(SvStream rNewStream) : rStream( rNewStream ) { @@ -40,7 +40,7 @@ rStream nID; if (nID != SV_NUMID_SIZES) { -OSL_FAIL(SV_NUMID_SIZES nicht gefunden); +OSL_FAIL(SV_NUMID_SIZES not found); } sal_uInt32 nSizeTableLen; rStream nSizeTableLen; @@ -57,7 +57,7 @@ ImpSvNumMultipleReadHeader::~ImpSvNumMultipleReadHeader() { DBG_ASSERT( pMemStream-Tell() == pMemStream-GetEndOfData(), -Sizes nicht vollstaendig gelesen ); +Sizes not completely read ); delete pMemStream; delete [] pBuf; @@ -69,9 +69,9 @@ void ImpSvNumMultipleReadHeader::EndEntry() { sal_uLong nPos = rStream.Tell(); -DBG_ASSERT( nPos = nEntryEnd, zuviel gelesen ); +DBG_ASSERT( nPos = nEntryEnd, Read too much ); if ( nPos != nEntryEnd ) -rStream.Seek( nEntryEnd ); // Rest ueberspringen +rStream.Seek( nEntryEnd ); // Skip the rest } //#pragma SEG_FUNCDEF(numhead_0d) @@ -93,11 +93,10 @@ if (nReadEnd = nEntryEnd) return nEntryEnd-nReadEnd; -OSL_FAIL(Fehler bei ImpSvNumMultipleReadHeader::BytesLeft); +OSL_FAIL(Error in ImpSvNumMultipleReadHeader::BytesLeft); return 0; } -// --- //#pragma SEG_FUNCDEF(numhead_0a) @@ -123,12 +122,12 @@ rStream static_castsal_uInt32(aMemStream.Tell()); rStream.Write( aMemStream.GetData(), aMemStream.Tell() ); -if ( nDataEnd - nDataPos != nDataSize ) // Default getroffen? +if ( nDataEnd - nDataPos != nDataSize ) // Hit Default? { nDataSize = nDataEnd - nDataPos; sal_uLong nPos = rStream.Tell(); rStream.Seek(nDataPos-sizeof(sal_uInt32)); -rStream nDataSize; // Groesse am Anfang eintragen +rStream nDataSize; // Add size at the start rStream.Seek(nPos); } } diff --git a/svl/source/numbers/numhead.hxx b/svl/source/numbers/numhead.hxx index 9e7bd2a..2beab9a0 100644 --- a/svl/source/numbers/numhead.hxx +++ b/svl/source/numbers/numhead.hxx @@ -22,7 +22,7 @@ #include tools/stream.hxx -// Header mit Groessenangaben fuer mehrere Objekte +// This header contains size measures for various objects class ImpSvNumMultipleReadHeader { diff --git a/svl/source/numbers/numuno.cxx b/svl/source/numbers/numuno.cxx index 8e5b4a1..b2436c2 100644 --- a/svl/source/numbers/numuno.cxx +++ b/svl/source/numbers/numuno.cxx @@ -26,7 +26,6 @@ using namespace com::sun::star; -// class SvNumFmtSuppl_Impl { @@ -38,9 +37,8 @@ pFormatter(p) {} }; -// -// Default-ctor fuer getReflection +// Default ctor for getReflection SvNumberFormatsSupplierObj::SvNumberFormatsSupplierObj() { pImpl = new SvNumFmtSuppl_Impl(NULL); @@ -68,18 +66,18 @@ void SvNumberFormatsSupplierObj::SetNumberFormatter(SvNumberFormatter* pNew) { -// der alte Numberformatter ist ungueltig geworden, nicht mehr darauf zugreifen! +// The old Numberformatter has been retired, do not access it anymore! pImpl-pFormatter = pNew; } void SvNumberFormatsSupplierObj::NumberFormatDeleted(sal_uInt32) { -// Basis-Implementierung tut nix... +// Base implementation; does nothing } void SvNumberFormatsSupplierObj::SettingsChanged() { -// Basis-Implementierung tut nix... +// Base implementation; does nothing } // XNumberFormatsSupplier @@ -135,10 +133,5 @@ pRet = reinterpret_castSvNumberFormatsSupplierObj*(sal::static_int_castsal_IntPtr(xUT-getSomething( getUnoTunnelId() ))); return pRet; } - - -// - - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/svl/source/numbers/supservs.cxx
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4295 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/4295/1 Translate German comments Change-Id: I1e852ec6961f11b9b5047442d974063496750440 --- M include/svx/svdmrkv.hxx 1 file changed, 155 insertions(+), 157 deletions(-) diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx index 133a438..555a7c4 100644 --- a/include/svx/svdmrkv.hxx +++ b/include/svx/svdmrkv.hxx @@ -30,60 +30,60 @@ // Defines // -// folgendes ist noch nicht bzw. erst zum Teil implementiert: -#define SDRSEARCH_DEEP 0x0001 /* rekursiv in Gruppenobjekte hinein */ -#define SDRSEARCH_ALSOONMASTER 0x0002 /* MasterPages werden auch durchsucht */ -#define SDRSEARCH_WHOLEPAGE0x0004 /* Nicht nur die ObjList der PageView */ -#define SDRSEARCH_TESTMARKABLE 0x0008 /* nur markierbare Objekte/Punkte/Handles/... */ -#define SDRSEARCH_TESTMACRO0x0010 /* Nur Objekte mit Macro */ -#define SDRSEARCH_TESTTEXTEDIT 0x0020 /* Nur TextEdit-faehige Objekte */ -#define SDRSEARCH_WITHTEXT 0x0040 /* Nur Objekte mit Text */ -#define SDRSEARCH_TESTTEXTAREA 0x0080 /* Den Textbereich von Objekten mit Text (TextEditHit) */ -#define SDRSEARCH_BACKWARD 0x0100 /* Rueckwaertssuche */ -#define SDRSEARCH_NEXT 0x0200 /* Suche startet hinter dem uebergebenen Objekt/Punkt/... */ -#define SDRSEARCH_MARKED 0x0400 /* Nur markierte Objekte/Punkte/... */ -#define SDRSEARCH_PASS2BOUND 0x0800 /* Wenn nix gefunden, dann neuer 2. Versuch mit BoundRectHit */ -#define SDRSEARCH_PASS3NEAREST 0x1000 /* Wenn nix gefunden, dann neuer 3. Versuch mit NearestBoundRectHit */ +// The following is not yet implemented, or just particially: +#define SDRSEARCH_DEEP 0x0001 /* recursive into group objects */ +#define SDRSEARCH_ALSOONMASTER 0x0002 /* MasterPages are also scanned */ +#define SDRSEARCH_WHOLEPAGE0x0004 /* Not just the ObjList of PageView */ +#define SDRSEARCH_TESTMARKABLE 0x0008 /* just markable Objekte/Punkte/Handles/... */ +#define SDRSEARCH_TESTMACRO0x0010 /* Just objects with macro */ +#define SDRSEARCH_TESTTEXTEDIT 0x0020 /* Just TextEdit-enabed objects */ +#define SDRSEARCH_WITHTEXT 0x0040 /* Just objects with text */ +#define SDRSEARCH_TESTTEXTAREA 0x0080 /* The textarea of objects with text (TextEditHit) */ +#define SDRSEARCH_BACKWARD 0x0100 /* Backwards search */ +#define SDRSEARCH_NEXT 0x0200 /* Search starts behind the transfered object/point/... */ +#define SDRSEARCH_MARKED 0x0400 /* Just marked objects/points/... */ +#define SDRSEARCH_PASS2BOUND 0x0800 /* In case of empty search results, then 2nd. try with BoundRectHit */ +#define SDRSEARCH_PASS3NEAREST 0x1000 /* In case of empty search results, then new 3rd. Try with NearestBoundRectHit */ #define SDRSEARCH_BEFOREMARK 0x2000 /* if one marked one found, ignore all behind that */ #define SDRSEARCH_PICKMARKABLE (SDRSEARCH_TESTMARKABLE) #define SDRSEARCH_PICKTEXTEDIT (SDRSEARCH_DEEP|SDRSEARCH_TESTMARKABLE|SDRSEARCH_TESTTEXTEDIT) #define SDRSEARCH_PICKMACRO (SDRSEARCH_DEEP|SDRSEARCH_ALSOONMASTER|SDRSEARCH_WHOLEPAGE|SDRSEARCH_TESTMACRO) -// SDRSEARCHPASS_... ist Rueckgabeparameterwert bei PickObj(). -#define SDRSEARCHPASS_DIRECT 0x /* Objekt durch direkten Hit getroffen */ -#define SDRSEARCHPASS_INACTIVELIST 0x0001 /* Obj auf der Page, nicht jedoch in der AktGroup (bei WHOLEPAGE) */ -#define SDRSEARCHPASS_MASTERPAGE 0x0002 /* Objekt auf der MasterPage gefunden */ -#define SDRSEARCHPASS_BOUND0x0010 /* Objekt erst beim Bound-Check gefunden */ -#define SDRSEARCHPASS_NEAREST 0x0020 /* Objekt erst beim Nearest-Check gefunden */ +// SDRSEARCHPASS_... is return parameter value at PickObj(). +#define SDRSEARCHPASS_DIRECT 0x /* Object is hit by 'direct hit' */ +#define SDRSEARCHPASS_INACTIVELIST 0x0001 /* Obj is on the page, but not in the AktGroup (at WHOLEPAGE) */ +#define SDRSEARCHPASS_MASTERPAGE 0x0002 /* Object was found on the MasterPage */ +#define SDRSEARCHPASS_BOUND0x0010 /* Object found, butjust after Bound-Check gefunden */ +#define SDRSEARCHPASS_NEAREST 0x0020 /* Object found, but just after Nearest-Check */ -enum SdrHitKind {SDRHIT_NONE, // Nicht getroffen, Schnaps gesoffen - SDRHIT_OBJECT,// Treffer versenkt - SDRHIT_BOUNDRECT, // Treffer am BoundRect - SDRHIT_BOUNDTL, // Treffer am BoundRect TopLeft - SDRHIT_BOUNDTC, // Treffer am BoundRect TopCenter - SDRHIT_BOUNDTR, // Treffer am BoundRect TopRight - SDRHIT_BOUNDCL, // Treffer am BoundRect CenterLeft - SDRHIT_BOUNDCR, // Treffer am BoundRect CenterRight - SDRHIT_BOUNDBL, // Treffer am BoundRect BottomLeft - SDRHIT_BOUNDBC, // Treffer
[PATCH] Translate German comments
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4295 to look at the new patch set (#2). Change subject: Translate German comments .. Translate German comments Change-Id: I1e852ec6961f11b9b5047442d974063496750440 --- M include/svx/svdmrkv.hxx 1 file changed, 154 insertions(+), 157 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/4295/2 -- To view, visit https://gerrit.libreoffice.org/4295 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e852ec6961f11b9b5047442d974063496750440 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Michael Meeks michael.me...@suse.com Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hello Matthias Freund, LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4295 to look at the new patch set (#3). Change subject: Translate German comments .. Translate German comments Change-Id: I1e852ec6961f11b9b5047442d974063496750440 --- M include/svx/svdmrkv.hxx 1 file changed, 154 insertions(+), 158 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/4295/3 -- To view, visit https://gerrit.libreoffice.org/4295 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e852ec6961f11b9b5047442d974063496750440 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Michael Meeks michael.me...@suse.com Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Matthias Freund matti...@yahoo.de ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments and general clean-up
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3294 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3294/1 Translate German comments and general clean-up Removed some whitespace, programmer handles in comments and commented out code. Change-Id: I68a1285355b14e122f218b2f483ebc74a2b2dbaf --- M vcl/source/gdi/outdev3.cxx M vcl/source/gdi/print.cxx 2 files changed, 113 insertions(+), 197 deletions(-) diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx index e47acb0..1c5f819 100644 --- a/vcl/source/gdi/outdev3.cxx +++ b/vcl/source/gdi/outdev3.cxx @@ -279,7 +279,7 @@ { if ( pFrame-ImplGetGraphics() ) { -// MT: Stupid typecast here and somewhere ((OutputDevice*)aVDev)-, because bug in .NET2002 compiler. +// Stupid typecast here and somewhere ((OutputDevice*)aVDev)-, because bug in .NET2002 compiler OutputDevice *pDevice = (OutputDevice*)pFrame; pDevice-mpGraphics-ClearDevFontCache(); pDevice-mpGraphics-GetDevFontList(pFrame-mpWindowImpl-mpFrameData-mpFontList); @@ -483,7 +483,7 @@ case DEFAULTFONT_CJK_SPREADSHEET: case DEFAULTFONT_CJK_HEADING: case DEFAULTFONT_CJK_DISPLAY: -aFont.SetFamily( FAMILY_SYSTEM ); // don't care, but don't use font subst config later... +aFont.SetFamily( FAMILY_SYSTEM ); // don't care, but don't use font subst config later... break; case DEFAULTFONT_CTL_TEXT: @@ -491,7 +491,7 @@ case DEFAULTFONT_CTL_SPREADSHEET: case DEFAULTFONT_CTL_HEADING: case DEFAULTFONT_CTL_DISPLAY: -aFont.SetFamily( FAMILY_SYSTEM ); // don't care, but don't use font subst config later... +aFont.SetFamily( FAMILY_SYSTEM ); // don't care, but don't use font subst config later... break; } @@ -1026,7 +1026,7 @@ // TODO: is it cheaper to calc matching attributes now or on demand? // calc matching attributes if other entries are already initialized -// MT: Perform05: Do lazy, quite expensive, not needed in start-up! +// Do lazy, quite expensive, not needed in start-up! // const FontSubstConfiguration rFontSubst = *FontSubstConfiguration::get(); // InitMatchData( rFontSubst, maSearchName ); // mbMatchData=true; // Somewhere else??? @@ -1101,7 +1101,7 @@ rSearchName.Equals( maSearchName, 0, maSearchName.Len() ) ) pTargetStyleName = rSearchName.GetBuffer() + maSearchName.Len() + 1; -// linear search, TODO: improve? +// TODO: linear search improve! PhysicalFontFace* pFontFace = mpFirst; PhysicalFontFace* pBestFontFace = pFontFace; FontMatchStatus aFontMatchStatus = {0,0,0, pTargetStyleName}; @@ -1228,7 +1228,7 @@ for( const char** ppNames = aGlyphFallbackList[0];; ++ppNames ) { // advance to next sub-list when end-of-sublist marker -if( !**ppNames )// #i46456# check for empty string, i.e., deref string itself not only ptr to it +if( !**ppNames ) // #i46456# check for empty string, i.e., deref string itself not only ptr to it { if( nBestQuality 0 ) if( ++nMaxLevel = MAX_FALLBACK ) @@ -1330,11 +1330,11 @@ else rFontSelData.maSearchName = OUString(); -//See fdo#32665 for an example. FreeSerif that has glyphs in normal -//font, but not in the italic or bold version +// See fdo#32665 for an example. FreeSerif that has glyphs in normal +// font, but not in the italic or bold version bool bSubSetOfFontRequiresPropertyFaking = rFontSelData.mbEmbolden || rFontSelData.maItalicMatrix != ItalicMatrix(); -// cache the result even if there was no match, unless its from part of a font for which the properties need +// Cache the result even if there was no match, unless its from part of a font for which the properties need // to be faked. We need to rework this cache to take into account that fontconfig can return different fonts // for different input sizes, weights, etc. Basically the cache is way to naive if (!bSubSetOfFontRequiresPropertyFaking) @@ -1455,7 +1455,7 @@ ImplDevFontListData* ImplDevFontList::FindFontFamily( const String rFontName ) const { -// normalize the font fomily name and +// normalize the font family name and OUString aName = rFontName; GetEnglishSearchFontName( aName ); ImplDevFontListData* pFound = ImplFindBySearchName( aName ); @@ -1736,7 +1736,7 @@ nTestMatch -= 100; // test font name substrings -// TODO: calculate name matching score using e.g. Levenstein distance +// TODO: calculate name matching score using e.g. Levenstein
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2691 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/2691/1 Translate German comments Change-Id: I0b386fd0c7cb0382fa3a5187389369966365b1fb --- M sw/source/core/draw/dobjfac.cxx M sw/source/core/para/paratr.cxx 2 files changed, 14 insertions(+), 27 deletions(-) diff --git a/sw/source/core/draw/dobjfac.cxx b/sw/source/core/draw/dobjfac.cxx index 6ad9d25..891856b 100644 --- a/sw/source/core/draw/dobjfac.cxx +++ b/sw/source/core/draw/dobjfac.cxx @@ -23,23 +23,16 @@ SwObjectFactory aSwObjectFactory; -/* -|* -|* void SwObjectFactory::MakeObject() -|* -\/ - IMPL_LINK( SwObjectFactory, MakeObject, SdrObjFactory*, pObjFactory ) { if ( pObjFactory-nInventor == SWGInventor ) { -//Kein switch, derzeit gibt es nur einen. +// No switch, there's only one at the moment OSL_ENSURE( pObjFactory-nIdentifier == SwFlyDrawObjIdentifier, -Falscher Inventor oder identifier. ); +Wrong inventor or identifier ); pObjFactory-pNewObj = new SwFlyDrawObj(); } return 0; } - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/core/para/paratr.cxx b/sw/source/core/para/paratr.cxx index 6810db2..1db5303 100644 --- a/sw/source/core/para/paratr.cxx +++ b/sw/source/core/para/paratr.cxx @@ -48,12 +48,6 @@ TYPEINIT1_AUTOFACTORY( SwNumRuleItem, SfxStringItem); TYPEINIT1_AUTOFACTORY( SwParaConnectBorderItem, SfxBoolItem); -/* -|*Beschreibung Methoden von SwFmtDrop -*/ - - - SwFmtDrop::SwFmtDrop() : SfxPoolItem( RES_PARATR_DROP ), SwClient( 0 ), @@ -90,7 +84,7 @@ void SwFmtDrop::SetCharFmt( SwCharFmt *pNew ) { -//Ummelden +// Rewire if ( GetRegisteredIn() ) GetRegisteredInNonConst()-Remove( this ); if(pNew) @@ -109,9 +103,8 @@ else if( pDefinedIn-GetDepends() !pDefinedIn-IsModifyLocked() ) { -// selbst den Abhaengigen vom Format bescheid sagen. Das -// Format selbst wuerde es nicht weitergeben, weil es ueber -// die Abpruefung nicht hinauskommt. +// Notify those who are dependend on the format on our own. +// The format itself wouldn't pass on the notify as it does not get past the check. pDefinedIn-ModifyBroadcast( this, this ); } } @@ -119,12 +112,12 @@ bool SwFmtDrop::GetInfo( SfxPoolItem ) const { -return true;// weiter +return true; // Continue } int SwFmtDrop::operator==( const SfxPoolItem rAttr ) const { -OSL_ENSURE( SfxPoolItem::operator==( rAttr ), keine gleichen Attribute ); +OSL_ENSURE( SfxPoolItem::operator==( rAttr ), No mathing attributes ); return ( nLines == ((SwFmtDrop)rAttr).GetLines() nChars == ((SwFmtDrop)rAttr).GetChars() nDistance == ((SwFmtDrop)rAttr).GetDistance() @@ -222,22 +215,25 @@ return true; } -// class SwRegisterItem - - +/** + * SwRegisterItem + */ SfxPoolItem* SwRegisterItem::Clone( SfxItemPool * ) const { return new SwRegisterItem( *this ); } -// class SwNumRuleItem - +/** + * SwNumRuleItem + */ SfxPoolItem* SwNumRuleItem::Clone( SfxItemPool * ) const { return new SwNumRuleItem( *this ); } int SwNumRuleItem::operator==( const SfxPoolItem rAttr ) const { -OSL_ENSURE( SfxPoolItem::operator==( rAttr ), keine gleichen Attribute ); +OSL_ENSURE( SfxPoolItem::operator==( rAttr ), No matching attributes ); return GetValue() == ((SwNumRuleItem)rAttr).GetValue(); } @@ -261,7 +257,5 @@ { return new SwParaConnectBorderItem( *this ); } - - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- To view, visit https://gerrit.libreoffice.org/2691 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b386fd0c7cb0382fa3a5187389369966365b1fb Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate german comments in sw/source/filter/ww8/wrtww8.cxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2617 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2617/1 Translate german comments in sw/source/filter/ww8/wrtww8.cxx Please, only apply this patch if you are a native speaking German. I'm not a native speaker, so a double check is really necessary and appreciated. Thanks in advance. Change-Id: Ic2fb6e97007c6b47851ad8a7a51e987da5a70877 --- M sw/source/filter/ww8/docxexportfilter.cxx M sw/source/filter/ww8/wrtw8nds.cxx M sw/source/filter/ww8/wrtw8num.cxx M sw/source/filter/ww8/wrtww8.hxx M sw/source/filter/ww8/wrtww8gr.cxx 5 files changed, 114 insertions(+), 127 deletions(-) diff --git a/sw/source/filter/ww8/docxexportfilter.cxx b/sw/source/filter/ww8/docxexportfilter.cxx index 8149b36..2226ed3 100644 --- a/sw/source/filter/ww8/docxexportfilter.cxx +++ b/sw/source/filter/ww8/docxexportfilter.cxx @@ -86,10 +86,8 @@ return true; } -// -// UNO stuff so that the filter is registered -// +// UNO stuff so that the filter is registered #define IMPL_NAME com.sun.star.comp.Writer.DocxExport OUString DocxExport_getImplementationName() diff --git a/sw/source/filter/ww8/wrtw8nds.cxx b/sw/source/filter/ww8/wrtw8nds.cxx index 9881fff..3112569 100644 --- a/sw/source/filter/ww8/wrtw8nds.cxx +++ b/sw/source/filter/ww8/wrtw8nds.cxx @@ -315,13 +315,13 @@ for( i = 0; i pTxtAttrs-Count(); i++ ) { const SwTxtAttr* pHt = (*pTxtAttrs)[i]; -nPos = *pHt-GetStart();// gibt erstes Attr-Zeichen +nPos = *pHt-GetStart();// give first Attr characters if( nPos = nStartPos nPos = nMinPos ) nMinPos = nPos; -if( pHt-GetEnd() ) // Attr mit Ende +if( pHt-GetEnd() ) // Attr to end { -nPos = *pHt-GetEnd(); // gibt letztes Attr-Zeichen + 1 +nPos = *pHt-GetEnd(); // give last Attr character + 1 if( nPos = nStartPos nPos = nMinPos ) nMinPos = nPos; } @@ -482,7 +482,7 @@ m_rExport.ExportPoolItemsToCHP( aExportItems, GetScript() ); -// HasTextItem nur in dem obigen Bereich erlaubt +// HasTextItem only allowed in the above range m_rExport.m_aCurrentCharPropStarts.pop(); m_rExport.pOutFmtNode = pOldMod; } @@ -580,12 +580,11 @@ return false; } -// HasItem ist fuer die Zusammenfassung des Doppel-Attributes Underline -// und WordLineMode als TextItems. OutAttr() ruft die Ausgabefunktion, -// die dann ueber HasItem() nach anderen Items an der -// Attribut-Anfangposition fragen kann. -// Es koennen nur Attribute mit Ende abgefragt werden. -// Es wird mit bDeep gesucht +//HasItem is for the summary of the double attributes: Underline and WordlineMode as TextItems. +// OutAttr () calls the output function, which can then can call HasItem () for other items at the +// beginning of the selected position. +// It can only be retrieved by the end attributes. +// It searches with bDeep const SfxPoolItem* SwWW8AttrIter::HasTextItem( sal_uInt16 nWhich ) const { const SfxPoolItem* pRet = 0; @@ -599,15 +598,15 @@ const SwTxtAttr* pHt = (*pTxtAttrs)[i]; const SfxPoolItem* pItem = pHt-GetAttr(); const xub_StrLen* pAtrEnd = 0; -if( 0 != ( pAtrEnd = pHt-GetEnd() ) // nur Attr mit Ende -nWhich == pItem-Which() // +if( 0 != ( pAtrEnd = pHt-GetEnd() ) // only Attr with an end +nWhich == pItem-Which() nTmpSwPos = *pHt-GetStart() nTmpSwPos *pAtrEnd ) { -pRet = pItem; // gefunden +pRet = pItem; // found it break; } else if (nTmpSwPos *pHt-GetStart()) -break; // dann kommt da nichts mehr +break; // nothing more to come } } return pRet; @@ -856,7 +855,7 @@ sal_uLong nDataStt = m_rWW8Export.pDataStrm-Tell(); m_rWW8Export.pChpPlc-AppendFkpEntry( m_rWW8Export.Strm().Tell() ); -// WinWord 2000 doesn't write this - so its a temp solution by W97 ? +// WinWord 2000 doesn't write this - so its a temp solution by W97 ? m_rWW8Export.WriteChar( 0x01 ); static sal_uInt8 aArr1[] = { @@ -974,7 +973,6 @@ // an write some data to the data stream, but dont ask // what the data mean, except for the URL. // The First piece is the WW8_PIC structure. -// static sal_uInt8 MAGIC_B[] = { 0xE0,0xC9,0xEA,0x79,0xF9,0xBA,0xCE,0x11, 0x8C,0x82,0x00,0xAA,0x00,0x4B,0xA9,0x0B @@ -1177,7 +1175,7 @@
[PATCH] Translate german comments in sw/source/filter/ww8/wrtww8.cxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2589 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/2589/1 Translate german comments in sw/source/filter/ww8/wrtww8.cxx Please, only apply this patch if you are a native speaking German. I'm not a native speaker, so a double check is really necessary and appreciated. Thanks in advance. Change-Id: I4df75b92ea7a66552df36f56de1c87d567d5b643 --- M sw/source/filter/ww8/wrtww8.cxx 1 file changed, 106 insertions(+), 116 deletions(-) diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx index f19c11b..f661fc8 100644 --- a/sw/source/filter/ww8/wrtww8.cxx +++ b/sw/source/filter/ww8/wrtww8.cxx @@ -78,7 +78,7 @@ #include svtools/imapobj.hxx #include tools/urlobj.hxx #include mdiexp.hxx // Progress -#include statstr.hrc // ResId fuer Statusleiste +#include statstr.hrc // ResId for the status list #include fmtline.hxx #include fmtfsize.hxx #include comphelper/extract.hxx @@ -117,15 +117,15 @@ */ class WW8_WrFkp { -sal_uInt8* pFkp; // gesamter Fkp ( zuerst nur FCs und Sprms ) -sal_uInt8* pOfs; // Pointer auf Offset-Bereich, spaeter nach pFkp kopiert +sal_uInt8* pFkp; // Fkp total ( first and only FCs and Sprms ) +sal_uInt8* pOfs; // pointer to the offset area, later copied by pFkp ePLCFT ePlc; short nStartGrp;// ab hier grpprls short nOldStartGrp; sal_uInt8 nItemSize; -sal_uInt8 nIMax; // Anzahl der Eintrags-Paare +sal_uInt8 nIMax; // number of entry pairs sal_uInt8 nOldVarLen; -bool bCombined; // true : Einfuegen verboten +bool bCombined; // true : paste not allowed sal_uInt8 SearchSameSprm( sal_uInt16 nVarLen, const sal_uInt8* pSprms ); public: @@ -155,15 +155,12 @@ }; -// - -// class WW8_WrPc sammelt alle Piece-Eintraege fuer ein Piece -// - - +// class WW8_WrPc collects all entry pieces for one piece class WW8_WrPc { -WW8_CP nStartCp;// Start ZeichenPosition vom Text -WW8_FC nStartFc;// Start File Position vom Text -sal_uInt16 nStatus; // Absatzende im Piece ? +WW8_CP nStartCp;// Starting character position of the text +WW8_FC nStartFc;// Starting position of the text file +sal_uInt16 nStatus; // End of the piece ? public: WW8_WrPc(WW8_FC nSFc, WW8_CP nSCp ) @@ -213,7 +210,7 @@ #define ANZ_DEFAULT_STYLES 16 -// die Namen der StorageStreams +// Names of the storage stream #define sMainStream rtl::OUString(WordDocument) #define sCompObj rtl::OUString(\1CompObj) @@ -221,19 +218,19 @@ { WW8Dop rDop = *rWrt.pDop; -// i#78951#, store the value of unknown compatability options +// i#78951#, store the value of unknown compatability options rDop.SetCompatabilityOptions( rWrt.pDoc-Getn32DummyCompatabilityOptions1()); rDop.SetCompatabilityOptions2( rWrt.pDoc-Getn32DummyCompatabilityOptions2()); rDop.fNoLeading = !rWrt.pDoc-get(IDocumentSettingAccess::ADD_EXT_LEADING); rDop.fUsePrinterMetrics = !rWrt.pDoc-get(IDocumentSettingAccess::USE_VIRTUAL_DEVICE); -// default TabStop schreiben +// write default TabStop const SvxTabStopItem rTabStop = DefaultItemGetSvxTabStopItem(*rWrt.pDoc, RES_PARATR_TABSTOP); rDop.dxaTab = (sal_uInt16)rTabStop[0].GetTabPos(); -// Zoom factor. +// Zoom factor ViewShell *pViewShell(rWrt.pDoc-GetCurrentViewShell()); if (pViewShell pViewShell-GetViewOptions()-GetZoomType() == SVX_ZOOM_PERCENT) rDop.wScaleSaved = pViewShell-GetViewOptions()-GetZoom(); @@ -276,9 +273,12 @@ rDop.fProtEnabled = 0; } -if (!xDocProps.is()) { +if (!xDocProps.is()) +{ rDop.dttmCreated = rDop.dttmRevised = rDop.dttmLastPrint = 0x45FBAC69; -} else { +} +else +{ ::util::DateTime uDT = xDocProps-getCreationDate(); Date aD(uDT.Day, uDT.Month, uDT.Year); Time aT(uDT.Hours, uDT.Minutes, uDT.Seconds, uDT.HundredthSeconds); @@ -291,14 +291,12 @@ Date aD3(uDT.Day, uDT.Month, uDT.Year); Time aT3(uDT.Hours, uDT.Minutes, uDT.Seconds, uDT.HundredthSeconds); rDop.dttmLastPrint = sw::ms::DateTime2DTTM(DateTime(aD3,aT3)); - } -// auch damit werden die DocStat-Felder in Kopf-/Fusszeilen nicht korrekt -// berechnet. -// ( we do not have this fields! ) +// Also, the DocStat fields in headers, footers are not calculated correctly. +// ( we do not have this fields! ) -// und noch fuer die Header und Footers +// and also for the Headers and Footers rDop.cWordsFtnEnd = rDStat.nWord;
[PATCH] Translate german comments in wrtw8sty.cxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2575 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2575/1 Translate german comments in wrtw8sty.cxx Please, only apply this patch if you are native speaking German. I'm not a native speaker, so a double check is really necessary and appreciated. Thanks in advance. Change-Id: Iee7603c3fb8d78b951b967bd5942df4b1e9634f6 --- M sw/source/filter/ww8/wrtw8sty.cxx 1 file changed, 75 insertions(+), 77 deletions(-) diff --git a/sw/source/filter/ww8/wrtw8sty.cxx b/sw/source/filter/ww8/wrtw8sty.cxx index 4c9e80f..a5a8efd 100644 --- a/sw/source/filter/ww8/wrtw8sty.cxx +++ b/sw/source/filter/ww8/wrtw8sty.cxx @@ -94,12 +94,12 @@ // cbSED is 12 (decimal)), C (hex). }; -// class WW8_WrPlc0 ist erstmal nur fuer Header / Footer-Positionen, d.h. es -// gibt keine inhaltstragende Struktur. +// class WW8_WrPlc0 is only used for header and footer positioning +// ie there is no content support structure class WW8_WrPlc0 { private: -std::vectorsal_uLong aPos; // PTRARR von CPs / FCs +std::vectorsal_uLong aPos; // PTRARR of CPs / FCs sal_uLong nOfs; //No copying @@ -118,16 +118,16 @@ #define WW8_RESERVED_SLOTS 15 -// GetId( SwCharFmt ) zur Benutzung im Text - nil verboten, -// Default Char Style stattdessen +// GetId( SwCharFmt ) for use in text - zero is not allowed, +// use Default Char Style instead sal_uInt16 MSWordExportBase::GetId( const SwCharFmt rFmt ) const { sal_uInt16 nRet = pStyles-GetSlot( rFmt ); return ( nRet != 0x0fff ) ? nRet : 10; // Default Char Style } -// GetId( SwTxtFmtColl ) zur Benutzung an TextNodes - nil verboten, -// Standard stattdessen +// GetId( SwTxtFmtColl ) for use in TextNodes - zero is not allowed, +// Standard instead sal_uInt16 MSWordExportBase::GetId( const SwTxtFmtColl rColl ) const { sal_uInt16 nRet = pStyles-GetSlot( rColl ); @@ -152,7 +152,7 @@ sal_uInt16 nAlloc = WW8_RESERVED_SLOTS + m_rExport.pDoc-GetCharFmts()-size() - 1 + m_rExport.pDoc-GetTxtFmtColls()-size() - 1; -// etwas grosszuegig ( bis zu 15 frei ) +// somewhat generous ( free for up to 15 ) pFmtA = new SwFmt*[ nAlloc ]; memset( pFmtA, 0, nAlloc * sizeof( SwFmt* ) ); @@ -164,14 +164,14 @@ delete[] pFmtA; } -// Sty_SetWWSlot() fuer Abhaengigkeiten der Styles - nil ist erlaubt +// Sty_SetWWSlot() dependencies for the styles - zero is allowed sal_uInt16 MSWordStyles::GetSlot( const SwFmt rFmt ) const { sal_uInt16 n; for ( n = 0; n nUsedSlots; n++ ) if ( pFmtA[n] == rFmt ) return n; -return 0xfff; // 0xfff: WW: nil +return 0xfff; // 0xfff: WW: zero } sal_uInt16 MSWordStyles::BuildGetSlot( const SwFmt rFmt ) @@ -275,7 +275,7 @@ { nUsedSlots = WW8_RESERVED_SLOTS;// soviele sind reserviert fuer // Standard und HeadingX u.a. -const SwCharFmts rArr = *m_rExport.pDoc-GetCharFmts(); // erst CharFmt +const SwCharFmts rArr = *m_rExport.pDoc-GetCharFmts(); // first CharFmt // das Default-ZeichenStyle ( 0 ) wird nicht mit ausgegeben ! for( sal_uInt16 n = 1; n rArr.size(); n++ ) { @@ -283,7 +283,7 @@ pFmtA[ BuildGetSlot( *pFmt ) ] = pFmt; } -const SwTxtFmtColls rArr2 = *m_rExport.pDoc-GetTxtFmtColls(); // dann TxtFmtColls +const SwTxtFmtColls rArr2 = *m_rExport.pDoc-GetTxtFmtColls(); // then TxtFmtColls // das Default-TextStyle ( 0 ) wird nicht mit ausgegeben ! for( sal_uInt16 n = 1; n rArr2.size(); n++ ) { @@ -296,20 +296,20 @@ static void impl_SkipOdd( ww::bytes* pO, sal_Size nTableStrmTell ) { if ( ( nTableStrmTell + pO-size() ) 1 ) // Start auf gerader -pO-push_back( (sal_uInt8)0 ); // Adresse +pO-push_back( (sal_uInt8)0 ); // Adress } void WW8AttributeOutput::EndStyle() { impl_SkipOdd( m_rWW8Export.pO, m_rWW8Export.pTableStrm-Tell() ); -short nLen = m_rWW8Export.pO-size() - 2;// Laenge des Styles +short nLen = m_rWW8Export.pO-size() - 2;// lenght of the styles sal_uInt8* p = m_rWW8Export.pO-front() + nPOPosStdLen1; ShortToSVBT16( nLen, p ); // nachtragen p = m_rWW8Export.pO-front() + nPOPosStdLen2; ShortToSVBT16( nLen, p ); // dito -m_rWW8Export.pTableStrm-Write( m_rWW8Export.pO-data(), m_rWW8Export.pO-size() ); // ins File damit +m_rWW8Export.pTableStrm-Write( m_rWW8Export.pO-data(), m_rWW8Export.pO-size() ); // write it into the file m_rWW8Export.pO-clear(); } @@ -346,7 +346,7 @@ sal_uInt16 nLen = static_cast sal_uInt16 ( ( pData - aWW8_STD ) + 1 + -((m_rWW8Export.bWrtWW8 ? 2 : 1 ) * (rName.Len() + 1)) ); // vorlaeufig +
Re: [PATCH] Translate German comments, various clean up
Hi Philipp, On Sun, 2013-03-03 at 22:51 +0100, Philipp Weissenbacher wrote: I submit this patch via the mailing list as I've had not luck with gerrit tonight. I did a clean clone from and now gerrit won add change-ids to my commit any more. Odd; the change-ids are added by a local git hook I think; you need to do: ./g -z to cleanup your local git :-) Anyways, see the enclosed patch. Thanks ! this time I think you were a victim of some severe global search/replace issues - checkout the s/und/and/ - which turned found into foand (as an example ;-) though there were a number of other issues that created if you'll read you'll see. Anyhow - I cleaned that up and pushed it. Thanks for the translation ! All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments, various clean up
Hi Michael, On 4 March 2013 12:19, Michael Meeks michael.me...@suse.com wrote: Hi Philipp, On Sun, 2013-03-03 at 22:51 +0100, Philipp Weissenbacher wrote: I submit this patch via the mailing list as I've had not luck with gerrit tonight. I did a clean clone from and now gerrit won add change-ids to my commit any more. Odd; the change-ids are added by a local git hook I think; you need to do: ./g -z to cleanup your local git :-) That fixed it, thanks. I'll add that to the wiki so that others have a way to go if they run into the same problem. Anyways, see the enclosed patch. Thanks ! this time I think you were a victim of some severe global search/replace issues - checkout the s/und/and/ - which turned found into foand (as an example ;-) though there were a number of other issues that created if you'll read you'll see. Anyhow - I cleaned that up and pushed it. Oh, that's too bad. I'll make sure that doesn't happen again. Regards, Philipp Thanks for the translation ! All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments, clean up some whitespace
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2539 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/2539/1 Translate German comments, clean up some whitespace Change-Id: I98c1ffcb404d63ea84ac68eb0087701976414ba3 --- M sc/source/core/data/dociter.cxx 1 file changed, 88 insertions(+), 91 deletions(-) diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx index 36c8092..a17df1f 100644 --- a/sc/source/core/data/dociter.cxx +++ b/sc/source/core/data/dociter.cxx @@ -81,7 +81,7 @@ bool ScDocumentIterator::GetThisCol() { -ScTable*pTab = NULL; +ScTable* pTab = NULL; while ( nTab pDoc-GetTableCount() (pTab = pDoc-maTabs[nTab]) == NULL ) { if ( nTab == nEndTab ) @@ -271,9 +271,8 @@ nRow = nStartRow; nTab = nStartTab; -nColRow = 0;// wird bei GetFirst initialisiert - -nNumFormat = 0; // werden bei GetNumberFormat initialisiert +nColRow = 0; // Initialized in GetFirst +nNumFormat = 0; // Initialized in GetNumberFormat pAttrArray = 0; nAttrEndRow = 0; } @@ -299,9 +298,8 @@ nTab++; if ( nTab nEndTab ) { -// rValue = 0.0;//! do not change caller's value! rErr = 0; -return false; // Ende und Aus +return false; // Over and out } } pCol = (pDoc-maTabs[nTab])-aCol[nCol]; @@ -333,10 +331,10 @@ nAttrEndRow, pCol-pAttrArray, nRow, pDoc ); rValue = pDoc-RoundValueAsShown( rValue, nNumFormat ); } -// -// wenn in der selben Spalte gleich noch eine Value-Cell folgt, die -// auch noch im Block liegt, den Wert jetzt schon holen -// +/* + * If there's another Value Cell in the same column, + * which is also within the Area, we retrieve it's value now already + */ if ( nColRow pCol-maItems.size() pCol-maItems[nColRow].nRow = nEndRow pCol-maItems[nColRow].pCell-GetCellType() == CELLTYPE_VALUE @@ -353,9 +351,9 @@ } } -return true;// gefunden +return true; // Found it! } -//break; + case CELLTYPE_FORMULA: { if (!bSubTotal || !((ScFormulaCell*)pCell)-IsSubTotal()) @@ -366,7 +364,7 @@ rValue = ((ScFormulaCell*)pCell)-GetValue(); nRow--; bNumValid = false; -return true;// gefunden +return true; // Found it! } else if ( bTextAsZero ) { @@ -378,6 +376,7 @@ } } break; + case CELLTYPE_STRING : case CELLTYPE_EDIT : { @@ -401,7 +400,7 @@ } } else -nRow = nEndRow + 1; // naechste Spalte +nRow = nEndRow + 1; // Next column } } @@ -415,7 +414,7 @@ { const ScBaseCell* pCell; SCSIZE nIdx = nColRow - 1; -// there might be rearranged something, so be on the safe side +// Something might have rearranged; be on the safe side if ( nIdx pCol-maItems.size() pCol-maItems[nIdx].nRow == nRow ) pCell = pCol-maItems[nIdx].pCell; else @@ -449,7 +448,7 @@ ScColumn* pCol = (pDoc-maTabs[nTab])-aCol[nCol]; pCol-Search( nRow, nColRow ); -nNumFormat = 0; // werden bei GetNumberFormat initialisiert +nNumFormat = 0; // Initialized in GetNumberFormat pAttrArray = 0; nAttrEndRow = 0; @@ -520,7 +519,7 @@ nRow = mpParam-nRow1; nTab = mpParam-nTab; -nColRow = 0;// wird bei GetFirst initialisiert +nColRow = 0; // Initialized in GetFirst SCSIZE i; SCSIZE nCount = mpParam-GetEntryCount(); for (i=0; (inCount) (mpParam-GetEntry(i).bDoQuery); i++) @@ -534,7 +533,7 @@ rItem.maString, nIndex, rItem.mfVal); rItem.meType = bNumber ? ScQueryEntry::ByValue : ScQueryEntry::ByString; } -nNumFormat = 0; //
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2540 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2540/1 Translate German comments Change-Id: I3c4b8fa5b80bdd4a38dc9ea15ad805e9430a6e68 --- M tools/source/ref/pstm.cxx M tools/unx/source/dll/toolsdll.cxx 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/tools/source/ref/pstm.cxx b/tools/source/ref/pstm.cxx index 60f8c86..ee5870c 100644 --- a/tools/source/ref/pstm.cxx +++ b/tools/source/ref/pstm.cxx @@ -370,11 +370,11 @@ sal_uInt32 nPos = Tell(); #endif sal_uInt32 n0 = 0; -*this n0; // wegen Sun sp +*this n0; // Because of Sun sp // Don't assert on stream error DBG_ASSERT( GetError() != SVSTREAM_OK || (sizeof( sal_uInt32 ) == Tell() -nPos), -keine 4-Byte fuer Langenangabe ); +No 4 byte as length parameter ); return Tell(); } @@ -563,7 +563,7 @@ sal_uInt32 nId = 0; sal_uInt16 nClassId; -rpObj = NULL; // specification: 0 in case of error +rpObj = NULL; // specification: 0 in case of error ReadId( *this, nHdr, nId, nClassId ); // get version nummer through masking @@ -699,7 +699,7 @@ rThis.SetStream( rStm ); sal_uInt8 nVers; -rThis nVers;// Version +rThis nVers; // Version if( 0 == nVers ) { sal_uInt32 nCount = 0; diff --git a/tools/unx/source/dll/toolsdll.cxx b/tools/unx/source/dll/toolsdll.cxx index 9766bf4..414c7d2 100644 --- a/tools/unx/source/dll/toolsdll.cxx +++ b/tools/unx/source/dll/toolsdll.cxx @@ -21,13 +21,9 @@ static void* aAppData[SHL_COUNT]; -/*** -|* -|*GetAppData() -|* -|*Beschreibung Daten fuer andere Libs abfragen -|* -***/ +/* + * Query data for other libraries + */ void** GetAppData( sal_uInt16 nSharedLib ) { -- To view, visit https://gerrit.libreoffice.org/2540 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c4b8fa5b80bdd4a38dc9ea15ad805e9430a6e68 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments to English in svmain.cxx
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2529 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2529/1 Translate German comments to English in svmain.cxx Change-Id: I4f27a839c6403c08983f0366402c852b0710029c --- M vcl/source/app/svmain.cxx 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx index c89a04e..32d627b 100644 --- a/vcl/source/app/svmain.cxx +++ b/vcl/source/app/svmain.cxx @@ -261,13 +261,13 @@ ImplSVData* pSVData = ImplGetSVData(); -// SV bei den Tools anmelden +// register with tools InitTools(); -// Main-Thread-Id merken +// set Main-Thread-Id to the current thread pSVData-mnMainThreadId = ::osl::Thread::getCurrentIdentifier(); -// Sal initialisieren +// Initialize the Sal RTL_LOGFILE_CONTEXT_TRACE( aLog, { ::CreateSalInstance ); pSVData-mpDefInst = CreateSalInstance(); if ( !pSVData-mpDefInst ) @@ -564,7 +564,7 @@ delete pSVData-mpSalTimer; pSVData-mpSalTimer = NULL; -// Sal deinitialisieren +// Deinit the Sal DestroySalInstance( pSVData-mpDefInst ); DeInitTools(); -- To view, visit https://gerrit.libreoffice.org/2529 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4f27a839c6403c08983f0366402c852b0710029c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments, various clean up
Hi all, I submit this patch via the mailing list as I've had not luck with gerrit tonight. I did a clean clone from and now gerrit won add change-ids to my commit any more. I tired downloading commit-msg and do 'git --amend' but that wasn't successful. Anyways, see the enclosed patch. Philipp 0001-Translate-German-comments-various-clean-up.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] translate German comments, remove obsolete code
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2049 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2049/1 translate German comments, remove obsolete code Change-Id: I4d6e3149f94234e2b884ab81e752805d07a63712 --- M sw/source/core/view/viewimp.cxx 1 file changed, 115 insertions(+), 97 deletions(-) diff --git a/sw/source/core/view/viewimp.cxx b/sw/source/core/view/viewimp.cxx index 6b114a2..8ae0086 100644 --- a/sw/source/core/view/viewimp.cxx +++ b/sw/source/core/view/viewimp.cxx @@ -43,18 +43,20 @@ #include IDocumentDeviceAccess.hxx #include IDocumentSettingAccess.hxx -/* -|* -|* SwViewImp::Init() -|* -|* Ersterstellung MA 25. Jul. 94 -|* Letzte AenderungMA 03. Nov. 95 -|* -|*/ +/** + + SwViewImp::Init() + + Created MA 25. Jul. 94 + Last change MA 03. Nov. 95 + + @author MA + +*/ void SwViewImp::Init( const SwViewOption *pNewOpt ) { OSL_ENSURE( pDrawView, SwViewImp::Init without DrawView ); -//Jetzt die PageView erzeugen wenn sie noch nicht existiert. +//Create PageView if it doesn't exist SwRootFrm *pRoot = pSh-GetLayout();//swmod 071108//swmod 071225 if ( !pSdrPageView ) { @@ -95,14 +97,16 @@ pDrawView-SetMarkHdlSizePixel(9); } -/* -|* -|* SwViewImp::SwViewImp() CTor fuer die Core-Internas -|* -|* Ersterstellung MA 25. Jul. 94 -|* Letzte AenderungMA 06. Sep. 96 -|* -|*/ +/** + + SwViewImp::SwViewImp() CTor for the core internals + + Created MA 25. Jul. 94 + Last change MA 06. Sep. 96 + + @author MA + +*/ SwViewImp::SwViewImp( ViewShell *pParent ) : pSh( pParent ), @@ -118,21 +122,21 @@ // OD 12.12.2002 #103492# mpPgPrevwLayout( 0 ) { -//bResetXorVisibility = -//HMHbShowHdlPaint = bResetHdlHiddenPaint = bSmoothUpdate = bStopSmooth = bStopPrt = sal_False; bFirstPageInvalid = sal_True; } -/** -|* -|* SwViewImp::~SwViewImp() -|* -|* Ersterstellung MA 25. Jul. 94 -|* Letzte AenderungMA 16. Dec. 94 -|* -**/ +/** + + SwViewImp::~SwViewImp() + + Created MA 25. Jul. 94 + Last change MA 16. Dec. 94 + + @author MA + +*/ SwViewImp::~SwViewImp() { @@ -141,7 +145,7 @@ // OD 12.12.2002 #103492# delete mpPgPrevwLayout; -//JP 29.03.96: nach ShowSdrPage muss auch HideSdrPage gemacht werden!!! +//JP 29.03.96: after ShowSdrPage HideSdrPage must also be executed!!! if( pDrawView ) pDrawView-HideSdrPage(); @@ -153,28 +157,32 @@ OSL_ENSURE( !pIdleAct,Be idle for the rest of your life. ); } -/** -|* -|* SwViewImp::DelRegions() -|* -|* Ersterstellung MA 14. Apr. 94 -|* Letzte AenderungMA 14. Apr. 94 -|* -**/ +/** + + SwViewImp::DelRegions() + + Created MA 14. Apr. 94 + Last change MA 14. Apr. 94 + + @author MA + +*/ void SwViewImp::DelRegion() { DELETEZ(pRegion); } -/** -|* -|* SwViewImp::AddPaintRect() -|* -|* Ersterstellung MA ?? -|* Letzte AenderungMA 27. Jul. 94 -|* -**/ +/** + + SwViewImp::AddPaintRect() + + Created MA ?? + Last change MA 27. Jul. 94 + + @author MA + +*/ sal_Bool SwViewImp::AddPaintRect( const SwRect rRect ) { @@ -188,14 +196,16 @@ return sal_False; } -/** -|* -|* ViewImp::CheckWaitCrsr() -|* -|* Ersterstellung MA 10. Aug. 94 -|* Letzte AenderungMA 10. Aug. 94 -|* -**/ +/** + + ViewImp::CheckWaitCrsr() + + Created MA 10. Aug. 94 + Last change MA 10. Aug. 94 + + @author MA + +*/ void SwViewImp::CheckWaitCrsr() { @@ -203,14 +213,16 @@ pLayAct-CheckWaitCrsr(); } -/** -|* -|* ViewImp::IsCalcLayoutProgress() -|* -|* Ersterstellung MA 12. Aug. 94 -|* Letzte AenderungMA 12. Aug. 94 -|* -**/ +/** + + ViewImp::IsCalcLayoutProgress() + + Created MA 12. Aug. 94 + Last change MA 12. Aug. 94 + + @author MA + +*/ sal_Bool SwViewImp::IsCalcLayoutProgress() const { @@ -219,14
[PATCH] translate German comments, remove obsolete code
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2054 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/2054/1 translate German comments, remove obsolete code Change-Id: Icfb1e2985f746d7a451037e2d411ebbfeed26a54 --- M sw/source/core/view/viewsh.cxx 1 file changed, 96 insertions(+), 118 deletions(-) diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 8d8d333..bec7c75 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -199,7 +199,7 @@ } bInEndAction = sal_True; -//Laeuft hiermit das EndAction der Letzten Shell im Ring? +//will this put the EndAction of the last shell in the sequence? ViewShell::bLstAct = sal_True; ViewShell *pSh = (ViewShell*)this-GetNext(); @@ -238,9 +238,8 @@ if ( bIsShellForCheckViewLayout ) GetLayout()-CheckViewLayout( GetViewOptions(), aVisArea ); -//Wenn wir selbst keine Paints erzeugen, so warten wir auf das Paint -//vom System. Dann ist das Clipping korrekt gesetzt; Beispiel: verschieben -//eines DrawObjektes. +//If we don't call Paints, we wait for the Paint of the system. +//Then the clipping is set correctly; e.g. shifting of a Draw object if ( Imp()-GetRegion() || aInvalidRect.HasArea() || bExtraData ) @@ -263,12 +262,11 @@ SwRegionRects *pRegion = Imp()-GetRegion(); -//JP 27.11.97: wer die Selection hided, muss sie aber auch -// wieder Showen. Sonst gibt es Paintfehler! -// z.B.: addional Mode, Seite vertikal hab zu sehen, in der -// Mitte eine Selektion und mit einem anderen Cursor an linken -// rechten Rand springen. Ohne ShowCrsr verschwindet die -// Selektion +//JP 27.11.97: what hid the selection, must also Show it, +// else we get Paint errors! +// e.g. additional mode, page half visible vertically, in the +// middle a selection and with an other cursor jump to left +// right border. Without ShowCrsr the selection disappears. bool bShowCrsr = pRegion IsA( TYPE(SwCrsrShell) ); if( bShowCrsr ) ((SwCrsrShell*)this)-HideCrsrs(); @@ -279,7 +277,7 @@ Imp()-pRegion = NULL; -//Erst Invert dann Compress, niemals andersherum! +//First Invert then Compress, never the other way round! pRegion-Invert(); pRegion-Compress(); @@ -293,7 +291,7 @@ bool bPaint = true; if ( IsEndActionByVirDev() ) { -//virtuelles device erzeugen und einstellen. +//create virtual device and set. if ( !pVout ) pVout = new VirtualDevice( *GetOut() ); MapMode aMapMode( GetOut()-GetMapMode() ); @@ -423,10 +421,10 @@ Imp()-EndAction(); -//Damit sich die automatischen Scrollbars auch richtig anordnen k?nnen -//muessen wir die Aktion hier kuenstlich beenden (EndAction loesst ein -//Notify aus, und das muss Start-/EndAction rufen um die Scrollbars -//klarzubekommen. +//We artificially end the action here to enable the automatic scrollbars +//to adjust themselves correctly +//EndAction sends a Notify, and that must call Start-/EndAction to +//adjust the scrollbars correctly --nStartAction; UISizeNotify(); ++nStartAction; @@ -446,7 +444,7 @@ void ViewShell::ImplLockPaint() { if ( GetWin() GetWin()-IsVisible() ) -GetWin()-EnablePaint( sal_False ); //Auch die Controls abklemmen. +GetWin()-EnablePaint( sal_False ); //Also cut off the controls. Imp()-LockPaint(); } @@ -458,7 +456,7 @@ { if ( (bInSizeNotify || bVirDev ) VisArea().HasArea() ) { -//Refresh mit virtuellem Device um das Flackern zu verhindern. +//Refresh with virtual device to avoid flickering. VirtualDevice *pVout = new VirtualDevice( *pOut ); pVout-SetMapMode( pOut-GetMapMode() ); Size aSize( VisArea().SSize() ); @@ -568,7 +566,7 @@ #if OSL_DEBUG_LEVEL 0 else { -//MA: 04. Nov. 94, braucht doch keiner oder?? +//MA: 04. Nov. 94, no one needs this, does one? OSL_ENSURE( !this, MakeVisible fuer Drucker wird doch gebraucht? ); } @@ -601,8 +599,8 @@ sal_uInt16 ViewShell::GetNumPages() { -//Es kann sein, das noch kein Layout existiert weil die Methode vom -//Root-Ctor gerufen wird. +//It is possible that no layout exists when the method from +//root-Ctor is called. return GetLayout() ? GetLayout()-GetPageNum() : 0; } @@ -666,14 +664,14 @@ void
[PATCH] Translate German comments, fix some ws
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1817 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1817/1 Translate German comments, fix some ws Change-Id: I962077a8c7d533c7eaf6d5ba68ec18966e5760a1 --- M sc/source/core/data/cell.cxx M sc/source/core/data/cell2.cxx 2 files changed, 56 insertions(+), 75 deletions(-) diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx index ce073e2..e734d88 100644 --- a/sc/source/core/data/cell.cxx +++ b/sc/source/core/data/cell.cxx @@ -1143,25 +1143,18 @@ pDocument-AddSubTotalCell(this); } -// irgendwie koennen unter os/2 mit rotter FPU-Exception /0 ohne Err503 gespeichert -// werden, woraufhin spaeter im NumberFormatter die BLC Lib bei einem fabs(-NAN) abstuerzt -//(#32739#) hier fuer alle Systeme ausbuegeln, damit da auch Err503 steht - -// somehow we can under os / 2 store without Err503 with rotter FPU / 0, followed later -// in the BLC Lib NumberFormatter a fabs (NAN) is crashing (# 32739 #) iron out here for all -// the systems, so there is also Err503 - +// On OS/2 with broken FPU exception, we can somehow store /0 without Err503. Later on in +// the BLC Lib NumberFormatter crashes when doing a fabs (NAN) (# 32739 #). +// We iron this out here for all systems, such that we also have an Err503 here. if ( aResult.IsValue() !::rtl::math::isFinite( aResult.GetDouble() ) ) { -OSL_FAIL(Formelzelle INFINITY !!! Woher kommt das Dokument?); +OSL_FAIL(Formula cell INFINITY!!! Where does this document come from?); aResult.SetResultError( errIllegalFPOperation ); bDirty = true; } -// DoubleRefs bei binaeren Operatoren waren vor v5.0 immer Matrix, -// jetzt nur noch wenn in Matrixformel, sonst implizite Schnittmenge -// Double Refs in binary operators were always in front of Matrix v5.0, now only when in an -// array formula, otherwise an implicit intersection +// DoubleRefs for binary operators were always a Matrix before version v5.0. +// Now this is only the case when when in an array formula, otherwise it's an implicit intersection if ( pDocument-GetSrcVersion() SC_MATRIX_DOUBLEREF GetMatrixFlag() == MM_NONE pCode-HasMatrixDoubleRefOps() ) { @@ -1169,9 +1162,8 @@ SetMatColsRows( 1, 1); } -// Must the cells be calculated? After Load cells can contain an error code, and then start -// the listener and ggbf. Recalculate if not RECALCMODE_NORMAL - +// Do the cells need to be calculated? After Load cells can contain an error code, and then start +// the listener and Recalculate (if needed) if not RECALCMODE_NORMAL if( !bNewCompiled || !pCode-GetCodeError() ) { StartListeningTo( pDocument ); @@ -1179,16 +1171,11 @@ bDirty = true; } if ( pCode-IsRecalcModeAlways() ) -{ // zufall(), heute(), jetzt() bleiben immer im FormulaTree, damit sie -// auch bei jedem F9 berechnet werden. - -// accident(), today(), now() always stay in the FormulaTree, so that they -// can also be calculated for each F9. +{ // random(), today(), now() always stay in the FormulaTree, so that they are calculated +// for each F9 bDirty = true; } -// Noch kein SetDirty weil noch nicht alle Listener bekannt, erst in -// SetDirtyAfterLoad. -// Still no SetDirty because all Listeners are not know, first in SetDirtyAfterLoad. +// No SetDirty yet, as no all Listeners are known yet (only in SetDirtyAfterLoad) } @@ -1204,12 +1191,8 @@ return; // no double/triple processing //! HACK: -// Wenn der Aufruf aus einem Reschedule im DdeLink-Update kommt, dirty stehenlassen -// Besser: Dde-Link Update ohne Reschedule oder ganz asynchron !!! - -// If the call comes from a Reschedule in the DdeLink-Update, dirty let stand -// Better: Dde-Link Update without Reschdule or completely asynchronously !!! - +// If the call originates from a Reschedule in DdeLink update, leave dirty +// Better: Do a Dde Link Update without Reschedule or do it completely asynchronously! if ( pDocument-IsInDdeLinkUpdate() ) return; @@ -1551,7 +1534,7 @@ p-GetStringResult() == aResult.GetString())) { // A convergence in the first iteration doesn't necessarily -// mean that it's done, it may be because not all related cells +// mean that it's done, it may be as not all related cells // of a circle changed their values yet. If the set really // converges it will do so also during the next iteration. This // fixes situations like of #i44115#. If this wasn't wanted an @@ -1592,7 +1575,6 @@ { // #i102616# Compare
[PATCH] Translate German comments, cleanup whitespace
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1568 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1568/1 Translate German comments, cleanup whitespace Change-Id: I4cea9568c5f24340c6bdac387efe8e94f8edb95a --- M sw/source/ui/dochdl/swdtflvr.cxx M sw/source/ui/docvw/edtdd.cxx M sw/source/ui/docvw/edtwin.cxx M sw/source/ui/inc/pview.hxx M sw/source/ui/inc/uitool.hxx M sw/source/ui/ribbar/conform.cxx M sw/source/ui/ribbar/conrect.cxx 7 files changed, 129 insertions(+), 192 deletions(-) diff --git a/sw/source/ui/dochdl/swdtflvr.cxx b/sw/source/ui/dochdl/swdtflvr.cxx index 28bd60c..9dd3f36 100644 --- a/sw/source/ui/dochdl/swdtflvr.cxx +++ b/sw/source/ui/dochdl/swdtflvr.cxx @@ -583,7 +583,7 @@ { case SWTRANSFER_OBJECTTYPE_DRAWMODEL: { -// dont change the sequence of commands +// don't change the sequence of commands SdrModel *pModel = (SdrModel*)pObject; xStream-SetBufferSize( 16348 ); @@ -822,7 +822,7 @@ SwDoc *const pTmpDoc = lcl_GetDoc(*pClpDocFac); -pTmpDoc-LockExpFlds(); // nie die Felder updaten - Text so belassen +pTmpDoc-LockExpFlds(); // Never update fields - leave text as is lclOverWriteDoc(*pWrtShell, *pTmpDoc); { @@ -843,7 +843,7 @@ pMarkAccess-deleteMark(*ppMark); } -// a new one was created in CORE (OLE-Objekte copied!) +// a new one was created in CORE (OLE objects copied!) aDocShellRef = pTmpDoc-GetTmpDocShell(); if( aDocShellRef.Is() ) SwTransferable::InitOle( aDocShellRef, *pTmpDoc ); @@ -2407,7 +2407,7 @@ sFileURL, aEmptyStr ); if( pFlt !rSh.GetView().GetDocShell()-ISA(SwWebDocShell) ) { -// and then pull up the insert-region-dialog by PostUser event +// and then pull up the insert-region-dialog by PostUser event SwSectionData * pSect = new SwSectionData( FILE_LINK_SECTION, rSh.GetDoc()-GetUniqueSectionName() ); @@ -3053,7 +3053,7 @@ { // first, ask for the SelectionType, then action-bracketing // (otherwise it's not pasted into a TableSelection!!!) -OSL_ENSURE( !rShell.ActionPend(), Paste darf nie eine Actionklammerung haben ); +OSL_ENSURE( !rShell.ActionPend(), Paste must never have an ActionPend ); if ( !pClpDocFac ) return sal_False; // the return value of the SwFEShell::Paste also is sal_Bool! @@ -3092,7 +3092,7 @@ // in the buffer, word in this context means 'something with spaces at beginning // and end'. In this case we definitely want these spaces to be inserted here. bInWrd = rShell.IsInWrd(); - bEndWrd = rShell.IsEndWrd(); +bEndWrd = rShell.IsEndWrd(); bSmart = bInWrd || bEndWrd; if( bSmart ) { diff --git a/sw/source/ui/docvw/edtdd.cxx b/sw/source/ui/docvw/edtdd.cxx index 0cdafc1..c75ec9b 100644 --- a/sw/source/ui/docvw/edtdd.cxx +++ b/sw/source/ui/docvw/edtdd.cxx @@ -77,7 +77,7 @@ if( rSh.GetDrawView()-Command( aDragEvent, this ) ) { rView.GetViewFrame()-GetBindings().InvalidateAll(sal_False); -return; // Event von der SdrView ausgewertet +return; // Event evaluated by SdrView } } @@ -218,13 +218,13 @@ } -// There's a special treatment for file lists with a single -// element, that depends on the actual content of the -// Transferable to be accessible. Since the transferable -// may only be accessed after the drop has been accepted -// (according to KA due to Java DD), we'll have to -// reevaluate the drop action once more _with_ the -// Transferable. +// There's a special treatment for file lists with a single +// element, that depends on the actual content of the +// Transferable to be accessible. Since the transferable +// may only be accessed after the drop has been accepted +// (according to KA due to Java DD), we'll have to +// reevaluate the drop action once more _with_ the +// Transferable. sal_uInt16 nEventAction; sal_Int8 nUserOpt = rEvt.mbDefault ? EXCHG_IN_ACTION_DEFAULT : rEvt.mnAction; @@ -415,8 +415,8 @@ } else if( rEvt.mbDefault ) { -// internal DragDrop: within same Doc a Move -// otherwise a Copy - Task 54974 +// internal DragDrop: within same Doc a Move +// otherwise a Copy - Task 54974
[PATCH] Translate German comments and improve some Germish
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/955 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/955/1 Translate German comments and improve some Germish Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 --- M svtools/inc/svtools/treelist.hxx M svtools/inc/svtools/treelistbox.hxx 2 files changed, 104 insertions(+), 115 deletions(-) -- To view, visit https://gerrit.libreoffice.org/955 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/954 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/954/1 Translate German comments Change-Id: I8cf27a705332c6e7ea62474c78d59911406d378e --- M sw/source/core/docnode/node2lay.cxx 1 file changed, 51 insertions(+), 48 deletions(-) -- To view, visit https://gerrit.libreoffice.org/954 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8cf27a705332c6e7ea62474c78d59911406d378e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/916 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/916/1 Translate German comments Change-Id: I14d8ba8869fde028d81ccd4ce694856bba8b9984 --- M sw/inc/index.hxx M sw/inc/ndtxt.hxx M sw/inc/node.hxx M sw/inc/tblenum.hxx 4 files changed, 5 insertions(+), 7 deletions(-) -- To view, visit https://gerrit.libreoffice.org/916 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14d8ba8869fde028d81ccd4ce694856bba8b9984 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/917 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/917/1 Translate German comments Change-Id: I54db750b79f77ee964c31febe466f082b9d1 --- M sw/source/core/docnode/ndtbl.cxx 1 file changed, 333 insertions(+), 341 deletions(-) -- To view, visit https://gerrit.libreoffice.org/917 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54db750b79f77ee964c31febe466f082b9d1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/899 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/899/1 Translate German comments Change-Id: I91e6fe51e6fb15cda90a6fab029d19c12cb3d251 --- M sw/source/core/docnode/ndsect.cxx 1 file changed, 88 insertions(+), 115 deletions(-) -- To view, visit https://gerrit.libreoffice.org/899 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91e6fe51e6fb15cda90a6fab029d19c12cb3d251 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/902 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/902/1 Translate German comments Change-Id: I5a5e9d99ee474432c70808ae0e5bca847c67fcbe --- M sw/source/core/docnode/section.cxx 1 file changed, 91 insertions(+), 107 deletions(-) -- To view, visit https://gerrit.libreoffice.org/902 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a5e9d99ee474432c70808ae0e5bca847c67fcbe Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/879 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/879/1 Translate German comments Change-Id: I19850b38bd3cefeb759e152c3af22daf2829ffe7 --- M sw/source/core/docnode/node.cxx 1 file changed, 123 insertions(+), 173 deletions(-) -- To view, visit https://gerrit.libreoffice.org/879 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I19850b38bd3cefeb759e152c3af22daf2829ffe7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments to English
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/880 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/880/1 Translate German comments to English Change-Id: If9483ca830c7902094c0e0d5a15755931ae87c46 --- M sw/source/core/docnode/swbaslnk.cxx 1 file changed, 32 insertions(+), 35 deletions(-) -- To view, visit https://gerrit.libreoffice.org/880 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9483ca830c7902094c0e0d5a15755931ae87c46 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in sw/source/core/docnode/ndnotxt....
From Bertrand Lorentz bertrand.lore...@gmail.com: Bertrand Lorentz has uploaded a new change for review. Change subject: Translate German comments in sw/source/core/docnode/ndnotxt.cxx .. Translate German comments in sw/source/core/docnode/ndnotxt.cxx Change-Id: Ibc948a9f1770945e5d9d37891570f0836ef3e231 --- M sw/source/core/docnode/ndnotxt.cxx 1 file changed, 6 insertions(+), 15 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/407/1 -- To view, visit https://gerrit.libreoffice.org/407 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc948a9f1770945e5d9d37891570f0836ef3e231 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Bertrand Lorentz bertrand.lore...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in sw/source/core/crsr/
From Bertrand Lorentz bertrand.lore...@gmail.com: Bertrand Lorentz has uploaded a new change for review. Change subject: Translate German comments in sw/source/core/crsr/ .. Translate German comments in sw/source/core/crsr/ Change-Id: Ib31c6c11162053a447112d76ed4580236fde92e8 --- M sw/source/core/crsr/crsrsh.cxx M sw/source/core/crsr/findattr.cxx 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/364/1 -- To view, visit https://gerrit.libreoffice.org/364 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib31c6c11162053a447112d76ed4580236fde92e8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Bertrand Lorentz bertrand.lore...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in sw/source/core/docnode/ndcopy.c...
From Bertrand Lorentz bertrand.lore...@gmail.com: Bertrand Lorentz has uploaded a new change for review. Change subject: Translate German comments in sw/source/core/docnode/ndcopy.cxx .. Translate German comments in sw/source/core/docnode/ndcopy.cxx Change-Id: I6de2586d54d3e0938e2e9701885a043c76f686ae --- M sw/source/core/docnode/ndcopy.cxx 1 file changed, 94 insertions(+), 88 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/365/1 -- To view, visit https://gerrit.libreoffice.org/365 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6de2586d54d3e0938e2e9701885a043c76f686ae Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Bertrand Lorentz bertrand.lore...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] translate german comments vcl/inc
Hi, herewith patch to take out all German comments of vcl/inc hope this helps -- Luc Castermans mailto:luc.casterm...@gmail.com 0001-translate-German-comments.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translate german comments vcl/inc
Hi Luc, On Sun, Jul 01, 2012 at 09:44:40AM +0200, Luc Castermans luc.casterm...@gmail.com wrote: herewith patch to take out all German comments of vcl/inc Thanks a lot, sounds like Philipp Riemer already pushed this. ;-) Keep up the good work! Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] [PATCH] translate german comments vcl/source
2012/7/1 Luc Castermans luc.casterm...@gmail.com: herewith another patch with comment translations Thank you very much! Pushed to master after additional cleanup. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate german comments
Am 2012-05-01 12:13, schrieb Michael Meeks: Hi Martin, On Thu, 2011-05-19 at 19:21 +0200, Martin Kepplinger wrote: Translate german code comments in writer/sw/source/ui/lingu to english! This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. Thanks for all your great work here :-) I'm just reviewing the commit that we have assignments for, and the process of correlating all your work on the mailing list vs. the eventual commits is a bit large. What would really help there is if you could send a blanket license statement for all your (50+) commits, that we can link into: http://wiki.documentfoundation.org/Development/Developers Something like: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license Thanks ! Michael. No problem. Indeed all of my past and future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. thanks martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments in frmcrsr.cxx
Pushed now. If s.o. still feels like taking a look.http://cgit.freedesktop.org/libreoffice/core/commit/?id=85adb267ac551f5f9ee8aaaef5fa9711fefb782d Philipp On 28 March 2012 14:37, Philipp Weissenbacher p.weissenbac...@gmail.comwrote: Hi all, Kindly asking for a review of my translation of frmcrsr.cxx. Thanks in advance and cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments in frmcrsr.cxx
On Mon, 2012-04-02 at 21:08 +0200, Philipp Weissenbacher wrote: Pushed now. If s.o. still feels like taking a look. :-) it looked lovely to me. Things like: -// 8626: kein SwTxtCursor::SetRightMargin( sal_False ); -// statt dessen steht ein SwSetToRightMargin im _UnitUp +// 8626: No SwTxtCursor::SetRightMargin( sal_False ); +// Instead we have a SwSetToRightMargin in _UnitUp Made me wonder: -what- is that number ? is this some bug-tracker / number from before the dawn of time ? If so, I suspect we could drop that, otherwise ... looks like a big improvement :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments in frmcrsr.cxx
Here you go: 25db817c873bb7f2548d7f8d7fdc65194d306755 That really makes it a bit cleaner, will do that right away in the future. Philipp On 2 April 2012 21:24, Michael Meeks michael.me...@suse.com wrote: On Mon, 2012-04-02 at 21:08 +0200, Philipp Weissenbacher wrote: Pushed now. If s.o. still feels like taking a look. :-) it looked lovely to me. Things like: -// 8626: kein SwTxtCursor::SetRightMargin( sal_False ); -// statt dessen steht ein SwSetToRightMargin im _UnitUp +// 8626: No SwTxtCursor::SetRightMargin( sal_False ); +// Instead we have a SwSetToRightMargin in _UnitUp Made me wonder: -what- is that number ? is this some bug-tracker / number from before the dawn of time ? If so, I suspect we could drop that, otherwise ... looks like a big improvement :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in frmcrsr.cxx
Hi all, Kindly asking for a review of my translation of frmcrsr.cxx. Thanks in advance and cheers, Philipp 0001-Translate-German-comments-fix-some-English-ones.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments in core/connectivity
Ow, what a shame. Seems I've already done all of this. (see e.g. b5995754http://cgit.freedesktop.org/libreoffice/core/commit/connectivity/source/inc/odbc/OFunctiondefs.hxx?id=b5995754836c864bb38446060e17772c63253e37 ). Maybe you can apply for an account too so that getting your changes gets easier for you? Philipp 2012/3/10 Tom Thorogood t...@tomthorogood.com Translate German comments in core/connectivity patch attached. -Tom Thorogood ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in core/connectivity
Translate German comments in core/connectivity patch attached. -Tom Thorogood From ae999e6851ae2969335211737bbce428a2097dcd Mon Sep 17 00:00:00 2001 From: Tom Thorogood t...@tomthorogood.com Date: Fri, 9 Mar 2012 22:35:32 -0500 Subject: [PATCH] Translate german comments in core/connectivity --- .../source/drivers/mozab/MPreparedStatement.hxx|1 - .../source/inc/odbc/ODatabaseMetaDataResultSet.hxx |1 - connectivity/source/inc/odbc/OFunctiondefs.hxx | 23 --- .../source/inc/odbc/OPreparedStatement.hxx |1 - connectivity/source/inc/odbc/OResultSet.hxx|1 - .../source/inc/odbc/OResultSetMetaData.hxx |1 - connectivity/source/inc/odbc/OStatement.hxx|1 - connectivity/source/parse/sqliterator.cxx |4 +- 8 files changed, 12 insertions(+), 21 deletions(-) diff --git a/connectivity/source/drivers/mozab/MPreparedStatement.hxx b/connectivity/source/drivers/mozab/MPreparedStatement.hxx index 31cfa97..ce2344f 100644 --- a/connectivity/source/drivers/mozab/MPreparedStatement.hxx +++ b/connectivity/source/drivers/mozab/MPreparedStatement.hxx @@ -109,7 +109,6 @@ namespace connectivity public: DECLARE_SERVICE_INFO(); -// ein Konstruktor, der fuer das Returnen des Objektes benoetigt wird: OPreparedStatement( OConnection* _pConnection,const ::rtl::OUString sql); void lateInit(); diff --git a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx index 7a17249..ee2af9e 100644 --- a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx +++ b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx @@ -128,7 +128,6 @@ namespace connectivity template typename T, SQLSMALLINT sqlTypeId T getInteger ( sal_Int32 columnIndex ); public: -// ein Konstruktor, der fuer das Returnen des Objektes benoetigt wird: ODatabaseMetaDataResultSet(OConnection* _pConnection); diff --git a/connectivity/source/inc/odbc/OFunctiondefs.hxx b/connectivity/source/inc/odbc/OFunctiondefs.hxx index a53f072..e356b64 100644 --- a/connectivity/source/inc/odbc/OFunctiondefs.hxx +++ b/connectivity/source/inc/odbc/OFunctiondefs.hxx @@ -64,17 +64,16 @@ #ifdef OS2__00 #ifdef ODBCIMP - -// Stub-Version: dynamische Bindung an die DLL zur Laufzeit. -// odbcstub definiert die in den Quellen benutzten NSQL...-Methoden -// als indirekte Funktionsaufrufe. -// odbcimp zieht sich selbst preos2, odbc und postos2 an. +// Stub version: dynamic bindings of DLLs at runtime. +// odbcstup defines them in the NSQL[...] methods as +// indirect function calls. +// odbcimp is extended by preo2, odbc, and postos2. // #include odbc3imp.hxx #else -// Zur Zeit verwenden wir die ODBC-DLL von Watcom-SQL direkt (ueber die -// mitgelieferte Lib). +// Currently we use the ODBC dll from Watcom-SQL directly +// (from the supplied lib) #ifndef ODBC_OS2 #define ODBC_OS2 @@ -101,8 +100,8 @@ #endif -// In der ODBC.H von Watcom werden Strings als char * erwartet -// (nicht, wie sonst bei ODBC ueblich, als UCHAR *). +// ODBC.H from Watcom will expect strings as 'char *' +// (not the case elsewhere in ODBC, where it's 'UCHAR *') #if defined( ICC ) #define SDB_ODBC_CHAR unsigned char #else @@ -115,8 +114,7 @@ #ifdef UNX -// Zur Zeit verwenden wir die ODBC-shared library von Q+E direkt (ueber die -// mitgelieferte Lib). +// Currently we use the supplied ODBC shared library from QE directly. #ifndef ODBC_UNX #define ODBC_UNX @@ -128,8 +126,7 @@ #else #include odbc/sqlext.h #endif -#undef sal_Bool // Ist in qeodbc.h definiert, wird aber von solar.h noch einmal -// definiert. +#undef sal_Bool // Defined in qeodbc.h, and is also defined in solar.h #define SDB_ODBC_CHAR UCHAR #define SQL_WCHAR (-8) diff --git a/connectivity/source/inc/odbc/OPreparedStatement.hxx b/connectivity/source/inc/odbc/OPreparedStatement.hxx index 076c9e05..bd05ea2 100644 --- a/connectivity/source/inc/odbc/OPreparedStatement.hxx +++ b/connectivity/source/inc/odbc/OPreparedStatement.hxx @@ -109,7 +109,6 @@ namespace connectivity throw (::com::sun::star::uno::Exception); public: DECLARE_SERVICE_INFO(); -// ein Konstruktor, der fuer das Returnen des Objektes benoetigt wird: OPreparedStatement( OConnection* _pConnection,const ::rtl::OUString sql); //XInterface diff --git a/connectivity/source/inc/odbc/OResultSet.hxx b/connectivity/source/inc/odbc/OResultSet.hxx index e0362251..a128f7d 100644 --- a/connectivity/source/inc/odbc/OResultSet.hxx +++ b/connectivity/source/inc/odbc/OResultSet.hxx @@ -200,7 +200,6 @@ namespace connectivity ) const; public: DECLARE_SERVICE_INFO(); -// ein
[PATCH] translate german comments
Hi :) Attached is one more German-English comment translation patch. Review much appreciated. Kind regards nicolas From a67c8fb99d0006664b1583bc11258a147ce90f0b Mon Sep 17 00:00:00 2001 From: Nicolas Christener nicolas.christe...@adfinis-sygroup.ch Date: Thu, 8 Mar 2012 20:37:40 +0100 Subject: [PATCH] translate german comments --- sw/source/core/layout/tabfrm.cxx | 322 ++ 1 files changed, 153 insertions(+), 169 deletions(-) diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx index 95eceb8..40c949f 100644 --- a/sw/source/core/layout/tabfrm.cxx +++ b/sw/source/core/layout/tabfrm.cxx @@ -96,10 +96,10 @@ SwTabFrm::SwTabFrm( SwTable rTab, SwFrm* pSib ): // #i26945# bConsiderObjsForMinCellHeight = sal_True; bObjsDoesFit = sal_True; -bFixSize = sal_False; //Nicht nochmal auf die Importfilter hereinfallen. +bFixSize = sal_False; //Don't fall for import filter again. nType = FRMC_TAB; -//Gleich die Zeilen erzeugen und einfuegen. +//Create the lines and insert them. const SwTableLines rLines = rTab.GetTabLines(); SwFrm *pTmpPrev = 0; for ( sal_uInt16 i = 0; i rLines.Count(); ++i ) @@ -127,7 +127,7 @@ SwTabFrm::SwTabFrm( SwTabFrm rTab ) : // #i26945# bConsiderObjsForMinCellHeight = sal_True; bObjsDoesFit = sal_True; -bFixSize = sal_False; //Nicht nochmal auf die Importfilter hereinfallen. +bFixSize = sal_False; //Don't fall for import filter again. nType = FRMC_TAB; SetFollow( rTab.GetFollow() ); @@ -180,7 +180,7 @@ void SwTabFrm::JoinAndDelFollows() |*/ void SwTabFrm::RegistFlys() { -OSL_ENSURE( Lower() Lower()-IsRowFrm(), Keine Zeilen. ); +OSL_ENSURE( Lower() Lower()-IsRowFrm(), No rows. ); SwPageFrm *pPage = FindPageFrm(); if ( pPage ) @@ -432,7 +432,7 @@ void lcl_MoveRowContent( SwRowFrm rSourceLine, SwRowFrm rDestLine ) while ( pTmpDestRow-GetNext() ) pTmpDestRow = (SwRowFrm*)pTmpDestRow-GetNext(); -OSL_ENSURE( pTmpDestRow-GetFollowRow() == pTmpSourceRow, Knoten in der Tabelle ); +OSL_ENSURE( pTmpDestRow-GetFollowRow() == pTmpSourceRow, Table contains node ); lcl_MoveRowContent( *pTmpSourceRow, *pTmpDestRow ); pTmpDestRow-SetFollowRow( pTmpSourceRow-GetFollowRow() ); @@ -996,9 +996,9 @@ bool SwTabFrm::Split( const SwTwips nCutPos, bool bTryToSplit, bool bTableRowKee lcl_InnerCalcLayout( this-Lower(), LONG_MAX, true ); } -//Um die Positionen der Zellen mit der CutPos zu vergleichen muessen sie -//ausgehend von der Tabelle nacheinander berechnet werden. Sie koennen -//wg. Positionsaenderungen der Tabelle durchaus ungueltig sein. +//In order to be able to compare the positions of the cells whit CutPos, +//they have to be calculated consecutively starting from the table. +//They can definitely be invalid because of position changes of the table. SwRowFrm *pRow = static_castSwRowFrm*(Lower()); if( !pRow ) return bRet; @@ -1268,9 +1268,9 @@ bool SwTabFrm::Split( const SwTwips nCutPos, bool bTryToSplit, bool bTableRowKee SwTwips nRet = 0; -//Optimierung beim neuen Follow braucht's kein Paste und dann kann -//das Optimierte Insert verwendet werden (nur dann treten gluecklicher weise -//auch groessere Mengen von Rows auf). +//Optimization: There is no paste needed for the new Follow and the +//optimized insert can be used (big amounts of rows luckily only occurs in +//such situations). if ( bNewFollow ) { SwFrm* pNxt = 0; @@ -1344,15 +1344,15 @@ bool SwTabFrm::Join() if ( !pFoll-IsJoinLocked() ) { SWRECTFN( this ) -pFoll-Cut(); //Erst ausschneiden um unuetze Benachrichtigungen zu -//minimieren. +pFoll-Cut(); //Cut out first to avoid unnecessary notifications. SwFrm *pRow = pFoll-GetFirstNonHeadlineRow(), *pNxt; SwFrm* pPrv = GetLastLower(); -SwTwips nHeight = 0;//Gesamthoehe der eingefuegten Zeilen als Return. +SwTwips nHeight = 0;//Total height of the inserted rows as return value. + while ( pRow ) { pNxt = pRow-GetNext(); @@ -1818,14 +1818,13 @@ void SwTabFrm::MakeAll() PROTOCOL_ENTER( this, PROT_MAKEALL, 0, 0 ) -LockJoin(); //Ich lass mich nicht unterwegs vernichten. -SwLayNotify aNotify( this );//uebernimmt im DTor die Benachrichtigung +LockJoin(); //I don't want to be destroyed on the way. +SwLayNotify aNotify( this );//does the notification in the DTor // If pos is invalid, we have to call a SetInvaKeep at aNotify. // Otherwise the keep atribute would not work in front of a table. const sal_Bool
[PATCH] Translate German comments in core/cppuhelper
From 806ed0c8a1352735f75f9c3067cf4a7cc4e2c55e Mon Sep 17 00:00:00 2001 From: Tom Thorogood t...@tomthorogood.com Date: Sat, 10 Mar 2012 14:13:16 -0500 Subject: [PATCH] Translate German comments in core/cppuhelper --- cppuhelper/source/propshlp.cxx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cppuhelper/source/propshlp.cxx b/cppuhelper/source/propshlp.cxx index a66f185..9c5610f 100644 --- a/cppuhelper/source/propshlp.cxx +++ b/cppuhelper/source/propshlp.cxx @@ -702,7 +702,7 @@ void OPropertySetHelper::fire pLC = aBoundLC.getContainer( pEvts[i].PropertyHandle ); if( pLC ) { -// Ueber alle Listener iterieren und Events senden +// Iterate over all listeners and send events OInterfaceIteratorHelper aIt( *pLC); while( aIt.hasMoreElements() ) { @@ -759,7 +759,7 @@ void OPropertySetHelper::fire } if( pLC ) { -// Ueber alle Listener iterieren und Events senden +// Iterate over all listeners and send events. OInterfaceIteratorHelper aIt( *pLC); while( aIt.hasMoreElements() ) { -- 1.7.4.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Translate German comments in core/cppuhelper
Hi, thanks for this. Pushed. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Translate German comments
Pushed. Looked ok to me - I don't know much of the german language, though. Thank you! On 03/01/2012 10:38 AM, Philipp Weissenbacher wrote: Hi all, I'd like to have a second set of eye-ball on these translations. Thanks, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi all, I'd like to have a second set of eye-ball on these translations. Thanks, Philipp 0001-Translate-German-comments-fix-some-whitespace.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments in connectivity
Hi LO devs! Here are some patches for connectivity/. Cheers, Philipp 0001-Translate-comments-to-German-and-fix-some-whitespace.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Translate German comments
Hi Philipp, looks good. Pushed. Thanks! Happy to not have to translate these comments when run into them :-) Cheers Radek On Wed, 2012-02-15 at 15:36 +0100, Philipp Weissenbacher wrote: Hi all, Lionel, Here are the files you mentioned earlier. Hope quality didn't suffer with this quick job. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. If you still find any German strings, please contact me and I'll help you. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments
On Wed, Feb 15, 2012 a-t 03:36:25PM +0100, Philipp Weissenbacher wrote: Here are the files you mentioned earlier. Thank you very much. Radek beat me to it to commit that, but there seems to be an untranslated word that is left; Geschachtelte in -// MIB 25.6.98: Geschachtelte Formulare abfangen ... oder muesste -// man sie submitten? +// MIB 25.6.98: Catch nested Forms Geschachtelte; or would we need to submit them? Maybe it means nested and should just be removed? I'm not sure. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. Line 2185 *after* your patch? That is: } // if (xDisp.is()) My guess is that this is an explicit end if. It shows what if is being closed there, so that one does not have to count braces / go up to see that. So it is a real comment, not forgotten code. Thanks for the pointer, though. Was worth checking out. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments
On 16 February 2012 13:37, Lionel Elie Mamane lio...@mamane.lu wrote: Thank you very much. Radek beat me to it to commit that, but there seems to be an untranslated word that is left; Geschachtelte in - // MIB 25.6.98: Geschachtelte Formulare abfangen ... oder muesste - // man sie submitten? + // MIB 25.6.98: Catch nested Forms Geschachtelte; or would we need to submit them? Maybe it means nested and should just be removed? I'm not sure. Hmm ... that seems to be a remains of my editing. Just remove Geschachtelte (and yes Geschachtelte means nested). You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. Line 2185 *after* your patch? That is: } // if (xDisp.is()) My guess is that this is an explicit end if. It shows what if is being closed there, so that one does not have to count braces / go up to see that. So it is a real comment, not forgotten code. Thanks for the pointer, though. Was worth checking out. Ah, ok. You're welcome. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
On Wed, Feb 15, 2012 at 01:46:55PM +0100, Philipp Weissenbacher wrote: So, any developer wishes on what to translate next? In general, dbaccess/ and connectivity/ are the two modules of particular interest to me. I get the impression I'll have to dig into forms/ in the next months, just today, I stumbled on forms/source/component/DatabaseForm.cxx and ListBox.cxx extensions/source/propctrlr/formmetadata.cxx has very few comments, but some are in German. (You can CC patches against these modules to me when you send them to the list.) -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
On Wed, 2012-02-15 at 13:46 +0100, Philipp Weissenbacher wrote: Find attached the patch that finalises my efforts to get rid of the German comments in sw/source/core/doc. Wonderful ! :-) Thanks Michael BTW for the mention in your Easy Hacks talk at FOSDEM. Much appreciated! Hey ! not appreciated nearly as much as the good work you're doing - it's awesome. So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. Any chance of that ? Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. Any chance of that ? I put it on my TODO list, but 2700 lines may take a while :). Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com: On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. Any chance of that ? I put it on my TODO list, but 2700 lines may take a while :). Philipp: shall we team up on above ? In my experience good translation requires some understanding of the code, this is sometimes a Catch22 as comment were meant to explain the code -- Luc Castermans mailto:luc.casterm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) kind regards signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) kind regards nicolas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments
Hi all, Lionel, Here are the files you mentioned earlier. Hope quality didn't suffer with this quick job. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. If you still find any German strings, please contact me and I'll help you. Cheers, Philipp 0001-Translate-German-comments.patch Description: Binary data 0002-Translate-German-comments.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) So I think we'll wait for that, right? I'd be happy to review any interim patches for you. @Luc: How about you start in dbaccess/ and I do connectivity/ as suggested by Llionel? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translate German comments - final patch
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com: Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) So I think we'll wait for that, right? I'd be happy to review any interim patches for you. @Luc: How about you start in dbaccess/ and I do connectivity/ as suggested by Llionel? OK, fine for me. Let's align off-list. Regards, -- Luc Castermans mailto:luc.casterm...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments
On 20/01/12 13:50, Philipp Weissenbacher wrote: Hi lo-devs, Some more translations ... thanks, pushed (with some tweaks) notes: - Vorlage can mean either template (if it's a document) or style if it's some content element (the latter are called *FmtColl in writer) - there is no too less, only too few A question about a line of code I found in doctxm.cxx (its at #1954 in the original file): // Insert as sorted for( i = 0; i aNums.size() aNums[i] nPage; ++i ) ; This is an empty loop that does ... nothing, AFAIKT? it increments the variable i, which is apparently used later on. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments and fix some English ones
Hi Philipp, On 2012-01-09 at 14:18 +0100, Philipp Weissenbacher wrote: Here are two more patches. Thank you, pushed! :-) Patch #1 contains a few FIXMEs. That's where my creativity failed me and I just couldn't figure out what the original author meant. Thus, I'd greatly appreciate feedback. In addition to translations patch #2 tries to fix some Denglish. Also, my git foo failed me with merge conflicts and it's weird merge-conflict-syntax. So I did it twice (which improved the translation a bit). But I missed MUSS noch optimiert werden's 14th birthday. :-( ;-) Heh :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments to English and correct the English ones
On 04/01/12 12:57, Philipp Weissenbacher wrote: Hi all, Here's another patch that translates the German comments to English and fixes some errors in the English ones. thanks, pushed (tweaked the translations a bit in a follow-up) In htmltbl.cxx: I interpreted 'tab' in some OSL_ENSUREs as 'table' and replaced 'table in table' with 'nested table' (that seems somewhat clearer to me). why not :) In number.cxx: The code on lines 531/532 seems to be duplicated on lines 535/536. The same is repeated on the next lines. Is that intended? surprisingly that is actually correct, because there are 2 arrays of size MAXLEVEL, i.e. it is an array [2][MAXLEVEL]; see the constructor of the class. but of course writing it in this way is rather ugly, nested loop would be nicer. some misc. translation points: - eventual means something completely different from German eventuell - echt groesser is a mathematical term and the echt is translated as strictly - when it comes to numbering, Gliederung is Outline regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Translate German comments to English and correct the English ones
On 4 January 2012 14:07, Michael Stahl mst...@redhat.com wrote: On 04/01/12 12:57, Philipp Weissenbacher wrote: Hi all, Here's another patch that translates the German comments to English and fixes some errors in the English ones. thanks, pushed (tweaked the translations a bit in a follow-up) In htmltbl.cxx: I interpreted 'tab' in some OSL_ENSUREs as 'table' and replaced 'table in table' with 'nested table' (that seems somewhat clearer to me). why not :) In number.cxx: The code on lines 531/532 seems to be duplicated on lines 535/536. The same is repeated on the next lines. Is that intended? surprisingly that is actually correct, because there are 2 arrays of size MAXLEVEL, i.e. it is an array [2][MAXLEVEL]; see the constructor of the class. but of course writing it in this way is rather ugly, nested loop would be nicer. some misc. translation points: - eventual means something completely different from German eventuell - echt groesser is a mathematical term and the echt is translated as strictly - when it comes to numbering, Gliederung is Outline Thanks a lot for these! This ambiguity of terms is what makes translating somewhat involved (next to monster/broken sentences). Regards, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Hi Michael, On Tue, 2011-12-06 at 17:54 +0100, Michael Stahl wrote: i hereby request protection of the following comment species: //JP 06.01.98: MUSS noch optimiert werden!!! Lol :-) the handful of these comments are of enormous cultural value to Writer developers which would probably be lost in translation ;) We should make a little graveyard for them, and put them all together there I guess ... Regards, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
On 05/12/11 11:10, Michael Meeks wrote: On Sat, 2011-12-03 at 00:08 +0100, Philipp Weissenbacher wrote: But then, what constitutes an old comment? Very often I found that the JP with a date comments were obviously added _after_ the original comment. Really - trying to detect and annotate fragile pieces of code with special comments is not a winning idea I think :-) so just carry on removing junk 'JP 12345' comments without any concern ... i hereby request protection of the following comment species: //JP 06.01.98: MUSS noch optimiert werden!!! the handful of these comments are of enormous cultural value to Writer developers which would probably be lost in translation ;) All the best, Michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Hi, From Björn's message: Hmm, in the future, maybe just adding a [very old comment] to it could be helpful. But no need to retroactively seek though old translations IMHO. Okay, won't do this then for Philipp's translations. Anyway, what constitutes a [very old comment], would that be anything before 2001? From Philipp's message: But then, what constitutes an old comment? Very often I found that the JP with a date comments were obviously added _after_ the original comment. That's interesting. How do you determine that..? By seeing that there is a conversation in the comments (original comment second comment about a change in behaviour)? Or because pointers to bugs are usually added later on when the product is already released? Or by some other means? Maybe a FIXME: Old comment would be a good heads-up? I'm almost sure, not all our old code is bad, so there is probably a need to fix /all/ of it. Also, the comments are literally littered with !ACHTUNG: ! and double question marks. What should we make of that? I'm not a fan of excessive punctuation, so I would just convert this to Attention!/Caution!/Warning!, whatever seems appropriate. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
On Sat, 2011-12-03 at 00:08 +0100, Philipp Weissenbacher wrote: Lol :-) I think Bjoern is just joking - we're well rid of that mess. We'll soon re-discover the fragile bits of code after we change them in future ;- Well I thought so already. Maybe we indeed should add a marker saying exactly that? Nah - we should expunge all superstitious comments as/when people change fragile code create bugs, hopefully they will re-write it, if not - they'll create a bug, and the bug fixer (while getting ill reading it) will hopefully re-write it :-) But then, what constitutes an old comment? Very often I found that the JP with a date comments were obviously added _after_ the original comment. Really - trying to detect and annotate fragile pieces of code with special comments is not a winning idea I think :-) so just carry on removing junk 'JP 12345' comments without any concern ... All the best, Michael -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Hi Björn, O, you removed all the JP: XX.XX.199X markers, which were always a warning to me to step very carefully as it meant there be dragons to me ;) Uhm, okay. Should we, as in: I, add them back in? Or should they be translated as here be dragons (or alternatively: here be JOEs [1])? (If you say yes now, note that it won't happen until Saturday/Sunday, when I have PC access again.) Astron. [1] http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdibrow.cxx#966 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
On Fri, Dec 02, 2011 at 11:15:27AM +0100, Stefan Knorr (Astron) wrote: O, you removed all the JP: XX.XX.199X markers, which were always a warning to me to step very carefully as it meant there be dragons to me ;) Uhm, okay. Should we, as in: I, add them back in? Or should they be translated as here be dragons (or alternatively: here be JOEs [1])? Hmm, in the future, maybe just adding a [very old comment] to it could be helpful. But no need to retroactively seek though old translations IMHO. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Hi Astron, On Fri, 2011-12-02 at 11:15 +0100, Stefan Knorr (Astron) wrote: O, you removed all the JP: XX.XX.199X markers, which were always a warning to me to step very carefully as it meant there be dragons to me ;) Uhm, okay. Should we, as in: I, add them back in? Or should they be translated as here be dragons (or alternatively: here be JOEs Lol :-) I think Bjoern is just joking - we're well rid of that mess. We'll soon re-discover the fragile bits of code after we change them in future ;- All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Hi, On 2 December 2011 13:06, Michael Meeks michael.me...@suse.com wrote: Hi Astron, On Fri, 2011-12-02 at 11:15 +0100, Stefan Knorr (Astron) wrote: O, you removed all the JP: XX.XX.199X markers, which were always a warning to me to step very carefully as it meant there be dragons to me ;) Uhm, okay. Should we, as in: I, add them back in? Or should they be translated as here be dragons (or alternatively: here be JOEs Lol :-) I think Bjoern is just joking - we're well rid of that mess. We'll soon re-discover the fragile bits of code after we change them in future ;- Well I thought so already. Maybe we indeed should add a marker saying exactly that? But then, what constitutes an old comment? Very often I found that the JP with a date comments were obviously added _after_ the original comment. Maybe a FIXME: Old comment would be a good heads-up? Also, the comments are literally littered with !ACHTUNG: ! and double question marks. What should we make of that? Lots of questions :). Cheers and have a fine weekend, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Heads up, everything that is in automation/ or basic/app is about to go away. August Sodora aug...@gmail.com (201) 280-8138 On Thu, Dec 1, 2011 at 3:33 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hello list, Another patch to translate docftn.cxx, docglbl.cxx, docglos.cxx and doclay.cxx. In doclay.cxx I translated 'Umlauf' with 'flow', I hope that's correct. I also tried my best to re-translate some of the close-to-gibberish English comments (knowing German helps a lot with these). Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
Apologies, this was meant to go to Eike's previous email regarding Date/Time constructors. August Sodora aug...@gmail.com (201) 280-8138 On Thu, Dec 1, 2011 at 3:36 PM, August Sodora aug...@gmail.com wrote: Heads up, everything that is in automation/ or basic/app is about to go away. August Sodora aug...@gmail.com (201) 280-8138 On Thu, Dec 1, 2011 at 3:33 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hello list, Another patch to translate docftn.cxx, docglbl.cxx, docglos.cxx and doclay.cxx. In doclay.cxx I translated 'Umlauf' with 'flow', I hope that's correct. I also tried my best to re-translate some of the close-to-gibberish English comments (knowing German helps a lot with these). Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
On Thu, 2011-12-01 at 15:36 -0500, August Sodora wrote: Heads up, everything that is in automation/ or basic/app is about to go away. Ah ! - it would be quite a good idea to make 'bin/find-german-comments' complain vigorously about these special cases (perhaps) to avoid translators spending time on translating dead code ;-) [if you're a python sort of guy]. Thanks :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments and correct some English ones
On Thu, Dec 01, 2011 at 09:33:12PM +0100, Philipp Weissenbacher wrote: In doclay.cxx I translated 'Umlauf' with 'flow', I hope that's correct. I also tried my best to re-translate some of the close-to-gibberish English comments (knowing German helps a lot with these). O, you removed all the JP: XX.XX.199X markers, which were always a warning to me to step very carefully as it meant there be dragons to me ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments
Hi Philipp, More translated comments. I used git format-patch HEAD~2 to generate them. Is that the right way? I'm still a git beginner :). Should be, yes. Somehow I can't get either to apply to master (fails at lines 216 and 53 respectively), could you please ./g pull -r and see what happens? If all goes well, just format-patch again. Is the patch size to email raito ok? Or should include more files per patch/email? I won't be able answer that. I'm still new to pushing :). Finally, linguistic comments: * be careful with brake v/ (line) break * please use US English (recognise recognize), it's a standard (I don't agree with that completely, either, but it will make the code more consistent) Regards, Astron ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments
Sorry for saying they didn't apply. They do. My bad. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments
Okay, pushed with a few modifications. Yay. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments
On Sat, 2011-11-19 at 12:22 +0100, Philipp Weissenbacher wrote: I didn't understand what //al la WW: 1 Inch means WW in these contexts means WinWord, so like Microsoft Word: 1 Inch I would guess is the meaning, and probably isn't German at all, but already in English :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Nov 03, 2011 at 10:46:36PM +0100, Philipp Weissenbacher wrote: On 29 October 2011 01:02, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Sure, I will try to build it. I wasn't sure if translating comments was serious enough a change to do that. I would tend to think that indeed, building LibreOffice just to translate comments is rather onerous a cost; I would like that we do not ask that of people. I've modified the Patch Handling Guidelines with instructions on how to enable the git hooks without building. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Mon, 2011-11-21 at 13:54 +0100, Lionel Elie Mamane wrote: I would tend to think that indeed, building LibreOffice just to translate comments is rather onerous a cost. Agreed, no point in stumbling over that. Having said that - comment translation patches should be -only- comments + whitespace + obvious stuff in this case; no substantive code changes. I would like that we do not ask that of people. I've modified the Patch Handling Guidelines with instructions on how to enable the git hooks without building. Lovely - thanks ! :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translate German comments
Hi all, I've continued translating in sw/source/core/doc (find the patch attached). - I missed one sentence in doccomp.cxx. Fixed that. - docdesc.cxx was a bit tricky: I didn't understand what //al la WW: 1 Inch means, so I left it as is. (al la by itself can mean is like in German, but I wasn't sure if that is meant here). There's an handled else statement In line 712. Someone might want to take a look at it. I wasn't sure how I should translate Ränder and Umrandung, so I used border and border strips. Is that right? Just 37 more files to go! Cheers, Philipp 0001-Translated-German-comments-to-English.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 29 October 2011 01:02, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. At least it explain the cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory but not why the hook for core are not set-up anyway... In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Sure, I will try to build it. I wasn't sure if translating comments was serious enough a change to do that. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH]: Translate German Comments
Philipp Weissenbacher píše v Pá 28. 10. 2011 v 22:23 +0200: Here's docfld.cxx from sw/source/core/doc. This one's quite long, so I'd appreciate a review by another German-speaker. I tried my best, to shorten the translation whilst preserving it's meaning (not that there would be much of it, sometimes). Also, the whitespace problem should be a thing of the past now. Great work! I like the new comments and have pushed them into master. Thanks for contribution. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 03:25, Norbert Thiebaud wrote: On Thu, Oct 27, 2011 at 8:19 PM, Norbert Thiebaudnthieb...@gmail.com wrote: On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. I hit sent a bit fast... One thing I forgot to mention. I did clean-up some trailing spaces... did you have to over-ride the commit hook or did it fail to warn you of the trailing spaces ? I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? Also, can you add yourself to http://wiki.documentfoundation.org/Development/Developers, referencing your post above that indicate the license. Don't be intimidated with the 'Developper' page title. This is to try to keep track of licensing declaration of committed stuff. Done! Thanks, Philipp Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 9:19 AM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? yes that was it. for gedit, google pointed me to: http://www.linuxuk.org/2009/05/trim-trailing-spaces-in-gedit/ https://github.com/jonleighton/gedit-trailsave ... Still I'm a bit concerned that the commit-hook did not complain can you sent the result of ls -l .git/hooks Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 16:33, Norbert Thiebaud wrote: On Fri, Oct 28, 2011 at 9:19 AM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? yes that was it. for gedit, google pointed me to: http://www.linuxuk.org/2009/05/trim-trailing-spaces-in-gedit/ https://github.com/jonleighton/gedit-trailsave ... Thanks, but it doesn't work with gedit 3 for me. I'll switch to vim for now anyway and use the remove whitespace on save autocmd. Still I'm a bit concerned that the commit-hook did not complain can you sent the result of ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 12:09 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample oh... that is not good! can you run ./g -z please, and verify that after that you have, afterward, something like $ ll .git/hooks/ total 112 -rwxr-xr-x 1 n_th staff 452 Aug 6 15:41 applypatch-msg.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 commit-msg - ../../git-hooks/commit-msg -rwxr-xr-x 1 n_th staff 896 Aug 6 15:41 commit-msg.sample -rwxr-xr-x 1 n_th staff 160 Aug 6 15:41 post-commit.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 post-merge - ../../git-hooks/post-merge -rwxr-xr-x 1 n_th staff 552 Aug 6 15:41 post-receive.sample -rwxr-xr-x 1 n_th staff 189 Aug 6 15:41 post-update.sample -rwxr-xr-x 1 n_th staff 398 Aug 6 15:41 pre-applypatch.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 pre-commit - ../../git-hooks/pre-commit -rwxr-xr-x 1 n_th staff 1578 Aug 6 15:41 pre-commit.sample -rwxr-xr-x 1 n_th staff 4951 Aug 6 15:41 pre-rebase.sample -rwxr-xr-x 1 n_th staff 1239 Aug 6 15:41 prepare-commit-msg.sample -rwxr-xr-x 1 n_th staff 3611 Aug 6 15:41 update.sample Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 20:12, Norbert Thiebaud wrote: On Fri, Oct 28, 2011 at 12:09 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample oh... that is not good! can you run ./g -z please, and verify that after that you have, afterward, something like $ ll .git/hooks/ total 112 -rwxr-xr-x 1 n_th staff 452 Aug 6 15:41 applypatch-msg.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 commit-msg - ../../git-hooks/commit-msg -rwxr-xr-x 1 n_th staff 896 Aug 6 15:41 commit-msg.sample -rwxr-xr-x 1 n_th staff 160 Aug 6 15:41 post-commit.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 post-merge - ../../git-hooks/post-merge -rwxr-xr-x 1 n_th staff 552 Aug 6 15:41 post-receive.sample -rwxr-xr-x 1 n_th staff 189 Aug 6 15:41 post-update.sample -rwxr-xr-x 1 n_th staff 398 Aug 6 15:41 pre-applypatch.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 pre-commit - ../../git-hooks/pre-commit -rwxr-xr-x 1 n_th staff 1578 Aug 6 15:41 pre-commit.sample -rwxr-xr-x 1 n_th staff 4951 Aug 6 15:41 pre-rebase.sample -rwxr-xr-x 1 n_th staff 1239 Aug 6 15:41 prepare-commit-msg.sample -rwxr-xr-x 1 n_th staff 3611 Aug 6 15:41 update.sample No, I just get: cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH]: Translate German Comments
Here's docfld.cxx from sw/source/core/doc. This one's quite long, so I'd appreciate a review by another German-speaker. I tried my best, to shorten the translation whilst preserving it's meaning (not that there would be much of it, sometimes). Also, the whitespace problem should be a thing of the past now. Cheers, Philipp From d4fe84c89e781f52cf96712c26f11d79c42d71fe Mon Sep 17 00:00:00 2001 From: Philipp Weissenbacher p.weissenbac...@gmail.com Date: Fri, 28 Oct 2011 22:03:40 +0200 Subject: [PATCH] Translate German comments --- sw/source/core/doc/docfld.cxx | 409 - 1 files changed, 199 insertions(+), 210 deletions(-) diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx index 239238e..3a81493 100644 --- a/sw/source/core/doc/docfld.cxx +++ b/sw/source/core/doc/docfld.cxx @@ -52,7 +52,7 @@ #include fmtfld.hxx #include tox.hxx #include txttxmrk.hxx -#include docfld.hxx // fuer Expression-Felder +#include docfld.hxx // for expression fields #include docufld.hxx #include ddefld.hxx #include usrfld.hxx @@ -69,7 +69,7 @@ #include authfld.hxx #include txtinet.hxx #include fmtcntnt.hxx -#include poolfmt.hrc // fuer InitFldTypes +#include poolfmt.hrc // for InitFldTypes #include SwUndoField.hxx #include switerator.hxx @@ -82,12 +82,11 @@ extern sal_Bool IsFrameBehind( const SwTxtNode rMyNd, sal_uInt16 nMySttPos, SV_IMPL_OP_PTRARR_SORT( _SetGetExpFlds, _SetGetExpFldPtr ) /* -Beschreibung: Feldtypen einfuegen +Description: Insert field types */ /* - * Implementierung der Feldfunktionen am Doc - * Return immer einen gueltigen Pointer auf den Typ. Wenn er also neu - * zugefuegt oder schon vorhanden ist. + * Implementation of field methods at the Doc + * Always returns a pointer to the type, if it's new or already added. */ SwFieldType* SwDoc::InsertFldType(const SwFieldType rFldTyp) { @@ -99,14 +98,13 @@ SwFieldType* SwDoc::InsertFldType(const SwFieldType rFldTyp) switch( nFldWhich ) { case RES_SETEXPFLD: -//JP 29.01.96: SequenceFelder beginnen aber bei INIT_FLDTYPES - 3!! -// Sonst gibt es doppelte Nummernkreise!! -//MIB 14.03.95: Ab sofort verlaesst sich auch der SW3-Reader -//beim Aufbau der String-Pools und beim Einlesen von SetExp-Feldern -//hierauf +//JP 29.01.96: SequenceFields start at INIT_FLDTYPES - 3!! +// Or we get doubble number circles!! +//MIB 14.03.95: From now on also the SW3-Reader relies on this, when +//constructing string pools and when reading SetExp fields if( nsSwGetSetExpType::GSE_SEQ ((SwSetExpFieldType)rFldTyp).GetType() ) i -= INIT_SEQ_FLDTYPES; -// kein break; +// no break; case RES_DBFLD: case RES_USERFLD: case RES_DDEFLD: @@ -149,7 +147,7 @@ SwFieldType* SwDoc::InsertFldType(const SwFieldType rFldTyp) case RES_USERFLD: case RES_SETEXPFLD: ((SwValueFieldType*)pNew)-SetDoc( this ); -// JP 29.07.96: opt. FeldListe fuer den Calculator vorbereiten: +// JP 29.07.96: Optionally prepare FieldList for Calculator: pUpdtFlds-InsertFldType( *pNew ); break; case RES_AUTHORITY : @@ -165,18 +163,17 @@ SwFieldType* SwDoc::InsertFldType(const SwFieldType rFldTyp) void SwDoc::InsDeletedFldType( SwFieldType rFldTyp ) { -// der FeldTyp wurde als geloescht gekennzeichnet und aus dem -// Array entfernt. Nun muss man nach diesem wieder suchen. -// - Ist der nicht vorhanden, dann kann er eingefuegt werden. -// - Wird genau der gleiche Typ gefunden, dann muss der geloeschte -// einen anderen Namen erhalten. +// The FldType was marked as deleted and removed from the array. +// One has to look this up again, now. +// - If it's not present, it can be re-inserted. +// - If the same type is found, the deleted one has to be renamed. sal_uInt16 nSize = pFldTypes-Count(), nFldWhich = rFldTyp.Which(); sal_uInt16 i = INIT_FLDTYPES; OSL_ENSURE( RES_SETEXPFLD == nFldWhich || RES_USERFLD == nFldWhich || -RES_DDEFLD == nFldWhich, Falscher FeldTyp ); +RES_DDEFLD == nFldWhich, Wrong FldType ); const ::utl::TransliterationWrapper rSCmp = GetAppCmpStrIgnore(); const String rFldNm = rFldTyp.GetName(); @@ -186,7 +183,7 @@ void SwDoc::InsDeletedFldType( SwFieldType rFldTyp ) if( nFldWhich == (pFnd = (*pFldTypes)[i])-Which() rSCmp.isEqual( rFldNm, pFnd-GetName() ) ) { -// neuen Namen suchen +// find new name sal_uInt16 nNum = 1; do { String sSrch( rFldNm ); @@ -196,17 +193,17 @@ void SwDoc
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. At least it explain the cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory but not why the hook for core are not set-up anyway... In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH]: Translate German Comments
Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Cheers, Philipp 0001-Translate-German-comments.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Oct 27, 2011 at 8:19 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. I hit sent a bit fast... One thing I forgot to mention. I did clean-up some trailing spaces... did you have to over-ride the commit hook or did it fail to warn you of the trailing spaces ? Also, can you add yourself to http://wiki.documentfoundation.org/Development/Developers, referencing your post above that indicate the license. Don't be intimidated with the 'Developper' page title. This is to try to keep track of licensing declaration of committed stuff. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translate german comments
Translate german code comments in writer/sw/source/ui/lingu to english! This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. --- sw/source/ui/lingu/hhcwrp.cxx | 13 ++--- sw/source/ui/lingu/hyp.cxx|6 +++--- sw/source/ui/lingu/olmenu.cxx |2 +- sw/source/ui/lingu/sdrhhcwrap.cxx |3 +-- 4 files changed, 11 insertions(+), 13 deletions(-) diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index 8739fe3..4e82474 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -36,7 +36,7 @@ #include hintids.hxx #include view.hxx #include wrtsh.hxx -#include swundo.hxx // fuer Undo-Ids +#include swundo.hxx // for Undo-Ids #include globals.hrc #include splargs.hxx @@ -77,7 +77,7 @@ using namespace ::com::sun::star::i18n; #define CHAR_PAR_BRK((sal_Char) 0x0D) // -// Beschreibung: Ggf. Rahmen/Objektshell abschalten +// Description: Turn off frame/object shell if applicable static void lcl_ActivateTextShell( SwWrtShell rWrtSh ) { @@ -418,7 +418,7 @@ void SwHHCWrapper::ReplaceUnit( lcl_ActivateTextShell( rWrtShell ); -// Das aktuelle Wort austauschen +// replace the current word rWrtShell.StartAllAction(); // select current unit @@ -672,14 +672,13 @@ sal_Bool SwHHCWrapper::ConvNext_impl( ) { //! modified version of SvxSpellWrapper::SpellNext -// Keine Richtungsaenderung, also ist der gewuenschte Bereich ( bStartChk ) -// vollstaendig abgearbeitet. +// no change of direction so the desired region is fully processed if( bStartChk ) bStartDone = sal_True; else bEndDone = sal_True; -if( bIsOtherCntnt bStartDone bEndDone ) // Dokument komplett geprueft? +if( bIsOtherCntnt bStartDone bEndDone ) // document completely checked? { bInfoBox = sal_True; return sal_False; @@ -695,7 +694,7 @@ sal_Bool SwHHCWrapper::ConvNext_impl( ) } else if ( bStartDone bEndDone ) { -// Bodybereich erledigt, Frage nach Sonderbereich +// body region done, ask about special region if( bIsConvSpecial HasOtherCnt_impl() ) { ConvStart_impl( pConvArgs, SVX_SPELL_OTHER ); diff --git a/sw/source/ui/lingu/hyp.cxx b/sw/source/ui/lingu/hyp.cxx index ea0d7e1..cc19ed2 100644 --- a/sw/source/ui/lingu/hyp.cxx +++ b/sw/source/ui/lingu/hyp.cxx @@ -56,7 +56,7 @@ using namespace ::com::sun::star; using ::rtl::OUString; /* - Beschreibung: Interaktive Trennung + Description: interactive separation */ SwHyphWrapper::SwHyphWrapper( SwView* pVw, @@ -94,7 +94,7 @@ void SwHyphWrapper::SpellStart( SvxSpellArea eSpell ) sal_Bool SwHyphWrapper::SpellContinue() { -// Fuer autom. Trennung Aktionen erst am Ende sichtbar machen +// for automatic separation, make actions visible only at the end SwWait *pWait = 0; if( bAutomatic ) { @@ -107,7 +107,7 @@ sal_Bool SwHyphWrapper::SpellContinue() PSH-HyphContinue( nPageCount, nPageStart ); SetLast( xHyphWord ); -// Fuer autom. Trennung Aktionen erst am Ende sichtbar machen +// for automatic separation, make actions visible only at the end if( bAutomatic ) { PSH-EndAllAction(); diff --git a/sw/source/ui/lingu/olmenu.cxx b/sw/source/ui/lingu/olmenu.cxx index d64ecf9..069e79b 100644 --- a/sw/source/ui/lingu/olmenu.cxx +++ b/sw/source/ui/lingu/olmenu.cxx @@ -744,7 +744,7 @@ void SwSpellPopup::Execute( sal_uInt16 nId ) of temporary auto correction is now undoable two and must reside in the same undo group.*/ -// nur aufnehmen, wenn es NICHT schon in der Autokorrektur vorhanden ist +// record only if it's NOT already present in autocorrection SvxAutoCorrect* pACorr = SvxAutoCorrCfg::Get()-GetAutoCorrect(); String aOrigWord( bGrammarResults ? OUString() : xSpellAlt-getWord() ) ; diff --git a/sw/source/ui/lingu/sdrhhcwrap.cxx b/sw/source/ui/lingu/sdrhhcwrap.cxx index 52c451d..3e70fcc 100644 --- a/sw/source/ui/lingu/sdrhhcwrap.cxx +++ b/sw/source/ui/lingu/sdrhhcwrap.cxx @@ -87,8 +87,7 @@ SdrHHCWrapper::SdrHHCWrapper( SwView* pVw, pOutlView = new OutlinerView( this, (pView-GetEditWin()) ); pOutlView-GetOutliner()-SetRefDevice(pView-GetWrtShell().getIDocumentDeviceAccess()-getPrinter( false )); -// Hack: Es sollten alle SdrTextObj-Attribute an die EditEngine -// uebertragen werden. +// Hack: all SdrTextObj attributes should be transferred to EditEngine pOutlView-SetBackgroundColor( Color( COL_WHITE ) ); -- 1.7.1 ___ LibreOffice mailing
[Libreoffice] [PATCH] Translate german comments
Translate all remaining german code comments in writer/sw/source/ui/index to english! This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. --- sw/source/ui/index/cntex.cxx |2 +- sw/source/ui/index/cnttab.cxx | 24 ++-- sw/source/ui/index/idxmrk.cxx |2 +- sw/source/ui/index/multmrk.cxx|2 +- sw/source/ui/index/swuiidxmrk.cxx | 75 ++--- sw/source/ui/index/toxmgr.cxx | 24 ++-- 6 files changed, 64 insertions(+), 65 deletions(-) diff --git a/sw/source/ui/index/cntex.cxx b/sw/source/ui/index/cntex.cxx index 21e60a0..a7e7e4d 100644 --- a/sw/source/ui/index/cntex.cxx +++ b/sw/source/ui/index/cntex.cxx @@ -353,7 +353,7 @@ void SwMultiTOXTabDialog::CreateOrUpdateExample( case TOKEN_ENTRY_NO : sTokenType.AssignAscii(RTL_CONSTASCII_STRINGPARAM( TokenEntryNumber)); -// fuer Inhaltsverzeichnis Numerierung +// numbering for content index break; case TOKEN_ENTRY_TEXT : case TOKEN_ENTRY: diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx index 29dc30e..c55e156 100644 --- a/sw/source/ui/index/cnttab.cxx +++ b/sw/source/ui/index/cnttab.cxx @@ -100,8 +100,8 @@ using ::rtl::OUString; using namespace ::sfx2; #include svtools/editbrowsebox.hxx -static const sal_Unicode aDeliStart = '['; //fuer die form -static const sal_Unicode aDeliEnd = ']'; //fuer die form +static const sal_Unicode aDeliStart = '['; // for the form +static const sal_Unicode aDeliEnd = ']'; // for the form #define POS_GRF0 #define POS_OLE1 @@ -3751,13 +3751,13 @@ voidSwTOXStylesTabPage::ActivatePage( const SfxItemSet ) aParaLayLB.Clear(); aLevelLB.Clear(); -// kein Hyperlink fuer Benutzerverzeichnisse +// not hyperlink for user directories sal_uInt16 i, nSize = m_pCurrentForm-GetFormMax(); -// form-Pattern anzeigen ohne Titel +// display form pattern without title -//1. TemplateEntry anzeigen +// display 1st TemplateEntry String aStr( SW_RES( STR_TITLE )); if( m_pCurrentForm-GetTemplate( 0 ).Len() ) { @@ -3791,7 +3791,7 @@ void SwTOXStylesTabPage::ActivatePage( const SfxItemSet ) aLevelLB.InsertEntry( aCpy ); } -// Templates initialisieren +// initialise templates const SwTxtFmtColl *pColl; SwWrtShell rSh = ((SwMultiTOXTabDialog*)GetTabDialog())-GetWrtShell(); const sal_uInt16 nSz = rSh.GetTxtFmtCollCount(); @@ -3800,7 +3800,7 @@ void SwTOXStylesTabPage::ActivatePage( const SfxItemSet ) if( !(pColl = rSh.GetTxtFmtColl( i ))-IsDefault() ) aParaLayLB.InsertEntry( pColl-GetName() ); -// Pool-Collections abfragen und fuer das Verzeichnis setzen +// query pool collections and set them for the directory for( i = 0; i m_pCurrentForm-GetFormMax(); ++i ) { aStr = m_pCurrentForm-GetTemplate( i ); @@ -3841,7 +3841,7 @@ IMPL_LINK( SwTOXStylesTabPage, EditStyleHdl, Button *, pBtn ) return 0; } /* - Beschreibung: Vorlagen zuweisen + Description: allocate templates */ IMPL_LINK( SwTOXStylesTabPage, AssignHdl, Button *, EMPTYARG ) { @@ -3900,7 +3900,7 @@ IMPL_LINK_INLINE_START( SwTOXStylesTabPage, DoubleClickHdl, Button *, EMPTYARG ) IMPL_LINK_INLINE_END( SwTOXStylesTabPage, DoubleClickHdl, Button *, EMPTYARG ) /* - Beschreibung: nur wenn selektiert enable + Description: enable only when selected */ IMPL_LINK( SwTOXStylesTabPage, EnableSelectHdl, ListBox *, EMPTYARG ) { @@ -3966,9 +3966,9 @@ SwEntryBrowseBox::SwEntryBrowseBox(Window* pParent, const ResId rId, xCheckController = new ::svt::CheckBoxCellController(aCellCheckBox); // -// HACK: BrowseBox invalidiert nicht ihre Childs, wie es eigentlich sein sollte. -// Deshalb wird WB_CLIPCHILDREN zurueckgesetzt, wodurch das Invalidieren -// der Childs erzwungen wird. +// HACK: BrowseBox doesn't invalidate its childs, how it should be. +// That's why WB_CLIPCHILDREN is reset in order to enforce the +// childs' invalidation WinBits aStyle = GetStyle(); if( aStyle WB_CLIPCHILDREN ) { diff --git a/sw/source/ui/index/idxmrk.cxx b/sw/source/ui/index/idxmrk.cxx index 66a407d..b756918 100644 --- a/sw/source/ui/index/idxmrk.cxx +++ b/sw/source/ui/index/idxmrk.cxx @@
Re: [Libreoffice] [PUSHED] [PATCH] Translate German comments.
Bookkeeping. -- Thorsten pgpSitna7zHXe.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments.
Hi Christoph, here are the translations of the terms as they are used in the Styles and Formatting window. German: Textkörper Einrückung - English: Text body indent German: Textkörper Einzug negativ - English: Hanging indent German: Textkörper Einzug - English: First line indent German: Grußformel - English: Complimentary close German: Gegenüberstellung - English: List indent Kind regards Regina Christoph Herzog schrieb: Hi, there are still some problems with the translation of comments in the patch attached. Despite my best efforts I was unable to figure out the meaning of several critical comments: RES_POOLCOLL_TEXT_IDENT: Is that text body indent? RES_POOLCOLL_TEXT_MOVE: Is that hanging? I also failed to see what style RES_POOLCOLL_CONFRONTATION would be and whether RES_POOLCOLL_GREETING would be salutation or rather Complimentary Close (there is style with this name). I have marked those with //TODO in the patch so it can be found and corrected easily by someone more competent than me. Thanks for your patience. Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice