Re: How to configure the default connection for virsh

2024-04-18 Thread Nir Soffer
On Thu, Apr 18, 2024 at 5:20 PM Daniel P. Berrangé wrote: > On Thu, Apr 18, 2024 at 05:07:24PM +0300, Nir Soffer wrote: > > We are using minikube vms, which require adding the user to to libvirt > > group[1]. > > We use `virsh -c qemu:///system` for debugging these vms

How to configure the default connection for virsh

2024-04-18 Thread Nir Soffer
We are using minikube vms, which require adding the user to to libvirt group[1]. We use `virsh -c qemu:///system` for debugging these vms or related libvirt networks. Using virsh without specifying the '-c' argument is a common mistake that leads to trouble, for example creating the libvirt

[ovirt-users] Re: virt-v2v paused by system after one hour or a bit more

2024-03-21 Thread Nir Soffer
On Thu, Mar 21, 2024 at 7:03 PM Cyril VINH-TUNG wrote: > Hello > > Here's the technique we use : > - create manually the vm on ovirt with same disks (same size that original > but you can choose target type, thin provision or preallocated) > - on any node, force activating the disks to make them

[ovirt-users] Re: virt-v2v paused by system after one hour or a bit more

2024-03-21 Thread Nir Soffer
On Thu, Mar 21, 2024 at 12:44 PM Claus Serbe via Users wrote: > Hi, > > I am migrating some vmware VM's from an NFS Storage via rhv-upload in > virt-v2v, what is working good. > > But now I try to move some bigger VM's with several disks and sadly after > a while (I would guess around an hour)

[ovirt-users] Re: Create Vm without Storage Domain

2024-03-20 Thread Nir Soffer
On Wed, Mar 20, 2024 at 12:06 PM Shafi Mohammed wrote: > Hi Guys , > > Thanks for the Info . > > I am trying to migrate my data from local to Storage domain . But it > requires twice the effort in terms of space and time to copy the data to > the local file system and then upload the disk to it

Re: Export checkpoint/bitmap from image on qcow2

2024-01-02 Thread Nir Soffer
long backup (e.g full backup, or incremental backup with a lot of data) blocks usage of the vm during the backup. You can start/stop/migrate a vm while it is being backed up and the backup can run on another host in the cluster (if using shared storage). Nir > On 12/18/23 18:44, Nir Soffer

Re: Export checkpoint/bitmap from image on qcow2

2023-12-18 Thread Nir Soffer
On Thu, Nov 30, 2023 at 4:14 PM João Jandre Paraquetti wrote: > > Hi, all > > I recently started looking into how to create incremental backups using > Libvirt+Qemu. I have already found that, since Libvirt 7.6.0, we can use > the virDomainBackupBegin API to create incremental backups of live VMs

[ovirt-devel] Re: Yuriy about NVMe over fabrics for oVirt

2023-11-23 Thread Nir Soffer
On Thu, Nov 2, 2023 at 4:40 PM Yuriy wrote: > Hi Nir! > > This is Yuriy. > We agreed to continue the subject via email. > So the options are: 1. Using Managed Block Storage (cinderlib) with a driver that supports NVMe/TCP. Lastest oVirt has the needed changes to configure this. Benny and I

Re: Is it normal to get bigger qcow2 image after blockcopy?

2023-11-06 Thread Nir Soffer
On Fri, Nov 3, 2023 at 3:25 AM Fangge Jin wrote: > > > On Thu, Nov 2, 2023 at 5:13 PM Fangge Jin wrote: > >> Recently, I found that the disk size of qcow2 image get bigger(from 6.16G >> to 8G in my test) after blockcopy. ❓ ❓ >> > Sorry, it should be "from 6.16G to 6.64G in my test"here > >>

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

2023-10-14 Thread Nir Soffer
the test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

2023-10-14 Thread Nir Soffer
the test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

[ovirt-users] Re: How to obtain vm snapshots status

2023-10-03 Thread Nir Soffer
On Tue, Sep 26, 2023 at 9:07 PM anton.alymov--- via Users wrote: > Hi! I use ovirt rest api to start vm, backup vm and then remove vm. > I start vm, wait for vmstatus up, then start backup, wait for starting, > finalize, wait for succeeded, wait for disk unlock. Looks like backup is > finished

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

2023-08-17 Thread Nir Soffer
On Tue, Aug 15, 2023 at 9:53 PM Eric Blake wrote: > On Mon, Aug 14, 2023 at 01:43:37PM -0500, Eric Blake wrote: > > > > +++ b/golang/configure/test.go > > > > @@ -25,8 +25,19 @@ > > > > import ( > > > > "fmt" > > > > "runtime" > > > > + "unsafe" > > > > ) > > > > > > > >

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

2023-08-13 Thread Nir Soffer
upport, but is relatively old these days. All other > systems appear unaffected by this bump in requirements, at least if > they can be configured to use developer backports. > > Suggested-by: Nir Soffer > Signed-off-by: Eric Blake > --- > > This replaces > https://l

Re: [Libguestfs] [libnbd PATCH v4 05/25] golang: Change logic of copy_uint32_array

2023-08-08 Thread Nir Soffer
ly just panic if the count is oversized: our > state machine guarantees that the server's response fits within 64M > bytes (count will be smaller than that, since it is multiple bytes per > extent entry). Good to check this, but not related to changing the way we copy the array. > S

[ovirt-users] Re: python sdk4 ovirt 4.5.5.0 master

2023-07-19 Thread Nir Soffer
On Mon, Jul 17, 2023 at 6:29 PM Jorge Visentini wrote: > > Hi. > > I am testing oVirt 4.5.5-0.master.20230712143502.git07e865d650.el8. > > I missed the python scripts to download and upload discs and images... Will > it still be possible to use them or should I consider using Ansible? See

Re: [Libguestfs] Libnbd asynchronous API with epoll

2023-07-09 Thread Nir Soffer
On Fri, Jul 7, 2023 at 11:59 AM Tage Johansson wrote: > On 7/6/2023 7:06 PM, Nir Soffer wrote: > > - After calling for example aio_notify_read(3), can I know that the next > reading from the file descriptor would block? > > No, you have to call again aio_get_direction() an

Re: [Libguestfs] Libnbd asynchronous API with epoll

2023-07-06 Thread Nir Soffer
On Wed, Jul 5, 2023 at 3:38 PM Tage Johansson wrote: > As part of the Rust bindings for Libnbd, I try to integrate the > asynchronous (aio_*) functions with Tokio > , the most used asynchronous runtime > in Rust. However, in its eventloop, Tokio uses epoll(7)

[PATCH] libvhost-user: Fix update of signalled_used

2023-05-09 Thread Nir Soffer
off-by: Nir Soffer --- subprojects/libvhost-user/libvhost-user.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 8fb61e2df2..5f26d2d378 100644 --- a/subproje

[Libguestfs] [PATCH libnbd v2] README: Document additional packages

2023-04-17 Thread Nir Soffer
When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer --- Changes sinve v1: - Remove `,` between package namses (Laszlo) README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..7eed0e31 100644

Re: [Libguestfs] [PATCH libnbd] README: Document additional packages

2023-04-17 Thread Nir Soffer
On Mon, Apr 17, 2023 at 7:38 PM Laszlo Ersek wrote: > > On 4/17/23 18:36, Nir Soffer wrote: > > When building from git we need autoconf, automake and libtool. > > > > Signed-off-by: Nir Soffer > > --- > > README.md | 7 +++ > > 1 file changed, 7 in

[Libguestfs] [PATCH libnbd] README: Document additional packages

2023-04-17 Thread Nir Soffer
When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer --- README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..42a187c0 100644 --- a/README.md +++ b/README.md @@ -32,10 +32,17 @@ ## License very liberal

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Nir Soffer
On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-04 Thread Nir Soffer
On Sat, Mar 4, 2023 at 12:15 AM Eric Blake wrote: > > In libnbd, we quickly learned that distinguishing between 'handle' > (verb for acting on an object) and 'handle' (noun describing which > object to act on) could get confusing; we solved it by renaming the > latter to 'cookie'. Copy that

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-04 Thread Nir Soffer
On Sat, Mar 4, 2023 at 12:15 AM Eric Blake wrote: > > In libnbd, we quickly learned that distinguishing between 'handle' > (verb for acting on an object) and 'handle' (noun describing which > object to act on) could get confusing; we solved it by renaming the > latter to 'cookie'. Copy that

Re: [Libguestfs] Checksums and other verification

2023-03-02 Thread Nir Soffer
On Thu, Mar 2, 2023 at 10:46 AM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 07:09:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones > > wrote: > > > I think it would be more useful if (or in addition) it could compute >

Re: [Libguestfs] Checksums and other verification

2023-02-28 Thread Nir Soffer
On Tue, Feb 28, 2023 at 4:13 PM Laszlo Ersek wrote: > > On 2/28/23 12:39, Richard W.M. Jones wrote: > > On Tue, Feb 28, 2023 at 12:24:04PM +0100, Laszlo Ersek wrote: > >> On 2/27/23 17:44, Richard W.M. Jones wrote: > >>> On Mon, Feb 27, 2023 at 08:42:23AM -0600, Eric Blake wrote: > Or

Re: [Libguestfs] Checksums and other verification

2023-02-27 Thread Nir Soffer
On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 04:24:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones > > wrote: > > > > > > > > > https://github.com/kubevirt/containerized-

Re: [Libguestfs] Checksums and other verification

2023-02-27 Thread Nir Soffer
On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones wrote: > > > https://github.com/kubevirt/containerized-data-importer/issues/1520 > > Hi Eric, > > We had a question from the Kubevirt team related to the above issue. > The question is roughly if it's possible to calculate the checksum of > an

Re: [Libguestfs] [PATCH 1/2] python: Avoid crash if callback parameters cannot be built

2023-02-20 Thread Nir Soffer
On Mon, Feb 20, 2023 at 10:45 AM Laszlo Ersek wrote: > > On 2/17/23 17:52, Eric Blake wrote: > > On Thu, Feb 16, 2023 at 03:09:02PM +0100, Laszlo Ersek wrote: > > >> - Py_BuildValue with the "O" format specifier transfers the new list's > >> *sole* reference (= ownership) to the just-built

[ovirt-users] Re: ImageIO Performance

2023-02-11 Thread Nir Soffer
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > > > > Hi All, > > > > We backup our VM's with a custom script based on the > > https://github.com/oVirt/python-ovirt-engine-sdk4/blob

[ovirt-users] Re: ImageIO Performance

2023-02-09 Thread Nir Soffer
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > The easiest way would be to enable debug logs - it will be even slower, > but we will see these logs showing all extents: Using the --debug option R

[ovirt-users] Re: ImageIO Performance

2023-02-09 Thread Nir Soffer
On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users wrote: > > Hi All, > > We backup our VM's with a custom script based on the > https://github.com/oVirt/python-ovirt-engine-sdk4/blob/main/examples/backup_vm.py > example. > This works fine, but we start to see scaling issues. > > On VM's

Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.

2023-01-31 Thread Nir Soffer
On Tue, Jan 31, 2023 at 12:34 AM Richard W.M. Jones wrote: > > On Fri, Nov 04, 2022 at 04:18:31PM -0500, Eric Blake wrote: > > Document all options in --help output. If -n is not in use, then > > enhance the banner to print the current state of h, and further tailor > > the advice given on

Re: [Libguestfs] [PATCH v2v v2] -o rhv-upload: Improve error message for invalid or missing -os parameter

2023-01-28 Thread Nir Soffer
detaches the domain from the data center in the window after the precheck completes and before the transfer starts. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > Thanks: Nir Soffer > --- > output/rhv-upload-precheck.py | 27

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
On Fri, Jan 27, 2023 at 1:18 PM Nir Soffer wrote: > > On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > Reported-by: Junqin Zhou > > --- > > output/rhv-upload-precheck.py | 7 +

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > --- > output/rhv-upload-precheck.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/output/rhv-upload-precheck.py

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain

2023-01-27 Thread Nir Soffer
On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > My RHV instance is dead at the moment so I didn't do much more than > check this compiles and passes the one test we have. Also I want to > spend as little time as possible on

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

[ovirt-users] Re: How does ovirt handle disks across multiple iscsi LUNs

2022-12-04 Thread Nir Soffer
On Sun, Nov 27, 2022 at 9:11 PM wrote: > A possibly obvious question I can't find the answer to anywhere—how does > ovirt allocate VM disk images when a storage domain has multiple LUNs? Are > these allocated one per LUN, so if e.g. a LUN runs out of space the disks > on that LUN (only) will be

[PATCH v2 5/5] qemu-img: Speed up checksum

2022-11-28 Thread Nir Soffer
5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH v2 1/5] qemu-img.c: Move IO_BUF_SIZE to the top of the file

2022-11-28 Thread Nir Soffer
This macro is used by various commands (compare, convert, rebase) but it is defined somewhere in the middle of the file. I'm going to use it in the new checksum command so lets clean up a bit before that. --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 4/5] iotests: Test qemu-img checksum

2022-11-28 Thread Nir Soffer
debugging in case of failures, the output includes a json map of the test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 63 +++ .../tests/qemu-img-checksum.out.qcow2 | 11 .../tests/qemu-img-checksum.out.raw | 10 +++ 3

[PATCH v2 3/5] qemu-img: Add checksum command

2022-11-28 Thread Nir Soffer
ng checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 24 ++ meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c | 183 +

[PATCH v2 2/5] Support format or cache specific out file

2022-11-28 Thread Nir Soffer
Extend the test finder to find tests with format (*.out.qcow2) or cache specific (*.out.nocache) out file. This worked before only for the numbered tests. --- tests/qemu-iotests/findtests.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/5] Add qemu-img checksum command using blkhash

2022-11-28 Thread Nir Soffer
tml - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html Nir Soffer (5): qemu-img.c: Move IO_BUF_SIZE to the top of the file Support format or cache specific out file qemu-img: Add checksum command iote

[PATCH v2 0/5] Add qemu-img checksum command using blkhash

2022-11-28 Thread Nir Soffer
tml - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html Nir Soffer (5): qemu-img.c: Move IO_BUF_SIZE to the top of the file Support format or cache specific out file qemu-img: Add checksum command iote

[PATCH v2 5/5] qemu-img: Speed up checksum

2022-11-28 Thread Nir Soffer
5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH v2 4/5] iotests: Test qemu-img checksum

2022-11-28 Thread Nir Soffer
debugging in case of failures, the output includes a json map of the test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 63 +++ .../tests/qemu-img-checksum.out.qcow2 | 11 .../tests/qemu-img-checksum.out.raw | 10 +++ 3

[PATCH v2 2/5] Support format or cache specific out file

2022-11-28 Thread Nir Soffer
Extend the test finder to find tests with format (*.out.qcow2) or cache specific (*.out.nocache) out file. This worked before only for the numbered tests. --- tests/qemu-iotests/findtests.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH v2 3/5] qemu-img: Add checksum command

2022-11-28 Thread Nir Soffer
ng checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 24 ++ meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c | 183 +

[PATCH v2 1/5] qemu-img.c: Move IO_BUF_SIZE to the top of the file

2022-11-28 Thread Nir Soffer
This macro is used by various commands (compare, convert, rebase) but it is defined somewhere in the middle of the file. I'm going to use it in the new checksum command so lets clean up a bit before that. --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-11-28 Thread Nir Soffer
On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote: > On 30.10.22 18:38, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > > > Add simple tests creating an image with all kinds

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-11-28 Thread Nir Soffer
On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote: > On 30.10.22 18:38, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > > > Add simple tests creating an image with all kinds

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-11-28 Thread Nir Soffer
On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote: > On 30.10.22 18:37, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > [...] > > > --- > > > docs/tools/qemu-i

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-11-28 Thread Nir Soffer
On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote: > On 30.10.22 18:37, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > [...] > > > --- > > > docs/tools/qemu-i

Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.

2022-11-04 Thread Nir Soffer
On Fri, Nov 4, 2022 at 11:18 PM Eric Blake wrote: [...] > @@ -127,7 +129,10 @@ def __call__(self, parser, namespace, values, > option_string=None): > os.environ["LIBNBD_DEBUG"] = "1" > > # Create the handle. > -if not args.n: > +if args.n: > +pass > +else: >

Re: [Libguestfs] [libnbd PATCH v2 2/3] nbdsh: Allow -u interleaved with -c

2022-11-04 Thread Nir Soffer
On Fri, Nov 4, 2022 at 11:18 PM Eric Blake wrote [...] Sorry but I did not read, but I noticed this: > @@ -165,7 +177,7 @@ def example(ex, desc): line("%-34s # %s" % (ex, desc)) > line("The ‘nbd’ module has already been imported.") > blank() > example("h =

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-10-30 Thread Nir Soffer
On Sun, Oct 30, 2022 at 7:38 PM Nir Soffer wrote: > On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote: > >> On 01.09.22 16:32, Nir Soffer wrote: >> > [...] > > +/* The current chunk. */ >> > +int64_t offset; >> > +int64_t length; >>

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-10-30 Thread Nir Soffer
On Sun, Oct 30, 2022 at 7:38 PM Nir Soffer wrote: > On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote: > >> On 01.09.22 16:32, Nir Soffer wrote: >> > [...] > > +/* The current chunk. */ >> > +int64_t offset; >> > +int64_t length; >>

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > The checksum command compute a checksum for disk image content using the > > blkhash library[1]. The blkhash library is not packaged yet, but it is > > available via copr[2]

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > Add coroutine based loop inspired by `qemu-img convert` design. > > > > Changes compared to `qemu-img convert`: > > > > - State for the entire image is kept in

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > Add coroutine based loop inspired by `qemu-img convert` design. > > > > Changes compared to `qemu-img convert`: > > > > - State for the entire image is kept in

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > Add simple tests creating an image with all kinds of extents, different > > formats, different backing chain, different protocol, and different > > image options. Since all image

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > Add simple tests creating an image with all kinds of extents, different > > formats, different backing chain, different protocol, and different > > image options. Since all image

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-10-30 Thread Nir Soffer
On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > On 01.09.22 16:32, Nir Soffer wrote: > > The checksum command compute a checksum for disk image content using the > > blkhash library[1]. The blkhash library is not packaged yet, but it is > > available via copr[2]

[ovirt-devel] Enable DCO app on github for enforcing signed-off-by

2022-10-26 Thread Nir Soffer
I'm not sure we enforce signed-off-by in all projects, but we do in the most important projects. There is a nice little app adding CI check with zero effort. Here is a bad commit: https://github.com/nirs/userstorage/pull/29 When the check fails the app provides useful help for users:

Re: [PATCH 0/3] Add qemu-img checksum command using blkhash

2022-10-18 Thread Nir Soffer
On Sun, Sep 18, 2022 at 12:35 PM Nir Soffer wrote: > ping > > Kevin, Hanna, I hope you have time to take a look. > > https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html Ping again, hopefully someone has time to look at this :-) > > > > On Thu,

Re: [PATCH 0/3] Add qemu-img checksum command using blkhash

2022-10-18 Thread Nir Soffer
On Sun, Sep 18, 2022 at 12:35 PM Nir Soffer wrote: > ping > > Kevin, Hanna, I hope you have time to take a look. > > https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html Ping again, hopefully someone has time to look at this :-) > > > > On Thu,

[ovirt-users] Re: Issue with disk import and disk upload - ovirt 4.5.2

2022-10-04 Thread Nir Soffer
On Mon, Oct 3, 2022 at 4:11 PM Proniakin Marcin wrote: > > Hello, > > > After upgrading ovirt to version 4.5.2, I've experienced issue with using > import function in import disk window in storage domain after attaching it > to data center. Logs in the attachment (#1). > > > Second issue is with

Re: [PATCH 0/3] Add qemu-img checksum command using blkhash

2022-09-18 Thread Nir Soffer
ping Kevin, Hanna, I hope you have time to take a look. https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html On Thu, Sep 1, 2022 at 5:32 PM Nir Soffer wrote: > > Since blkhash is available only via copr now, the new command is added as > optional feature, b

Re: [PATCH 0/3] Add qemu-img checksum command using blkhash

2022-09-18 Thread Nir Soffer
ping Kevin, Hanna, I hope you have time to take a look. https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html On Thu, Sep 1, 2022 at 5:32 PM Nir Soffer wrote: > > Since blkhash is available only via copr now, the new command is added as > optional feature, b

[PATCH 3/3] qemu-img: Speed up checksum

2022-09-01 Thread Nir Soffer
5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH 1/3] qemu-img: Add checksum command

2022-09-01 Thread Nir Soffer
ng checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 22 + meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c | 191 +

[PATCH 0/3] Add qemu-img checksum command using blkhash

2022-09-01 Thread Nir Soffer
Since blkhash is available only via copr now, the new command is added as optional feature, built only if blkhash-devel package is installed. Nir Soffer (3): qemu-img: Add checksum command iotests: Test qemu-img checksum qemu-img: Speed up checksum docs/tools/qemu-img.rst

[PATCH 2/3] iotests: Test qemu-img checksum

2022-09-01 Thread Nir Soffer
includes a json map of every test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 149 ++ .../qemu-iotests/tests/qemu-img-checksum.out | 74 + 2 files changed, 223 insertions(+) create mode 100755 tests/qemu-iotests/tests/qemu-img

[PATCH 1/3] qemu-img: Add checksum command

2022-09-01 Thread Nir Soffer
ng checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 22 + meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c | 191 +

[PATCH 3/3] qemu-img: Speed up checksum

2022-09-01 Thread Nir Soffer
5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH 2/3] iotests: Test qemu-img checksum

2022-09-01 Thread Nir Soffer
includes a json map of every test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 149 ++ .../qemu-iotests/tests/qemu-img-checksum.out | 74 + 2 files changed, 223 insertions(+) create mode 100755 tests/qemu-iotests/tests/qemu-img

[PATCH 0/3] Add qemu-img checksum command using blkhash

2022-09-01 Thread Nir Soffer
Since blkhash is available only via copr now, the new command is added as optional feature, built only if blkhash-devel package is installed. Nir Soffer (3): qemu-img: Add checksum command iotests: Test qemu-img checksum qemu-img: Speed up checksum docs/tools/qemu-img.rst

[ovirt-users] Re: Veeam Backup for RHV (oVirt)

2022-07-27 Thread Nir Soffer
On Wed, Jul 27, 2022 at 2:56 PM wrote: > > Hi! > Not really sure if this is right place to ask, but.. > > I am trying to use Veeam Backup for Red Hat Virtualization on oVirt 4.5.1. > I have been using it on version 4.4.10.7 and it works ok there. > > On Veeam Release page it says that supported

[ovirt-devel] Re: github testing: merge with branch, or use PR HEAD?

2022-07-07 Thread Nir Soffer
On Wed, Jun 15, 2022 at 12:26 PM Yedidyah Bar David wrote: > > Hi all, > > I was annoyed for some time now by the fact that when I used some > github-CI-generated RPMs, with a git hash in their names, I could > never find this git hash anywhere - not in my local git repo, nor in > github. Why is

[ovirt-users] Re: Cannot Enable incremental backup

2022-07-06 Thread Nir Soffer
On Thu, Jul 7, 2022 at 12:40 AM Jonas wrote: > Hello all > > I'm trying to create incremental backups for my VMs on a testing cluster > and am using the functions from > https://gitlab.com/nirs/ovirt-stress/-/blob/master/backup/backup.py. > Note that the VM configuration is not backed up, so

[ovirt-users] Re: Import KVM VMs on individual iSCSI luns

2022-07-02 Thread Nir Soffer
On Sat, Jul 2, 2022 at 9:40 AM wrote: > > Greetings, > > Is it possible with oVirt to import existing VMs where the underlying > storage is on raw iSCSI luns and to keep them on those luns? > > The historical scenario is that we have Virtual farms in multiple sites > managed by an ancient

[ovirt-users] Re: Failed to Start services ovirt-imageio

2022-06-26 Thread Nir Soffer
load (see the events tag in engine UI) from /var/log/vdsm/vdsm.log - ovirt-imageio log from the host performing the upload from /var/log/ovirt-imageio/daemon.log Nir > > I will be glad to read from you soon. > > Appreciated > > > On Tue, Jun 21, 2022 at 3:19 PM Nir Soffer wrote: &

[ovirt-users] Re: Failed to Start services ovirt-imageio

2022-06-21 Thread Nir Soffer
On Tue, Jun 21, 2022 at 8:18 AM АБИОЛА А. Э wrote: > > Hello Sir, > I am new to Ovirt and I tried to deploy it 3weeks into my oracle linux with > no success. > I got the following error messages > Please how can i fix this error to successfully deploy it. > I will be glad to read from you soon.

[ovirt-devel] Re: Projects missing safe dir config in COPR

2022-06-13 Thread Nir Soffer
On Mon, Jun 13, 2022 at 1:39 PM Michal Skrivanek wrote: > > Hi, > I scanned the current projects and AFAICT these are the active projects that > don't have builds configured properly. Please add "git config --global --add > safe.directory ..." to the COPR makefile > Otherwise COPR build may not

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Nir Soffer
On Thu, Jun 9, 2022 at 6:24 PM Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > + go test -count=1 -v > > > === RUN Test010Load > > > --- PASS: Test010Load (0.00s) > > > === RUN TestAioBuffer > > > --- PASS: TestAioBuffer (0.00s) > > >

[Libguestfs] [PATCH libnbd] golang: aio_buffer.go: Explicit panic() on invalid usage

2022-06-09 Thread Nir Soffer
Previously we depended on the behavior on common platforms to panic when trying to use a nil pointer, but Richard reported that it segfault on RISC-V. Avoid the undocumented assumptions and panic explicitly with a useful panic message. Signed-off-by: Nir Soffer --- golang/aio_buffer.go | 9

Re: [Libguestfs] libnbd golang failure on RISC-V

2022-06-09 Thread Nir Soffer
On Thu, Jun 9, 2022 at 6:48 PM Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 04:24:12PM +0100, Richard W.M. Jones wrote: > > On Thu, Jun 09, 2022 at 03:20:02PM +0100, Daniel P. Berrangé wrote: > > > > + go test -count=1 -v > > > > === RUN Test010Load > > > > --- PASS: Test010Load

[ovirt-users] Re: HA VM Lease failure with full data storage domain

2022-06-02 Thread Nir Soffer
hub or > the RedHat bugzilla? Bugzilla is still the preferred place, but you can use github if you like, we will look at it in both places. Nir > -Patrick Hibbs > > On Thu, 2022-06-02 at 22:08 +0300, Nir Soffer wrote: > > On Thu, Jun 2, 2022 at 9:52 PM Patrick Hibbs > > wrote: >

[ovirt-users] Re: HA VM Lease failure with full data storage domain

2022-06-02 Thread Nir Soffer
deeper next week. Nir > Jun 02 10:33:47 ryuki.codenet kernel: ovirtmgmt: port 4(vnet2) entered > disabled state > ---snip--- > > That looks like some SELinux failure. > > -Patrick Hibbs > > On Thu, 2022-06-02 at 19:44 +0300, Nir Soffer wrote: > > On Thu

Re: [linux-lvm] lvm commands hanging when run from inside a kubernetes pod

2022-06-02 Thread Nir Soffer
On Thu, Jun 2, 2022 at 9:41 AM Abhishek Agarwal wrote: > > These are not different LVM processes. The container process is using the LVM > binary that the node itself has. We have achieved this by using scripts that > point to the same lvm binary that is used by the node. > > Configmap(~shell

[ovirt-users] Re: HA VM Lease failure with full data storage domain

2022-06-02 Thread Nir Soffer
On Thu, Jun 2, 2022 at 7:44 PM Nir Soffer wrote: > > On Thu, Jun 2, 2022 at 7:14 PM Patrick Hibbs wrote: > > > > OK, so the data storage domain on a cluster filled up to the point that > > the OS refused to allocate any more space. > > > > This happened becaus

[ovirt-users] Re: HA VM Lease failure with full data storage domain

2022-06-02 Thread Nir Soffer
On Thu, Jun 2, 2022 at 7:14 PM Patrick Hibbs wrote: > > OK, so the data storage domain on a cluster filled up to the point that > the OS refused to allocate any more space. > > This happened because I tried to create a new prealloc'd disk from the > Admin WebUI. The disk creation claims to be

  1   2   3   4   5   6   7   8   9   10   >