[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19495#discussion_r144991277 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -270,6 +270,60 @@ class FlatMapGroupsWithStateSuite

[GitHub] spark issue #19452: [SPARK-22136][SS] Evaluate one-sided conditions early in...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19452 Waiting for build 82819 to pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19452: [SPARK-22136][SS] Evaluate one-sided conditions early in...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19452 LGTM. Will merge after tests pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19495#discussion_r144972393 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -270,6 +270,60 @@ class FlatMapGroupsWithStateSuite

[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19495#discussion_r144972248 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/GroupState.scala --- @@ -205,92 +205,127 @@ trait GroupState[S] extends LogicalGroupState[S

[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19495#discussion_r144963002 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/GroupStateImpl.scala --- @@ -119,32 +115,39 @@ private[sql] class GroupStateImpl[S

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144937226 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -221,43 +228,29 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144708446 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -349,14 +350,35 @@ case class

spark git commit: [SPARK-22238] Fix plan resolution bug caused by EnsureStatefulOpPartitioning

Repository: spark Updated Branches: refs/heads/master 014dc8471 -> e8547ffb4 [SPARK-22238] Fix plan resolution bug caused by EnsureStatefulOpPartitioning ## What changes were proposed in this pull request? In EnsureStatefulOpPartitioning, we check that the inputRDD to a SparkPlan has the

[GitHub] spark issue #19467: [SPARK-22238] Fix plan resolution bug caused by EnsureSt...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19467 Merging to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19495: [SPARK-22278][SS] Expose current event time water...

GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/19495 [SPARK-22278][SS] Expose current event time watermark and current processing time in GroupState ## What changes were proposed in this pull request? Complex state-updating and/or timeout

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144664962 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -349,12 +356,28 @@ case class

[GitHub] spark issue #19467: [SPARK-22238] Fix plan resolution bug caused by EnsureSt...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19467 LGTM, assuming tests pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144651101 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144533029 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144532481 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144450136 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r19963 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -161,6 +164,10 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r19650 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -206,10 +213,19 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144437858 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,68 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144437488 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,68 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144437411 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -355,6 +362,8 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144437332 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -402,17 +411,27 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144437093 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -161,6 +164,10 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144436846 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -206,10 +213,19 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144436721 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -206,10 +213,19 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144436114 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -21,7 +21,7 @@ import

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144436075 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -127,12 +127,13 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144435919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -127,12 +127,13 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144435689 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -221,43 +237,36 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144435539 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -221,43 +237,36 @@ case class

[GitHub] spark issue #19467: [SPARK-22238] Fix plan resolution bug caused by EnsureSt...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19467 Whoops, i missed one comment. Not LGTM. Need tests in PlannerSuite that tests whether EnsureRequirements respects numPartitions in ClusteredDistribution

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144403807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -50,7 +50,8 @@ case class EnsureRequirements(conf

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144434463 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StatefulOperatorTest.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144434390 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StatefulOperatorTest.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144433715 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -214,7 +214,7 @@ class StateStoreRDDSuite

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144402006 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -243,8 +246,9 @@ case class HashPartitioning

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144408406 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EnsureStatefulOpPartitioningSuite.scala --- @@ -53,7 +53,7 @@ class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144406045 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -43,10 +43,11 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144406113 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -239,7 +240,7 @@ case class StateStoreRestoreExec

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144372504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -387,9 +400,10 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144371994 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144154295 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -590,10 +590,33 @@ case class CoalesceExec(numPartitions

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152923 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -131,17 +132,17 @@ class IncrementalExecution

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152859 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -131,17 +132,17 @@ class IncrementalExecution

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152254 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -590,10 +590,33 @@ case class CoalesceExec(numPartitions

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144128814 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144131323 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -220,37 +232,36 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144128720 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144130110 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -127,12 +127,13 @@ case class

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r143879728 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144099476 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r143879599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r143807269 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144099311 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144097795 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144128285 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object

[GitHub] spark pull request #19452: [SPARK-22136][SS] Evaluate one-sided conditions e...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r144132422 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -355,12 +364,16 @@ case class

spark git commit: [SPARK-22187][SS] Update unsaferow format for saved state such that we can set timeouts when state is null

ll, and avoid these confusing corner cases. ## How was this patch tested? Refactored tests. Author: Tathagata Das <tathagata.das1...@gmail.com> Closes #19416 from tdas/SPARK-22187. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/sp

[1/2] spark git commit: [SPARK-22136][SS] Implement stream-stream outer joins.

Repository: spark Updated Branches: refs/heads/master 5f6943345 -> 3099c574c http://git-wip-us.apache.org/repos/asf/spark/blob/3099c574/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala -- diff

[2/2] spark git commit: [SPARK-22136][SS] Implement stream-stream outer joins.

[SPARK-22136][SS] Implement stream-stream outer joins. ## What changes were proposed in this pull request? Allow one-sided outer joins between two streams when a watermark is defined. ## How was this patch tested? new unit tests Author: Jose Torres Closes #19327 from

[GitHub] spark issue #19327: [SPARK-22136][SS] Implement stream-stream outer joins.

Github user tdas commented on the issue: https://github.com/apache/spark/pull/19327 LGTM. Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142562531 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithState_StateManager.scala --- @@ -0,0 +1,143

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142536858 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -157,11 +164,20 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142533513 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -425,6 +426,10 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142530623 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,222 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142530435 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,222 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142530086 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,222 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142344009 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142343784 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142339309 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142339158 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142338734 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142338500 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142338421 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142336109 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142335872 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142335782 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -470,3 +475,283 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142335578 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala --- @@ -425,6 +426,10 @@ class StreamingJoinSuite extends

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142304163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithState_StateManager.scala --- @@ -0,0 +1,143

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142303254 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -376,9 +388,35 @@ class FlatMapGroupsWithStateSuite

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142303281 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -376,9 +388,35 @@ class FlatMapGroupsWithStateSuite

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142303228 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -397,50 +435,23 @@ class

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142303057 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithState_StateManager.scala --- @@ -0,0 +1,143

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142303019 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithState_StateManager.scala --- @@ -0,0 +1,143

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19416#discussion_r142302989 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala --- @@ -62,26 +60,7 @@ case class

[GitHub] spark pull request #19416: [SPARK-22187][SS] Update unsaferow format for sav...

GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/19416 [SPARK-22187][SS] Update unsaferow format for saved state such that we can set timeouts when state is null ## What changes were proposed in this pull request? Currently, the group state

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r142288587 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala --- @@ -233,16 +234,53 @@ object

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141989504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -133,242 +134,6 @@ object

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141987778 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141987664 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986897 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986865 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -207,31 +221,108 @@ case class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986696 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986708 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986634 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986168 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141986227 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141985815 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala --- @@ -413,36 +414,103 @@ class

[GitHub] spark pull request #19327: [SPARK-22136][SS] Implement stream-stream outer j...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r141982780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala --- @@ -233,16 +234,54 @@ object

<    5   6   7   8   9   10   11   12   13   14   >