Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

> On Oct 27, 2016, at 4:31 PM, Pete Brunet wrote: > > I moved the source to > src/jdk.accessibility/windows/native/bridge/src “src” subdirectory is redundant that should be dropped. > and the includes to > src/jdk.accessibility/windows/native/bridge/include Please

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/16 6:31 PM, Pete Brunet wrote: > On 10/27/16 1:30 PM, Mandy Chung wrote: >>> On Oct 27, 2016, at 10:44 AM, Phil Race wrote: >>> >>> No, we are definitely shipping those. >>> Unless of course you think we should stop shipping JNI headers too … >>> >> No. I tried

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/16 1:30 PM, Mandy Chung wrote: >> On Oct 27, 2016, at 10:44 AM, Phil Race wrote: >> >> No, we are definitely shipping those. >> Unless of course you think we should stop shipping JNI headers too … >> > No. I tried to understand what is external interface. I

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/2016 11:52 AM, Pete Brunet wrote: On 10/27/16 1:47 PM, Pete Brunet wrote: On 10/27/16 1:34 PM, Phil Race wrote: In which case be careful it is not built by the JDK build .. Build team, Is there anything I need to handle here to make sure it isn't? Actually, let me give it a try. I

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/16 1:47 PM, Pete Brunet wrote: > > On 10/27/16 1:34 PM, Phil Race wrote: >> In which case be careful it is not built by the JDK build .. > Build team, Is there anything I need to handle here to make sure it isn't? Actually, let me give it a try. I should be able to resolve any issues.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/16 1:34 PM, Phil Race wrote: > In which case be careful it is not built by the JDK build .. Build team, Is there anything I need to handle here to make sure it isn't? > unless that is actually required .. which I didn't think it was. > > -phil. > > On 10/27/2016 11:30 AM, Mandy Chung

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/16 1:34 PM, Phil Race wrote: > In which case be careful it is not built by the JDK build .. > unless that is actually required .. which I didn't think it was. It isn't. > > -phil. > > On 10/27/2016 11:30 AM, Mandy Chung wrote: >> Please move AccessBridgeCalls.c to >>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

In which case be careful it is not built by the JDK build .. unless that is actually required .. which I didn't think it was. -phil. On 10/27/2016 11:30 AM, Mandy Chung wrote: Please move AccessBridgeCalls.c to src/jdk.accessibility/windows/native/bridge directory.

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Thank you, Erik On 10/27/16 5:40 AM, Erik Joelsson wrote: On 2016-10-27 02:45, Vladimir Kozlov wrote: AOT JEP: https://bugs.openjdk.java.net/browse/JDK-8166089 Subtask: https://bugs.openjdk.java.net/browse/JDK-8166416 Webrev: http://cr.openjdk.java.net/~kvn/aot/top.webrev/ hotspot.m4: 296:

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

> On Oct 27, 2016, at 10:44 AM, Phil Race wrote: > > No, we are definitely shipping those. > Unless of course you think we should stop shipping JNI headers too … > No. I tried to understand what is external interface. I took it that these header files are external

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 27, 2016, at 8:12 AM, Vladimir Kozlov > wrote: > > On 10/27/16 10:55 AM, Christian Thalinger wrote: >> >>> On Oct 27, 2016, at 2:40 AM, Erik Joelsson wrote: >>> >>> >>> >>> On 2016-10-27 02:45, Vladimir Kozlov wrote: AOT

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On 27 Oct 2016, at 20:12, Vladimir Kozlov wrote: > > On 10/27/16 10:55 AM, Christian Thalinger wrote: >> >>> On Oct 27, 2016, at 2:40 AM, Erik Joelsson wrote: >>> >>> >>> >>> On 2016-10-27 02:45, Vladimir Kozlov wrote: AOT JEP:

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 10/27/16 10:55 AM, Christian Thalinger wrote: On Oct 27, 2016, at 2:40 AM, Erik Joelsson wrote: On 2016-10-27 02:45, Vladimir Kozlov wrote: AOT JEP: https://bugs.openjdk.java.net/browse/JDK-8166089 Subtask: https://bugs.openjdk.java.net/browse/JDK-8166416

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Done as you suggested. I will update webrevs later. One problem left. How to switch off ENABLE_AOT if we can't build libjelfshim.so (libelf not found or wrong version)? ENABLE_AOT and JVM_FEATURES_server are defined before LIBJELFSHIM_ENABLED is defined. Can I reset ENABLE_AOT (based on

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 27, 2016, at 2:40 AM, Erik Joelsson wrote: > > > > On 2016-10-27 02:45, Vladimir Kozlov wrote: >> AOT JEP: >> https://bugs.openjdk.java.net/browse/JDK-8166089 >> Subtask: >> https://bugs.openjdk.java.net/browse/JDK-8166416 >> Webrev: >>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

No, we are definitely shipping those. Unless of course you think we should stop shipping JNI headers too ... -phil On 10/27/2016 10:37 AM, Mandy Chung wrote: Should they be kept just in the source and not to be included in the image/include directory? It’s not clear to me if anyone needs

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Should they be kept just in the source and not to be included in the image/include directory? It’s not clear to me if anyone needs these header files from the JDK image as AccessBridgeCalls.c is obtained from the source. Mandy > On Oct 27, 2016, at 6:48 AM, Pete Brunet

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

This all seems fine. Do other accessbridge files still have the remnants of SCCS ? :- That was purged from all the other JDK files when we moved to mercurial. 33 /* 34 * @(#)AccessBridgeCalls.c 1.25 05/08/22 35 */ If "yes", then I suggest to file a clean-up bug to clean up all of

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

OK, thanks. I'll do that tomorrow. For now I did built 'hotspot-only' and sent out a webrev with the requiredppc/s390 changes for hotspot to the corresponding review thread. Would be nice if you could integrate them into your patch right away. Thanks, Volker On Thu, Oct 27, 2016 at 6:24 PM,

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Yes, you need to integrate graal-core into hotspot for that. I just send final RFR which explains what to do: 8166417: Graal-core into JDK for AOT compiler Regards, Vladimir On 10/27/16 8:45 AM, Volker Simonis wrote: I can't even compile this on Linux/x86_64. I get the following error:

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

I can't even compile this on Linux/x86_64. I get the following error: /usr/work/d046063/OpenJDK/jdk9-hs/jdk/src/java.base/share/classes/module-info.java:159: error: module not found: jdk.vm.compiler jdk.vm.compiler; ^

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On Thu, Oct 27, 2016 at 2:22 PM, Volker Simonis wrote: > Hi, > > currently libelf support is checked on every 64-bit Linux and Solaris > platform (see lib-elf.m4): > > if ((test "x$OPENJDK_TARGET_OS" = "xlinux" \ >|| test "x$OPENJDK_TARGET_OS" = "xsolaris") &&

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Thanks for noticing that Phil. Updated at http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/ On 10/27/16 9:20 AM, Philip Race wrote: > But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev. > > -phil. > > On 10/26/16, 9:27 PM, Anirvan Sarkar wrote: >> Hi, >> >> If you

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

I see. I specifically removed generated-configure.sh from webrev since it has to be generated. I will add version of webrev with it. Regards, Vladimir On 10/27/16 3:14 AM, Volker Simonis wrote: Hi Vladimir, I'm trying to build and test these changes on our platforms and I've just realized

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev. -phil. On 10/26/16, 9:27 PM, Anirvan Sarkar wrote: Hi, If you replace the hex number with 'tip' then it will always point to the latest version. Something like

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

The .h files are unlicensed in the bundle/install so no need? On 10/26/16 11:52 PM, Mandy Chung wrote: > Should the same change be applied to the .h files as well? > > Mandy > >> On Oct 26, 2016, at 7:24 PM, Pete Brunet wrote: >> >> Please review the latest update at >>

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 2016-10-27 02:45, Vladimir Kozlov wrote: AOT JEP: https://bugs.openjdk.java.net/browse/JDK-8166089 Subtask: https://bugs.openjdk.java.net/browse/JDK-8166416 Webrev: http://cr.openjdk.java.net/~kvn/aot/top.webrev/ hotspot.m4: 296: Comment is misleading. Should just be removed.

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Hi, currently libelf support is checked on every 64-bit Linux and Solaris platform (see lib-elf.m4): if ((test "x$OPENJDK_TARGET_OS" = "xlinux" \ || test "x$OPENJDK_TARGET_OS" = "xsolaris") && \ (test "x$OPENJDK_TARGET_CPU_BITS" = "x64")); then LIBJELFSHIM_ENABLED="true"

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Hi Vladimir, I'm trying to build and test these changes on our platforms and I've just realized that the top-level changes do not contained the generated-configure.sh script. I for myself have generated it for me, but I think it would be useful to always include that into a webrev for convenience

Re: Fix for JDK-8160146 : Resolve disabled GCC warning 'deprecated-declarations' for libawt_xawt

Looks good. /Erik On 2016-10-27 11:02, Ajit Ghaisas wrote: Hi, Fix of HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8165232"JDK-8165232 has fixed the 'deprecated' warnings from libawt_xawt. Now, only removing warning suppression from makefile remains. This webrev

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Build change looks good. /Erik On 2016-10-27 04:24, Pete Brunet wrote: Please review the latest update at http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/ The change is to AccessBridgeCalls.c. The license has been changed from GPL2 to BSD. This is because the file was originally

Fix for JDK-8160146 : Resolve disabled GCC warning 'deprecated-declarations' for libawt_xawt

Hi, Fix of HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8165232"JDK-8165232 has fixed the 'deprecated' warnings from libawt_xawt. Now, only removing warning suppression from makefile remains. This webrev does it. http://cr.openjdk.java.net/~aghaisas/8160146/webrev.0/