On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters wrote:
> Implementation of [JEP draft: Compile the JDK as
> C++17](https://bugs.openjdk.org/browse/JDK-8310260)
The minimum compiler requirements have not been implemented yet, as I wanted to
leave their discretion to any reviewers before
Implementation of [JEP draft: Compile the JDK as
C++17](https://bugs.openjdk.org/browse/JDK-8310260)
-
Commit messages:
- vm_version_linux_riscv.cpp
- allocation.cpp
- 8310260
Changes: https://git.openjdk.org/jdk/pull/14988/files
Webrev:
Hi,
It looks like Adoptium is building with CentOS 6.10[1] which does not
append --as-needed linker flag by default. This results in the
.gnu_version section created and the bug worked around with Temurin
builds.
In Debian/Ubuntu the toolchain automatically uses -as-needed by
default so we've
On Wed, 16 Aug 2023 19:22:01 GMT, Sergey Bylokhov wrote:
> Why initial patch was reverter using this comment: "unfortunately, did not
> prove to be as useful as expected"? What was the problem? What about the
> "pedantic" option which was added last time?
Hi, the problem was that gcc and
On Thu, 17 Aug 2023 01:57:46 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change size of op_index back.
>
> src/hotspot/share/utilities/elfFile.hpp line 486:
>
>> 484: DwarfFile*
On Wed, 16 Aug 2023 23:56:58 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Thu, 17 Aug 2023 01:01:02 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Thu, 17 Aug 2023 00:37:55 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change size of op_index back.
>
> src/hotspot/share/utilities/elfFile.cpp line 1454:
>
>> 1452: return
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 16 Aug 2023 23:56:58 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Wed, 16 Aug 2023 23:43:36 GMT, Coleen Phillimore wrote:
>> uint64_t operation_advance;
>> if (!_reader.read_uleb128(_advance, 4)) {
>> // Must be at most 4 bytes because the index register is only 4
>> bytes wide.
>> return false;
>> }
>>
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 16 Aug 2023 23:10:30 GMT, Coleen Phillimore wrote:
>> So put the cast here?
>
> uint64_t operation_advance;
> if (!_reader.read_uleb128(_advance, 4)) {
> // Must be at most 4 bytes because the index register is only 4 bytes
> wide.
> return false;
> }
>
On Wed, 16 Aug 2023 23:02:45 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/utilities/elfFile.cpp line 1723:
>>
>>> 1721: void
>>> DwarfFile::LineNumberProgram::LineNumberProgramState::set_index_register(const
>>> uint64_t operation_advance,
>>> 1722:
On Wed, 16 Aug 2023 21:38:52 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove wrong comment.
>
> src/hotspot/share/utilities/elfFile.cpp line 1723:
>
>> 1721: void
>>
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less
On Wed, 16 Aug 2023 18:51:03 GMT, Thomas Stuefe wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert to use static_cast.
>
> src/hotspot/share/logging/logOutput.cpp line 77:
>
>> 75: ntags++;
>> 76:
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 16 Aug 2023 13:48:35 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote:
> Use most recent devkit when using jib.
>
> Test: staged, configured from scratch and verified micros locally
Marked as reviewed by erikj (Reviewer).
-
PR Review:
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote:
> Use most recent devkit when using jib.
>
> Test: staged, configured from scratch and verified micros locally
Marked as reviewed by mikael (Reviewer).
-
PR Review:
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote:
> Use most recent devkit when using jib.
>
> Test: staged, configured from scratch and verified micros locally
Looks fine.
-
Marked as reviewed by shade (Reviewer).
PR Review:
Use most recent devkit when using jib.
Test: staged, configured from scratch and verified micros locally
-
Commit messages:
- Update jib-profiles.js to use JMH 1.37
Changes: https://git.openjdk.org/jdk/pull/15313/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15313=00
On Wed, 16 Aug 2023 13:48:35 GMT, Coleen Phillimore wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
>> warnings in runtime code. This is the last one I'm going to do for runtime
>> for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 16 Aug 2023 13:01:53 GMT, Christian Hagedorn
wrote:
>> This code:
>>
>> uint64_t isa;
>> if (!_reader.read_uleb128(, 4)) {
>> // isa register is 4 bytes wide.
>> return false;
>> }
>> _state->_isa = isa; // only save 4 bytes
>>
>> returns 64
On Wed, 16 Aug 2023 12:33:47 GMT, Coleen Phillimore wrote:
>> When we read the 64 bit values in the code, the values are 64 bits though.
>> So static_cast<> to narrow the result is more correct ?
>
> This code:
>
> uint64_t isa;
> if (!_reader.read_uleb128(, 4)) {
> // isa
On Wed, 16 Aug 2023 12:30:18 GMT, Coleen Phillimore wrote:
>> According to the DWARF 4 spec, the discriminator is an unsigned integer
>> (i.e. 32 bits). Also, the other fields like `isa or `column` are unsigned
>> integer. I think we would be good to keep them as unsigned integer to follow
>>
On Wed, 16 Aug 2023 12:22:15 GMT, Christian Hagedorn
wrote:
>> src/hotspot/share/utilities/elfFile.cpp line 1426:
>>
>>> 1424: return false;
>>> 1425: }
>>> 1426: _state->_discriminator = static_cast(discriminator);
>>
>> @chhagedorn These fields are declared as 32 bits
On Wed, 16 Aug 2023 11:45:54 GMT, Coleen Phillimore wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make elf fields 64 bits removing some static casts.
>
> src/hotspot/share/utilities/elfFile.cpp line 1426:
>
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Thu, 10 Aug 2023 20:31:20 GMT, Coleen Phillimore wrote:
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion
> warnings in runtime code. This is the last one I'm going to do for runtime
> for a while.
> Tested with tier1-4.
src/hotspot/share/utilities/elfFile.cpp
On Tue, 15 Aug 2023 12:36:05 GMT, Aleksey Shipilev wrote:
> [JDK-8294941](https://bugs.openjdk.org/browse/JDK-8294941) cut out some
> unused files in GHA sysroots. But I notice that even after that, we still
> have quite a bit of fluff there, especially in RISC-V sysroot. We can cut a
> bit
38 matches
Mail list logo
