[clang] 9ef66ed - [clang-format][NFC] correctly sort StatementAttributeLike-macros' IO.map

2021-05-25 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2021-05-26T07:59:08+02:00 New Revision: 9ef66ed43758a575e1f53a09f07ecb7e3025aafa URL: https://github.com/llvm/llvm-project/commit/9ef66ed43758a575e1f53a09f07ecb7e3025aafa DIFF:

[PATCH] D102465: [Coroutines] Mark every parameter

2021-05-25 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. If it would take times to mark parameter passed by value only, I think we could proceed with this one first. We can try to optimize it later. After all, correctness is most important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

2021-05-25 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> Would it be fine to revert this for now to work out the kinks? I dont think. This is a known problem, not caused by this patch, just exposed. You can search bugzilla for it, simply, if there is an UB, llvm should emit a “ret”. Repository: rG LLVM Github

[PATCH] D102995: errorUnsupported should be non-fatal

2021-05-25 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. X86-64 ABI requires float/double arguments to use XMM registers. All x86-64 CPUs have SSE2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102995/new/ https://reviews.llvm.org/D102995

[PATCH] D103131: support debug info for alias variable

2021-05-25 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui added a comment. In D103131#2780997 , @dblaikie wrote: > Looks like GCC emits aliases as a `DW_TAG_variable` without a location, not > as a `DW_TAG_imported_declaration` - what gave you the inspiration to do it > in this way? (I think

[PATCH] D103131: support debug info for alias variable

2021-05-25 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Looks like GCC emits aliases as a `DW_TAG_variable` without a location, not as a `DW_TAG_imported_declaration` - what gave you the inspiration to do it in this way? (I think it's probably good, but DWARF doesn't lend itself to novelty so much... can be good to stick

[PATCH] D102995: errorUnsupported should be non-fatal

2021-05-25 Thread MJ via Phabricator via cfe-commits
majiang31312 added a comment. In D102995#2778674 , @craig.topper wrote: > "fatal" in the comment means don't diagnose any additional errors and > immediately stop. We attempt to recover to detect more errors, but the > emitted binary code is likely

[PATCH] D103131: support debug info for alias variable

2021-05-25 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui created this revision. kamleshbhalui added reviewers: dblaikie, aprantl, probinson. kamleshbhalui added a project: LLVM. Herald added a subscriber: jeroen.dobbelaere. kamleshbhalui requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

2021-05-25 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

2021-05-25 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-25 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 347814. hctim marked an inline comment as done. hctim added a comment. Address Vitaly's suggestions, make some slight changes so that cross-compilation and running under QEMU doesn't require staging the runtimes in the host compiler. Repository: rG LLVM

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-25 Thread Mitch Phillips via Phabricator via cfe-commits
hctim marked 2 inline comments as done. hctim added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC +

[PATCH] D103112: Reimplement __builtin_unique_stable_name-

2021-05-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 347805. erichkeane added a comment. Apply the clang-format patch from CI, also apply the unused variable fix clang-tidy suggested. The rest of the issues in clang-tidy are identifying functions in a recursive call-chain, but they are all part of the

[PATCH] D102736: Fix tmp files being left on Windows builds.

2021-05-25 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 347802. akhuang marked 5 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files:

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

2021-05-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi all, it looks like this commit led to some unexpected behavior in our build. When compiling something like: // clang++ -c -S -o - /tmp/test.cc -std=c++17 -O1 static int do_nothing(void* unused) { for (;;) { } return 0; } typedef int

[PATCH] D102736: Fix tmp files being left on Windows builds.

2021-05-25 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Nice, this seems to be working out. Comment at: clang/include/clang/Frontend/CompilerInstance.h:170 std::string TempFilename; +Optional TempFile; aganea wrote: > Can we always use `TempFile`? And remove `TempFilename` in that

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-25 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 34. quinnp added a comment. This update is motivated by comments made by @nemanjai. All of the builtin names have been changed to follow the convention of __builtin__. To fulfill the original goal of compatibility with the XL compiler, macros have been

[PATCH] D103112: Reimplement __builtin_unique_stable_name-

2021-05-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: aaron.ballman, rjmccall. Herald added subscribers: Naghasan, dexonsmith, martong, Anastasia, mgrang. erichkeane requested review of this revision. The original version of this was reverted, and @rjmcall provided some advice to

[PATCH] D102975: [HIP] Check compatibility of -fgpu-sanitize with offload arch

2021-05-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 347769. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102975/new/ https://reviews.llvm.org/D102975 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

2021-05-25 Thread Delesley Hutchins via Phabricator via cfe-commits
delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. Thanks for taking the time to discuss things with me. :-) Wrt. to the TEST_LOCKED_FUNCTION, I agree that you can simulate the behavior using Assert and Lock. But that pattern is too

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

2021-05-25 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D102026#2779983 , @aaronpuchert wrote: > So this change will allow shared/exclusive - asserted/unmanaged joins until > my follow-up will disallow them again, though because of the > asserted/unmanaged part and not the

[PATCH] D103081: [analyzer] RetainCountChecker: Disable reference counting for OSMetaClass.

2021-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks! Looks like the windows buildbot is broken and it's not our fault (sccache broke on their end). I'll commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

2021-05-25 Thread Steven Wan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc644aeca8f: Revert [AIX] Avoid structor alias; die before bad alias codegen (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM

[clang] 5bc644a - Revert "[AIX] Avoid structor alias; die before bad alias codegen"

2021-05-25 Thread Steven Wan via cfe-commits
Author: Jake Egan Date: 2021-05-25T15:07:40-04:00 New Revision: 5bc644aeca8fc6a734308d81781935de26ea4cde URL: https://github.com/llvm/llvm-project/commit/5bc644aeca8fc6a734308d81781935de26ea4cde DIFF: https://github.com/llvm/llvm-project/commit/5bc644aeca8fc6a734308d81781935de26ea4cde.diff

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-25 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: MaskRay, mehdi_amini. dblaikie added a comment. In D102650#2779193 , @urnathan wrote: > dblaikie, do you know if there's a way to do it outside of arc? (for reasons, > I've not got arc to work from inside work). I tried not

[PATCH] D103081: RetainCountChecker: Disable reference counting for OSMetaClass.

2021-05-25 Thread Georgeta Igna via Phabricator via cfe-commits
georgi_igna updated this revision to Diff 347748. georgi_igna added a comment. RetainCountChecker: Disable reference counting for OSMetaClass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103081/new/ https://reviews.llvm.org/D103081 Files:

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

2021-05-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Recently we added diagnosing ODR-use of host variables in device functions, which includes ODR-use of const host variables since they are not really emitted on device side. This caused

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

2021-05-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/include/llvm/Support/TargetRegistry.h:26 #include "llvm/ADT/iterator_range.h" +#include "llvm/MC/MCObjectFileInfo.h" #include "llvm/Support/CodeGen.h" `include/llvm/Support/TargetRegistry.h now has cyclic

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

2021-05-25 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In D101191#2779631 , @spatel wrote: > In D101191#2779007 , @fhahn wrote: > >> Looks like this is causing an infinite loop in instcombine: >>

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

2021-05-25 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D102026#2777438 , @delesley wrote: > The warn/not-warn is consistent with more relaxed handling of managed locks, > but exclusive/shared difference could lead to confusion. Both mechanisms are > sound; they're just not

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-25 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 347709. feg208 added a comment. Addresses review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-25 Thread Fred Grim via Phabricator via cfe-commits
feg208 marked 2 inline comments as done. feg208 added a comment. The tests still need to be added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

2021-05-25 Thread Jason Zheng via Phabricator via cfe-commits
jzzheng22 updated this revision to Diff 347708. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103097/new/ https://reviews.llvm.org/D103097 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl Index:

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

2021-05-25 Thread Jason Zheng via Phabricator via cfe-commits
jzzheng22 created this revision. jzzheng22 added reviewers: cfe-commits, Anastasia. jzzheng22 requested review of this revision. Herald added a project: clang. Extend debug info handling by adding DWARF address space mapping for SPIR, with corresponding test case. Repository: rG LLVM Github

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

2021-05-25 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko, steakhal, martong, dcoughlin, baloghadamsoftware. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun.

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

2021-05-25 Thread Jamie Schmeiser via Phabricator via cfe-commits
jamieschmeiser added a comment. @thakis, can you please verify that the changes no longer affect the MS headers? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

2021-05-25 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: vsavchenko, NoQ, steakhal, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. ASDenysPetrov

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

2021-05-25 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:3496-3501 + assert(!Tok.is(tok::l_brace) || !Tok.is(BK_Block) || +

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-05-25 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D101868#2777423 , @feg208 wrote: > In D101868#2776633 , > @HazardyKnusperkeks wrote: > >> In D101868#2775550 , @feg208 wrote: >>

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

2021-05-25 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In D101191#2779007 , @fhahn wrote: > Looks like this is causing an infinite loop in instcombine: > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34661 This seems likely to be another partial undef/poison vector problem (

[clang] 21aa107 - Reland "Do not create LLVM IR `constant`s for objects with dynamic initialisation"

2021-05-25 Thread Momchil Velikov via cfe-commits
Author: Momchil Velikov Date: 2021-05-25T15:54:40+01:00 New Revision: 21aa107eb79f8ddc5e7ca4e8f3476338dfa90049 URL: https://github.com/llvm/llvm-project/commit/21aa107eb79f8ddc5e7ca4e8f3476338dfa90049 DIFF:

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

2021-05-25 Thread Momchil Velikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21aa107eb79f: Reland Do not create LLVM IR `constant`s for objects with dynamic… (authored by chill). Repository: rG LLVM Github Monorepo

[clang] 8427053 - [clang][ARM] When handling multiple -mimplicit-it mark all as used

2021-05-25 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2021-05-25T14:53:07Z New Revision: 8427053f81922b0665a1ad3f561c09f8c0b8dd30 URL: https://github.com/llvm/llvm-project/commit/8427053f81922b0665a1ad3f561c09f8c0b8dd30 DIFF: https://github.com/llvm/llvm-project/commit/8427053f81922b0665a1ad3f561c09f8c0b8dd30.diff

[PATCH] D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used

2021-05-25 Thread David Spickett via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8427053f8192: [clang][ARM] When handling multiple -mimplicit-it mark all as used (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[PATCH] D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers.

2021-05-25 Thread Felix Berger via Phabricator via cfe-commits
flx created this revision. flx added reviewers: aaron.ballman, hokein, ymandel. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This change extends isOnlyUsedAsConst() to avoid false

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

2021-05-25 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:2 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple x86_64-linux-gnu -target-feature -x87 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 +// RUN: %clang_cc1

[PATCH] D103086: [clang][ARM] When handling multiple -mimplicit-it mark all as used

2021-05-25 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, and sorry for not testning this aspect in the updated version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103086/new/

[PATCH] D103086: [clang][ARM] When handling multiple -mimplcit-it mark all as used

2021-05-25 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a reviewer: mstorsjo. DavidSpickett added a comment. You could argue that one of them is actually "unused" but I tried `-march` which also takes the last value and that does not warn when it ignores earlier values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103086: [clang][ARM] When handling multiple -mimplcit-it mark all as used

2021-05-25 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since 4468e5b8999291cc84b78f33f207dcd0e58146bc

[clang] 16e78ec - [Headers][WASM] adjust test that runs the optimizer; NFC

2021-05-25 Thread Sanjay Patel via cfe-commits
Author: Sanjay Patel Date: 2021-05-25T09:17:10-04:00 New Revision: 16e78ec0b43c33c818525ea9b5d39731022f1cbb URL: https://github.com/llvm/llvm-project/commit/16e78ec0b43c33c818525ea9b5d39731022f1cbb DIFF: https://github.com/llvm/llvm-project/commit/16e78ec0b43c33c818525ea9b5d39731022f1cbb.diff

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

2021-05-25 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 347662. ASDenysPetrov added a comment. More minor improvements in unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files:

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

2021-05-25 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 347658. ASDenysPetrov added a comment. Minor improvements in unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files:

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

2021-05-25 Thread Andrew Savonichev via Phabricator via cfe-commits
asavonic added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:2 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple x86_64-linux-gnu -target-feature -x87 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 +// RUN: %clang_cc1

[PATCH] D103082: [AArch64][SVE] Optimize svbool dupq ACLE intrinsic to fixed predicate patterns

2021-05-25 Thread Bradley Smith via Phabricator via cfe-commits
bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, joechrisellis, sdesmalen. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D103081: RetainCountChecker: Disable reference counting for OSMetaClass.

2021-05-25 Thread Georgeta Igna via Phabricator via cfe-commits
georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103081 Files: clang/lib/Analysis/RetainSummaryManager.cpp

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

2021-05-25 Thread ksyx via Phabricator via cfe-commits
ksyx updated this revision to Diff 347637. ksyx added a comment. fix: indent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102839/new/ https://reviews.llvm.org/D102839 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

2021-05-25 Thread lin.sun via Phabricator via cfe-commits
sunlin created this revision. Herald added subscribers: kristof.beyls, mgorny. sunlin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copy the arm_*.h files only "ARM" is in build targets. Repository: rG LLVM Github Monorepo

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

2021-05-25 Thread Momchil Velikov via Phabricator via cfe-commits
chill updated this revision to Diff 347631. chill added a comment. This revision is now accepted and ready to land. Updated a test to run for `x86_64-linux` instead of `%itanium_abi_triple`, to avoid having invalid syntax for MACH-O sections. The patch itself does not care about section

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

2021-05-25 Thread Marco Elver via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG280333021e95: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute (authored by melver). Repository: rG LLVM Github Monorepo

[PATCH] D102927: [NFC][CodeGenOptions] Refactor checking SanitizeCoverage options

2021-05-25 Thread Marco Elver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca6df734069a: [NFC][CodeGenOptions] Refactor checking SanitizeCoverage options (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102929: [NFC][SanitizeCoverage] Test always_inline functions work

2021-05-25 Thread Marco Elver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG85feebf5a340: [NFC][SanitizeCoverage] Test always_inline functions work (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102929/new/

[clang] 2803330 - [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

2021-05-25 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2021-05-25T12:57:14+02:00 New Revision: 280333021e9550d80f5c1152a34e33e81df1e178 URL: https://github.com/llvm/llvm-project/commit/280333021e9550d80f5c1152a34e33e81df1e178 DIFF: https://github.com/llvm/llvm-project/commit/280333021e9550d80f5c1152a34e33e81df1e178.diff

[clang] 85feebf - [NFC][SanitizeCoverage] Test always_inline functions work

2021-05-25 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2021-05-25T12:57:14+02:00 New Revision: 85feebf5a3401eab4c71288e2dc089faf547ab4c URL: https://github.com/llvm/llvm-project/commit/85feebf5a3401eab4c71288e2dc089faf547ab4c DIFF: https://github.com/llvm/llvm-project/commit/85feebf5a3401eab4c71288e2dc089faf547ab4c.diff

[clang] ca6df73 - [NFC][CodeGenOptions] Refactor checking SanitizeCoverage options

2021-05-25 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2021-05-25T12:57:14+02:00 New Revision: ca6df734069ae590d1632e920ceba03bea317549 URL: https://github.com/llvm/llvm-project/commit/ca6df734069ae590d1632e920ceba03bea317549 DIFF: https://github.com/llvm/llvm-project/commit/ca6df734069ae590d1632e920ceba03bea317549.diff

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

2021-05-25 Thread ksyx via Phabricator via cfe-commits
ksyx updated this revision to Diff 347603. ksyx marked 2 inline comments as done. ksyx retitled this revision from "[RISCV][Clang] Add -mno-idiv option to disable hardware int division" to "[RISCV][Clang] Add -mno-div option to disable hardware int division". ksyx edited the summary of this

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-25 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan added a comment. dblaikie, do you know if there's a way to do it outside of arc? (for reasons, I've not got arc to work from inside work). I tried not setting a reviewer, but then that got autofilled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

2021-05-25 Thread Jano Simas via Phabricator via cfe-commits
janosimas updated this revision to Diff 347622. janosimas added a comment. Fix test issue. Use correct clang-tidy flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 Files:

[PATCH] D102761: [clangd] New ParsingCallback for semantics changes

2021-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. > It seems like a lit test for this would be terrible. A ClangdServer one > should be possible, but I can't quite wrap my head around how to write it. > (Delivering the PreambleData as a param would make the test easier, you could > assert that the preamble version was

[PATCH] D102761: [clangd] New ParsingCallback for semantics changes

2021-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 347621. kadircet marked an inline comment as done. kadircet added a comment. - s/onSemanticsMaybeChanged/onPreamblePublished Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102761/new/

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

2021-05-25 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. @effective-light just FYI, if you are interested in improving fast-math flags handling during matrix lowering on the LLVM side, there's https://bugs.llvm.org/show_bug.cgi?id=49738 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102761: [clangd] New ParsingCallback for semantics changes

2021-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It seems like a lit test for this would be terrible. A ClangdServer one should be possible, but I can't quite wrap my head around how to write it. (Delivering the PreambleData as a

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

2021-05-25 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I've decided to land this without the test. Thank you for your contribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 ___

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

2021-05-25 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. Thanks, I'll have a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

2021-05-25 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Herald added a subscriber: foad. Looks like this is causing an infinite loop in instcombine: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34661 Reproducer test case: https://oss-fuzz.com/download?testcase_id=6383789942112256 , hangs with `opt -instcombine`,

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

2021-05-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Apologies for the slow reply, it was a long weekend here. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3314 if (getLangOpts().CPlusPlus && Tok.is(tok::identifier)) { -VirtSpecifiers::Specifier Specifier = isCXX11VirtSpecifier(Tok); -

[clang] d59b4ac - [analyzer][ctu] Reland "Avoid parsing invocation list again and again..

2021-05-25 Thread Balazs Benics via cfe-commits
Author: Ella Ma Date: 2021-05-25T09:44:13+02:00 New Revision: d59b4acf80d59c461decd41400988febaf0af8ca URL: https://github.com/llvm/llvm-project/commit/d59b4acf80d59c461decd41400988febaf0af8ca DIFF: https://github.com/llvm/llvm-project/commit/d59b4acf80d59c461decd41400988febaf0af8ca.diff LOG:

[clang] f05b70c - Revert "[analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU"

2021-05-25 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2021-05-25T09:29:56+02:00 New Revision: f05b70c23687fdf3de349ab1dd99ad79c4c40e85 URL: https://github.com/llvm/llvm-project/commit/f05b70c23687fdf3de349ab1dd99ad79c4c40e85 DIFF: https://github.com/llvm/llvm-project/commit/f05b70c23687fdf3de349ab1dd99ad79c4c40e85.diff

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

2021-05-25 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdb8af0f21dc9: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand… (authored by OikawaKirie, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] db8af0f - [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

2021-05-25 Thread Balazs Benics via cfe-commits
Author: Ella Ma Date: 2021-05-25T09:19:14+02:00 New Revision: db8af0f21dc9aad4d336754c857c24470afe53e3 URL: https://github.com/llvm/llvm-project/commit/db8af0f21dc9aad4d336754c857c24470afe53e3 DIFF: https://github.com/llvm/llvm-project/commit/db8af0f21dc9aad4d336754c857c24470afe53e3.diff LOG:

[PATCH] D102989: Align documentation in Format.h and ClangFormatStyleOptions.rst for EmptyLineAfterAccessModifier

2021-05-25 Thread Max Sagebaum via Phabricator via cfe-commits
Max_S added a comment. I added the setting in the title. Could you please land this for me. Thank. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102989/new/ https://reviews.llvm.org/D102989 ___

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

2021-05-25 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:2 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple x86_64-linux-gnu -target-feature -x87 +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 +// RUN: %clang_cc1