[PATCH] D87981: [X86] AMX programming model.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4675 } +case Intrinsic::x86_tilestored64_internal: { + unsigned Opc = X86::PTILESTOREDV; yubing wrote: > It seems there should be a check here, according to

[clang] 285dd08 - [Driver] Delete -fsanitize-coverage-blocklist= in favor of -fsanitize-coverage-ignorelist=

Author: Fangrui Song Date: 2021-06-15T20:32:24-07:00 New Revision: 285dd08b56215840d721961add4a355b60d673a7 URL: https://github.com/llvm/llvm-project/commit/285dd08b56215840d721961add4a355b60d673a7 DIFF: https://github.com/llvm/llvm-project/commit/285dd08b56215840d721961add4a355b60d673a7.diff

[clang] 4590b40 - [Debug-Info] guard DW_LANG_C_plus_plus_14 under strict dwarf

Author: Chen Zheng Date: 2021-06-16T03:17:56Z New Revision: 4590b406c02e4e6803d2644195dbb78bc09c25c7 URL: https://github.com/llvm/llvm-project/commit/4590b406c02e4e6803d2644195dbb78bc09c25c7 DIFF: https://github.com/llvm/llvm-project/commit/4590b406c02e4e6803d2644195dbb78bc09c25c7.diff LOG:

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai updated this revision to Diff 352326. vsapsai added a comment. Split out smaller parts as separate reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 Files:

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

vsapsai added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:444-447 void MarkFileIncludeOnce(const FileEntry *File) { HeaderFileInfo = getFileInfo(File); -FI.isImport = true; FI.isPragmaOnce = true; This affects the result

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s +//

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, bruno. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. There is a separate field `isPragmaOnce` and when `isImport` combines both, it complicates HeaderFileInfo

[PATCH] D104350: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

vsapsai created this revision. vsapsai added a reviewer: dexonsmith. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104350 Files:

[PATCH] D104348: [index] Fix performance regression with indexing macros

benlangmuir created this revision. benlangmuir added a reviewer: arphaman. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using FileIndexRecord with macros, symbol references can be seen out of source order, which was

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

vitalybuka added a comment. In D101832#2820465 , @MaskRay wrote: > In D101832#2736636 , @MaskRay wrote: > >> I think @vitalybuka has concrete suggestion on the naming. > > If ignorelist is used, I can delete

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

aganea added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s +//

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} mcgrathr wrote: > I think you'll eventually need to make this

[PATCH] D87981: [X86] AMX programming model.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4675 } +case Intrinsic::x86_tilestored64_internal: { + unsigned Opc = X86::PTILESTOREDV; It seems there should be a check here, according to line4575: ``` if

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Any comments? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2819871 , @ychen wrote: > - Merge D102145 by @ChuanqiXu's request. Thanks a lot. Could you add me as a reviewer? So that I can see this patch in my main page. Repository: rG

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we are using `HeaderSearch` state from building a module and if an invisible submodule imports a

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

vitalybuka added inline comments. Comment at: clang/docs/AddressSanitizer.rst:19 +* Enable ``runtime`` with: ``ASAN_OPTIONS=detect_stack_use_after_return=1`` +* Use-after-scope (clang flag ``-fsanitize-address-use-after-scope``) * Double-free, invalid free

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. what're the rules about module level attributes like this? For instance: Does this affect/hinder inlining (if the attributes don't match between the caller and callee)? Other situations that might matter? Comment at:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. @rjmccall Added some tests covering these semantics: clang/test/SemaObjCXX/block-capture.mm and also some extra documentation to checkEscapingByref. Not sure if I got the terminology right here.. @Quuxplusone any other interesting corner cases for these new tests?

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!!

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: qcolombet, dblaikie. Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352299. andrewjcg added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > Assuming I'm answering the correct question that the returns_nonnull is > preserved through a PCH, the answer is yes. Thanks! > As mentioned this isn't strictly needed and the BE can elide

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

bruno added subscribers: jansvoboda11, vsapsai, dexonsmith. bruno added a comment. Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side? Comment at: clang/lib/Lex/HeaderSearch.cpp:445 +return None;

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda added a comment. F17415480: _usr_local_google_home_kda_src_uar_llvm-project_build_tools_clang_docs_html_AddressSanitizer.html.png Comment at: clang/docs/AddressSanitizer.rst:18 +* Use-after-return (clang flag

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352289. kda marked 2 inline comments as done. kda added a comment. - more consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352287. kda marked 2 inline comments as done. kda added a comment. - more beauty, added UsersManual changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1401-1402 + +// FIXME: This case in particular is resulting in failed assertion. +Range First = Range(Tmin, Max); +Range Second = Range(Min, Tmax); I

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 352283. manas edited the summary of this revision. manas added a comment. Herald added a subscriber: martong. Add logic for computing rangeset for an expression containing BO_Add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} I think you'll eventually need to make this an `#if` or `if

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse vitalybuka wrote: > leonardchan wrote: >

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 352271. mizvekov added a comment. -bugs +tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

MaskRay added a comment. Herald added a subscriber: ormris. In D101832#2736636 , @MaskRay wrote: > I think @vitalybuka has concrete suggestion on the naming. If ignorelist is used, I can delete `-fsanitize-coverage-blocklist=` Repository: rG LLVM

[clang] bddef53 - [docs] Exclude FlangOption and re-generate ClangCommandLineReference.rst

Author: Fangrui Song Date: 2021-06-15T15:22:07-07:00 New Revision: bddef537776e15fa21e2ec11a4b2543d6d91fedc URL: https://github.com/llvm/llvm-project/commit/bddef537776e15fa21e2ec11a4b2543d6d91fedc DIFF: https://github.com/llvm/llvm-project/commit/bddef537776e15fa21e2ec11a4b2543d6d91fedc.diff

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse leonardchan wrote: > leonardchan wrote:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 352268. ggeorgakoudis added a comment. Update non-remark tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#2819869 , @lebedev.ri wrote: > (This is not offload-specific, right?) > This does not bring any compatibility issues, right? It's not offload-specific, so the patch applies to host OpenMP too. The patch, as

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

vitalybuka added a subscriber: rsmith. vitalybuka added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3 --- NOTE: This file is automatically generated by running clang-tblgen

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. In D98799#2820198 , @ahatanak wrote: > There are several files other than CGBlocks.cpp in which > `FunctionDecl::Create` is called to create fake FunctionDecls. Do those > places have to be fixed too? This issue in this

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers added inline comments. Comment at: llvm/test/Linker/warn-stack-frame.ll:6 + +; CHECK-MISMATCH: error: linking module flags 'warn-stack-size': IDs have conflicting values + dblaikie wrote: > If you like, you could make this a function attribute

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 352240. quinnp added a comment. Changed the target architecture of tests to follow the convention: BE-pwr7 LE-pwr8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:158 break; } +return (OpName + "(\"" + Id + "\")").str(); gribozavr2 wrote: > Please use spaces instead of tabs (throughout the patch). I think those markers

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

ymandel updated this revision to Diff 352237. ymandel added a comment. try to fix tabs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104317/new/ https://reviews.llvm.org/D104317 Files: clang/lib/Tooling/Transformer/Stencil.cpp Index:

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

rsmith added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:125 + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1; + This is per-declaration state; I don't think

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx marked an inline comment as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 352236. flx added a comment. Remove now unnecessary FunctionDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files:

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski updated this revision to Diff 352234. awarzynski added a comment. Add missing test (forgot to add when making the submission) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 Files:

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 352233. flx marked an inline comment as done. flx added a comment. Directly examine initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. Ping, I do not have commit access, can someone submit this as time permits ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

ahatanak added a comment. There are several files other than CGBlocks.cpp in which `FunctionDecl::Create` is called to create fake FunctionDecls. Do those places have to be fixed too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/

[clang] dc3bd11 - Adding the rest of the C11 papers to the status page.

Author: Aaron Ballman Date: 2021-06-15T16:13:26-04:00 New Revision: dc3bd11e5b6be7a5430b32dc8155e2435a542918 URL: https://github.com/llvm/llvm-project/commit/dc3bd11e5b6be7a5430b32dc8155e2435a542918 DIFF: https://github.com/llvm/llvm-project/commit/dc3bd11e5b6be7a5430b32dc8155e2435a542918.diff

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:158 break; } +return (OpName + "(\"" + Id + "\")").str(); Please use

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

ymandel created this revision. ymandel added a reviewer: gribozavr2. ymandel requested review of this revision. Herald added a project: clang. Currently, the implementation combines OOP and overloads, using a template to tie the two together. In practice, this has proven confusing with no

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6478ef61b1a4: [asan] Remove Asan, Ubsan support of RTEMS and Myriad (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 6478ef6 - [asan] Remove Asan, Ubsan support of RTEMS and Myriad

Author: Vitaly Buka Date: 2021-06-15T12:59:05-07:00 New Revision: 6478ef61b1a4dd86f520b199e0fd6762e8306353 URL: https://github.com/llvm/llvm-project/commit/6478ef61b1a4dd86f520b199e0fd6762e8306353 DIFF: https://github.com/llvm/llvm-project/commit/6478ef61b1a4dd86f520b199e0fd6762e8306353.diff

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

vitalybuka updated this revision to Diff 352221. vitalybuka added a comment. remove unrelated fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D104295: removes redundant test

This revision was automatically updated to reflect the committed changes. Closed by commit rGefebe76e93d5: Remove redundant test that was causing intermittent build bot failures. (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] efebe76 - Remove redundant test that was causing intermittent build bot failures.

Author: Douglas Yung Date: 2021-06-15T12:46:03-07:00 New Revision: efebe76e93d50562a0d834e39f096eac24aa3c0c URL: https://github.com/llvm/llvm-project/commit/efebe76e93d50562a0d834e39f096eac24aa3c0c DIFF: https://github.com/llvm/llvm-project/commit/efebe76e93d50562a0d834e39f096eac24aa3c0c.diff

[PATCH] D104295: removes redundant test

dyung added a comment. I'll commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104295/new/ https://reviews.llvm.org/D104295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. In D101868#2820075 , @dyung wrote: > Another +1 for it failing intermittently on the bot I watch over, > llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the > test or to remove it would be appreciated!

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added a comment. Indeed, I found another case with a regression: return iter::chain.from_iterable( [](auto&& ite) -> auto& { return ite.second; }); it's format all inline. And also another different in that case (without lambda): ASSERT_NO_THROW(

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

dyung added a comment. Another +1 for it failing intermittently on the bot I watch over, llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the test or to remove it would be appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

vitalybuka updated this revision to Diff 352215. vitalybuka added a comment. Herald added a subscriber: dexonsmith. restore few lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279 Files:

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG994bb937f020: [PowerPC] Moving defineXLCompatMacros() definition (authored by quinnp, committed by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 994bb93 - [PowerPC] Moving defineXLCompatMacros() definition

Author: Quinn Pham Date: 2021-06-15T14:25:43-05:00 New Revision: 994bb937f020a014c7039151169649a7076ca9b1 URL: https://github.com/llvm/llvm-project/commit/994bb937f020a014c7039151169649a7076ca9b1 DIFF: https://github.com/llvm/llvm-project/commit/994bb937f020a014c7039151169649a7076ca9b1.diff

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:124 - // 28 bits left in a 64-bit word. + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1;

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3302af9d4c39: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

HazardyKnusperkeks added a comment. Just asking: Would it be different if there is `auto`, `decltype(auto)`, `decltype(a+b)`, `typename` or `template` as trailing return type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 352208. nickdesaulniers added a comment. - fixup double fn attr in test as per @melver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/ https://reviews.llvm.org/D104253 Files:

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

MaskRay added a comment. For the function attributing disabling instrumentation of -fprofile-generate/-fprofile-instr-generate/-fcs-profile-generate/-fprofile-arcs, how about `no_profile`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added a comment. I have gotten rid of notes for the time being. The trouble is that, we were not figuring out whether the null-pointer de-reference was occurring due to the null value being swapped with the current pointer. We just //assumed// that. So I am guessing we would need a

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 352201. RedDocMD added a comment. Refactored common code, removed note emission Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files:

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added a comment. The current implementation of how notes are emitted in `handleSwap` is broken. Consider the following code: #include void foo() { auto ptr1 = std::unique_ptr(new int(10)); auto ptr2 = std::unique_ptr(new int(13)); ptr1.swap(ptr2); ptr1.reset();

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:217 + if (() != smartptr::getNullDereferenceBugType() || + !BR.isInteresting(FirstArgThisRegion)) +return; vsavchenko wrote: >

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D104082#2818281 , @ahatanak wrote: > C++ non-virtual thunks and global initialization functions > (`_GLOBAL__sub_I_*`) have only linkage

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan updated this revision to Diff 352194. leonardchan added a comment. Rebase and remove `__hwasan_shadow_memory_dynamic_address`. We don't need to set it anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay updated this revision to Diff 352193. MyDeveloperDay added a comment. Add support for TemplateCloser before LambdaBrace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352192. SaurabhJha added a comment. Document matrix scalar division Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352191. SaurabhJha added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc006b3e5dc3: [compiler-rt][hwasan] Add GetShadowOffset function (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 352189. ychen added a comment. - Merge D102145 by @ChuanqiXu's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

lebedev.ri added a comment. (This is not offload-specific, right?) This does not bring any compatibility issues, right? Does this bring any compatibility issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

leonardchan updated this revision to Diff 352186. leonardchan marked 2 inline comments as done. leonardchan retitled this revision from "[compiler-rt][hwasan] Add SHADOW_OFFSET macro" to "[compiler-rt][hwasan] Add GetShadowOffset function". Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Looks great! Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. Stay tuned a little, I think I spotted the problem ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 ___ cfe-commits mailing

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe52364532afb: [NewPM] Remove SpeculateAroundPHIs pass (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e523645 - [NewPM] Remove SpeculateAroundPHIs pass

Author: Roman Lebedev Date: 2021-06-15T20:35:55+03:00 New Revision: e52364532afb2748c324f360bc1cc12605d314f3 URL: https://github.com/llvm/llvm-project/commit/e52364532afb2748c324f360bc1cc12605d314f3 DIFF: https://github.com/llvm/llvm-project/commit/e52364532afb2748c324f360bc1cc12605d314f3.diff

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

lebedev.ri added a comment. I see. Going to land this now. Thanks for looking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 ___ cfe-commits mailing list

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 352178. ggeorgakoudis added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase to NewGlobalization and amend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

aeubanks accepted this revision. aeubanks added a comment. looks good, we can always revive the pass later if somebody wants it for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

lebedev.ri updated this revision to Diff 352176. lebedev.ri retitled this revision from "[NewPM] Remove SpeculateAroundPHIs pass from pipeline" to "[NewPM] Remove SpeculateAroundPHIs pass". lebedev.ri added a comment. Herald added a subscriber: mgorny. On Tue, Jun 15, 2021 at 8:14 PM Wei Mi

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. Thanks for doing this. These changes look good, but I can't get them to build successfully. I'm using the GNU 9.3 C++ compiler. My build fails to link the bin/flang-new executable. Here's an excerpt of the error messages: [4436/4439] Generating

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

waltl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:761 + // There's no libpthread or librt on Android. + if (!TC.getTriple().isAndroid()) { CmdArgs.push_back("-lpthread"); Just to be super cautious, can be keep this line

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 4:52 PM Wei Mi wrote: > > > On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li > wrote: > >> >> >> On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> lebedev.ri added a subscriber: MaskRay. >>> lebedev.ri added a

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

stella.stamenova created this revision. stella.stamenova added a reviewer: v.g.vassilev. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The library depends on Attributes.inc, so it has

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279

[PATCH] D68891: Remove unnecessary triple from test

This revision was automatically updated to reflect the committed changes. Closed by commit rGe32a92c6fe8e: Remove unnecessary triple from test (authored by JohnTitor, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D68891?vs=224680=352167#toc Repository: rG LLVM Github

[PATCH] D68891: Remove unnecessary triple from test

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing

[clang] e32a92c - Remove unnecessary triple from test

Author: Yuki Okushi Date: 2021-06-15T09:49:45-07:00 New Revision: e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed URL: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed DIFF: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed.diff

[clang] a6948da - DirectoryWatcher: close a possible window of race on Windows

Author: Saleem Abdulrasool Date: 2021-06-15T09:15:17-07:00 New Revision: a6948da86ad7e78d66b26263c2681ef6385cc234 URL: https://github.com/llvm/llvm-project/commit/a6948da86ad7e78d66b26263c2681ef6385cc234 DIFF:

  1   2   >