[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ibm128-cast.c:59 + // IEEE: %{{.+}} = fadd ppc_fp128 %{{.+}}, %{{.+}} + w + q; + // CHECK: %{{.+}} = fadd ppc_fp128 %{{.+}}, %{{.+}} It's controversial enough to consider, as

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 379918. hsmhsm marked 2 inline comments as done. hsmhsm added a comment. Rebase + minor clean-up to patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files:

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3065992 , @MaskRay wrote: > I looked at the libgcc mechanism at one time. I remember that in most cases > it just uses `PT_GNU_EH_FRAME` and these eh_frame boundary registry functions > are not needed. > Can ORC just

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos marked 4 inline comments as done. pmatos added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/externref-tableget.ll:8 + +define %externref @get_externref_from_table(i32 %i) { + %p = getelementptr [0 x %externref], [0 x %externref] addrspace (1)*

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 379917. pmatos added a comment. Herald added subscribers: cfe-commits, ormris, jdoerfert, steven_wu. Herald added a project: clang. Simplified a lot of code that required some further fixes and de-duplication. Most importantly, I added many more testcases to

[clang] 12cbc8c - [analyzer] Fix property access kind detection inside parentheses.

Author: Artem Dergachev Date: 2021-10-14T21:07:19-07:00 New Revision: 12cbc8cbf071901686b36e192a6d4da19deb6ec6 URL: https://github.com/llvm/llvm-project/commit/12cbc8cbf071901686b36e192a6d4da19deb6ec6 DIFF:

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

MaskRay added a comment. I looked at the libgcc mechanism at one time. I remember that most cases just use `PT_GNU_EH_FRAME` and these eh_frame boundary registry functions are not needed. Can ORC just use `PT_GNU_EH_FRAME`? Clang passes `--eh-frame-hdr` to ld even in `-static` mode, unlike

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu marked an inline comment as done. noajshu added inline comments. Comment at: llvm/include/llvm/Support/Caching.h:1 +//===- Caching.h - LLVM File Cache Handling Configuration -===// +// MaskRay wrote: > There needs to be a `*- C++ -*-`. >

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379912. noajshu added a comment. Add *- C++ -*- header indicator to Caching.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files:

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel created this revision. housel added a reviewer: cfe-commits. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. housel requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[clang] effbf0b - PR52183: Don't emit code for a void-typed constant expression.

Author: Richard Smith Date: 2021-10-14T20:55:51-07:00 New Revision: effbf0bdd039237542ac5e9afe1f23c9386010e2 URL: https://github.com/llvm/llvm-project/commit/effbf0bdd039237542ac5e9afe1f23c9386010e2 DIFF: https://github.com/llvm/llvm-project/commit/effbf0bdd039237542ac5e9afe1f23c9386010e2.diff

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 379907. ChuanqiXu added a comment. Herald added a subscriber: dexonsmith. Address the comments from @rsmith. It looks much better now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 Files:

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @pchaigno as @efriedma suggested, we can add some transformation in BPF target IR passes to ignore @llvm.stacksave() and @llvm.stackrestore(). I should have a patch ready soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

vsapsai created this revision. vsapsai added reviewers: Bigcheese, bnbarham. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Add a test that shows a warning is emitted when we cannot find a visible protocol and merge definition

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 6 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus added a comment. @MyDeveloperDay Thanks for the follow-up! I've rebased on latest main. Out of curiosity, as I am trying to wrap my head around the llvm workflow: Could I `arc land ...` myself once you sign off with "ready to land" even if I don't have llvm commit rights? If so,

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus updated this revision to Diff 379892. roligugus added a comment. [git-clang-format] Rebase D84375 on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

craig.topper added a comment. In D111778#3064555 , @erichkeane wrote: > In D111778#3064439 , @craig.topper > wrote: > >> In D111778#3064287 , @FreddyYe >> wrote: >>

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379882. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379881. keith marked an inline comment as done. keith added a comment. Extract fallback status logic to another function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + JDevlieghere wrote: > I'm pretty sure there was a reason we stopped doing this. There should be >

[PATCH] D111853: [NFC][Interpreter] Remove unused CompilerInvocation

roligugus created this revision. roligugus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111853 Files: clang/lib/Interpreter/Interpreter.cpp Index:

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Caching.h:1 +//===- Caching.h - LLVM File Cache Handling Configuration -===// +// There needs to be a `*- C++ -*-`. Can you check whether the

[PATCH] D111471: [NVPTX] Add a late SROA pass which allows optimizing away more allocas.

tra updated this revision to Diff 379872. tra edited the summary of this revision. tra added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

ychen added a comment. Herald added a subscriber: dang. In D58751#1417467 , @manmanren wrote: > r355333 Hello, thanks for this nice feature. Are there any docs on how to use it? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks updated this revision to Diff 379866. aeubanks added a comment. force off for the clang interpreter I thought I ran check-clang, apparently I didn't Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3063245 , @lkail wrote: > This LGTM as the start point to support int128 on AIX. We might need more > patches involving libraries in the LLVM monorepo, we can do that > progressively. Agreed (although

[clang] 675ed4c - [NFC][Interpreter] Remove unused CompilerInvocation

Author: Arthur Eubanks Date: 2021-10-14T15:17:49-07:00 New Revision: 675ed4c82df6bb53536270d900843a985ef9036e URL: https://github.com/llvm/llvm-project/commit/675ed4c82df6bb53536270d900843a985ef9036e DIFF:

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

enh added a comment. "shut up and take my money!" :-) Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) (stray tabs?) Repository: rG LLVM

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Oct 12, 2021 at 7:35 PM David Blaikie wrote: > On Mon, Oct 11, 2021 at 2:46 PM Richard Smith > wrote: > >> On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: >> >>> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >>> wrote: >>> On Mon, 13 Sept 2021 at 19:24, David Blaikie via

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111476/new/ https://reviews.llvm.org/D111476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

vsapsai added a comment. Ping. Failed tests seem to be unrelated (don't know how this change would cause "flangOmpReport.so: cannot open shared object file: No such file or directory"). If you think it would be better, can rebase and trigger new builds. Repository: rG LLVM Github Monorepo

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379830. martong added a comment. - Fix signedness mismatch assertaion and add a test case for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/ https://reviews.llvm.org/D110357 Files:

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a5f61c4f6f: [clang] Support -clear-ast-before-backend without -disable-free (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] d0a5f61 - [clang] Support -clear-ast-before-backend without -disable-free

Author: Arthur Eubanks Date: 2021-10-14T13:43:53-07:00 New Revision: d0a5f61c4f6fccec87fd5207e3fcd9502dd59854 URL: https://github.com/llvm/llvm-project/commit/d0a5f61c4f6fccec87fd5207e3fcd9502dd59854 DIFF:

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk added a comment. There are some invariants about what family of APIs TreeTransform methods should call, and I've forgotten what they are, so I'm hesitant to approve this. Test case looks good, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks updated this revision to Diff 379827. aeubanks added a comment. add more comments about the cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111767/new/ https://reviews.llvm.org/D111767 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield created this revision. mbenfield added reviewers: enh, gbiv. Herald added a reviewer: george.burgess.iv. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

mizvekov updated this revision to Diff 379810. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111830/new/ https://reviews.llvm.org/D111830 Files: clang/lib/Sema/SemaExprMember.cpp clang/test/CXX/drs/dr1xx.cpp

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl updated this revision to Diff 379806. yaxunl edited the summary of this revision. yaxunl added a comment. diagnose sanitizer args only once. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 Files:

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RecordMemberExprValidator was not looking through ElaboratedType nodes when looking for candidates which occur in base classes. Signed-off-by:

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 379807. yonghong-song added a comment. - fix clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/ https://reviews.llvm.org/D99 Files: clang/include/clang/AST/ASTContext.h

[clang] 68157fe - Fix a crash on valid consteval code.

Author: Aaron Ballman Date: 2021-10-14T15:48:10-04:00 New Revision: 68157fe15b238428d0fdbeb38c14afd5bda574da URL: https://github.com/llvm/llvm-project/commit/68157fe15b238428d0fdbeb38c14afd5bda574da DIFF: https://github.com/llvm/llvm-project/commit/68157fe15b238428d0fdbeb38c14afd5bda574da.diff

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. > I took a look and in its simplest form moving TextDiagnosticPrinter.cpp to > lib/Basic but also requires DiagnosticRender.cpp and TextDiagnostic.cpp to > also move to lib/Basic too, > > But DiagnosticRender.cpp has a dependency on lib/Edit so clang-format now > needs

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D111270#3062802 , @aeubanks wrote: > In D111270#3060484 , @dblaikie > wrote: > >> Plan is still to

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + I'm pretty sure there was a reason we stopped doing this. There should be some discussion

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecbcd058fbd: [Driver][Darwin] Use T reference instead of getToolChain().getTriple(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[clang] 8ecbcd0 - [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

Author: Frederic Cambus Date: 2021-10-14T21:30:39+02:00 New Revision: 8ecbcd058fbd552375fda614f36a1e01755c2620 URL: https://github.com/llvm/llvm-project/commit/8ecbcd058fbd552375fda614f36a1e01755c2620 DIFF:

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is strict. + CI.getHeaderSearchOpts().ModulesStrictContextHash = true; + dexonsmith wrote: > IIUC, explicit

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman closed this revision. aaron.ballman added a comment. I landed the non-pmf changes in b9941de0bfac4bad93e11dff26396e34a53e3891 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/

[clang] b9941de - Fix a rejects-valid with consteval on overloaded operators

Author: Aaron Ballman Date: 2021-10-14T14:47:29-04:00 New Revision: b9941de0bfac4bad93e11dff26396e34a53e3891 URL: https://github.com/llvm/llvm-project/commit/b9941de0bfac4bad93e11dff26396e34a53e3891 DIFF: https://github.com/llvm/llvm-project/commit/b9941de0bfac4bad93e11dff26396e34a53e3891.diff

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman updated this revision to Diff 379795. aaron.ballman added a comment. Updated the patch to add new test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/ https://reviews.llvm.org/D111817 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote: > > rsmith wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > > Was

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

dblaikie accepted this revision. dblaikie added subscribers: aaron.ballman, rsmith. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK, thanks! Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379787. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if (CodeGenOpts.ClearASTBeforeBackend) { +// The ASTContext may be unusable after this. +C.cleanup(); C.getAllocator().Reset(); dblaikie

[PATCH] D110898: Pass template parameters when printing template argument lists for function templates

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110898/new/ https://reviews.llvm.org/D110898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

efriedma added a comment. I don't think my opinion has changed here. I'm against the solution proposed in this patch. The other solutions discussed in the review seem fine. (The simplest is just to make the bpf backend ignore stacksave/stackrestore calls.) Repository: rG LLVM Github

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 379772. yonghong-song retitled this revision from "[POC][BTF] support btf_type_tag attribute" to "[Clang][LLVM][Attr] support btf_type_tag attribute". yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added

[clang] f7a3214 - [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

Author: Frederic Cambus Date: 2021-10-14T19:43:59+02:00 New Revision: f7a3214306cb83c350a89e2247f67983dbd792ea URL: https://github.com/llvm/llvm-project/commit/f7a3214306cb83c350a89e2247f67983dbd792ea DIFF:

[PATCH] D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a3214306cb: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111793/new/ https://reviews.llvm.org/D111793

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } erichkeane wrote: > rsmith wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Was this one missed too? > > > I

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } rsmith wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Was this one missed too? > > I

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote:

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:13800 ExprResult R = MaybeBindToTemporary(TheCall); if (R.isInvalid()) erichkeane wrote: > Wonder if as a 'while we're here' we should make this the same as the

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane added a comment. This seems like two places this was missed in: https://reviews.llvm.org/D63960 however I see a another place grepping around we might have missed too? Can you find a way to write tests for that? Also, perhaps 1 more cleanup? Comment at:

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3062608 , @vsapsai wrote: > I can be wrong but I like writing less data as it can result in savings for > more projects. For example, if compile time is dominated by method > deserialization and not by

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); erichkeane wrote: > so the only real change here is that `ExitFunctionBodyRAII` ends here, > instead of the end of the function?

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

erichkeane added a comment. In D111778#3064439 , @craig.topper wrote: > In D111778#3064287 , @FreddyYe > wrote: > >> In D111778#3063891 , @erichkeane >> wrote: >> >>>

[PATCH] D111708: [libTooling] Add "switch"-like Stencil combinator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c218d4fdb7: [libTooling] Add switch-like Stencil combinator (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b6c218d - [libTooling] Add "switch"-like Stencil combinator

Author: Yitzhak Mandelbaum Date: 2021-10-14T16:45:37Z New Revision: b6c218d4fdb74c0ee467e078721438c3396dc599 URL: https://github.com/llvm/llvm-project/commit/b6c218d4fdb74c0ee467e078721438c3396dc599 DIFF: https://github.com/llvm/llvm-project/commit/b6c218d4fdb74c0ee467e078721438c3396dc599.diff

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. It seems that Clang 11 regressed functionality that was working in Clang 10 regarding calling a few overloaded

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f7ba572 - [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

Author: Craig Topper Date: 2021-10-14T09:25:03-07:00 New Revision: f7ba572483dd424c6235901d1c6cb3650c46b477 URL: https://github.com/llvm/llvm-project/commit/f7ba572483dd424c6235901d1c6cb3650c46b477 DIFF: https://github.com/llvm/llvm-project/commit/f7ba572483dd424c6235901d1c6cb3650c46b477.diff

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ba572483dd: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2089 else return Error(ValueExprLoc, "bad arch string " + Arch); } maybe we could have a NFC patch later to add ``` // Emit the arch string if needed. if

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:35 const Driver = ToolChain.getDriver(); + const llvm::Triple = ToolChain.getTriple(); Is there a specific reason to choose the name `T`? FWICS different drivers use

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); so the only real change here is that `ExitFunctionBodyRAII` ends here, instead of the end of the function? I guess this SEEMS

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

craig.topper added a comment. In D111778#3064287 , @FreddyYe wrote: > In D111778#3063891 , @erichkeane > wrote: > >> Supporting these types requires changes to the library so that we can check >> these, right?

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3edc5af099: [analyzer][solver] Handle simplification to ConcreteInt (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110913/new/

[clang] ac3edc5 - [analyzer][solver] Handle simplification to ConcreteInt

Author: Gabor Marton Date: 2021-10-14T17:53:29+02:00 New Revision: ac3edc5af09947210d8f8d25ddd7e42379ef6454 URL: https://github.com/llvm/llvm-project/commit/ac3edc5af09947210d8f8d25ddd7e42379ef6454 DIFF: https://github.com/llvm/llvm-project/commit/ac3edc5af09947210d8f8d25ddd7e42379ef6454.diff

[PATCH] D111815: [clang-format] [PR42014,PR52021] don't let clang-format assert/crash when file being formatted is read-only/locked

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, curdeius, HazardyKnusperkeks. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. This is a bug which gets reported from time to time and we've had multiple attempts to

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. When reaching the end of a function body, we need to ensure that the `ExitFunctionBodyRAII` object is destroyed before

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

FreddyYe added a comment. In D111778#3063891 , @erichkeane wrote: > Supporting these types requires changes to the library so that we can check > these, right? Do you have the library changes for these as well? The > constants used to check for

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. Passed internal CI, still working on a Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing list

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida updated this revision to Diff 379721. cishida added a comment. Fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111468/new/ https://reviews.llvm.org/D111468 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay added a comment. @thakis , At the back of my mind is those people who always say "Measure, Measure, Measure"... This issue still plagues us, we constantly get bugs reported that come back to this.

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the changes. Nice working pulling this into shape. LGTM Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:149 + (AArch64::AEK_BF16

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ marked an inline comment as done. mubashar_ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:86 +- Support has been added for the following processors (command-line identifiers in parentheses): + - Arm Cortex-A510 (cortex-a510)

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379717. mubashar_ marked an inline comment as done. mubashar_ added a comment. Corrected PAUTH duplication mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Ping! Does anyone have any feedback on this? I'd really like to start getting us caught up on standards implementation, and this seems like it might be an easy win (unless someone on the list knows why it is just plain wrong/more complicated than I think!).

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379713. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Added crypto and no-crypto tests for -mcpu and added new section for Arm and AArch64 support in release notes. CHANGES SINCE LAST ACTION

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#2967565 , @Anastasia wrote: > In D107769#2960441 , @svenvh wrote: > >> I have done an alternative spin of this patch: instead of introducing >> `RequireDisabledExtension`,

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. In D111443#3062139 , @eugenis wrote: > Right, but a cache for SanitizerArgs is not enough to avoid repeated > diagnostics, is it? Ex. if I request a non-existing sanitizer, I think I > would get errors from host arg parsing, as

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus created this revision. fcambus added reviewers: krytarowski, mgorny. Herald added a subscriber: fedor.sergeev. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith updated this revision to Diff 379701. bsmith added a comment. - Remove mention of 128-bit chunks from help texts - Allow any positive integer value for -mvscale-{min,max}, not just powers of 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2126-2130 + // Initiate the reorganization of the equality information. E.g., if we + // have `c + 1 == 0` then we'd like to express that `c == -1`. It makes + //

  1   2   >