[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

manojgupta added a comment. > More subjective: for most users this whole -march business is abstracted away > in build systems, so they won't have to deal with this, that's why this isn't > so much of an improvement. > If we want a better user experience set options, there are probably other

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG85914b757015: [clang] fix regression deducing pack expansion arguments introduced by D110216 (authored by mizvekov).

[clang] 85914b7 - [clang] fix regression deducing pack expansion arguments introduced by D110216

Author: Matheus Izvekov Date: 2021-11-19T03:36:20+01:00 New Revision: 85914b757015dfbc780dc254696acb95b8dc7679 URL: https://github.com/llvm/llvm-project/commit/85914b757015dfbc780dc254696acb95b8dc7679 DIFF:

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. This is good to go, sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112481/new/ https://reviews.llvm.org/D112481

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/new/ https://reviews.llvm.org/D113523 ___

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

mizvekov added a comment. Thanks for testing! I am just going to push this since it's a straightforward regression fix and Richard is on vacations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114207/new/ https://reviews.llvm.org/D114207

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

bruno added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; + }

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

cpsauer created this revision. cpsauer added a reviewer: sammccall. cpsauer created this object with visibility "All Users". Herald added subscribers: usaxena95, kadircet. cpsauer requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project:

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu added a comment. In D110215#3139809 , @aaron.ballman wrote: > In D110215#3139589 , @ChuanqiXu > wrote: > >> Change includes: >> >> - Add parent for newly created global module fragment. >> - Add a

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

lkail added a comment. Confirmed it solves our internal regressions, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114207/new/ https://reviews.llvm.org/D114207 ___ cfe-commits mailing list

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM with @Quuxplusone's opinions addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 ___ cfe-commits mailing list

[PATCH] D114212: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the type name of the thisPointertype.

flx created this revision. flx added reviewers: ymandel, courbet, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The matching did not work correctly for

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

This revision was automatically updated to reflect the committed changes. Closed by commit rG2782cb8da0b3: libfuzzer: All building libfuzzer for ARM32 (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112091/new/

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

mizvekov added a comment. In D114197#3141400 , @fwolff wrote: > Thanks for the quick review! Can you also commit it for me? You can use name > and email as in commit `738e7f1231949ec248c1d8d154783338215613d1`. Thank you! Sure np, I will give some time

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test case had been missing when the original code was introduced by 2fcb863b2b278. Signed-off-by: Matheus Izvekov Repository: rG LLVM

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); + return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 || + (Ver == 6 && Triple.isARM());

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz marked an inline comment as not done. salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:28 +/// Replace invalid characters in the identifier with '_'. +static std::string replaceInvalidChars(StringRef

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese created this revision. Bigcheese added reviewers: jansvoboda11, dexonsmith. Bigcheese added a project: clang. Bigcheese requested review of this revision. Herald added a subscriber: cfe-commits. This patch makes clang-scan-deps use the virtual path for module maps instead of the on

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:700 + /// Record code for included files. + PP_INCLUDED_FILES = 66, }; Small detail. Do you need to add the new record to `ASTWriter::WriteBlockInfoBlock`? It's not

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added a comment. Haven't checked the details of serialization/deserialization. High-level question about different serialization approaches (bitvector vs list of file ids) is in D112915 . Comment at:

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a comment. @dstenb Thanks for the confirmation! @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114034/new/ https://reviews.llvm.org/D114034

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz marked an inline comment as not done. salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:28 +/// Replace invalid characters in the identifier with '_'. +static std::string replaceInvalidChars(StringRef

[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added a comment. I think AST format for `IncludedFiles` was discussed here, so I'll continue here though the bulk of implementation is in D114095 now. Have you compared the size of resulting .pcm files when you are using a bitvector compared to a list

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

keryell added a comment. In D114025#3140192 , @Quuxplusone wrote: > I think "sanity-check" could be reasonably replaced with "smoke-test," but > (1) this PR doesn't do that, and (2) the phrase "smoke-test" is probably > //harder// to understand, It

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

aaronpuchert added a comment. In D113795#3137250 , @gribozavr2 wrote: > Sorry, here I also find the old code to be more readable. Admittedly this isn't mainly about readability but about reducing boilerplate. A large number of functions start like

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff added a comment. Thanks for the quick review! Can you also commit it for me? You can use name and email as in commit `738e7f1231949ec248c1d8d154783338215613d1`. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

aaronpuchert added a comment. In D113793#3137244 , @gribozavr2 wrote: > I find the code more readable and robust when the `check*` function checks > its applicability itself. After this refactoring, it is not so clear when > each check functions

[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! I skimmed through the original patch and couldn't understand the `RenameFcn` part, thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen closed this revision. steffenlarsen marked an inline comment as done. steffenlarsen added a comment. In D107054#3141285 , @tra wrote: > I think this patch has been obsoleted by https://reviews.llvm.org/D113249 > which has already landed. >

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/ https://reviews.llvm.org/D114197

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 13 inline comments as done. ZarkoCA added a comment. @Quuxplusone Thanks for thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388332. ZarkoCA added a comment. - Address review comments - Also rename some variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley updated this revision to Diff 388329. mattbeardsley edited the summary of this revision. mattbeardsley added a comment. Well, I've goofed. I was working in a shared fork where someone added a RenameFcn check locally (not sure we should be doing that, but that's besides the point).

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 marked an inline comment as done. jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1022 + std::string getName() const override { +return "HasOverloadedOperatorNameMatcher"; + } ymandel wrote: >

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 updated this revision to Diff 388327. jcking1034 marked 2 inline comments as done. jcking1034 added a comment. Update comments, drop "Matcher" suffix from `getName`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113917/new/

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, alexfh, whisperity, mizvekov. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, jeroen.dobbelaere, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber:

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I think this patch has been obsoleted by https://reviews.llvm.org/D113249 which has already landed. My apologies for letting the patch slip through the cracks. CHANGES SINCE LAST ACTION

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22443 + Style); +} + Quuxplusone wrote: > I'd like to see `module :private;` > I'd like to see `import ;` > I'd like to see `import foo...bar;` > I'd like to see

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114130/new/ https://reviews.llvm.org/D114130

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

bader added a comment. Herald added subscribers: carlosgalvezp, asavonic. @tra, ping. @steffenlarsen, does it make sense to add support for recently released 11.5 as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107054/new/ https://reviews.llvm.org/D107054

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

modimo updated this revision to Diff 388307. modimo added a comment. Condense lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114130/new/ https://reviews.llvm.org/D114130 Files: clang/include/clang/Driver/Options.td

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3140688 , @rjmccall wrote: > In D108479#3140638 , @samitolvanen > wrote: > >> In D108479#3133578

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

HazardyKnusperkeks added a comment. In D114142#3139756 , @MyDeveloperDay wrote: > I'm thinking that those cases are handled else where > > as S=1 on those elements (which means space required before) > > M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. The current goal seems to be achieved. I have no idea what are acceptable module names or so, I've not yet looked into them. CHANGES SINCE LAST ACTION

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl added a comment. In D113925#3141011 , @gandhi21299 wrote: > @yaxunl thanks for the review! My Github account is locked unfortunately so I > will have to ask you to push this commit to the main branch. Thank you! Sure. Repository: rG LLVM

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added a comment. @yaxunl thanks for the review! My Github account is locked unfortunately so I will have to ask you to push this commit to the main branch. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#3093323 , @aaron.ballman wrote: > In D108643#3106438 , @aaron.ballman > wrote: > >> Ping > > Ping. Ping. CHANGES SINCE LAST ACTION

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay added inline comments. Comment at: clang/docs/ClangPlugins.rst:133 +Clang plugins can receive arguments from the compiler driver command +line via the `fplugin-arg--` option. + Mention whether `` can contain `-` Comment at:

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:39 +// intercepted. +static const llvm::StringSet<> FUNCTIONS_TO_IGNORE_NAMESPACE = { +"__errno_location", "malloc", "calloc", "realloc", "free"};

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:28 +/// Replace invalid characters in the identifier with '_'. +static std::string replaceInvalidChars(StringRef Identifier) { + std::string Fixed{Identifier};

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay added a comment. Nasty, but let me take a look module: private; import ; import foo... bar; import..; module foo: private; module public : while; they all feel all kinds of wrong! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/

[PATCH] D113917: Add infrastructure to support matcher names.

ymandel added a comment. Looks good, just small comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:88 +/// can be useful for cases like debugging matchers. +template std::string makeMatcherNameFromType() { + return "Matcher"; Please

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj added a comment. ping for clang-tidy review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

thakis added a comment. > So, some notes: > > - We should probably also do an AKA on the type diff. > - Chromium should use a clearer name for that typedef perhaps? Though calling > the first template parameter of span as `T` is common, maybe a better name > here would be `element_type`. > >

[PATCH] D114173: [clang][modules] Apply local submodule visibility to includes

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai, rsmith, bruno. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, the preprocessor tracks the set of included

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3140638 , @samitolvanen wrote: > In D108479#3133578 , @rjmccall > wrote: > >> If we do need to support constant expressions of this > > Yes, we need this also in constant

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388253. jansvoboda11 added a comment. Add missed newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388251. jansvoboda11 added a comment. Apply part of Volodymyr's cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:62 +void test(NoBitfield x) { + // no-warning in this function, except for operator+. + static_assert(is_same_v);

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen marked an inline comment as done. samitolvanen added a comment. In D108479#3133578 , @rjmccall wrote: > If we do need to support constant expressions of this Yes, we need this also in constant expressions. > I think we should have the

[PATCH] D113505: [NFC][clang] Inclusive language: replace masterPort with mainPort

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a14244cc645: [NFC][clang] Inclusive language: replace masterPort with mainPort (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7a14244 - [NFC][clang] Inclusive language: replace masterPort with mainPort

Author: Quinn Pham Date: 2021-11-18T11:51:06-06:00 New Revision: 7a14244cc645bbbcbf5056e7a00fadbb339e92ed URL: https://github.com/llvm/llvm-project/commit/7a14244cc645bbbcbf5056e7a00fadbb339e92ed DIFF: https://github.com/llvm/llvm-project/commit/7a14244cc645bbbcbf5056e7a00fadbb339e92ed.diff

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

Quuxplusone added a comment. In D113898#3140320 , @kuhnel wrote: > When trying to revert some of the changes, I just noticed there are a couple > of `if (const auto* ...` in `CodeComplete.cpp` and `AST.cpp` (and maybe other > files as well). So some

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); + return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 || + (Ver == 6 && Triple.isARM());

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22443 + Style); +} + I'd like to see `module :private;` I'd like to see `import ;` I'd like to see `import foo...bar;` I'd like to see `import ..;` Is

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388242. jansvoboda11 added a comment. Rebase, add type alias, improve map allocation in `ASTReader`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:28 +/// Replace invalid characters in the identifier with '_'. +static std::string replaceInvalidChars(StringRef Identifier) { + std::string Fixed{Identifier};

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added inline comments. Comment at: clang/include/clang/AST/Redeclarable.h:261 assert(Current && "Advancing while iterator has reached end"); - // Sanity check to avoid infinite loop on invalid redecl chain. + // Validation check to avoid infinite

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:105 + has(memberExpr(hasDeclaration(fieldDecl(isBitField(, + hasParent( + binaryOperator(anyOf(hasOperatorName("<<"),

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal updated this revision to Diff 388240. steakhal marked 2 inline comments as done. steakhal edited the summary of this revision. steakhal added a comment. - added more tests - add a detailed comment about the situation we suppress - see through parenExprs CHANGES SINCE LAST ACTION

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay updated this revision to Diff 388241. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Add some more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 Files: clang/docs/ReleaseNotes.rst

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#3139684 , @martong wrote: > In D104550#3139239 , @stevewan > wrote: > >> In D104550#2849582 , @vsavchenko >> wrote: >> >>> In

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen updated this revision to Diff 388237. samitolvanen added a comment. Renamed to `__builtin_function_start`, allowed only FunctionDecls as a parameter, added support for C++ member functions, and disallowed comparisons in integral constant expressions. Repository: rG LLVM Github

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

sammccall added a comment. In D113898#3140320 , @kuhnel wrote: > When trying to revert some of the changes, I just noticed there are a couple > of `if (const auto* ...` in `CodeComplete.cpp` and `AST.cpp` (and maybe other > files as well). So some

[PATCH] D114096: [clang][lex][modules] Stop tracking number of includes

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Squashed into D114095 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114096/new/ https://reviews.llvm.org/D114096

[PATCH] D114095: [clang][lex][modules] Move number of includes from HeaderFileInfo to Preprocessor

jansvoboda11 updated this revision to Diff 388231. jansvoboda11 added a comment. Squash with D114096 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114095/new/ https://reviews.llvm.org/D114095 Files:

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 added a comment. Still a WIP, but might be get some feedback on the direction. I'm not 100% sure when to consider a search path that triggered the creation of `Module` as used. Doing so on `Module` creation is not

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added a comment. The tests in this are broken for windows, which I've fixed in 45e102a173680fd3c90def79a7f0766ed2786ff0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 45e102a - [Clang][SVE] Fix windows test breakage in 26f56438e3dab44cea4c8f16d4cb16e9424b02c6

Author: Bradley Smith Date: 2021-11-18T16:52:32Z New Revision: 45e102a173680fd3c90def79a7f0766ed2786ff0 URL: https://github.com/llvm/llvm-project/commit/45e102a173680fd3c90def79a7f0766ed2786ff0 DIFF: https://github.com/llvm/llvm-project/commit/45e102a173680fd3c90def79a7f0766ed2786ff0.diff

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Thanks for the update, I am okay with the `.cpp` file, now I continue the review with the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list

[PATCH] D113709: Don't consider `LinkageSpec` when calculating DeclContext `Encloses`

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. > We don't properly handle lookup through using declarations when there is a > linkage spec in the common chain. Pedantic note: you mean using *directives*. At some point, we should

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 388219. ASDenysPetrov added a comment. Fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:229-233 +// We want to keep the following invariant at all times: +// ---[ First --> +// -[ Second ---> +if (First->From() > Second->From()) +

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: clang/test/SemaCXX/Float16.cpp:4 +// RUN: %clang_cc1 -fsyntax-only -verify -triple armv7a-linux-gnu %s +// RUN: %clang_cc1 -fsyntax-only

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I think this makes sense to do given that you need to explicitly opt into inferred modules anyway. This isn't implicitly finding module maps, as we already have a module map with

[PATCH] D112923: [clang][deps] Reset some benign codegen options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112923/new/ https://reviews.llvm.org/D112923

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140192 , @Quuxplusone wrote: > Peanut gallery says: I'd recommend //not// taking this particular patch; it > seems much less "obvious" than the whitelist/inclusionlist type of patch. > Whereas "whitelist" is just a

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. When trying to revert some of the changes, I just noticed there are a couple of `if (const auto* ...` in `CodeComplete.cpp` and `AST.cpp` (and maybe other files as well). So some folks seem to be using this right now. If we want to be consistent, we would have to remove

[libunwind] bab3981 - [libunwind] Add an interface for dynamic .eh_frame registration

Author: Peter S. Housel Date: 2021-11-18T08:06:46-08:00 New Revision: bab39816085d715e52c2131fa249ccd10178764b URL: https://github.com/llvm/llvm-project/commit/bab39816085d715e52c2131fa249ccd10178764b DIFF:

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbab39816085d: [libunwind] Add an interface for dynamic .eh_frame registration (authored by housel). Repository: rG

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388207. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Reword comments based on suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26f56438e3da: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +… (authored by bsmith). Repository: rG LLVM Github

[clang] 26f5643 - [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

Author: Bradley Smith Date: 2021-11-18T15:52:28Z New Revision: 26f56438e3dab44cea4c8f16d4cb16e9424b02c6 URL: https://github.com/llvm/llvm-project/commit/26f56438e3dab44cea4c8f16d4cb16e9424b02c6 DIFF: https://github.com/llvm/llvm-project/commit/26f56438e3dab44cea4c8f16d4cb16e9424b02c6.diff

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > JonChesterfield

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > Here, we

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added a comment. LGTM. I will defer to @tra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >