Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-11 Thread Mandy Chung
On 10/11/18 4:54 AM, Daniel Fuchs wrote: Hi Mandy, On 10/10/2018 17:56, Mandy Chung wrote: The javadoc of SimpleFormatter::format(LogRecord) method does describe the format argument is a java.util.Formatter format string. Also the class description also links to this method.  So I think

Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-11 Thread Daniel Fuchs
Hi Mandy, On 10/10/2018 17:56, Mandy Chung wrote: The javadoc of SimpleFormatter::format(LogRecord) method does describe the format argument is a java.util.Formatter format string. Also the class description also links to this method. So I think these two broken links can simply be removed and

Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-10 Thread Mandy Chung
On 10/10/18 8:44 AM, Daniel Fuchs wrote: Hi Mandy, On 10/10/2018 16:32, Mandy Chung wrote: Alternatively, this can link to java.util.Formatter class as the text is "format string".  It seems that Formatter class fits better with the SimpleFormatter class description than String.format.

Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-10 Thread Daniel Fuchs
Hi Mandy, On 10/10/2018 16:32, Mandy Chung wrote: On 10/10/18 3:39 AM, Daniel Fuchs wrote: Hi, Please find below a doc-only fix for: 8211960: broken links in java.util.logging https://bugs.openjdk.java.net/browse/JDK-8211960 webrev:

Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-10 Thread Mandy Chung
On 10/10/18 3:39 AM, Daniel Fuchs wrote: Hi, Please find below a doc-only fix for: 8211960: broken links in java.util.logging https://bugs.openjdk.java.net/browse/JDK-8211960 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8211960/webrev.00/index.html Alternatively, this can link to

Re: RFR [12] - 8211960: broken links in java.util.logging

2018-10-10 Thread Chris Hegarty
On 10/10/18 11:39, Daniel Fuchs wrote: Hi, Please find below a doc-only fix for: 8211960: broken links in java.util.logging https://bugs.openjdk.java.net/browse/JDK-8211960 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8211960/webrev.00/index.html Looks good. -Chris.

RFR [12] - 8211960: broken links in java.util.logging

2018-10-10 Thread Daniel Fuchs
Hi, Please find below a doc-only fix for: 8211960: broken links in java.util.logging https://bugs.openjdk.java.net/browse/JDK-8211960 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8211960/webrev.00/index.html The original link was intended to refer to java.util.Formatter#syntax, which is