Re: JDK 9 RFR Update String.join sample code to use List convenience factory methods

On 5/31/16 6:31 PM, Joseph D. Darcy wrote: The String.join javadoc contains some sample code to demonstrate how to use the method. The sample code can be improved with the new-in-JDK-9 List convenience factory method. Please review this patch to update the sample code: ---

Re: JDK 9 RFR Update String.join sample code to use List convenience factory methods

looks fine joe > On May 31, 2016, at 9:31 PM, Joseph D. Darcy wrote: > > Hello, > > The String.join javadoc contains some sample code to demonstrate how to use > the method. The sample code can be improved with the new-in-JDK-9 List > convenience factory method. Please

JDK 9 RFR Update String.join sample code to use List convenience factory methods

Hello, The String.join javadoc contains some sample code to demonstrate how to use the method. The sample code can be improved with the new-in-JDK-9 List convenience factory method. Please review this patch to update the sample code: --- a/src/java.base/share/classes/java/lang/String.java

Re: handling the deprecations introduced by early access builds 116 and 118 of jdk 9

On 5/30/16 11:48 AM, Richard Hillegas wrote: Dalibor Topic recommended that I post this feedback on core-libs-dev. This is my feedback after ameliorating the deprecation warnings which surfaced when I compiled and tested Apache Derby with early access builds 116 and 118 of JDK 9. Derby is a

RFR(s): 8157777: RMI test DeadCachedConnection doesn't wait for registry to die

Hi all, Please review this small test fix to improve the reliability of an RMI test. Basically this waits for a subprocess to exit instead of proceeding immediately. webrev: http://cr.openjdk.java.net/~smarks/reviews/815/webrev.0/ bug:

Re: RFR: JDK-8157850 Jar tests should pass through VM options

Pushed. Can someone give Andrey some commit bits? On Tue, May 31, 2016 at 10:23 AM, Martin Buchholz wrote: > I approve this change. > > On Mon, May 30, 2016 at 4:59 PM, David Holmes wrote: >> On 27/05/2016 2:20 AM, Andrey Nazarov wrote: >>> >>>

Re: JDK 9 RFR of problem listing of java_sql_Timestamp.java

I think that we can fix the bug itself since the fix is trivial and already proposed by Mandy, no? On 01.06.16 1:17, Joseph D. Darcy wrote: Hello, After the push for , the test java/beans/XMLEncoder/java_sql_Timestamp.java is failing across platforms. I'd like to problem list the test

JDK 9 RFR of problem listing of java_sql_Timestamp.java

Hello, After the push for , the test java/beans/XMLEncoder/java_sql_Timestamp.java is failing across platforms. I'd like to problem list the test until the fix for JDK-8158281: "java_sql_Timestamp.java fails with AssertionError" is ready. Patch below. Thanks, -Joe ---

RFR (JAXP) 8158246: Several api/org_xml/sax/helpers/XMLReader tests failed due to no SAXException occurs

Hi, This issue was caused by the change 8152912 where the logic was changed so that the parser was directly instantiated when the className was within the DEFAULT_PACKAGE. The problem is that the className can be wrong even if it contains the DEFAULT_PACKAGE. The patch reverts the change

JDK 9 RFR of JDK-5040830: (ann) please improve toString() for annotations containing exception proxies

Hello, Some background, when everything is going well, the toString form of an annotation looks something like // Old non-erroneous annotation @DangerousAnnotation(utopia=BRIGADOON, thirtyTwoBitsAreNotEnough=42, classy=interface Fleeting, classies=[class java.lang.Object, int],

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Thanks Paul. Best to have consistent formatting. Webrev updated in place. On the beginning quote observation, I wasn't too such myself. Presumably a typo. I've removed for now. Regards, Sean. On 31/05/2016 19:48, Paul Benedict wrote: Hi Sean, I just have a few minor comments. Nearly all

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Hi Sean, I just have a few minor comments. Nearly all the new messages follow the message/colon/space/details format. There are a few missing the space between the colon and details: *) ImageHeader: "jimage header not the correct size:" *) JrtPath throw new ProviderMismatchException("path

Re: RFR 9: 8158254 : Put java/time/test/java/time/TestClock_System on the problem list for Solaris

Thanks Joe, Lance, Corrected to use solaris-all. Roger On 5/31/2016 2:16 PM, joe darcy wrote: The syntax used elsewhere in the file is "solaris-all"; I'm not sure just "solaris" would have the right semantics. +1 if "solaris-all" were used. Thanks, -Joe On 5/31/2016 11:11 AM, Lance

Re: RFR 9: 8158254 : Put java/time/test/java/time/TestClock_System on the problem list for Solaris

The syntax used elsewhere in the file is "solaris-all"; I'm not sure just "solaris" would have the right semantics. +1 if "solaris-all" were used. Thanks, -Joe On 5/31/2016 11:11 AM, Lance Andersen wrote: +1 On May 31, 2016, at 2:09 PM, Roger Riggs wrote: Please

Re: RFR 9: 8158254 : Put java/time/test/java/time/TestClock_System on the problem list for Solaris

+1 > On May 31, 2016, at 2:09 PM, Roger Riggs wrote: > > Please review this change to add a java.time test to the ProblemList.txt, > only for Solaris. > > A change[1] was tried for a more efficient way to read the current time but > it didn't work out > and had to be

RFR 9: 8158254 : Put java/time/test/java/time/TestClock_System on the problem list for Solaris

Please review this change to add a java.time test to the ProblemList.txt, only for Solaris. A change[1] was tried for a more efficient way to read the current time but it didn't work out and had to be fixed. The original change propagated to the jdk9-master but the fix [2] has not yet.

Fwd: JDK 9 r-team mtg notes, 5/26/16

> Begin forwarded message: > > From: Sandeep Konchady > Subject: Fwd: JDK 9 r-team mtg notes, 5/26/16 > Date: May 31, 2016 at 11:07:48 AM PDT > To: javase-sqe-staff_ww_grp staff > > > >> Begin forwarded message: >> >> From:

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

I've gone ahead with a trimmed down webrev as per Alan's request. new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v2/webrev/ Regards, Sean. On 16/05/2016 15:10, Alan Bateman wrote: On 16/05/2016 14:45, Seán Coffey wrote: On 16/05/16 13:51, Alan Bateman wrote: On

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

Hi Stephen, Thanks for the suggestions and the code. Regards, Nadeesh On 5/31/2016 7:15 PM, Stephen Colebourne wrote: Where the new patterns are described in Javadoc, there is no discussion of the difference between "H" and "HH". Add after "Patterns containing "HH" will format and parse a

Re: RFR: JDK-8157850 Jar tests should pass through VM options

I approve this change. On Mon, May 30, 2016 at 4:59 PM, David Holmes wrote: > On 27/05/2016 2:20 AM, Andrey Nazarov wrote: >> >> Thanks for feedback guys. >> >> I've updated review >> http://cr.openjdk.java.net/~anazarov/8157850/webrev.02/ > > > Using test.tool.vm.opts

handling the deprecations introduced by early access builds 116 and 118 of jdk 9

Dalibor Topic recommended that I post this feedback on core-libs-dev. This is my feedback after ameliorating the deprecation warnings which surfaced when I compiled and tested Apache Derby with early access builds 116 and 118 of JDK 9. Derby is a pure Java relational database whose original

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

Ulf, thanks for the suggestions! On 5/31/16 6:27 AM, Ulf Zibis wrote: Hi Sherman, 1.) wouldn't it be better to have a public getBytes() in AbstractStringBuilder? Then you could save the array copy with sb.toString() here: 178 return new ZipPath(this, sb.toString(), zc.isUTF8());

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Thanks Paul!! Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.03/ Thanks, Shilpi On 5/31/2016 7:57 PM, Paul Sandoz wrote: >"Returns an array containing Method objects reflecting all the declared methods of the class or interface represented by this Class object, including

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

> On 31 May 2016, at 14:17, shilpi.rast...@oracle.com wrote: > > Hi All, > > Please see updated webrev > http://cr.openjdk.java.net/~srastogi/8147585/webrev.02/ > I meant do something like this: static class MethodsWithAnnotations { @LambdaWithParameter public void

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

Where the new patterns are described in Javadoc, there is no discussion of the difference between "H" and "HH". Add after "Patterns containing "HH" will format and parse a two digit hour, zero-padded if necessary. Patterns containing "H" will format with no zero-padding, and parse either one or

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

Hi Sherman, 1.) wouldn't it be better to have a public getBytes() in AbstractStringBuilder? Then you could save the array copy with sb.toString() here: 178 return new ZipPath(this, sb.toString(), zc.isUTF8()); 525 return zfs.getBytes(to.toString()); You could simplify even

Re: RFR 8154189: Deprivilege java.sql and java.sql.rowset module

Hi Sean, Yes I will and add you to the watch list… Best Lance > On May 31, 2016, at 8:16 AM, Sean Mullan wrote: > > On 05/27/2016 02:10 PM, Lance Andersen wrote: >>> The change looks fine. >> Thank you >>> > >>> >It’s okay to grants AllPermission to get started. It’d

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Hi All, Please see updated webrev http://cr.openjdk.java.net/~srastogi/8147585/webrev.02/ On 5/31/2016 2:21 PM, Paul Sandoz wrote: On 31 May 2016, at 10:35, shilpi.rast...@oracle.com wrote: Thanks Paul for comments. Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.01/ Now

Re: RFR 8154189: Deprivilege java.sql and java.sql.rowset module

On 05/27/2016 02:10 PM, Lance Andersen wrote: The change looks fine. Thank you > >It’s okay to grants AllPermission to get started. It’d be nice if we could grant fine-grained permissions in the future. Agree, it is something to try and work towards. Hi Lance, Could you file a separate

Re: RFR: 8151876: (tz) Support tzdata2016d

Masayoshi, I still think the test adds value. At minimum it identifies timezones which don't have a localised string in the JRE provider. We need to start another discussion about how best to represent timezone names for newly added timezones. At the moment, short and long formats will be

RE: RFR: 8151876: (tz) Support tzdata2016d

Hi Masayoshi,   Thank you, I will delete this test before pushing the patch.     Regards, Ramanand.   From: Masayoshi Okutsu Sent: Tuesday, May 31, 2016 11:37 AM To: Ramanand Patil; Seán Coffey; i18n-...@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8151876: (tz)

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

> On 31 May 2016, at 10:35, shilpi.rast...@oracle.com wrote: > > Thanks Paul for comments. > > Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.01/ > > Now processing only public abstract methods of interface. > Thanks. It would be good to get some got feedback from those wiser

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

> On 31 May 2016, at 07:07, Xueming Shen wrote: > > Thanks Paul, > > updated accordingly. > > http://cr.openjdk.java.net/~sherman/8061777/webrev > +1 Alas it’s awkward to do the converse for constructor accepting byte[] that may or may not be utf-8 given the

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Thanks Paul for comments. Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.01/ Now processing only public abstract methods of interface. Thanks, Shilpi On 5/30/2016 6:35 PM, Paul Sandoz wrote: Hi Shilpi, You have found the right place but i am not sure your fix is entirely

RE: RFR: Implement RandomAccess spliterator

This is an interesting problem. > > for (; i < hi; ++i) { > > @SuppressWarnings("unchecked") > > E e = lst.get(i); > > action.accept(e); > > checkForComodification(mc); > > } > > return; > > For better performance ArrayList.spliterator() does not check for >

Re: RFR: 8151876: (tz) Support tzdata2016d

The CheckDisplayNames.java change is different from what I suggested and doesn't make sense. But we no longer need the test. I'd suggest CheckDisplayNames.java be removed. Otherwise, the fix looks OK to me. Masayoshi On 5/31/2016 3:03 AM, Ramanand Patil wrote: Hi Masayoshi and All, Here