Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Aleksei Voitylov
Kim, Thank you for posting this. It's an important step to make. I wanted to clarify a couple of points: 1. Since this is infrastructure JEP, is the version of JDK which will undergo such changes going to be some future version or does it apply to past versions as well? I'm concerned with

Re: Review Request: 6202130: java.util.jar.Attributes.writeMain() can't handle multi-byte chars

2018-10-04 Thread Martin Buchholz
"utf8" is a thing. "utf" is not. On Thu, Oct 4, 2018 at 12:58 PM, Philipp Kunz wrote: > Thanks to Sherman's hint, I revised the test to use the terms unicode > character and utf encoding consistently and not utf character. Affects > only the test, mostly in comments and a few identifiers. > >

Re: generated code and jigsaw modules

2018-10-04 Thread Richard Hillegas
On 10/4/18 9:45 AM, Alan Bateman wrote: On 04/10/2018 17:10, Richard Hillegas wrote: I am looking for advice about how to tighten up module encapsulation while generating byte code on the fly. I ask this question on behalf of Apache Derby, a pure-Java relational database whose original code

Re: generated code and jigsaw modules

2018-10-04 Thread Richard Hillegas
On 10/4/18 9:26 AM, Remi Forax wrote: - Mail original - De: "Richard Hillegas" À: "core-libs-dev" Envoyé: Jeudi 4 Octobre 2018 18:10:13 Objet: generated code and jigsaw modules I am looking for advice about how to tighten up module encapsulation while generating byte code on the fly.

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Kim Barrett
> On Oct 4, 2018, at 4:35 AM, Volker Simonis wrote: > > Hi Tim, Jeff, > > Kim has assembled a quite detailed list of new C++ features intended for use > in HotSpot/OpenJDK (with links to the corresponding C++ standard) > > https://bugs.openjdk.java.net/browse/JDK-8208089 Note that this list

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Kim Barrett
> On Oct 4, 2018, at 9:17 AM, Aleksei Voitylov > wrote: > > Kim, > > Thank you for posting this. It's an important step to make. I wanted to > clarify a couple of points: > > 1. Since this is infrastructure JEP, is the version of JDK which will undergo > such changes going to be some future

Re: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Kim Barrett
> On Oct 4, 2018, at 2:59 AM, Lindenmaier, Goetz > wrote: > > Hi, > > I appreciate this is handled in a JEP and well communicated! > > XLc, the compiler we use for AIX, might be a bottleneck here. > > But we currently have no compiler-constraints by products on > our aix port of jdk12 (for

Re: [12] RFR: 8211398: Square character support for the Japanese new era

2018-10-04 Thread Roger Riggs
Hi Naoto, Looks ok to me. Regards, Roger On 10/04/2018 04:30 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8211398 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8211398/webrev.00/ This change

[12] RFR: 8211398: Square character support for the Japanese new era

2018-10-04 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8211398 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8211398/webrev.00/ This change is to allow the code point (U+32FF) which will designate the square character for the

Re: Review Request: JDK-8206240: java.lang.Class.newInstance() is causing caller to leak

2018-10-04 Thread Peter Levart
Hi Mandy, On 10/04/2018 07:45 PM, Alan Bateman wrote: On 03/10/2018 18:28, Mandy Chung wrote: : On 10/3/18 9:30 AM, Peter Levart wrote: Hi Mandy, I don't know if this matters though, but should Reflection.getCallerClass() ever return null, previous behavior was to throw NPE (from

Re: Review Request: 6202130: java.util.jar.Attributes.writeMain() can't handle multi-byte chars

2018-10-04 Thread Philipp Kunz
Thanks to Sherman's hint, I revised the test to use the terms unicode character and utf encoding consistently and not utf character. Affects only the test, mostly in comments and a few identifiers. Philipp On Wed, 2018-10-03 at 12:48 -0700, Xueming Shen wrote: > +1 > > only nit is it might be

Re: Review Request: JDK-8206240: java.lang.Class.newInstance() is causing caller to leak

2018-10-04 Thread Alan Bateman
On 03/10/2018 18:28, Mandy Chung wrote: : On 10/3/18 9:30 AM, Peter Levart wrote: Hi Mandy, I don't know if this matters though, but should Reflection.getCallerClass() ever return null, previous behavior was to throw NPE (from Reflection.verifyMemberAccess(...)), now the checks are

Re: generated code and jigsaw modules

2018-10-04 Thread Alan Bateman
On 04/10/2018 17:10, Richard Hillegas wrote: I am looking for advice about how to tighten up module encapsulation while generating byte code on the fly. I ask this question on behalf of Apache Derby, a pure-Java relational database whose original code dates back to Java 1.2. I want to reduce

Re: generated code and jigsaw modules

2018-10-04 Thread Remi Forax
- Mail original - > De: "Richard Hillegas" > À: "core-libs-dev" > Envoyé: Jeudi 4 Octobre 2018 18:10:13 > Objet: generated code and jigsaw modules > I am looking for advice about how to tighten up module encapsulation > while generating byte code on the fly. I ask this question on

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

2018-10-04 Thread raffaello . giulietti
On 2018-10-04 15:28, Ulf Adams wrote: > On Thu, Sep 27, 2018 at 5:37 PM Raffaello Giulietti > mailto:raffaello.giulie...@gmail.com>> > wrote: > > Hi Ulf, > > > On 2018-09-27 16:40, Ulf Adams wrote: > > Hi Raffaello, > > > > I am the author of a recent publication on double

generated code and jigsaw modules

2018-10-04 Thread Richard Hillegas
I am looking for advice about how to tighten up module encapsulation while generating byte code on the fly. I ask this question on behalf of Apache Derby, a pure-Java relational database whose original code dates back to Java 1.2. I want to reduce Derby's attack-surface when running with a

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

2018-10-04 Thread raffaello . giulietti
On 2018-10-03 11:12, Andrew Dinn wrote: > On 02/10/18 19:17, Martin Buchholz wrote: >> Raffaello and Ulf should talk. >> It seems like Ulf's ryu project is trying to solve the same problem. >> ryu is also still being worked on, but there is already a published paper >> and ryu is being adopted by

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

2018-10-04 Thread raffaello . giulietti
Hi, On 2018-10-02 20:17, Martin Buchholz wrote: > Raffaello and Ulf should talk. I work on this project in my spare time, which is limited and not entirely devoted to programming for the OpenJDK, of course ;-) Starting this weekend, I'll try to recollect my notes and organize them in paper or

RFR 8207690: SearchPath API for classpath and similar path strings

2018-10-04 Thread Roger Riggs
Please review a revised API for parsing search and using paths. Thanks for the earlier comments and suggestions. java.util.SearchPath is an immutable sequence of strings, typically filesystem paths. A search path is created from a list of strings or by  splitting a string using

Re: Fwd: Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-04 Thread David Lloyd
On Wed, Oct 3, 2018 at 7:53 PM Sergey Bylokhov wrote: > Hi, Sean. > One question related to SecurityManager and performance, is it possible > to provide a special version of AccessController.doPrivileged which will > be noop if SecurityManager is not present? TBH that method (at least, the

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

2018-10-04 Thread Ulf Adams
On Thu, Sep 27, 2018 at 5:37 PM Raffaello Giulietti < raffaello.giulie...@gmail.com> wrote: > Hi Ulf, > > > On 2018-09-27 16:40, Ulf Adams wrote: > > Hi Raffaello, > > > > I am the author of a recent publication on double to string conversion > > [1] - the Ryu algorithm. I've been aware of the

Re: Fwd: Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-04 Thread Sean Mullan
On 10/3/18 8:52 PM, Sergey Bylokhov wrote: Hi, Sean. One question related to SecurityManager and performance, is it possible to provide a special version of AccessController.doPrivileged which will be noop if SecurityManager is not present? Yes, it may be possible, and we have prototyped it.

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Magnus Ihse Bursie
> 4 okt. 2018 kl. 10:57 skrev Martijn Verburg : > > Hi Kim, > > I like this initiative. I'm wondering if some of these rules can be easily > codified or written into a jcheck style checker (ccheck?) so that Authors > can adhere to the conventions and not rely on a Human review to pick out >

JarFile constructor throws undocumented exception (only) on Windows OS

2018-10-04 Thread Jaikiran Pai
Please consider the following trivial code: import java.util.jar.*; import java.io.*; public class JarFileTest {     public static void main(final String[] args) throws Exception {         final String tmpDir = System.getProperty("java.io.tmpdir");         try {             final JarFile jarFile

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Martijn Verburg
Hi Kim, I like this initiative. I'm wondering if some of these rules can be easily codified or written into a jcheck style checker (ccheck?) so that Authors can adhere to the conventions and not rely on a Human review to pick out where that convention isn't met. Cheers, Martijn On Wed, 3 Oct

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Volker Simonis
Hi Tim, Jeff, Kim has assembled a quite detailed list of new C++ features intended for use in HotSpot/OpenJDK (with links to the corresponding C++ standard) https://bugs.openjdk.java.net/browse/JDK-8208089 Could you please provide a summary of which of these features are already available since

RE: JEP JDK-8208089: Implement C++14 Language Features

2018-10-04 Thread Lindenmaier, Goetz
Hi, I appreciate this is handled in a JEP and well communicated! XLc, the compiler we use for AIX, might be a bottleneck here. But we currently have no compiler-constraints by products on our aix port of jdk12 (for jdk11 we must stay with the current compiler xlc 12 which does not support