On Tue, 29 Nov 2022 19:39:02 GMT, Aleksey Shipilev wrote:
> [JDK-8271820](https://bugs.openjdk.org/browse/JDK-8271820) introduced the
> `@Stable private Boolean callerSensitive;` cache in `Method`. That field is
> essentially a tri-state `Boolean` that relies on its `null` value to serve as
>
On Fri, 2 Dec 2022 02:01:57 GMT, Jie Fu wrote:
> Hi all,
>
> The following 3 tests fail with debug VMs due to lack of @enablePreview after
> JDK-8297215.
>
>
> * jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
> * jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
>
On Fri, 2 Dec 2022 02:01:57 GMT, Jie Fu wrote:
> Hi all,
>
> The following 3 tests fail with debug VMs due to lack of @enablePreview after
> JDK-8297215.
>
>
> * jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
> * jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
>
On Fri, 2 Dec 2022 05:16:14 GMT, Joe Darcy wrote:
> (Failures seen in subsequent testing in Oracle.)
Thanks @jddarcy for your review.
-
PR: https://git.openjdk.org/jdk/pull/11469
On Fri, 2 Dec 2022 02:01:57 GMT, Jie Fu wrote:
> Hi all,
>
> The following 3 tests fail with debug VMs due to lack of @enablePreview after
> JDK-8297215.
>
>
> * jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
> * jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
>
On Fri, 2 Dec 2022 02:19:49 GMT, Joe Darcy wrote:
> How are you running the tests? They pass on Oracle-internal tier 1 to 3
> testing.
Just run with
Ben="java/lang/Thread/virtual/stress/GetStackTraceALot.java
java/lang/Thread/virtual/HoldsLock.java jdk/internal/vm/Continuation/Basic.java"
On Fri, 2 Dec 2022 02:01:57 GMT, Jie Fu wrote:
> Hi all,
>
> The following 3 tests fail with debug VMs due to lack of @enablePreview after
> JDK-8297215.
>
>
> * jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
> * jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
>
Hi all,
The following 3 tests fail with debug VMs due to lack of @enablePreview after
JDK-8297215.
* jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
* jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
* jtreg:test/jdk/jdk/internal/vm/Continuation/Basic.java
Let's
On Wed, 30 Nov 2022 18:07:07 GMT, Andrew John Hughes wrote:
> Update to the latest tzdata, 2022g.
>
> Primary changes:
> * `America/Ojinaga` (CST) is split, creating `America/Ciudad_Juarez` (MST/MDT)
> * `America/Pangnirtung` becomes a link to `America/Iqaluit`
> * `America/Ojinaga` gains DST
On Thu, 1 Dec 2022 19:30:29 GMT, Naoto Sato wrote:
>> What's the expected behavior?
>
> I confirmed that the standalone `keytool` did not echo the input, which
> should be OK for this IMO.
If the console cannot be used anyway inside jshell, then this is good enough.
-
PR:
On Wed, 30 Nov 2022 18:48:30 GMT, Liam Miller-Cushon wrote:
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
This pull
On Thu, 1 Dec 2022 17:53:02 GMT, Maurizio Cimadamore
wrote:
>> Yes, I mean the layout of the underlying value that is being accessed. i.e.
>> can't access a boolean as an int.
>>
>> The behavior is undefined either way. Even when a VaList is created from
>> Java, we create the same
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
On Thu, 1 Dec 2022 19:37:28 GMT, Jonathan Gibbons wrote:
>> src/java.base/share/classes/java/lang/Character.java line 172:
>>
>>> 170: * occur. For example, in a future release, synchronization may fail.
>>> 171: *
>>> 172: * @spec https://www.unicode.org/reports/tr27 Unicode 3.1.0
>>
>>
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
On 11/28/22 3:27 PM, Phil Race wrote:
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
Please review a "somewhat automated" change to insert `@spec` tags into doc
comments, as appropriate, to leverage the recent new javadoc feature to generate a new
page listing the references to
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote:
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
This pull request has now been integrated.
Changeset: 770ff5a8
Author:Joe Darcy
URL:
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated
On Thu, 10 Nov 2022 23:51:19 GMT, Naoto Sato wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Thu, 1 Dec 2022 19:19:01 GMT, Erik Gahlin wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> test/jdk/jdk/jfr/threading/TestDeepVirtualStackTrace.java line 46:
>
>> 44: * @modules
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed in the `@spec` tags.
>
> "Somewhat automated" means that
Mike,
Thank you for the additional info.
In general, the intent of this patch is to leverage the existing links
in the doc comments, but given that there is now an intent to update
those links as well, I have incorporated the change into the latest update.
-- Jon
On 11/28/22 7:14 PM,
On Wed, 23 Nov 2022 23:04:36 GMT, Joe Wang wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove updates from unexported files
>
> src/java.xml/share/classes/javax/xml/XMLConstants.java line 35:
>
>> 33: *
On Thu, 1 Dec 2022 18:53:38 GMT, Joe Darcy wrote:
>> Usual start-of-release updates. Symbol updates in initial version reflect
>> JDK 20 build 21.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated
On Thu, 1 Dec 2022 17:53:58 GMT, Weijun Wang wrote:
>> I can still see the password on screen. Here `in` is a
>> `jdk.jshell.execution.Util` so the updated check on line 58 above failed.
>>
>> $ jshell -C--add-exports -Cjava.base/sun.security.tools.keytool=ALL-UNNAMED
>> -R--add-exports
On Thu, 1 Dec 2022 18:00:11 GMT, Joe Darcy wrote:
>> Similar to an update recently done for langtools tests, update the libraries
>> regression tests to take advantage of the @enablePreview jtreg feature.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request
Are there any opinions about whether or not to extend NMT across the JDK?
This blocks https://bugs.openjdk.org/browse/JDK-8296360, and I had a PR
prepared as https://github.com/openjdk/jdk/pull/10988. Originally I was
hoping to get this into JDK 20, but I don't think that is realistic
anymore. I
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Feedback from reviewers
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new:
On Wed, 30 Nov 2022 21:47:47 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/share/prims/jvm.cpp line 1385:
>
>> 1383: vframeStream vfst(thread);
>> 1384: for(;
On Thu, 1 Dec 2022 17:00:02 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
> A small clarification of the VaList spec to say that attempts to access
> elements through an incorrect memory layout result in undefined behavior.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Feedback from reviewers
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new:
On Wed, 30 Nov 2022 21:39:40 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/share/classfile/javaClasses.cpp line 1731:
>
>> 1729: }
>> 1730:
>> 1731: void
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
On Thu, 1 Dec 2022 17:22:49 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/VaList.java line 56:
>>
>>> 54: * Safety considerations
>>> 55: * The behavior of any attempts to access a value in the va list,
>>> whether through one of the {@code nextVarg} overloads
>>>
On Thu, 1 Dec 2022 16:08:39 GMT, Weijun Wang wrote:
>> Sure. Trying out now...
>
> I can still see the password on screen. Here `in` is a
> `jdk.jshell.execution.Util` so the updated check on line 58 above failed.
>
> $ jshell -C--add-exports -Cjava.base/sun.security.tools.keytool=ALL-UNNAMED
On Thu, 1 Dec 2022 11:44:11 GMT, Lance Andersen wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve test
>
> test/jdk/tools/jar/ManifestDirectoryCompression.java line 81:
>
>> 79:
>> 80: @Test
>>
On Wed, 30 Nov 2022 21:34:59 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/cpu/aarch64/aarch64.ad line 3635:
>
>> 3633: }
>> 3634: } else if
On Wed, 30 Nov 2022 18:54:49 GMT, Jorn Vernee wrote:
>> A small clarification of the VaList spec to say that attempts to access
>> elements through an incorrect memory layout result in undefined behavior.
>
> Jorn Vernee has refreshed the contents of this pull request, and previous
> commits
On Thu, 1 Dec 2022 17:20:18 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>>
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
Liam Miller-Cushon has updated the pull request incrementally with one
On Thu, 1 Dec 2022 11:44:07 GMT, Lance Andersen wrote:
>> Unfortunately it's recursing on `cleanup` in the lambda, so it can't throw
>> checked exceptions without more refactoring. This is imitating the recursive
>> deletion approach in another jar test, I'm happy to swap this out if you'd
>>
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the
On Wed, 30 Nov 2022 20:48:12 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
On Thu, 1 Dec 2022 15:49:30 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/Password.java line 63:
>>
>>> 61: // readPassword returns "" if you just press ENTER with
>>> the built-in Console,
>>> 62: // to be compatible with old Password
On Thu, 1 Dec 2022 15:16:29 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Adds a test
>> - Removed JavaIOAccess.charset() which is no longer needed
>
>
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>>
On Thu, 24 Nov 2022 10:08:31 GMT, Sergey Tsypanov wrote:
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()`
> which in turn specifies the same exception thrown under the same conditions
> and the implementation does exactly the same checks. This means we can remove
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote:
>> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()`
>> which in turn specifies the same exception thrown under the same conditions
>> and the implementation does exactly the same checks. This means we can
>>
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>>
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>>
> The proposed updates for JDK 20 are:
>
> - ForkJoinPool.externalSubmit
> - ForkJoinWorkerThread.getQueuedTaskCount
>
> These methods will be used to improve the Thread.yield implementation for
> virtual threads. The range of alternatives explored include not exposing an
> API and protected
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>>
On Sun Nov 6 00:17:19 UTC 2022 Johannes Kuhn wrote:
...
In particular, I would love to see the following methods added*:
- double Double.fromUnsignedLong(long i)
- long Double.toUnsignedLong(double d)
- float Float.fromUnsignedLong(long i)
- long Float.toUnsignedLong(float f)
...
The
On Thu, 1 Dec 2022 01:29:40 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
On Thu, 1 Dec 2022 01:21:13 GMT, Liam Miller-Cushon wrote:
>> test/jdk/tools/jar/ManifestDirectoryCompression.java line 60:
>>
>>> 58: }
>>> 59: Files.delete(dir);
>>> 60: } catch (IOException e) {
>>
>> Have the method throw IOException and you do not need the
On Thu, 1 Dec 2022 09:08:11 GMT, Jan Lahoda wrote:
> The jdk.internal.javac.PreviewFeature.Feature needs to be updated to reflect
> JEP 432 and JEP 433 properly.
This pull request has now been integrated.
Changeset: fc9d419b
Author:Jan Lahoda
URL:
Hi Thomas and Carter,
I opened up a PR for this to allow more specific comments on the
implementation:
https://github.com/openjdk/jdk/pull/11449
If this discussion leads to us not wanting to proceed with the change I
will withdraw the PR.
Some more comments below.
On 2022-12-01 08:26,
On Fri, 25 Nov 2022 14:53:57 GMT, Alan Bateman wrote:
> Two (since 19) usages of Unsafe.getAndAddInt to update a static field provide
> the Class object as the base instead of the base object returned by
> Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
This pull
On Wed, 30 Nov 2022 02:19:15 GMT, Martin Buchholz wrote:
> The introduction of POOLIDS_BASE strengthens the case for renaming POOLIDS to
> POOLIDS_OFFSET for clarity - I would do that.
I checked with Doug and he suggests we leave it as is.
-
PR:
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote:
>> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()`
>> which in turn specifies the same exception thrown under the same conditions
>> and the implementation does exactly the same checks. This means we can
>>
On Thu, 1 Dec 2022 01:29:40 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
The jdk.internal.javac.PreviewFeature.Feature needs to be updated to reflect
JEP 432 and JEP 433 properly.
-
Commit messages:
- 8297928: Update jdk.internal.javac.PreviewFeature.Feature to reflect JEP 432
and JEP 433
Changes: https://git.openjdk.org/jdk/pull/11447/files
Webrev:
On Thu, 1 Dec 2022 09:08:11 GMT, Jan Lahoda wrote:
> The jdk.internal.javac.PreviewFeature.Feature needs to be updated to reflect
> JEP 432 and JEP 433 properly.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11447
On Thu, 1 Dec 2022 05:44:44 GMT, Joe Darcy wrote:
>> Similar to an update recently done for langtools tests, update the libraries
>> regression tests to take advantage of the @enablePreview jtreg feature.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()`
> which in turn specifies the same exception thrown under the same conditions
> and the implementation does exactly the same checks. This means we can remove
> the check from `String.offsetByCodePoints()` and rely on
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()`
> which in turn specifies the same exception thrown under the same conditions
> and the implementation does exactly the same checks. This means we can remove
> the check from `String.offsetByCodePoints()` and rely on
On Wed, 30 Nov 2022 20:41:47 GMT, Claes Redestad wrote:
>> Sergey Tsypanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 1 Dec 2022 05:44:44 GMT, Joe Darcy wrote:
>> Similar to an update recently done for langtools tests, update the libraries
>> regression tests to take advantage of the @enablePreview jtreg feature.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a
70 matches
Mail list logo
