Re: RFR: 8306431: File.listRoots method description should be re-examined [v10]

2023-06-07 Thread Alan Bateman
On Thu, 8 Jun 2023 04:00:31 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request with a new target

Re: RFR: 8306431: File.listRoots method description should be re-examined [v10]

2023-06-07 Thread Alan Bateman
On Thu, 8 Jun 2023 04:00:31 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request with a new target

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 03:53:06 GMT, Nagata-Haruhito wrote: >> Nagata-Haruhito has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Follow CSR description > > Thank you for your many help. I try to sync fork to solve GHA failure. >

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 03:53:06 GMT, Nagata-Haruhito wrote: >> Nagata-Haruhito has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Follow CSR description > > Thank you for your many help. I try to sync fork to solve GHA failure.

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 03:53:06 GMT, Nagata-Haruhito wrote: >> Nagata-Haruhito has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Follow CSR description > > Thank you for your many help. I try to sync fork to solve GHA failure.

Re: RFR: 8306431: File.listRoots method description should be re-examined [v10]

2023-06-07 Thread Nagata-Haruhito
> I fixed File.listRoots description. > * remove "the insertion or ejection of removable media" > * change "available" to "existing" > > Please review this change. Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Nagata-Haruhito
On Thu, 8 Jun 2023 00:54:28 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request incrementally with

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 00:54:34 GMT, Brian Burkhalter wrote: > Thank you. I have approved the PR so I think you can `/integrate` now. It needs to be `/integrate`d before I can `/sponsor` it. - PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1222383959

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

2023-06-07 Thread David Holmes
On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >>

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

2023-06-07 Thread Chen Liang
On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >>

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v11]

2023-06-07 Thread Chen Liang
> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`. > > A few implementation-detail methods in VarHandle are now documented with the > implied constraints to avoid subtle problems in the future. Changed > `IndirectVarHandle` to call `asDirect` lazily to accomodate the

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v5]

2023-06-07 Thread Chen Liang
On Thu, 8 Jun 2023 00:12:39 GMT, Paul Sandoz wrote: > Ok, yes, it's less likely now but possible a MH has been explicitly obtained > before the defining class has been intialized. In this case I still think we > can clear the table out after processing any existing entries, since > subsequent

Integrated: 8309630: Clean up tests that reference deploy modules

2023-06-07 Thread Mandy Chung
On Wed, 7 Jun 2023 19:03:31 GMT, Mandy Chung wrote: > Trivial fix. The deploy modules no longer exist. The tests are updated > not to reference them. This pull request has now been integrated. Changeset: e8a59843 Author:Mandy Chung URL:

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 00:53:18 GMT, Nagata-Haruhito wrote: > Thank you very match. I changed as follow the CSR description. Thank you. I have approved the PR so I think you can integrate now. - PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1222327170

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Nagata-Haruhito
On Wed, 7 Jun 2023 17:47:53 GMT, Brian Burkhalter wrote: >> The CSR is updated so it's focused on the two parts of the updated docs. So >> I think you can finalize. > >> I think you can finalize. > > @Nagata-Haruhito I took the liberty of finalizing the CSR. If you would make > the requested

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Brian Burkhalter
On Thu, 8 Jun 2023 00:54:28 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request incrementally with

Re: RFR: 8306431: File.listRoots method description should be re-examined [v9]

2023-06-07 Thread Nagata-Haruhito
> I fixed File.listRoots description. > * remove "the insertion or ejection of removable media" > * change "available" to "existing" > > Please review this change. Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision: Follow CSR

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v6]

2023-06-07 Thread Joe Darcy
> Time to get JDK 22 underway... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 39 commits: - Merge branch 'master' into JDK-8306584 - Merge branch 'master' into JDK-8306584 - Update wording to be consistent with

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v6]

2023-06-07 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v5]

2023-06-07 Thread Paul Sandoz
On Wed, 7 Jun 2023 22:38:29 GMT, Chen Liang wrote: > > Change only the static field var handle implementations to call `target()`, > > since it is unnecessary on the others. > > Unfortunately, I don't think there is a convenient way for VH implementations > to easily unwrap the correct VH; a

Re: RFR: 8309630: Clean up tests that reference deploy modules

2023-06-07 Thread Brent Christian
On Wed, 7 Jun 2023 19:03:31 GMT, Mandy Chung wrote: > Trivial fix. The deploy modules no longer exist. The tests are updated > not to reference them. Looks fine. - Marked as reviewed by bchristi (Reviewer). PR Review:

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v2]

2023-06-07 Thread Doug Simon
On Wed, 7 Jun 2023 22:51:48 GMT, Doug Simon wrote: >> This PR improves the startup time for libgraal by speeding up how >> `VM.savedProps` is copied into libgraal. This data structure is now >> serialized to a native buffer directly from C++ and the native buffer is >> then directly decoded

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal

2023-06-07 Thread Doug Simon
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote: > This PR improves the startup time for libgraal by speeding up how > `VM.savedProps` is copied into libgraal. This data structure is now > serialized to a native buffer directly from C++ and the native buffer is then > directly decoded by

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v2]

2023-06-07 Thread Doug Simon
> This PR improves the startup time for libgraal by speeding up how > `VM.savedProps` is copied into libgraal. This data structure is now > serialized to a native buffer directly from C++ and the native buffer is then > directly decoded by libgraal. > > ## Times > > The basic benchmarking

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v10]

2023-06-07 Thread Chen Liang
> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`. > > A few implementation-detail methods in VarHandle are now documented with the > implied constraints to avoid subtle problems in the future. Changed > `IndirectVarHandle` to call `asDirect` lazily to accomodate the

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v5]

2023-06-07 Thread Chen Liang
On Wed, 7 Jun 2023 20:26:47 GMT, Paul Sandoz wrote: > Change only the static field var handle implementations to call `target()`, > since it is unnecessary on the others. Unfortunately, I don't think there is a convenient way for VH implementations to easily unwrap the correct VH; a

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

2023-06-07 Thread Mandy Chung
> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has > been reported. Those issues were related with exception being thrown with > invalid arguments. We propose to remove the old core reflection > implementation in JDK 22. The

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 21:37:42 GMT, Jonathan Gibbons wrote: >> Sure we can; this relates to an earlier comment of yours on >> Utils.isDirectSupertype here: >> https://github.com/openjdk/jdk/pull/14357#discussion_r1222053011 > > The general criticism here is whether we should restrict in any way

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 20:48:58 GMT, Pavel Rappo wrote: >> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java >> line 673: >> >>> 671: * >>> 672: * For now a warning is issued if a doc comment inherits from >>> 673: * an indirect supertype. >> >>

Integrated: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern()

2023-06-07 Thread Raffaello Giulietti
On Wed, 7 Jun 2023 11:20:02 GMT, Raffaello Giulietti wrote: > The cached `namedGroup` field must be invalidated during an invocation of > `Matcher.usePattern()` This pull request has now been integrated. Changeset: 90027ff2 Author:Raffaello Giulietti URL:

RFR: 8305104: Remove old core reflection implementation

2023-06-07 Thread Mandy Chung
JEP 416 integrated in JDK 18 and since then, only a couple minor issues has been reported. Those issues were related with exception being thrown with invalid arguments. We propose to remove the old core reflection implementation in JDK 22. The `-Djdk.reflect.useDirectMethodHandle=false`

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 19:16:51 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 19:13:55 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 20:29:07 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v5]

2023-06-07 Thread Paul Sandoz
On Wed, 7 Jun 2023 00:10:59 GMT, Paul Sandoz wrote: >>> I believe instead of changing the guards we can change the implementation >>> of the static methods on the concrete static VHs to call `asDirect()` (lets >>> also add `@ForceInline` on `asDirect`), since `linkToStatic` will pass the >>>

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v3]

2023-06-07 Thread Roger Riggs
On Wed, 7 Jun 2023 19:14:36 GMT, Raffaello Giulietti wrote: >> The cached `namedGroup` field must be invalidated during an invocation of >> `Matcher.usePattern()` > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v3]

2023-06-07 Thread Raffaello Giulietti
> The cached `namedGroup` field must be invalidated during an invocation of > `Matcher.usePattern()` Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added descriptions to the RuntimeExceptions in the test. -

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

RFR: 8309630: Clean up tests that reference deploy modules

2023-06-07 Thread Mandy Chung
Trivial fix. The deploy modules no longer exist. The tests are updated not to reference them. - Commit messages: - 8309630: Clean up tests that reference deploy modules Changes: https://git.openjdk.org/jdk/pull/14367/files Webrev:

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v2]

2023-06-07 Thread Roger Riggs
On Wed, 7 Jun 2023 18:51:47 GMT, Raffaello Giulietti wrote: >> test/jdk/java/util/regex/NamedGroupsTests.java line 367: >> >>> 365: } >>> 366: if (!m.group("a").equals("bar")) { >>> 367: throw new RuntimeException(); >> >> Failures will be easier to resolve if

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v2]

2023-06-07 Thread Raffaello Giulietti
On Wed, 7 Jun 2023 17:51:48 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Renamed the additional test. > > test/jdk/java/util/regex/NamedGroupsTests.java line 367: > >> 365: } >>

Integrated: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Mandy Chung
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote: > `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI [v3]

2023-06-07 Thread Mandy Chung
> `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and `jdk.internal.vm.compiler.management` as they are upgradeable

Integrated: JDK-8309574: Improve core reflection tests for JEP 445

2023-06-07 Thread Joe Darcy
On Wed, 7 Jun 2023 02:45:53 GMT, Joe Darcy wrote: > Add some basic core reflections tests for unnamed classes. This pull request has now been integrated. Changeset: 4ffc8cc2 Author:Joe Darcy URL: https://git.openjdk.org/jdk/commit/4ffc8cc2169c6b34ce5d9cf0ce98125520c4495a Stats:

Re: RFR: JDK-8309574: Improve core reflection tests for JEP 445 [v2]

2023-06-07 Thread Joe Darcy
> Add some basic core reflections tests for unnamed classes. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI [v2]

2023-06-07 Thread Mandy Chung
> `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and `jdk.internal.vm.compiler.management` as they are upgradeable

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v2]

2023-06-07 Thread Roger Riggs
On Wed, 7 Jun 2023 11:51:19 GMT, Raffaello Giulietti wrote: >> The cached `namedGroup` field must be invalidated during an invocation of >> `Matcher.usePattern()` > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Brian Burkhalter
On Wed, 7 Jun 2023 17:24:15 GMT, Alan Bateman wrote: > I think you can finalize. @Nagata-Haruhito I took the liberty of finalizing the CSR. If you would make the requested changes (change "the root directory" to "a root directory") in the two classes, then we can approve it and hopefully get

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Daniel Fuchs
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote: > `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote: > `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Mandy Chung
On Wed, 7 Jun 2023 16:59:07 GMT, Alan Bateman wrote: >> `FieldSetAccessibleTest` attempts to load all JDK classes and test >> `setAccessible` on their public fields to work properly. It should filter >> the modules that directly and indirectly depend on >> `jdk.internal.vm.compiler` and

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 12:09:33 GMT, Alan Bateman wrote: >> Nagata-Haruhito has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refer review comment > > src/java.base/share/classes/java/io/File.java line 1822: > >> 1820: * that the

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 17:16:50 GMT, Mandy Chung wrote: >> test/jdk/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java line >> 314: >> >>> 312: }); >>> 313: >>> 314: Set deployModules = Set.of("javafx.deploy", >>> "jdk.deploy", "jdk.plugin", "jdk.javaws"); >>

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote: > `FieldSetAccessibleTest` attempts to load all JDK classes and test > `setAccessible` on their public fields to work properly. It should filter > the modules that directly and indirectly depend on `jdk.internal.vm.compiler` > and

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-07 Thread Naoto Sato
On Wed, 7 Jun 2023 03:37:26 GMT, SUN Guoyun wrote: >> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" >> TEST=gc/TestAllocHumongousFragment.java >> error info: >> >> Caused by: java.lang.NullPointerException: Cannot invoke >> "sun.util.locale.BaseLocale.getVariant()" because

Re: RFR: JDK-8309574: Improve core reflection tests for JEP 445

2023-06-07 Thread Mandy Chung
On Wed, 7 Jun 2023 02:45:53 GMT, Joe Darcy wrote: > Add some basic core reflections tests for unnamed classes. Marked as reviewed by mchung (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14345#pullrequestreview-1468111408

RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

2023-06-07 Thread Mandy Chung
`FieldSetAccessibleTest` attempts to load all JDK classes and test `setAccessible` on their public fields to work properly. It should filter the modules that directly and indirectly depend on `jdk.internal.vm.compiler` and `jdk.internal.vm.compiler.management` as they are upgradeable and

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still

Re: RFR: 8285368: Overhaul doc-comment inheritance

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote: > Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for

Re: RFR: 8285368: Overhaul doc-comment inheritance

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 15:27:28 GMT, Jonathan Gibbons wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >>

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll()

2023-06-07 Thread Viktor Klang
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote: > This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. @DougLea @AlanBateman I had a look as well, didn't find

Re: RFR: 8285368: Overhaul doc-comment inheritance

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote: > Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for

RFR: 8285368: Overhaul doc-comment inheritance

2023-06-07 Thread Pavel Rappo
Please review this long-awaited change to documentation inheritance. This change improves "methods comment algorithm" and introduces directed documentation inheritance. While "methods comment algorithm" -- automatic search for inheritable documentation -- has been improved, it still cannot read

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-07 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-07 Thread Chen Liang
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is

Integrated: JDK-8309219: Fix xlc17 clang 15 warnings in java.base

2023-06-07 Thread JoKern65
On Fri, 2 Jun 2023 10:08:09 GMT, JoKern65 wrote: > This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in java.base. > > Compiling on AIX with xlc17 which contains the new clang 15 frontend > shows

Re: RFR: JDK-8309219: Fix xlc17 clang 15 warnings in java.base [v3]

2023-06-07 Thread Martin Doerr
On Wed, 7 Jun 2023 11:23:26 GMT, JoKern65 wrote: >> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared >> code https://github.com/openjdk/jdk/pull/14146 >> It handles the part in java.base. >> >> Compiling on AIX with xlc17 which contains the new clang 15 frontend >>

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 11:55:57 GMT, Daniel Jeliński wrote: > That being said, the number of long-lived `BaseLocale` objects is very > limited; we only keep them in Locale, LocaleKey, and Locale.CONSTANT_LOCALES. > Unless I'm missing something, we could solve this problem by removing >

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 03:37:26 GMT, SUN Guoyun wrote: >> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" >> TEST=gc/TestAllocHumongousFragment.java >> error info: >> >> Caused by: java.lang.NullPointerException: Cannot invoke >> "sun.util.locale.BaseLocale.getVariant()" because

Integrated: 8308445: Linker should check that capture state segment is big enough

2023-06-07 Thread Jorn Vernee
On Tue, 6 Jun 2023 16:22:41 GMT, Jorn Vernee wrote: > Fix the bug mentioned in the JBS issue. > > The implementation is updated to slice the capture state segment using the > capture state layout. This checks both that the segment is big enough, and > that it is properly aligned. > >

Integrated: 8308031: Linkers should reject unpromoted variadic parameters

2023-06-07 Thread Jorn Vernee
On Tue, 30 May 2023 17:25:35 GMT, Jorn Vernee wrote: > In C, arguments smaller than `int` are promoted to (`unsigned`) `int`, and > `float` is promoted to `double`, when being passed as variadic argument (see > e.g. >

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 08:16:19 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request incrementally with

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-07 Thread Daniel Jeliński
On Wed, 7 Jun 2023 03:37:26 GMT, SUN Guoyun wrote: >> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" >> TEST=gc/TestAllocHumongousFragment.java >> error info: >> >> Caused by: java.lang.NullPointerException: Cannot invoke >> "sun.util.locale.BaseLocale.getVariant()" because

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() [v2]

2023-06-07 Thread Raffaello Giulietti
> The cached `namedGroup` field must be invalidated during an invocation of > `Matcher.usePattern()` Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Renamed the additional test. - Changes: - all:

Re: RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern()

2023-06-07 Thread Raffaello Giulietti
On Wed, 7 Jun 2023 11:20:02 GMT, Raffaello Giulietti wrote: > The cached `namedGroup` field must be invalidated during an invocation of > `Matcher.usePattern()` Also added a test for this change. - PR Comment: https://git.openjdk.org/jdk/pull/14350#issuecomment-1580578032

RFR: 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern()

2023-06-07 Thread Raffaello Giulietti
The cached `namedGroup` field must be invalidated during an invocation of `Matcher.usePattern()` - Commit messages: - 8309515: Stale cached data from Matcher.namedGroups() after Matcher.usePattern() Changes: https://git.openjdk.org/jdk/pull/14350/files Webrev:

Re: RFR: JDK-8309219: Fix xlc17 clang 15 warnings in java.base [v3]

2023-06-07 Thread JoKern65
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in java.base. > > Compiling on AIX with xlc17 which contains the new clang 15 frontend > shows the following warnings. > > built by

Withdrawn: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes itself

2023-06-07 Thread duke
On Tue, 6 Dec 2022 14:04:44 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application > fails to

Re: RFR: 8308445: Linker should check that capture state segment is big enough [v2]

2023-06-07 Thread Maurizio Cimadamore
On Tue, 6 Jun 2023 17:24:34 GMT, Jorn Vernee wrote: >> Fix the bug mentioned in the JBS issue. >> >> The implementation is updated to slice the capture state segment using the >> capture state layout. This checks both that the segment is big enough, and >> that it is properly aligned. >> >>

Re: RFR: JDK-8309219: Fix xlc17 clang 15 warnings in java.base [v2]

2023-06-07 Thread Martin Doerr
On Wed, 7 Jun 2023 09:03:27 GMT, JoKern65 wrote: >> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared >> code https://github.com/openjdk/jdk/pull/14146 >> It handles the part in java.base. >> >> Compiling on AIX with xlc17 which contains the new clang 15 frontend >>

Re: RFR: JDK-8309219: Fix xlc17 clang 15 warnings in java.base [v2]

2023-06-07 Thread JoKern65
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in java.base. > > Compiling on AIX with xlc17 which contains the new clang 15 frontend > shows the following warnings. > > built by

Re: RFR: 8289220: Locale.forLanguageTag throws NPE due to soft ref used in locale cache being cleared [v6]

2023-06-07 Thread Andrey Turbanov
On Wed, 7 Jun 2023 03:37:26 GMT, SUN Guoyun wrote: >> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp" >> TEST=gc/TestAllocHumongousFragment.java >> error info: >> >> Caused by: java.lang.NullPointerException: Cannot invoke >> "sun.util.locale.BaseLocale.getVariant()" because

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-07 Thread Adam Sotona
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is

Re: RFR: 8306431: File.listRoots method description should be re-examined [v7]

2023-06-07 Thread Nagata-Haruhito
On Mon, 5 Jun 2023 18:04:09 GMT, Brian Burkhalter wrote: >> Nagata-Haruhito has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move SecurityException paragraph > > src/java.base/share/classes/java/io/File.java line 1821: > >> 1819: *

Re: RFR: 8306431: File.listRoots method description should be re-examined [v8]

2023-06-07 Thread Nagata-Haruhito
> I fixed File.listRoots description. > * remove "the insertion or ejection of removable media" > * change "available" to "existing" > > Please review this change. Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision: Refer review

Re: RFR: 8308286 Fix clang warnings in linux code [v4]

2023-06-07 Thread Alexey Ushakov
On Thu, 1 Jun 2023 15:01:37 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit

Integrated: 8306647: Implementation of Structured Concurrency (Preview)

2023-06-07 Thread Alan Bateman
On Thu, 11 May 2023 13:08:55 GMT, Alan Bateman wrote: > This is the implementation of: > > - JEP 453: Structured Concurrency (Preview) > - JEP 446: Scoped Values (Preview) > > For the most part, this is just moving code and tests. StructuredTaskScope > moves to j.u.concurrent as a preview

Re: RFR: 8301569: list mode of jmod and jimage cannot be used normally in turkish locale

2023-06-07 Thread Jaikiran Pai
On Wed, 31 May 2023 19:46:57 GMT, Glavo wrote: > > Hello @Glavo, I see you reopened this PR, so I'm guessing you are still > > interested in pursuing this further. Are you considering updating this PR > > to implement Alan's suggestion to do similar changes in `JImageTask.java` > > and