Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v2]

2024-06-10 Thread Joe Darcy
> Misc small doc updates and addition of `@Overrides` annotations. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional comm

Integrated: 8333828: Use value javadoc tag in java.lang.{Float, Double}

2024-06-10 Thread Joe Darcy
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote: > Use the value tag to make the javadoc for various format-related constants > more informative to readers. Currently the information is available by > following the "Constant Field Values" link. > > I'll reflow the

Re: RFR: 8333828: Use value javadoc tag in java.lang.{Float, Double} [v3]

2024-06-10 Thread Joe Darcy
> Use the value tag to make the javadoc for various format-related constants > more informative to readers. Currently the information is available by > following the "Constant Field Values" link. > > I'll reflow the paragraphs before a push. Joe Darcy has updated the p

Re: RFR: 8333828: Use value javadoc tag in java.lang.{Float, Double} [v2]

2024-06-07 Thread Joe Darcy
> Use the value tag to make the javadoc for various format-related constants > more informative to readers. Currently the information is available by > following the "Constant Field Values" link. > > I'll reflow the paragraphs before a push. Joe Darcy has updated the p

RFR: 8333828: Use value javadoc tag in java.lang.{Float, Double}

2024-06-07 Thread Joe Darcy
Use the value tag to make the javadoc for various format-related constants more informative to readers. Currently the information is available by following the "Constant Field Values" link. I'll reflow the paragraphs before a push. - Commit messages: - JDK-8333828: Use value

RFR: 8333768: Minor doc updates to java.lang.{Float, Double}

2024-06-06 Thread Joe Darcy
Misc small doc updates and addition of `@Overrides` annotations. - Commit messages: - JDK-8333768: Minor doc updates to java.lang.{Float, Double} Changes: https://git.openjdk.org/jdk/pull/19590/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19590=00 Issue:

Integrated: 8330182: Start of release updates for JDK 24

2024-06-06 Thread Joe Darcy
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote: > Get JDK 24 underway. This pull request has now been integrated. Changeset: 75dc2f85 Author: Joe Darcy Committer: Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/75dc2f8518d0adea30f7065d6732b807c0220756 Stats: 2

Re: RFR: 8330182: Start of release updates for JDK 24 [v12]

2024-06-05 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits: - Update copyright. - Updated problem list after bug fix. - Merge branch 'master' into JDK-8330188 - Merge branch 'master' into

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java

2024-06-03 Thread Joe Darcy
On Mon, 3 Jun 2024 17:26:52 GMT, Nizar Benalla wrote: > Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML

Re: RFR: 8333377: Migrate Generic Signature parsing to ClassFile API

2024-05-31 Thread Joe Darcy
On Fri, 17 May 2024 12:01:23 GMT, Chen Liang wrote: > Core reflection's generic signature parsing uses an ancient library with > outdated visitor pattern on a tree model and contains unnecessary > boilerplates. This is a duplication of ClassFile API's signature model. We > should just move to

Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base` [v2]

2024-05-31 Thread Joe Darcy
On Tue, 28 May 2024 22:31:15 GMT, Jonathan Gibbons wrote: >> With the advent of JEP 467, `///` comments may be treated as documentation >> comments, and may be subject to the recently new `javac` warning about >> "dangling doc comments" in unexpected places. >> >> In keeping with the policy

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v34]

2024-05-30 Thread Joe Darcy
On Fri, 31 May 2024 01:34:45 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8330182: Start of release updates for JDK 24 [v11]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Temporarily problem list java.lang.instrument tests until jar generation is fixed. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/fi

Re: RFR: 8332586: Avoid cloning empty arrays in java.lang.reflect.{Method,Constructor}

2024-05-30 Thread Joe Darcy
On Tue, 21 May 2024 13:49:18 GMT, jengebr wrote: > Improve `java/lang/reflect/Method.java` by eliminating needless cloning of > Class[0] instances. This cloning is intended to prevent callers from > changing array contents, but smany Methods have zero exceptions or zero > parameters, and

Re: RFR: 8330182: Start of release updates for JDK 24 [v10]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge branch 'master' into JDK-8330188 - Update symbol files for JDK 23 build 25. - Correct release year. - Merge branch 'mas

Re: RFR: 8330182: Start of release updates for JDK 24 [v9]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update symbol files for JDK 23 build 25. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-29 Thread Joe Darcy
On Fri, 24 May 2024 21:39:33 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-29 Thread Joe Darcy
On Fri, 24 May 2024 21:39:33 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8330182: Start of release updates for JDK 24 [v8]

2024-05-28 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Correct release year. - Merge branch 'master' into JDK-8330188 - Add symbol files current with JDK 23 build 24. - Merge branch 'mas

Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base` [v2]

2024-05-28 Thread Joe Darcy
On Tue, 28 May 2024 20:26:40 GMT, Naoto Sato wrote: >> As a non-standard comment, it will trigger a warning (and hence an error), >> since the prevailing standard for `java.base` is to compile with all >> warnings enabled (`-Xlint`) and no warnings found (verified by `-Werror`) >> >> The

Re: RFR: 8330182: Start of release updates for JDK 24 [v7]

2024-05-24 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add symbol files current with JDK 23 build 24. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/files - new: https://git.openjdk.org/

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v7]

2024-05-24 Thread Joe Darcy
On Fri, 10 May 2024 21:06:22 GMT, Vicente Romero wrote: >> As the core reflection code will encounter record classes compiled before >> and after the javac code generation change, if the old behavior can be >> triggered in javac using `--release $OLD`/`--source $OLD`, that would be >> helpful

Re: RFR: 8330182: Start of release updates for JDK 24 [v6]

2024-05-24 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'master' into JDK-8330188 - Merge branch 'master' into JDK-8330188 - Fix-up test. - Merge branch 'master' into

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v7]

2024-05-22 Thread Joe Darcy
On Thu, 23 May 2024 01:05:07 GMT, Chen Liang wrote: > > As a general comment, please update all the links to "mandated" so that the > > text "implicitly declared" get linked to the MANDATED enum constant. > > Should we update the API specification for `Parameter::isImplicit`, which > checks

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v7]

2024-05-22 Thread Joe Darcy
On Tue, 12 Dec 2023 22:21:29 GMT, Joe Darcy wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixing comment > > As the core reflection code will encounter record classes compiled

Re: RFR: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory [v7]

2024-05-20 Thread Joe Darcy
On Fri, 17 May 2024 08:28:15 GMT, Raffaello Giulietti wrote: >> All random number generator algorithms are implemented in module >> `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory` >> is no longer needed. > > Raffaello Giulietti has updated the pull request

Re: RFR: 8330182: Start of release updates for JDK 24 [v5]

2024-05-20 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Fix-up test. - Merge branch 'master' into JDK-8330188 - Adjust test for deprecated options. - Merge branch 'master' into JDK-8330

Re: RFR: 8330182: Start of release updates for JDK 24 [v4]

2024-05-09 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Adjust test for deprecated options. - Merge branch 'master' into JDK-8330188 - Update deprecated options test. - Merge branch 'mas

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Joe Darcy
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by darcy (Reviewer). > This PR is standalone as opposed to dependent because the #18787

Re: RFR: 8305457: Implement java.io.IO [v3]

2024-05-07 Thread Joe Darcy
On Tue, 7 May 2024 17:37:57 GMT, Pavel Rappo wrote: > Yes, we do. There's a common misconception that `{@inheritDoc}` inherits the > complete doc comment. In reality, `{@inheritDoc}` inherits only the main > description, which does not include any `@throws` tags. > > A `@throws` tag is either

Re: RFR: 8305457: Implement java.io.IO

2024-05-06 Thread Joe Darcy
On Tue, 7 May 2024 01:26:30 GMT, Chen Liang wrote: > Should this be final? With only the private constructor, it doesn't matter too much in practice, but an explicit `final` would be good documentation if that is the intent. - PR Review Comment:

Re: RFR: 8330182: Start of release updates for JDK 24 [v3]

2024-04-29 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Upd

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v19]

2024-04-29 Thread Joe Darcy
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote: >> Reflection is not retrieving generic type information for mandated >> parameters. This is a known issue which has been explicitly stated in the >> API of some reflection methods. Fix for >>

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v19]

2024-04-29 Thread Joe Darcy
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote: >> Reflection is not retrieving generic type information for mandated >> parameters. This is a known issue which has been explicitly stated in the >> API of some reflection methods. Fix for >>

Re: RFR: 8330182: Start of release updates for JDK 24 [v2]

2024-04-29 Thread Joe Darcy
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote: > There are further updates to this test in the pipeline (new deprecated flags > in 23) so you will need to keep updating to reflect that. Thanks @dholmes-ora ; acknowledged. - PR Review Comment:

Re: RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Joe Darcy
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote: > This checker checks the values of the `@since` tag found in the documentation > comment for an element against the release in which the element first > appeared. > > Real since value of an API element is computed as the oldest release

Integrated: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-28 Thread Joe Darcy
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote: > Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. This pull request has now been integrated. Changeset: 4e5c25ee Author: Joe Darcy URL: https://git.openjdk.org/jdk/

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v10]

2024-04-25 Thread Joe Darcy
On Tue, 19 Mar 2024 19:32:10 GMT, Joe Darcy wrote: >> I think splitting `CharArraySequence` into two versions is somewhat dubious >> as more observable types at call sites may mean the performance gain in >> targeted micros is lost. How much of an improvement di

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute [v2]

2024-04-25 Thread Joe Darcy
> Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jd

RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy
Remove unnecessary setting of variable y, found by an IDE inspection noted in the bug report. - Commit messages: - JDK-8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute Changes: https://git.openjdk.org/jdk/pull/18963/files Webrev:

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote: > Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. All Math and StrictMath regression tests pass with this change. Examining the code, y does look to be overwritten on all the code paths

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]

2024-04-22 Thread Joe Darcy
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote: >> Please review a set of updates to clean up use of `/**` comments in the >> vicinity of declarations. >> >> There are various categories of update: >> >> * "Box comments" beginning with `/**` >> * Misplaced doc comments before

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Joe Darcy
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or

Integrated: 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION

2024-04-18 Thread Joe Darcy
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote: > 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION This pull request has now been integrated. Changeset: 235ba9a7 Author: Joe Darcy URL: https://git.openjdk.org/jdk/commit/235ba9a7025964b1e43149c7102e26b82b2081ad St

RFR: 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION

2024-04-17 Thread Joe Darcy
8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION - Commit messages: - JDK-8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION Changes: https://git.openjdk.org/jdk/pull/18828/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18828=00 Issue:

Re: RFR: 8330182: Start of release updates for JDK 24 [v2]

2024-04-16 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with two additional commits since the last revision: - Correct release date as observed in review feedback. - Improve javadoc of class file update. - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8330182: Start of release updates for JDK 24

2024-04-16 Thread Joe Darcy
On Tue, 16 Apr 2024 21:21:43 GMT, Chen Liang wrote: >> Get JDK 24 underway. > > src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481: > >> 1479: int JAVA_23_VERSION = 67; >> 1480: >> 1481: /** 68 */ > > We need `@since 24` here. Ah, good catch; looks like I was

Re: RFR: 8330182: Start of release updates for JDK 24

2024-04-15 Thread Joe Darcy
On Mon, 15 Apr 2024 19:57:49 GMT, Iris Clark wrote: > The copyright year was not updated in all files *14.java. I assume that's > intentional. I'll run my copyright update script before pushing. > I've also Reviewed the associated CSRs. Thanks. > make/conf/version-numbers.conf line 36: >

Re: RFR: 8330182: Start of release updates for JDK 24

2024-04-15 Thread Joe Darcy
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote: > Get JDK 24 underway. This initial version of the PR intentionally excludes the creation of the new symbol files so that the fundamental code aspects of the update are easier to see. - PR Comment: https://git.openjdk.org/

RFR: 8330182: Start of release updates for JDK 24

2024-04-15 Thread Joe Darcy
Get JDK 24 underway. - Commit messages: - JDK-8330182: Start of release updates for JDK 24 Changes: https://git.openjdk.org/jdk/pull/18787/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18787=00 Issue: https://bugs.openjdk.org/browse/JDK-8330182 Stats: 101 lines in 37

Integrated: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-15 Thread Joe Darcy
On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote: > Straightforward test update so it doesn't have to be trivially updated for > each JDK version. This pull request has now been integrated. Changeset: da75e015 Author: Joe Darcy URL: https://git.openjdk.org/jdk/

Re: RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-13 Thread Joe Darcy
On Sat, 13 Apr 2024 00:40:45 GMT, Chen Liang wrote: > Thanks for this fix. I recall that I had to add this flag because otherwise > compileSources fails when `@enablePreview` is there. If we can drop the > preview flag, that would be the best. Thanks; I did a quick experiment and the test

RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-12 Thread Joe Darcy
Straightforward test update so it doesn't have to be trivially updated for each JDK version. - Commit messages: - JDK-8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic Changes: https://git.openjdk.org/jdk/pull/18769/files Webrev:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v8]

2024-04-05 Thread Joe Darcy
On Fri, 5 Apr 2024 18:32:09 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >> The

Withdrawn: JDK-8329556: javax.lang.model suppor for Derived Record Creation (Preview)

2024-04-05 Thread Joe Darcy
On Wed, 3 Apr 2024 05:56:55 GMT, Joe Darcy wrote: > Exploratory work in support of https://github.com/openjdk/jdk/pull/18509. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/18590

Re: RFR: JDK-8329556: javax.lang.model suppor for Derived Record Creation (Preview)

2024-04-05 Thread Joe Darcy
On Wed, 3 Apr 2024 05:56:55 GMT, Joe Darcy wrote: > Exploratory work in support of https://github.com/openjdk/jdk/pull/18509. The changes in this PR are being incorporated into the larger PR for derived record creation. - PR Comment: https://git.openjdk.org/jdk/pull/18

Integrated: JDK-8329624: Add visitors for preview language features

2024-04-04 Thread Joe Darcy
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote: > When new language features are added, the javax.lang.model may need to be > updated. For certain classes of features, the API update includes introducing > a new set of concrete visitors to handle the language feature. >

Re: RFR: JDK-8329624: Add visitors for preview language features [v2]

2024-04-04 Thread Joe Darcy
ent of any particular language > change. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add informative links. - Changes: - all: https://git.openjdk.org/jdk/pull/18609/files - new: https://git.openjdk.org/jdk/pull/18609/

Re: RFR: JDK-8329624: Add visitors for preview language features

2024-04-04 Thread Joe Darcy
On Thu, 4 Apr 2024 05:48:25 GMT, Alan Bateman wrote: > The visitor classes are themselves preview APIs. Is this the first time that > preview APIs have been proposed without a JEP? Just wondering how much > visibility this preview API will get. To clarify the intention, the visitor classes

Re: RFR: JDK-8329624: Add visitors for preview language features

2024-04-03 Thread Joe Darcy
On Wed, 3 Apr 2024 21:05:20 GMT, Vicente Romero wrote: >> When new language features are added, the javax.lang.model may need to be >> updated. For certain classes of features, the API update includes >> introducing a new set of concrete visitors to handle the language feature. >> >> The API

Re: RFR: JDK-8329624: Add visitors for preview language features

2024-04-03 Thread Joe Darcy
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote: > When new language features are added, the javax.lang.model may need to be > updated. For certain classes of features, the API update includes introducing > a new set of concrete visitors to handle the language feature. >

RFR: JDK-8329624: Add visitors for preview language features

2024-04-03 Thread Joe Darcy
When new language features are added, the javax.lang.model may need to be updated. For certain classes of features, the API update includes introducing a new set of concrete visitors to handle the language feature. The API scaffolding to support the new feature tends to be considerably larger

Integrated: JDK-8329557: Fix statement around MathContext.DECIMAL128 rounding

2024-04-03 Thread Joe Darcy
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote: > Happened to notice a semantic typo in the description of > MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended, > and added some additional information to make the related descriptions mo

Re: RFR: JDK-8329557: Fix statement around MathContext.DECIMAL128 rounding

2024-04-03 Thread Joe Darcy
On Wed, 3 Apr 2024 14:55:07 GMT, Raffaello Giulietti wrote: >> Happened to notice a semantic typo in the description of >> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended, >> and added some additional information to make the related descriptions more >>

RFR: JDK-8329556: javax.lang.model suppor for Derived Record Creation (Preview)

2024-04-03 Thread Joe Darcy
Exploratory work in support of https://github.com/openjdk/jdk/pull/18509. - Commit messages: - Add more support for component local variables. - Add uses of new visitor types. - JDK-8329556: javax.lang.model suppor for Derived Record Creation (Preview) - Baseline on 04 version of

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-03 Thread Joe Darcy
On Tue, 2 Apr 2024 18:09:52 GMT, Joe Darcy wrote: > > For the `javax.lang.model` changes, as a new ElementKind is being > > introduced, there should be a matching layer of new concrete visitors and > > selected updates to existing visitor implementations, etc. >

RFR: JDK-8329557: Fix statement around MathContext.DECIMAL128 rounding

2024-04-02 Thread Joe Darcy
Happened to notice a semantic typo in the description of MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended, and added some additional information to make the related descriptions more informative. - Commit messages: - JDK-8329557: Fix statement around

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-02 Thread Joe Darcy
On Tue, 2 Apr 2024 18:05:43 GMT, Joe Darcy wrote: > For the `javax.lang.model` changes, as a new ElementKind is being introduced, > there should be a matching layer of new concrete visitors and selected > updates to existing visitor implementations, etc. I can help develop the visito

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-02 Thread Joe Darcy
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >>

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v10]

2024-03-19 Thread Joe Darcy
On Tue, 12 Mar 2024 14:03:01 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> restore comment > > I think splitting `CharArraySequence` into two versions is somewhat dubious > as more observable

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v12]

2024-03-13 Thread Joe Darcy
On Wed, 13 Mar 2024 13:51:27 GMT, Claes Redestad wrote: > Relying on the upper bounds check of `charAt` doesn't work well with the > `CharArraySequence` whose `charAt` deliberately does not throw an IIOBE if > the array is longer than the provided length, ie, it'll look at chars beyond > the

Integrated: JDK-8327487: Further augment WorstCaseTests with more cases

2024-03-12 Thread Joe Darcy
On Wed, 6 Mar 2024 17:54:57 GMT, Joe Darcy wrote: > The atan2 and hypot cases added would fail for a particular test library that > has errors in the millions of ulps for those inputs, rather than the small > number of ulps specified for the error. This pull request has now been i

Re: RFR: 8327786: Add fluent setAccessible()

2024-03-11 Thread Joe Darcy
On Tue, 12 Mar 2024 00:16:52 GMT, Mandy Chung wrote: > I agree with the evaluation of > [JDK-8327786](https://bugs.openjdk.org/browse/JDK-8327786) that > `setAccessible(true)` isn't for most developers and this proposal is not > worth doing. I concur. - PR Comment:

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v4]

2024-03-11 Thread Joe Darcy
On Mon, 11 Mar 2024 20:41:25 GMT, Shaojin Wen wrote: >> The current BigDecimal(String) constructor calls String#toCharArray, which >> has a memory allocation. >> >> >> public BigDecimal(String val) { >> this(val.toCharArray(), 0, val.length()); // allocate char[] >> } >> >> >> When the

Re: RFR: JDK-8327487: Further augment WorstCaseTests with more cases [v3]

2024-03-11 Thread Joe Darcy
> The atan2 and hypot cases added would fail for a particular test library that > has errors in the millions of ulps for those inputs, rather than the small > number of ulps specified for the error. Joe Darcy has updated the pull request incrementally with one additional commit since

Re: RFR: JDK-8327487: Further augment WorstCaseTests with more cases [v2]

2024-03-06 Thread Joe Darcy
> The atan2 and hypot cases added would fail for a particular test library that > has errors in the millions of ulps for those inputs, rather than the small > number of ulps specified for the error. Joe Darcy has updated the pull request incrementally with one additional commit since

RFR: JDK-8327487: Further augment WorstCaseTests with more cases

2024-03-06 Thread Joe Darcy
The atan2 and hypot cases added would fail for a particular test library that has errors in the millions of ulps for those inputs, rather than the small number of ulps specified for the error. - Commit messages: - JDK-8327487: Further augment WorstCaseTests with more cases

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

2024-03-04 Thread Joe Darcy
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote: > Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Looks fine; thanks for sending out the fix. test/jdk/java/lang/Double/ParseDouble.java line 559: > 557: private static void

Integrated: JDK-8316708: Augment WorstCaseTests with more cases

2024-03-01 Thread Joe Darcy
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote: > A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZi

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v9]

2024-03-01 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the un

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v8]

2024-02-28 Thread Joe Darcy
On Wed, 28 Feb 2024 06:08:18 GMT, Joe Darcy wrote: >> A new paper >> >> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and >> Quadruple Precision" >> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann >> https://me

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v8]

2024-02-27 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to r

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v7]

2024-02-27 Thread Joe Darcy
On Tue, 27 Feb 2024 11:20:11 GMT, Raffaello Giulietti wrote: > There are no libraries that have worse errors than OpenLibm, so I'm wondering > what these values are good for? When I was working on updating the worst-case tests for Math, I would check the input values in Math.foo() and

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v7]

2024-02-27 Thread Joe Darcy
On Tue, 27 Feb 2024 11:20:01 GMT, Raffaello Giulietti wrote: > I can't find this one on the paper. Good catch; must have been a cut and paste error on my part. - PR Review Comment: https://git.openjdk.org/jdk/pull/15879#discussion_r1504993038

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Joe Darcy
On Tue, 27 Feb 2024 19:21:13 GMT, Chad Rakoczy wrote: > What is the issue with this? Is there a different way to set a timeout? The > test tests that format does not take a long time to run so I would like to > have a timeout Hard-coded timeout in a test are generally considered harmful as

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Joe Darcy
On Tue, 27 Feb 2024 17:24:03 GMT, Chad Rakoczy wrote: > [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug > with Formatter.format taking a long time when there is a lot of padding. This > test runs Formatter.format with very large padding. Test fails before >

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v7]

2024-02-26 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Appease jcheck.

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v6]

2024-02-26 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update atan2 and hypot

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v5]

2024-02-26 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Expand

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v3]

2024-02-25 Thread Joe Darcy
On Mon, 26 Feb 2024 06:43:43 GMT, Joe Darcy wrote: > To improve the "fingerprinting" coverage of the StrictMath tests, I've added > test cases where the worst-case of a non-FDLIBM library is larger than the > FDLIBM worst-case. Assuming reasonable methodology of th

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v3]

2024-02-25 Thread Joe Darcy
On Sat, 24 Feb 2024 20:31:13 GMT, Joe Darcy wrote: >> A new paper >> >> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and >> Quadruple Precision" >> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann >> https://me

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v4]

2024-02-25 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with five additional commits since the last revision: - Fix missing minus sign.

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v3]

2024-02-24 Thread Joe Darcy
On Fri, 23 Feb 2024 19:18:22 GMT, Joe Darcy wrote: > > Both `Math.cos` and `StrictMath.cos` produce the correctly rounded result > > here. I don't know why the paper says otherwise. Perhaps OpenLibm is not > > exactly fdlibm. > > I've looked a bit over the OpenLibm

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v3]

2024-02-24 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Imp

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v2]

2024-02-23 Thread Joe Darcy
On Fri, 22 Sep 2023 15:33:11 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request conta

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v2]

2024-02-23 Thread Joe Darcy
On Fri, 22 Sep 2023 21:32:26 GMT, Joe Darcy wrote: > For FDLIBM tan, the stated error in the Math.tan spec is 1 ulp and the FDLIBM > sources say tan is "nearly rounded," which could reasonably be interpreted as > meaning within 1 ulp. However, the reported error by the

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v2]

2024-02-23 Thread Joe Darcy
nputs with generate the worst-case observed errors in different > math library implementations. The FDLIBM-related worst cases should be added > to the test suite. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the un

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases

2024-02-23 Thread Joe Darcy
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote: > A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZi

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases

2024-02-23 Thread Joe Darcy
On Fri, 22 Sep 2023 15:48:26 GMT, Raffaello Giulietti wrote: > Both `Math.cos` and `StrictMath.cos` produce the correctly rounded result > here. I don't know why the paper says otherwise. Perhaps OpenLibm is not > exactly fdlibm. I've looked a bit over the OpenLibm changelog. They've added a

Integrated: JDK-8326530: Widen allowable error bound of Math.tan

2024-02-23 Thread Joe Darcy
On Thu, 22 Feb 2024 22:00:26 GMT, Joe Darcy wrote: > Widen acceptable error bound of Math.tan to accommodate the worst-case > observed error which is slightly outside of the allowable range. This pull request has now been integrated. Changeset: 63f6a563 Author: Joe Darcy URL:

  1   2   3   4   5   6   7   8   >